Re: [More Like This] Query building

2016-04-12 Thread Scott Stults
Hi Alessandro, It's not uncommon for Solr patches to remain uncommitted for months, even years. In fact some never get merged. Don't let that discourage you! k/r, Scott On Fri, Mar 11, 2016 at 11:49 AM, Alessandro Benedetti < abenede...@apache.org> wrote: > I start to feel that is not that

Re: [More Like This] Query building

2016-03-11 Thread Alessandro Benedetti
I start to feel that is not that easy to contribute improvements or small fix to Solr ( if they are not super interesting to the mass) . I think this one could be a good improvement in the MLT but I would love to discuss this with some committer. The patch is attached, it is there since months

Re: [More Like This] Query building

2016-02-11 Thread Alessandro Benedetti
Hi Guys, is it possible to have any feedback ? Is there any process to speed up bug resolution / discussions ? just want to understand if the patch is not good enough, if I need to improve it or simply no-one took a look ... https://issues.apache.org/jira/browse/LUCENE-6954 Cheers On 11 January

Re: [More Like This] Query building

2016-01-11 Thread Alessandro Benedetti
Hi guys, the patch seems fine to me. I didn't spend much more time on the code but I checked the tests and the pre-commit checks. It seems fine to me. Let me know , Cheers On 31 December 2015 at 18:40, Alessandro Benedetti wrote: >

Re: [More Like This] Query building

2015-12-31 Thread Alessandro Benedetti
https://issues.apache.org/jira/browse/LUCENE-6954 First draft patch available, I will check better the tests new year ! On 29 December 2015 at 13:43, Alessandro Benedetti wrote: > Sure, I will proceed tomorrow with the Jira and the simple patch + tests. > > In the

Re: [More Like This] Query building

2015-12-29 Thread Anshum Gupta
Feel free to create a JIRA and put up a patch if you can. On Tue, Dec 29, 2015 at 4:26 PM, Alessandro Benedetti wrote: > Hi guys, > While I was exploring the way we build the More Like This query, I > discovered a part I am not convinced of : > > > > Let's see how we

Re: [More Like This] Query building

2015-12-29 Thread Alessandro Benedetti
Sure, I will proceed tomorrow with the Jira and the simple patch + tests. In the meantime let's try to collect some additional feedback. Cheers On 29 December 2015 at 12:43, Anshum Gupta wrote: > Feel free to create a JIRA and put up a patch if you can. > > On Tue, Dec