Re: JDK 9 RFR of JDK-8134554: Add sound tests to tier 3

2015-08-27 Thread Sergey Bylokhov
Hi, Joe. Can you clarify a little bit a "tier 3"? On 27.08.15 3:14, joe darcy wrote: Hello, Please review the changes below for JDK-8134554: Add sound tests to tier 3 Thanks, -Joe diff -r ee8b1bc2f534 test/TEST.groups --- a/test/TEST.groupsThu Aug 27 07:52:12 2015 +0800 +++ b/test/T

Re: JDK 9 RFR of JDK-8134554: Add sound tests to tier 3

2015-08-27 Thread joe darcy
Hi Sergey, The general tiered testing policy is described in: http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html with tier 3 specifically discussed in http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html Quoting from the latter: As a reminder, JDK 9 is n

Re: [9] Review Request: 8133677 Specification of AudioFileReader should be clarifed

2015-08-27 Thread Phil Race
+1 -phil. On 08/20/2015 06:01 AM, alexey menkov wrote: Looks good for me. regards Alex On 19.08.2015 18:24, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is specification update of AudioFileReader. CCC request will be filed after technical review. According to specifica

Re: JDK 9 RFR of JDK-8134554: Add sound tests to tier 3

2015-08-27 Thread Sergey Bylokhov
Thanks for clarification. The fix looks fine. On 27.08.15 19:41, joe darcy wrote: Hi Sergey, The general tiered testing policy is described in: http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html with tier 3 specifically discussed in http://mail.openjdk.java.net/pipermail/

JDK 9 RFR of JDK-8134632: Mark javax/sound/midi/Devices/InitializationHang.java as headful

2015-08-27 Thread joe darcy
Hello, Please review the the small patch below to address: JDK-8134632: Mark javax/sound/midi/Devices/InitializationHang.java as headful When the test javax/sound/midi/Devices/InitializationHang.java is failing (as part of tier 3) when run in some of our headless test environments

Re: JDK 9 RFR of JDK-8134632: Mark javax/sound/midi/Devices/InitializationHang.java as headful

2015-08-27 Thread Phil Race
approved. -phil. On 8/27/15 4:09 PM, joe darcy wrote: Hello, Please review the the small patch below to address: JDK-8134632: Mark javax/sound/midi/Devices/InitializationHang.java as headful When the test javax/sound/midi/Devices/InitializationHang.java is failing (as part of tie