[9] Review Request: 8168998 Incorrect implementation of equals in Encoding and Type in JavaSound

2016-11-01 Thread Sergey Bylokhov
Hello, Audio Guru. Please review the fix for jdk9. AudioFormat.Encoding(null) and AudioFIleFormat.Type(null) equal to any objects which return null from toString(). Note that behavior of null in these constructors is not specified and can throw an exception. I wonder why the null is accepted i

Re: [9] Review Request: 8168998 Incorrect implementation of equals in Encoding and Type in JavaSound

2016-11-01 Thread Phil Race
+1 -phil On 11/01/2016 10:03 AM, Sergey Bylokhov wrote: Hello, Audio Guru. Please review the fix for jdk9. AudioFormat.Encoding(null) and AudioFIleFormat.Type(null) equal to any objects which return null from toString(). Note that behavior of null in these constructors is not specified and

JDK 9 RFR of JDK-8169024: Problem list OpenNonIntegralNumberOfSampleframes.java until JDK-8168881 is fixed

2016-11-01 Thread joe darcy
Hello, The test javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java started failing on multiple platform with the recent client integration of JDK-8167435. The failing test should be problem listed until the fix for JDK-8168881 is developed. Patch below. Thanks, -Joe --- a/

Re: JDK 9 RFR of JDK-8169024: Problem list OpenNonIntegralNumberOfSampleframes.java until JDK-8168881 is fixed

2016-11-01 Thread Sergey Bylokhov
The fix is currently in progress and will prepare for review today. Is it really necessary to updated the problem list? On 02.11.16 0:34, joe darcy wrote: Hello, The test javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java started failing on multiple platform with the recent cl