Hello.
With my OpenJDK 6 release manager hat on, I've been working to update
the version of Gervill used to OpenJDK 6 to a newer version that passes
the JCK tests, etc. and I'd like some review of my integration work.
Before this exercise, I don't have any prior experience with sound code.
platforms.
Cheers,
-Joe
regards,
Karl
Frá: [EMAIL PROTECTED] [EMAIL PROTECTED] Fyrir hönd Joe Darcy [EMAIL
PROTECTED]
Sent: 22. júlí 2008 22:53
Viðtakandi: [EMAIL PROTECTED]
Afrit: sound-dev@openjdk.java.net; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Efni: Updating Ge
Hi Karl.
Karl Helgason wrote:
Hi Joe,
Gervill CVS has the newest code and Gervill overlays in IcedTea 6 are then
copied from Gervill CVS.
Any fixes that have been done in Gervill overlays in IcedTea 6 has also been
done Gervill CVS.
Gervill in OpenJDK 6 b10 was based on version 0.9 of Gervill
Alex Menkov wrote:
Karl Helgason wrote:
WaveExtensibleFileReader,WaveFloatFileWriter,WaveFloatFileReader
has been
moved to src.floatwav in the Gervill CVS. Because they aren't
directly related with
Gervill Synthesizer. They simply add support for float encoded Wave
files.
And WaveExtensibleF
Joe Darcy wrote:
Hi Karl.
Karl Helgason wrote:
Hi Joe,
Gervill CVS has the newest code and Gervill overlays in IcedTea 6 are
then copied from Gervill CVS.
Any fixes that have been done in Gervill overlays in IcedTea 6 has
also been done Gervill CVS.
Gervill in OpenJDK 6 b10 was based on
Hello,
Please review this change to address serial lint warnings in javax.sound:
8034046: Fix serial lint warnings in javax.sound
http://cr.openjdk.java.net/~darcy/8034046.0/
Mostly this change is adding six missing serialVersionUID fields; I
verified the reported serialver values were
Hello,
As part of Project Lambda, a FunctionalInterface annotation type was
added to the platform to mark interfaces that are intended to be used in
lambda expressions. I've sent out a code review request to add this
annotation to types in the core-libs area [1].
To assist the sound team in
Hello,
Please review the patch below which addresses
JDK-8037173: Fix serial lint warnings in sun.audio
Thanks,
-Joe
diff -r 55dc85ff351f
src/share/classes/sun/audio/InvalidAudioFormatException.java
--- a/src/share/classes/sun/audio/InvalidAudioFormatException.java Tue
Mar 11 10:46:
Hello,
Please review a fix for
JDK-8039863: Fix fallthrough lint warnings in sound
http://cr.openjdk.java.net/~darcy/8039863.0/
Without having domain knowledge of this code, it wasn't clear to me
whether or not the fall through was intended.
Thanks,
-Joe
--- old/src/share/classes/c
Hello,
Please review this change to address the raw and unchecked warnings in
com.sun.media.sound:
JDK-8042256: Fix raw and unchecked lint warnings in com.sun.media.sound
http://cr.openjdk.java.net/~darcy/8042256.0/
Patch below.
Thanks,
-Joe
--- old/src/share/classes/com/sun/media/
* ping*
-Joe
On 4/30/2014 9:50 PM, Joe Darcy wrote:
Hello,
Please review this change to address the raw and unchecked warnings in
com.sun.media.sound:
JDK-8042256: Fix raw and unchecked lint warnings in
com.sun.media.sound
http://cr.openjdk.java.net/~darcy/8042256.0/
Patch below
Hello,
Please review this fix for
JDK-8042871: Fix raw and unchecked warnings in sun.audio
http://cr.openjdk.java.net/~darcy/8042871.0/
Patch below.
Thanks,
-Joe
--- old/src/share/classes/sun/audio/AudioDevice.java2014-05-14
23:04:08.0 -0700
+++ new/src/share/classes/sun
net/~darcy/8042871.1/
Thanks,
-Joe
On 5/15/14 10:08 AM, Joe Darcy wrote:
Hello,
Please review this fix for
JDK-8042871: Fix raw and unchecked warnings in sun.audio
http://cr.openjdk.java.net/~darcy/8042871.0/
Patch below.
Thanks,
-Joe
Hello,
Please review these changes to address
JDK-8044553: Fix raw and unchecked lint warnings in javax.sound.*
http://cr.openjdk.java.net/~darcy/8044553.0/
Patch below.
Thanks,
-Joe
--- old/src/share/classes/javax/sound/midi/MidiFileFormat.java
2014-06-04 00:19:41.0 -0700
+
*ping*
Thanks,
-Joe
On 06/04/2014 12:25 AM, Joe Darcy wrote:
Hello,
Please review these changes to address
JDK-8044553: Fix raw and unchecked lint warnings in javax.sound.*
http://cr.openjdk.java.net/~darcy/8044553.0/
Patch below.
Thanks,
-Joe
OExcEption.
I don't see any problems but you can sanity test by running the reg. tests
under test/javax/sound/
-phil
On 6/5/14 3:06 PM, Joe Darcy wrote:
*ping*
Thanks,
-Joe
On 06/04/2014 12:25 AM, Joe Darcy wrote:
Hello,
Please review these changes to address
JDK-8044553: Fix ra
Hello,
To support the next iteration of tiered testing in JDK 9, with an eye
toward running client library tests, please review the patch below which
addresses
JDK-8129822: Define "headful" jtreg keyword
Some test environments are headless, including test environments often
used for the
Hi Alan,
On 6/30/2015 12:09 AM, Alan Bateman wrote:
On 30/06/2015 00:16, Joseph D. Darcy wrote:
Hello,
Please review the proposed fix for
8081547: Prepare client libs regression tests for running in a
concurrent, headless jtreg environment
http://cr.openjdk.java.net/~darcy/8081547
Hello,
As part of implementing tiered testing [1], client library tests which
use randomness should be marked with the corresponding keyword. The
analogous changes have been made in core libs, see JDK-8078334: Mark
regression tests using randomness.
Webrev at
JDK-8134084 : Mark client l
HTH,
-Joe
-phil.
On 08/20/2015 10:47 AM, joe darcy wrote:
Hello,
As part of implementing tiered testing [1], client library tests
which use randomness should be marked with the corresponding keyword.
The analogous changes have been made in core libs, see JDK-8078334:
Mark regression tests
time) {
try {
// add +/-5ms variance to increase randomness
Thread.sleep(time + (long)(5 - Math.random()*10));
} catch (InterruptedException e) {};
}
-Joe
-phil.
On 8/20/2015 11:44 AM, joe darcy wrote:
Hi Phil,
On 8/20/2015 11:14 AM, Phil Race wrote
Hello,
Please review the changes below for
JDK-8134554: Add sound tests to tier 3
Thanks,
-Joe
diff -r ee8b1bc2f534 test/TEST.groups
--- a/test/TEST.groupsThu Aug 27 07:52:12 2015 +0800
+++ b/test/TEST.groupsWed Aug 26 17:12:23 2015 -0700
@@ -50,7 +50,8 @@
tier3 = \
:jdk_rmi
propriate client libs teams.
As a point of comparison, the automated beans and imageio tests are
already in tier 3.
Thanks,
-Joe
On 8/27/2015 9:31 AM, Sergey Bylokhov wrote:
Hi, Joe.
Can you clarify a little bit a "tier 3"?
On 27.08.15 3:14, joe darcy wrote:
Hello,
Please re
Hello,
Please review the the small patch below to address:
JDK-8134632: Mark javax/sound/midi/Devices/InitializationHang.java
as headful
When the test
javax/sound/midi/Devices/InitializationHang.java
is failing (as part of tier 3) when run in some of our headless test
environments
Hello,
Until the root cause of JDK-8148915 is addressed, the test
javax/sound/sampled/DirectAudio/bug6400879.java
should be marked as intermittently failing.
Please review the below patch which does this.
Thanks,
-Joe
diff -r 3bce90b8839e test/javax/sound/sampled/DirectAudio/bug6400879.java
Looks fine Sergey; thanks,
-Joe
On 4/7/2016 12:35 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk9/dev.
The ProblemList.txt is updated to include the failed test until the
JDK-8148915 [1] is resolved.
[1] https://bugs.openjdk.java.net/browse/JDK-8148915
diff -r a33325f2fc14
Hello,
The test
javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java
started failing on multiple platform with the recent client integration
of JDK-8167435. The failing test should be problem listed until the fix
for JDK-8168881 is developed.
Patch below.
Thanks,
-Joe
--- a/
Hello,
Now that JDK-8168881 has been fixed, the test
javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java
should be removed from the problem list. Patch below.
Thanks,
-Joe
--- a/test/ProblemList.txtTue Nov 15 13:31:52 2016 -0800
+++ b/test/ProblemList.txtWed Nov 16 09:5
Hello,
I jumped the gun a bit in my earlier review request for
JDK-8169803: Remove OpenNonIntegralNumberOfSampleframes.java from
the problem list
since the fix was only in the client forest and not dev. [1]
Please review this patch to reinstate the problem listing until the fix
propagat
+1
Thanks Amy,
-Joe
On 12/1/2016 1:56 AM, Amy Lu wrote:
javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java
This test was problem listed since the fix JDK-8168881 was only in the
client forest and not dev.
Now that fix JDK-8168881 is in dev [1], test could be removed from
P
Looks fine Sergey; thanks,
-Joe
On 4/19/2018 5:19 PM, Sergey Bylokhov wrote:
Hello, Audio Guru.
Please review the fix for jdk11.
Bug: https://bugs.openjdk.java.net/browse/JDK-8202050
The "Recording.java" test is added to the ProblemList.
The test will be fixed in:
https://bugs.openjdk.java
Hello,
Quick background, I'm working on expanding the compile-time
serialization checks of javac's -Xlint:serial option. Ahead of that work
going back, I'm analyzing the JDK sources and plan to pre-suppress the
coming-soon new warnings, fixing or at least filing follow-up bugs for
any problem
re meant to the an aid,
especially to writing new serializable types, while also prompting some
examination of the existing types in an effort to allow the warning to
enabled by default in the build.
Thanks,
-Joe
-phil
On 9/21/19, 12:48 PM, Joe Darcy wrote:
Hello,
Quick background, I'
proved by me .. but .. it would be good if you can point out any
other cases
where you think we can compatibly make changes to get rid of the need
for suppressing this new warning.
-phil
On 9/23/19, 12:54 PM, Joe Darcy wrote:
Hi Phil,
On 9/22/2019 1:25 PM, Philip Race wrote:
+ @Suppress
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
35 matches
Mail list logo
