Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Paul Goyette
On Sun, 19 Jan 2014, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Sun Jan 19 18:16:13 UTC 2014 Modified Files: src/sys/opencrypto: cryptodev.c Log Message: bail out unloading for now How about the following changes? @@ -143,6 +143,8 @@ static

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
On Jan 19, 10:22am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | How about the following changes? You need to handle the regular open too, not justthe get (look for the other fd_clone) | @@ -143,6 +143,8 @@ static intcryptoread(dev_t dev,

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
On Jan 19, 10:37am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | That's covered in cryptoopen() at line 1060 I missed that patch | Handled indirectly. The MODULE_CMD_FINI calls config_cfdata_detach() | which attempts to detach each device instance.

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Paul Goyette
On Sun, 19 Jan 2014, Christos Zoulas wrote: On Jan 19, 10:37am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | That's covered in cryptoopen() at line 1060 I missed that patch No worry. | Handled indirectly. The MODULE_CMD_FINI calls

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
On Jan 19, 11:21am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | | Handled indirectly. The MODULE_CMD_FINI calls config_cfdata_detach() | | which attempts to detach each device instance. If a detach fails, then | | config_cfdata_detach fails, and

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Paul Goyette
On Sun, 19 Jan 2014, John Nemeth wrote: } Handled indirectly. The MODULE_CMD_FINI calls config_cfdata_detach() } which attempts to detach each device instance. If a detach fails, then } config_cfdata_detach fails, and the unload will fail. Does this mean that you'll end up with some

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
In article pine.neb.4.64.1401191416060.22...@screamer.whooppee.com, Paul Goyette p...@whooppee.com wrote: On Sun, 19 Jan 2014, John Nemeth wrote: } Handled indirectly. The MODULE_CMD_FINI calls config_cfdata_detach() } which attempts to detach each device instance. If a detach fails, then }

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread John Nemeth
On Jan 19, 10:37am, Paul Goyette wrote: } On Sun, 19 Jan 2014, Christos Zoulas wrote: } On Jan 19, 10:22am, p...@whooppee.com (Paul Goyette) wrote: } } | How about the following changes? } } You need to handle the regular open too, not justthe get (look for the } other fd_clone) } } That's

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Paul Goyette
The mere existence of a non-zero unit is a reference that needs to prevent unloading. The two checks (unit# and ref-count) are equivalent and redundant, and only one of them needs to be there. On Sun, 19 Jan 2014, Christos Zoulas wrote: In article

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
On Jan 19, 3:04pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | The mere existence of a non-zero unit is a reference that needs to | prevent unloading. What if it is the last reference? Then the ref count will go to zero after close without

Re: CVS commit: src/sys/opencrypto

2014-01-19 Thread Paul Goyette
On Sun, 19 Jan 2014, Christos Zoulas wrote: On Jan 19, 3:04pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/opencrypto | The mere existence of a non-zero unit is a reference that needs to | prevent unloading. What if it is the last reference? Then the ref count

CVS commit: src/usr.bin/make

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 10:23:29 UTC 2014 Modified Files: src/usr.bin/make: make.1 Log Message: Emphasise the fact that the regexp and replacement in :C/// are subjected to variable expansion before regexp parsing. This was already documented

CVS commit: src/sys/arch

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 10:30:19 UTC 2014 Modified Files: src/sys/arch/amd64/include: pcb.h src/sys/arch/i386/include: pcb.h Log Message: Remove the unused 'struct md_coredump'. To generate a diff of this commit: cvs rdiff -u -r1.21

CVS commit: src/lib/libc

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 11:36:45 UTC 2014 Modified Files: src/lib/libc: Makefile Log Message: If MKREPRO=yes, make the tags file refer to /usr/src instead of referring to the actual source directory ${NETBSDSRC}. To generate a diff of this

CVS commit: src/sys

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 13:35:58 UTC 2014 Modified Files: src/sys/arch/i386/i386: freebsd_machdep.c src/sys/arch/i386/include: freebsd_machdep.h src/sys/compat/freebsd: freebsd_ptrace.c Log Message: Rip out the code that might

CVS commit: src/sys/compat/freebsd

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 13:36:40 UTC 2014 Removed Files: src/sys/compat/freebsd: freebsd_ptrace.h Log Message: No longer used. To generate a diff of this commit: cvs rdiff -u -r1.6 -r0 src/sys/compat/freebsd/freebsd_ptrace.h Please note that

CVS commit: src/tests/crypto/opencrypto

2014-01-19 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 19 13:41:00 UTC 2014 Modified Files: src/tests/crypto/opencrypto: h_aesctr1.c Log Message: Sprinkle in some UNCONST() To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/crypto/opencrypto/h_aesctr1.c

CVS commit: src/sys

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 14:30:38 UTC 2014 Modified Files: src/sys/arch/i386/i386: freebsd_machdep.c ibcs2_machdep.c machdep.c process_machdep.c svr4_machdep.c trap.c src/sys/arch/i386/include: npx.h

CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jan 19 18:16:13 UTC 2014 Modified Files: src/sys/opencrypto: cryptodev.c Log Message: bail out unloading for now To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/sys/opencrypto/cryptodev.c Please note

CVS commit: src/tests/lib/libcurses

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 21:50:17 UTC 2014 Modified Files: src/tests/lib/libcurses/director: Makefile src/tests/lib/libcurses/slave: Makefile Log Message: Remove -g from CPPFLAGS and LDFLAGS in curses tests. The debug information

CVS commit: src/tests/lib/libcurses/director

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 22:09:34 UTC 2014 Modified Files: src/tests/lib/libcurses/director: Makefile Log Message: Remove -O0 from CPPFLAGS, and instead set COPTS.testlang_parse.c += -Wno-uninitialized. Without the old -O0, and without the new

CVS commit: src/sbin/ifconfig

2014-01-19 Thread Matt Thomas
Module Name:src Committed By: matt Date: Sun Jan 19 22:31:13 UTC 2014 Modified Files: src/sbin/ifconfig: af_link.c Log Message: Rename link to link_pkw to avoid shadowing the link syscall. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/arch/i386/include

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 23:27:30 UTC 2014 Modified Files: src/sys/arch/i386/include: npx.h Log Message: Add a couple of __CTASSERT() for the sizes of the fp save structures. To generate a diff of this commit: cvs rdiff -u -r1.28 -r1.29

CVS commit: src/gnu/dist/gcc4/libobjc

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 00:05:57 UTC 2014 Modified Files: src/gnu/dist/gcc4/libobjc: archive.c sendmsg.c Log Message: fix some inlines to make compilable with later versions of gcc To generate a diff of this commit: cvs rdiff -u -r1.1.1.1

CVS commit: src/sys/dev/pci

2014-01-19 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Jan 20 01:10:38 UTC 2014 Modified Files: src/sys/dev/pci: pucdata.c Log Message: Fix a bug that EG20T's UARTs from #1 to #3 never match. Tested with my MinnowBoard. To generate a diff of this commit: cvs rdiff -u -r1.89

CVS commit: src/external/bsd/openpam/dist/lib

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:15:03 UTC 2014 Modified Files: src/external/bsd/openpam/dist/lib: openpam_log.c Log Message: gcc 4.1 does not support pragma diagnostic ignored To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/external/bsd/ntp/lib/libntp

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:32:12 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libntp: Makefile Log Message: Gcc-4.1 does not have -Wno-error To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9

CVS commit: src/external/bsd/ntp/lib/libiscntp

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:37:53 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libiscntp: Makefile Log Message: gcc 4.1 does not have -Wno-error To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/external/bsd/ntp/lib/libopts

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:43:34 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libopts: Makefile Log Message: ignore format errors for old gcc To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9

CVS commit: src/external/bsd/ntp/bin/ntpd

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:52:54 UTC 2014 Modified Files: src/external/bsd/ntp/bin/ntpd: Makefile Log Message: use the old style no-error for gcc-4.1 To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/external/bsd/tmux/dist

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:08:27 UTC 2014 Modified Files: src/external/bsd/tmux/dist: log.c Log Message: gcc-4.1 does not have the pragma diagnostic ignored To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/distrib/sets/lists/xdebug

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:32:57 UTC 2014 Modified Files: src/distrib/sets/lists/xdebug: md.vax Log Message: add missing. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/distrib/sets/lists/xdebug/md.vax Please note that

CVS commit: src/distrib/sets/lists/debug

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:34:20 UTC 2014 Modified Files: src/distrib/sets/lists/debug: mi Log Message: fix typo To generate a diff of this commit: cvs rdiff -u -r1.49 -r1.50 src/distrib/sets/lists/debug/mi Please note that diffs are not

CVS commit: src/sys/kern

2014-01-19 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Mon Jan 20 07:47:22 UTC 2014 Modified Files: src/sys/kern: vfs_cache.c Log Message: Change cache_prune() to test for end-of-list before testing for an invalid entry. Prevents a lifelock when the end-of-list marker gets invalid

CVS commit: src/usr.bin/make

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 10:23:29 UTC 2014 Modified Files: src/usr.bin/make: make.1 Log Message: Emphasise the fact that the regexp and replacement in :C/// are subjected to variable expansion before regexp parsing. This was already documented

CVS commit: src/sys/arch

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 10:30:19 UTC 2014 Modified Files: src/sys/arch/amd64/include: pcb.h src/sys/arch/i386/include: pcb.h Log Message: Remove the unused 'struct md_coredump'. To generate a diff of this commit: cvs rdiff -u -r1.21

CVS commit: src/lib/libc

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 11:36:45 UTC 2014 Modified Files: src/lib/libc: Makefile Log Message: If MKREPRO=yes, make the tags file refer to /usr/src instead of referring to the actual source directory ${NETBSDSRC}. To generate a diff of this

CVS commit: src/sys

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 13:35:58 UTC 2014 Modified Files: src/sys/arch/i386/i386: freebsd_machdep.c src/sys/arch/i386/include: freebsd_machdep.h src/sys/compat/freebsd: freebsd_ptrace.c Log Message: Rip out the code that might

CVS commit: src/sys/compat/freebsd

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 13:36:40 UTC 2014 Removed Files: src/sys/compat/freebsd: freebsd_ptrace.h Log Message: No longer used. To generate a diff of this commit: cvs rdiff -u -r1.6 -r0 src/sys/compat/freebsd/freebsd_ptrace.h Please note that

CVS commit: src/tests/crypto/opencrypto

2014-01-19 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 19 13:41:00 UTC 2014 Modified Files: src/tests/crypto/opencrypto: h_aesctr1.c Log Message: Sprinkle in some UNCONST() To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/crypto/opencrypto/h_aesctr1.c

CVS commit: src/sys

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 14:30:38 UTC 2014 Modified Files: src/sys/arch/i386/i386: freebsd_machdep.c ibcs2_machdep.c machdep.c process_machdep.c svr4_machdep.c trap.c src/sys/arch/i386/include: npx.h

CVS commit: src/sys/opencrypto

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jan 19 18:16:13 UTC 2014 Modified Files: src/sys/opencrypto: cryptodev.c Log Message: bail out unloading for now To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/sys/opencrypto/cryptodev.c Please note

CVS commit: src/tests/lib/libcurses

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 21:50:17 UTC 2014 Modified Files: src/tests/lib/libcurses/director: Makefile src/tests/lib/libcurses/slave: Makefile Log Message: Remove -g from CPPFLAGS and LDFLAGS in curses tests. The debug information

CVS commit: src/tests/lib/libcurses/director

2014-01-19 Thread Alan Barrett
Module Name:src Committed By: apb Date: Sun Jan 19 22:09:34 UTC 2014 Modified Files: src/tests/lib/libcurses/director: Makefile Log Message: Remove -O0 from CPPFLAGS, and instead set COPTS.testlang_parse.c += -Wno-uninitialized. Without the old -O0, and without the new

CVS commit: src/sbin/ifconfig

2014-01-19 Thread Matt Thomas
Module Name:src Committed By: matt Date: Sun Jan 19 22:31:13 UTC 2014 Modified Files: src/sbin/ifconfig: af_link.c Log Message: Rename link to link_pkw to avoid shadowing the link syscall. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/arch/i386/include

2014-01-19 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jan 19 23:27:30 UTC 2014 Modified Files: src/sys/arch/i386/include: npx.h Log Message: Add a couple of __CTASSERT() for the sizes of the fp save structures. To generate a diff of this commit: cvs rdiff -u -r1.28 -r1.29

CVS commit: src/gnu/dist/gcc4/libobjc

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 00:05:57 UTC 2014 Modified Files: src/gnu/dist/gcc4/libobjc: archive.c sendmsg.c Log Message: fix some inlines to make compilable with later versions of gcc To generate a diff of this commit: cvs rdiff -u -r1.1.1.1

CVS commit: src/sys/dev/pci

2014-01-19 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Mon Jan 20 01:10:38 UTC 2014 Modified Files: src/sys/dev/pci: pucdata.c Log Message: Fix a bug that EG20T's UARTs from #1 to #3 never match. Tested with my MinnowBoard. To generate a diff of this commit: cvs rdiff -u -r1.89

CVS commit: src/external/bsd/openpam/dist/lib

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:15:03 UTC 2014 Modified Files: src/external/bsd/openpam/dist/lib: openpam_log.c Log Message: gcc 4.1 does not support pragma diagnostic ignored To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/external/bsd/ntp/lib/libntp

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:32:12 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libntp: Makefile Log Message: Gcc-4.1 does not have -Wno-error To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9

CVS commit: src/external/bsd/ntp/lib/libiscntp

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:37:53 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libiscntp: Makefile Log Message: gcc 4.1 does not have -Wno-error To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/external/bsd/ntp/lib/libopts

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:43:34 UTC 2014 Modified Files: src/external/bsd/ntp/lib/libopts: Makefile Log Message: ignore format errors for old gcc To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9

CVS commit: src/external/bsd/ntp/bin/ntpd

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 01:52:54 UTC 2014 Modified Files: src/external/bsd/ntp/bin/ntpd: Makefile Log Message: use the old style no-error for gcc-4.1 To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/external/bsd/tmux/dist

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:08:27 UTC 2014 Modified Files: src/external/bsd/tmux/dist: log.c Log Message: gcc-4.1 does not have the pragma diagnostic ignored To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/distrib/sets/lists/xdebug

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:32:57 UTC 2014 Modified Files: src/distrib/sets/lists/xdebug: md.vax Log Message: add missing. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/distrib/sets/lists/xdebug/md.vax Please note that

CVS commit: src/distrib/sets/lists/debug

2014-01-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 20 02:34:20 UTC 2014 Modified Files: src/distrib/sets/lists/debug: mi Log Message: fix typo To generate a diff of this commit: cvs rdiff -u -r1.49 -r1.50 src/distrib/sets/lists/debug/mi Please note that diffs are not

CVS commit: src/sys/kern

2014-01-19 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Mon Jan 20 07:47:22 UTC 2014 Modified Files: src/sys/kern: vfs_cache.c Log Message: Change cache_prune() to test for end-of-list before testing for an invalid entry. Prevents a lifelock when the end-of-list marker gets invalid