CVS commit: src/sys/dev/pci/ixgbe

2012-06-16 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 16 19:54:01 UTC 2012 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: Add explicit (void *) casts for when sysctl_createv() is passed CTLTYPE_INT but the address of a structure (and a function). To generate a

CVS commit: src/sys/arch/amd64

2012-06-16 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 16 20:47:04 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/arch/amd64/include: segments.h Log Message: memseg_baseaddr() is only called from valid_user_selector() and both only locally. Make

CVS commit: src/sys/dev/pci/ixgbe

2012-06-16 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 16 19:54:01 UTC 2012 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: Add explicit (void *) casts for when sysctl_createv() is passed CTLTYPE_INT but the address of a structure (and a function). To generate a

CVS commit: src/sys/arch/amd64

2012-06-16 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 16 20:47:04 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/arch/amd64/include: segments.h Log Message: memseg_baseaddr() is only called from valid_user_selector() and both only locally. Make

CVS commit: src/sys/arch/hp700/hp700

2012-06-08 Thread David Laight
Module Name:src Committed By: dsl Date: Fri Jun 8 07:53:41 UTC 2012 Modified Files: src/sys/arch/hp700/hp700: machdep.c Log Message: Fix type of variable passed to sysctl (int - bool). To generate a diff of this commit: cvs rdiff -u -r1.113 -r1.114

CVS commit: src/sys/arch/hp700/hp700

2012-06-08 Thread David Laight
Module Name:src Committed By: dsl Date: Fri Jun 8 07:53:41 UTC 2012 Modified Files: src/sys/arch/hp700/hp700: machdep.c Log Message: Fix type of variable passed to sysctl (int - bool). To generate a diff of this commit: cvs rdiff -u -r1.113 -r1.114

Re: CVS commit: src/sys/dev/dkwedge

2012-06-07 Thread David Laight
of the classic device names. Fall back to classic device names when the label has an empty name or the default name 'fictitious'. You probably also want to detect duplicate names... David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/etc

2012-06-05 Thread David Laight
+ \ - $(linecount $(sh $0.local $opts -s all)) )) + $(linecount $($HOST_SH $0.local $opts -s all)) )) Are \\s really not needed here? Not needed for line continuations inside shell constructs. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/kern

2012-06-04 Thread David Laight
a few more of those). The acpi ones won't matter because acpi is LE only. Unfortunately I don't think a cvs patch will apply ... On Jun 3, 2012, at 09:23, David Laight wrote: Module Name:src Committed By: dsl Date: Sun Jun 3 16:23:44 UTC 2012 Modified Files

Re: CVS commit: src/sys

2012-06-03 Thread David Laight
, like console settings configurable via installboot? You can request it from the boot.cfg file, there is no need for a second way - it only confuses things. David -- David Laight: da...@l8s.co.uk

CVS commit: src/sys/rump/librump/rumpkern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:45:11 UTC 2012 Modified Files: src/sys/rump/librump/rumpkern: rump.c Log Message: Fix build now that sysctl_createv() checks its arg type. To generate a diff of this commit: cvs rdiff -u -r1.240 -r1.241

CVS commit: src/external/cddl/osnet/dist/lib/libzfs/common

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:53:52 UTC 2012 Modified Files: src/external/cddl/osnet/dist/lib/libzfs/common: libzfs_sendrecv.c Log Message: Not sure why this has just started to fail! But it really isn't a good idea to compare a uint64_t to NULL.

CVS commit: src/tests/modules/k_helper

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:59:44 UTC 2012 Modified Files: src/tests/modules/k_helper: k_helper.c Log Message: Fix build - delete extra To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/modules/k_helper/k_helper.c Please

CVS commit: src/sys/kern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 11:37:45 UTC 2012 Modified Files: src/sys/kern: vfs_bio.c Log Message: Fix processing of vm.bufmem_lowater and vm.bufmem_hiwater on 64bit systems. The values are 'u_long' so copying them into an 'int' temporary (to avoid

CVS commit: src/sys/dev/pckbport

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 13:52:46 UTC 2012 Modified Files: src/sys/dev/pckbport: synaptics.c Log Message: Remove a couple of (void *) casts added in the previous commin. They aren't needed here (script error). To generate a diff of this commit:

CVS commit: src/sys/kern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 16:23:44 UTC 2012 Modified Files: src/sys/kern: vfs_bio.c Log Message: Use separate temporaries for the 'int' percentage and the 'long' water marks. Previous paniced on sparc64 due to a misaligned copy. To generate a

CVS commit: src/sys/rump/librump/rumpkern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:45:11 UTC 2012 Modified Files: src/sys/rump/librump/rumpkern: rump.c Log Message: Fix build now that sysctl_createv() checks its arg type. To generate a diff of this commit: cvs rdiff -u -r1.240 -r1.241

CVS commit: src/external/cddl/osnet/dist/lib/libzfs/common

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:53:52 UTC 2012 Modified Files: src/external/cddl/osnet/dist/lib/libzfs/common: libzfs_sendrecv.c Log Message: Not sure why this has just started to fail! But it really isn't a good idea to compare a uint64_t to NULL.

CVS commit: src/tests/modules/k_helper

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 10:59:44 UTC 2012 Modified Files: src/tests/modules/k_helper: k_helper.c Log Message: Fix build - delete extra To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/modules/k_helper/k_helper.c Please

CVS commit: src/sys/kern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 11:37:45 UTC 2012 Modified Files: src/sys/kern: vfs_bio.c Log Message: Fix processing of vm.bufmem_lowater and vm.bufmem_hiwater on 64bit systems. The values are 'u_long' so copying them into an 'int' temporary (to avoid

CVS commit: src/sys/dev/pckbport

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 13:52:46 UTC 2012 Modified Files: src/sys/dev/pckbport: synaptics.c Log Message: Remove a couple of (void *) casts added in the previous commin. They aren't needed here (script error). To generate a diff of this commit:

CVS commit: src/sys/kern

2012-06-03 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 3 16:23:44 UTC 2012 Modified Files: src/sys/kern: vfs_bio.c Log Message: Use separate temporaries for the 'int' percentage and the 'long' water marks. Previous paniced on sparc64 due to a misaligned copy. To generate a

CVS commit: src/sys/sys

2012-06-02 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 2 21:27:51 UTC 2012 Modified Files: src/sys/sys: cdefs.h Log Message: Add a __always_inline To generate a diff of this commit: cvs rdiff -u -r1.98 -r1.99 src/sys/sys/cdefs.h Please note that diffs are not public domain;

CVS commit: src/sbin/sysctl

2012-06-02 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 2 21:38:09 UTC 2012 Modified Files: src/sbin/sysctl: sysctl.c Log Message: Add support for unsigned decimal values. To generate a diff of this commit: cvs rdiff -u -r1.142 -r1.143 src/sbin/sysctl/sysctl.c Please note

CVS commit: src/sys/sys

2012-06-02 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 2 21:27:51 UTC 2012 Modified Files: src/sys/sys: cdefs.h Log Message: Add a __always_inline To generate a diff of this commit: cvs rdiff -u -r1.98 -r1.99 src/sys/sys/cdefs.h Please note that diffs are not public domain;

CVS commit: src/sys

2012-06-02 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 2 21:36:48 UTC 2012 Modified Files: src/sys/arch/evbppc/obs405/dev: obsled.c src/sys/arch/i386/i386: machdep.c src/sys/arch/macppc/dev: obio.c src/sys/arch/sparc64/dev: lom.c

CVS commit: src/sbin/sysctl

2012-06-02 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Jun 2 21:38:09 UTC 2012 Modified Files: src/sbin/sysctl: sysctl.c Log Message: Add support for unsigned decimal values. To generate a diff of this commit: cvs rdiff -u -r1.142 -r1.143 src/sbin/sysctl/sysctl.c Please note

Re: CVS commit: src/sys

2012-05-31 Thread David Laight
On Wed, May 30, 2012 at 05:11:09PM -0700, John Nemeth wrote: On Oct 11, 4:10pm, David Laight wrote: } } Module Name:src } Committed By: dsl } Date: Mon May 21 21:34:16 UTC 2012 } } Modified Files: } src/sys/arch/i386/stand/lib: exec.c } src/sys/arch

Re: CVS commit: src/sys

2012-05-31 Thread David Laight
On Thu, May 31, 2012 at 10:06:28AM +0200, Martin Husemann wrote: On Thu, May 31, 2012 at 07:38:53AM +0100, David Laight wrote: IIRC you can explicitly request (from boot.cfg) that any module be loaded. There is no need for boot itself to always try to load such a module. Yes

Re: CVS commit: src/sys

2012-05-31 Thread David Laight
On Thu, May 31, 2012 at 08:32:42PM +0200, Martin Husemann wrote: On Thu, May 31, 2012 at 06:30:38PM +0100, David Laight wrote: But you don't want /boot to try to load the module if the ffs code is present in the kernel. Since /boot has no way of knowing what is in the loaded kernel

CVS commit: src/sys/arch/amd64/amd64

2012-05-22 Thread David Laight
Module Name:src Committed By: dsl Date: Tue May 22 21:10:26 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: If we get a fault setting the user %gs, or on a iret that is returning to userspace, we must do a 'swapgs' to reload the kernel %gs_base.

CVS commit: src/sys/arch/amd64/amd64

2012-05-22 Thread David Laight
Module Name:src Committed By: dsl Date: Tue May 22 21:14:37 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: trap.c Log Message: Treat traps in kernel mode during the 'return to user' iret sequence as user faults. Based heavily in the i386 code with the correct opcode

CVS commit: src/sys/arch/amd64/amd64

2012-05-22 Thread David Laight
Module Name:src Committed By: dsl Date: Tue May 22 21:10:26 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: If we get a fault setting the user %gs, or on a iret that is returning to userspace, we must do a 'swapgs' to reload the kernel %gs_base.

CVS commit: src/sys/arch/amd64/amd64

2012-05-22 Thread David Laight
Module Name:src Committed By: dsl Date: Tue May 22 21:14:37 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: trap.c Log Message: Treat traps in kernel mode during the 'return to user' iret sequence as user faults. Based heavily in the i386 code with the correct opcode

CVS commit: src/sys

2012-05-21 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 21 21:34:16 UTC 2012 Modified Files: src/sys/arch/i386/stand/lib: exec.c src/sys/arch/sandpoint/stand/altboot: main.c src/sys/lib/libsa: ext2fs.c ffsv1.c ffsv2.c globals.c lfsv1.c lfsv2.c stand.h

CVS commit: src/sys

2012-05-21 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 21 21:34:16 UTC 2012 Modified Files: src/sys/arch/i386/stand/lib: exec.c src/sys/arch/sandpoint/stand/altboot: main.c src/sys/lib/libsa: ext2fs.c ffsv1.c ffsv2.c globals.c lfsv1.c lfsv2.c stand.h

CVS commit: src/sys/arch/amd64/include

2012-05-17 Thread David Laight
Module Name:src Committed By: dsl Date: Thu May 17 19:38:54 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Let the user of INTRENTRY_L() place a label on the 'swapgs' used when faulting from user space. To generate a diff of this commit:

CVS commit: src/sys/arch/amd64/include

2012-05-17 Thread David Laight
Module Name:src Committed By: dsl Date: Thu May 17 19:38:54 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Let the user of INTRENTRY_L() place a label on the 'swapgs' used when faulting from user space. To generate a diff of this commit:

CVS commit: src/sys/arch/amd64/include

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 20:51:20 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Move all the XEN differences to a single conditional. Merge the XEN/non-XEN versions of INTRFASTEXIT and INTR_RECURSE_HWFRAME by

CVS commit: src/sys/arch/amd64/include

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 21:04:10 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Add a ';' that got deleted in a slight tidyup. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18

CVS commit: src/sys/arch/amd64/amd64

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 21:09:29 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: Rejig the way TRAP() and ZTRAP() are defined and add Z/TRAP_NJ() that excludes the 'jmp alltraps'. Use the _NJ versions for trap entries

CVS commit: src/sys/arch/amd64/include

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 20:51:20 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Move all the XEN differences to a single conditional. Merge the XEN/non-XEN versions of INTRFASTEXIT and INTR_RECURSE_HWFRAME by

CVS commit: src/sys/arch/amd64/include

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 21:04:10 UTC 2012 Modified Files: src/sys/arch/amd64/include: frameasm.h Log Message: Add a ';' that got deleted in a slight tidyup. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18

CVS commit: src/sys/arch/amd64/amd64

2012-05-07 Thread David Laight
Module Name:src Committed By: dsl Date: Mon May 7 21:09:29 UTC 2012 Modified Files: src/sys/arch/amd64/amd64: vector.S Log Message: Rejig the way TRAP() and ZTRAP() are defined and add Z/TRAP_NJ() that excludes the 'jmp alltraps'. Use the _NJ versions for trap entries

CVS commit: src/sys

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 16:36:54 UTC 2012 Modified Files: src/sys/kern: kern_malloc.c uipc_mbuf.c src/sys/rump/librump/rumpkern: memalloc.c src/sys/sys: malloc.h mbuf.h param.h Log Message: Remove the unused 'struct malloc_type'

CVS commit: src/sys/dev/ieee1394

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 18:31:41 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwmem.c fwohcivar.h if_fwip.c Log Message: Change to consistently use M_FW for all malloc/free. It probably doesn't

CVS commit: src/sys

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 20:27:32 UTC 2012 Modified Files: src/sys/dev: firmload.c src/sys/dev/ieee1394: sbp.c src/sys/fs/efs: efs_ihash.c src/sys/kern: kern_malloc.c src/sys/netsmb: smb_conn.c smb_dev.c smb_iod.c

CVS commit: src/sys/dev/isa

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 21:13:56 UTC 2012 Modified Files: src/sys/dev/isa: isadmavar.h Log Message: Patch out the 'struct malloc_type' from the isa_dma alloc routines. All the i386 kernels now build To generate a diff of this commit: cvs rdiff

CVS commit: src/sys

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 16:36:54 UTC 2012 Modified Files: src/sys/kern: kern_malloc.c uipc_mbuf.c src/sys/rump/librump/rumpkern: memalloc.c src/sys/sys: malloc.h mbuf.h param.h Log Message: Remove the unused 'struct malloc_type'

CVS commit: src/sys/dev/ieee1394

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 18:31:41 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwmem.c fwohcivar.h if_fwip.c Log Message: Change to consistently use M_FW for all malloc/free. It probably doesn't

CVS commit: src/sys

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 20:27:32 UTC 2012 Modified Files: src/sys/dev: firmload.c src/sys/dev/ieee1394: sbp.c src/sys/fs/efs: efs_ihash.c src/sys/kern: kern_malloc.c src/sys/netsmb: smb_conn.c smb_dev.c smb_iod.c

CVS commit: src/sys/dev/isa

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 21:13:56 UTC 2012 Modified Files: src/sys/dev/isa: isadmavar.h Log Message: Patch out the 'struct malloc_type' from the isa_dma alloc routines. All the i386 kernels now build To generate a diff of this commit: cvs rdiff

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-22 Thread David Laight
brings the value inside valid range. The cast is really in the wrong place as well. I am 100% against adding casts of numeric values to appease a tool that isn't tracking the domains of the expressions. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libc/gen

2012-03-21 Thread David Laight
... David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libc

2012-03-13 Thread David Laight
fclose(), anything else is mostly pointless.) David -- David Laight: da...@l8s.co.uk

CVS commit: src/usr.sbin/installboot

2012-03-10 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Mar 10 18:42:19 UTC 2012 Modified Files: src/usr.sbin/installboot: installboot.8 src/usr.sbin/installboot/arch: i386.c Log Message: Some FAT16 filesystems don't have 'hidden sectors' correctly set to the offset of the

CVS commit: src/sys/arch/i386/stand/fatboot

2012-03-10 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Mar 10 23:59:36 UTC 2012 Modified Files: src/sys/arch/i386/stand/fatboot: Makefile fatboot.S Added Files: src/sys/arch/i386/stand/fatboot/fat12: Makefile Log Message: Add support for directly booting from FAT12

CVS commit: src/usr.sbin/installboot

2012-03-10 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Mar 10 18:42:19 UTC 2012 Modified Files: src/usr.sbin/installboot: installboot.8 src/usr.sbin/installboot/arch: i386.c Log Message: Some FAT16 filesystems don't have 'hidden sectors' correctly set to the offset of the

CVS commit: src/sys/arch/i386/stand/fatboot

2012-03-10 Thread David Laight
Module Name:src Committed By: dsl Date: Sat Mar 10 23:59:36 UTC 2012 Modified Files: src/sys/arch/i386/stand/fatboot: Makefile fatboot.S Added Files: src/sys/arch/i386/stand/fatboot/fat12: Makefile Log Message: Add support for directly booting from FAT12

Re: CVS commit: src/lib/libc

2012-03-04 Thread David Laight
a function that is like gets, but takes a buffer length (ie discards the \n - and maybe the rest of the line). That could be used as a compile-time substitute when the buffer size is known - ie when 'sizeof buffer != sizeof (char *)' David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libc

2012-03-04 Thread David Laight
On Sun, Mar 04, 2012 at 10:38:19PM +0200, Alan Barrett wrote: On Sun, 04 Mar 2012, David Laight wrote: I wonder it it would be worth adding a function that is like gets, but takes a buffer length (ie discards the \n - and maybe the rest of the line). C2011 has char *gets_s(char *s

Re: CVS commit: src/lib/libc

2012-03-04 Thread David Laight
On Sun, Mar 04, 2012 at 09:42:21PM +0100, Joerg Sonnenberger wrote: On Sun, Mar 04, 2012 at 08:20:20PM +, David Laight wrote: I wonder it it would be worth adding a function that is like gets, but takes a buffer length (ie discards the \n - and maybe the rest of the line

Re: CVS commit: src/sys/arch/sparc64/sparc64

2012-03-03 Thread David Laight
in a 32bit kernel? David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libc

2012-03-01 Thread David Laight
function not 'secure' versions. Microsoft's exception-throwing functions are even worse! (Mind you Microsoft's _snprintf() is particulary borked.) David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/usr.bin/tip

2012-02-24 Thread David Laight
On Fri, Feb 24, 2012 at 09:27:09AM +0100, Joerg Sonnenberger wrote: On Fri, Feb 24, 2012 at 08:11:19AM +, David Laight wrote: On Thu, Feb 23, 2012 at 11:39:19PM +, Joerg Sonnenberger wrote: Module Name: src Committed By: joerg Date: Thu Feb 23 23:39:19 UTC

Re: CVS commit: src/sys/kern

2012-01-31 Thread David Laight
than needed. The advantage of Joerg's is that you don't have to 'know' the type of the member. Sudden barin explosion - how about (untested): #define sizeof_var_struct(s, m, c) \ offsetof(s, m[0]) + (c) * (offsetof(s, m[1]) - offsetof(s, m[0])) David -- David Laight: da

Re: CVS commit: src/sys/kern

2012-01-31 Thread David Laight
think this will work: offsetof(s, m) + n * sizeof((s*)NULL-m[0]). I don't believe there is a problem using m[0], just m[non-constant-expr]. OTOH 'sizeof (s *)0-m[0]' might be deemed invalid (because it has an inferred dereference of NULL. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/kern

2012-01-22 Thread David Laight
-- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/arch/i386/i386

2012-01-21 Thread David Laight
printf into a separate function, so that it doesn't stack up when called recursively. (One just needs to make sure that the compiler doesn't inline it again.) Recursion in the kernel? Isn't that really frowned upon itself? David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev/bluetooth

2012-01-11 Thread David Laight
out changing the LED for caps-lock (and other locks) is pressed should change the LEDs on all keyboards, and the inter-device cross call could also cause problems. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev/rasops

2011-12-26 Thread David Laight
Hmmm... I wonder if it would (have been) better to #define 'variables' used as pre-processor predicates to themselves (ie #define alpha alpha) to avoid these issues? Probably a bit late to change things though! David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev

2011-12-02 Thread David Laight
On Thu, Dec 01, 2011 at 04:48:34PM -0500, Christos Zoulas wrote: On Dec 1, 5:50pm, da...@l8s.co.uk (David Laight) wrote: -- Subject: Re: CVS commit: src/sys/dev | I'd rather the .c file wasn't polluted with #ifdefs. | Probably better to #define fss_compat_ioctl(...) EINVAL somewhere

Re: CVS commit: src/lib/libcrypt

2011-12-01 Thread David Laight
. This is also true of the plethora of names for 'better' strcpy() and sprintf() functions available on some platforms. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Laight
the compat code loadable - in which case this would need to be a real function call (possibly an indirect one). David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev

2011-12-01 Thread David Laight
be a nice trick... I was thinking is something horrid that would make the source clean(ish). Avoiding the function call is only necessary for very space-constrained kernels. Which could be done by using a #define instead of the weak alias. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev/ic

2011-11-03 Thread David Laight
for examples. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/arch/sandpoint/stand/altboot

2011-10-31 Thread David Laight
that can be reordered before/after one that matters - so need greater control than enforcing specific membars. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/libexec/ld.elf_so/arch/powerpc

2011-10-28 Thread David Laight
of using FP registers for memory copy? (Or some other integer-only action) Or is that only a problem with specific architectures due to the way the instruction set has been defined to gcc. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libperfuse

2011-10-23 Thread David Laight
value, and the highest value is probably useful. David [1] The 'memory' limits are based on the amount of physical memory, the relevant system limit would actually include the amount of swap. -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/lib/libc

2011-10-16 Thread David Laight
) fcntl(fd, F_SETFD, 0); return fd; } #endif and the use open_clowxec() in the code. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/dev/ata

2011-10-05 Thread David Laight
for 256 sectors is probably a good idea! David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread David Laight
with the missing prototype being a compile error, and remove the cast. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/tests/lib/libm

2011-09-16 Thread David Laight
. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/external/bsd/bind/dist/lib/isc/include/isc

2011-09-14 Thread David Laight
() checking the result from ferror/fprintf will only give a false sense of security - and make the code unreadable. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/etc/mtree

2011-09-07 Thread David Laight
-- David Laight: da...@l8s.co.uk

Re: CVS commit: src/etc/mtree

2011-09-05 Thread David Laight
. Mostly make will look for files in SRCDIR before OBJDIR. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src

2011-09-02 Thread David Laight
problem, especially since (char *)0 isn't a useful definition! This is where 'lint' comes in handy, since it (effectively) checked that args matched the inferred prototype ... David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src

2011-08-23 Thread David Laight
to a library. However it is also reasonable to 'ride' another recent minor version change. I'd have thought that these functions could be added 'hidded' to allow other developers (etc) to do further testing, then the version bumped when they are made visible by default. David -- David Laight

Re: CVS commit: src/bin/sh

2011-08-23 Thread David Laight
as the asm output from gcc for a compilation that is known to get it wrong. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/bin/sh

2011-08-23 Thread David Laight
problem. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/arch/ofppc/ofppc

2011-08-18 Thread David Laight
when playing 'hunt the label'. After all disks get moved between machines. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/arch/i386/conf

2011-08-09 Thread David Laight
and change the kernel config/build to build modules then link the required ones into a partially linked kernel with 'ld -r' before doing a final link to a fully fixed up kernel. This should also make it possible for a user to include an extra module. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src

2011-08-01 Thread David Laight
On Mon, Aug 01, 2011 at 12:28:55PM +, Marc Balmer wrote: According to the Oxford Dictionary of Etymology, a wether is a male sheep or ram. I always thought it was a ram without its 'bits'... David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys

2011-07-30 Thread David Laight
that you couldn't avoid a lock, and algorithms that claimed to do so were broken. The so-called atomic ops effectively use the data item itself as the lock. For a single access this might be a gain because 'unlock' often needs another synchronising bus cycle. David -- David Laight: da

Re: CVS commit: src/sbin/disklabel

2011-07-26 Thread David Laight
agnostic. 8k sectors, 8k fragments and 64k blocks should work for FFSv1 and FFSv2. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/crypto/external/bsd/openssl/lib/libcrypto/arch

2011-07-25 Thread David Laight
generation of AMD CPUs. So essentially, IIRC it is something to do with branch prediction? But my memory keeps thinking of a constraint about the number of branches/labels in a cache line - and I'm sure the non-use of 1 byte return instructions was all related. David -- David Laight: da

Re: CVS commit: src/crypto/external/bsd/openssl/lib/libcrypto/arch

2011-07-25 Thread David Laight
On Mon, Jul 25, 2011 at 08:38:13PM +0200, Joerg Sonnenberger wrote: On Mon, Jul 25, 2011 at 07:24:57PM +0100, David Laight wrote: On Mon, Jul 25, 2011 at 11:52:52AM +0200, Joerg Sonnenberger wrote: Much better. One thing remains. It would be nice to replace .byte 0xf3,0xc3

Re: CVS commit: src/sys/arch

2011-07-18 Thread David Laight
:~dsl/protoz David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/sys/kern

2011-06-05 Thread David Laight
On Thu, Jun 02, 2011 at 09:21:11PM +0100, David Laight wrote: On Thu, Jun 02, 2011 at 06:54:44PM +, David Laight wrote: Module Name:src Committed By: dsl Date: Thu Jun 2 18:54:44 UTC 2011 Modified Files: src/sys/kern: vfs_syscalls.c Log

CVS commit: src/sys/compat

2011-06-05 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Jun 5 08:42:59 UTC 2011 Modified Files: src/sys/compat/linux/common: linux_sched.c src/sys/compat/netbsd32: netbsd32_fs.c netbsd32_netbsd.c Log Message: Delete some splurious commas and very unexpected trailing space

<    1   2   3   4   5   6   7   8   9   >