CVS commit: src/sys/dev/ieee1394

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:01:32 UTC 2022 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: fwip_async_output(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with "IF_POLL() -> IF_DEQUEUE() on success". To generate a diff

CVS commit: src/sys/dev/ieee1394

2022-08-20 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sat Aug 20 19:01:32 UTC 2022 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: fwip_async_output(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with "IF_POLL() -> IF_DEQUEUE() on success". To generate a diff

CVS commit: src/sys/dev/ieee1394

2021-12-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Dec 20 19:56:42 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ieee1394: Need kernel lock around config_found. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54

CVS commit: src/sys/dev/ieee1394

2021-12-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Dec 20 19:56:42 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ieee1394: Need kernel lock around config_found. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54

CVS commit: src/sys/dev/ieee1394

2021-12-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 08:17:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: s/transcat/transact/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ieee1394/fwohci.c Please

CVS commit: src/sys/dev/ieee1394

2021-12-05 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 08:17:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: s/transcat/transact/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.148 -r1.149 src/sys/dev/ieee1394/fwohci.c Please

CVS commit: src/sys/dev/ieee1394

2021-11-10 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Nov 10 16:08:17 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: s/avaliable/available/ To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/ieee1394/fwdev.c Please note that diffs

CVS commit: src/sys/dev/ieee1394

2021-11-10 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Nov 10 16:08:17 UTC 2021 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: s/avaliable/available/ To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/ieee1394/fwdev.c Please note that diffs

CVS commit: src/sys/dev/ieee1394

2021-04-12 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Apr 12 09:22:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.h Log Message: convert union member from [0] array to [3] array, so that attempts to access these members later will work. does not affect size of the

CVS commit: src/sys/dev/ieee1394

2021-04-12 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Apr 12 09:22:21 UTC 2021 Modified Files: src/sys/dev/ieee1394: firewire.h Log Message: convert union member from [0] array to [3] array, so that attempts to access these members later will work. does not affect size of the

CVS commit: src/sys/dev/ieee1394

2020-01-28 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Wed Jan 29 06:19:39 UTC 2020 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: Adopt . To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/ieee1394/if_fwip.c Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2020-01-28 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Wed Jan 29 06:19:39 UTC 2020 Modified Files: src/sys/dev/ieee1394: if_fwip.c Log Message: Adopt . To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/dev/ieee1394/if_fwip.c Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2019-10-15 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Oct 15 18:21:47 UTC 2019 Modified Files: src/sys/dev/ieee1394: firewire.c fwohci.c fwohcireg.h Log Message: Use unsigned to avoid undefined behavior. Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.48

CVS commit: src/sys/dev/ieee1394

2019-10-15 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Oct 15 18:21:47 UTC 2019 Modified Files: src/sys/dev/ieee1394: firewire.c fwohci.c fwohcireg.h Log Message: Use unsigned to avoid undefined behavior. Found by kUBSan. To generate a diff of this commit: cvs rdiff -u -r1.48

CVS commit: src/sys/dev/ieee1394

2019-09-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Sep 23 06:56:20 UTC 2019 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused assignment. Found by the lgtm bot. To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/dev/ieee1394/sbp.c

CVS commit: src/sys/dev/ieee1394

2019-09-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Sep 23 06:56:20 UTC 2019 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused assignment. Found by the lgtm bot. To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/dev/ieee1394/sbp.c

CVS commit: src/sys/dev/ieee1394

2018-12-13 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Dec 13 16:38:26 UTC 2018 Modified Files: src/sys/dev/ieee1394: fwdma.c Log Message: Fix fwdma_free() for when bus_dmamap_unload() clobbers the dmamap. Prevents KASSERTs on detaches of sbp(4) and fwohci(4) on amd64. We

CVS commit: src/sys/dev/ieee1394

2018-12-13 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Dec 13 16:38:26 UTC 2018 Modified Files: src/sys/dev/ieee1394: fwdma.c Log Message: Fix fwdma_free() for when bus_dmamap_unload() clobbers the dmamap. Prevents KASSERTs on detaches of sbp(4) and fwohci(4) on amd64. We

CVS commit: src/sys/dev/ieee1394

2018-03-31 Thread Sevan Janiyan
Module Name:src Committed By: sevan Date: Sat Mar 31 14:50:45 UTC 2018 Modified Files: src/sys/dev/ieee1394: fwohcireg.h Log Message: Listed UniNorth device is in fact the UniNorth 2 interface, rename. https://pci-ids.ucw.cz/read/PC/106b/0031 To generate a diff of this

CVS commit: src/sys/dev/ieee1394

2018-03-31 Thread Sevan Janiyan
Module Name:src Committed By: sevan Date: Sat Mar 31 14:50:45 UTC 2018 Modified Files: src/sys/dev/ieee1394: fwohcireg.h Log Message: Listed UniNorth device is in fact the UniNorth 2 interface, rename. https://pci-ids.ucw.cz/read/PC/106b/0031 To generate a diff of this

CVS commit: src/sys/dev/ieee1394

2017-06-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 25 12:39:27 UTC 2017 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: memory leak, found by Mootja; it seems that we should check the return value of 'fw_bindadd' in several other places, but whatever To

CVS commit: src/sys/dev/ieee1394

2017-06-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 25 12:39:27 UTC 2017 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: memory leak, found by Mootja; it seems that we should check the return value of 'fw_bindadd' in several other places, but whatever To

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Nov 21 01:19:35 UTC 2016 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Let's try initializing the pointers *before* dereferencing them! Oops. To generate a diff of this commit: cvs rdiff -u -r1.140 -r1.141

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Nov 21 01:19:35 UTC 2016 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Let's try initializing the pointers *before* dereferencing them! Oops. To generate a diff of this commit: cvs rdiff -u -r1.140 -r1.141

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:56:13 UTC 2016 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: KASSERT(mutex_owner(...)) ---> KASSERT(mutex_owned(...)) If this is not correct, then there's something bogus in this code anyway, so

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:56:13 UTC 2016 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: KASSERT(mutex_owner(...)) ---> KASSERT(mutex_owned(...)) If this is not correct, then there's something bogus in this code anyway, so

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:47:39 UTC 2016 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwohci.c Log Message: Kill some more tsleep. And no, surrounding tsleep by mutex_exit/mutex_enter does not fix problems even

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:47:39 UTC 2016 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwohci.c Log Message: Kill some more tsleep. And no, surrounding tsleep by mutex_exit/mutex_enter does not fix problems even

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:36:45 UTC 2016 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwohci.c Log Message: Defer initialization of isodma channels until we know how many. Should fix a bug I introduced four years ago

CVS commit: src/sys/dev/ieee1394

2016-11-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Nov 20 22:36:45 UTC 2016 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwohci.c Log Message: Defer initialization of isodma channels until we know how many. Should fix a bug I introduced four years ago

CVS commit: src/sys/dev/ieee1394

2014-11-21 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Fri Nov 21 23:37:25 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: No reason not to make the string const. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/sys/dev/ieee1394/fwcrom.c Please

CVS commit: src/sys/dev/ieee1394

2014-11-21 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Fri Nov 21 23:37:25 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: No reason not to make the string const. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/sys/dev/ieee1394/fwcrom.c Please

CVS commit: src/sys/dev/ieee1394

2014-09-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Sep 21 17:10:01 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: fix cut-n-paste, use arrays instead of separate variables to avoid code duplication. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/ieee1394

2014-09-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Sep 21 18:03:47 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: ran sed too agressively. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/ieee1394/fwcrom.c Please note that

CVS commit: src/sys/dev/ieee1394

2014-09-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Sep 21 18:03:47 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: ran sed too agressively. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/ieee1394/fwcrom.c Please note that

CVS commit: src/sys/dev/ieee1394

2014-03-27 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Mar 28 02:16:47 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: Deal with snprintf more gracefully. To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/ieee1394/fwcrom.c Please

CVS commit: src/sys/dev/ieee1394

2014-03-27 Thread Hisashi T Fujinaka
Module Name:src Committed By: htodd Date: Fri Mar 28 04:09:19 UTC 2014 Modified Files: src/sys/dev/ieee1394: iec13213.h Log Message: Fix build. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ieee1394/iec13213.h Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2014-03-27 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Mar 28 02:16:47 UTC 2014 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: Deal with snprintf more gracefully. To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/ieee1394/fwcrom.c Please

CVS commit: src/sys/dev/ieee1394

2014-03-27 Thread Hisashi T Fujinaka
Module Name:src Committed By: htodd Date: Fri Mar 28 04:09:19 UTC 2014 Modified Files: src/sys/dev/ieee1394: iec13213.h Log Message: Fix build. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ieee1394/iec13213.h Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2013-10-16 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Oct 16 17:40:55 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: add missing ifdefs To generate a diff of this commit: cvs rdiff -u -r1.135 -r1.136 src/sys/dev/ieee1394/fwohci.c Please note that diffs

CVS commit: src/sys/dev/ieee1394

2013-10-16 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Oct 16 17:40:55 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: add missing ifdefs To generate a diff of this commit: cvs rdiff -u -r1.135 -r1.136 src/sys/dev/ieee1394/fwohci.c Please note that diffs

CVS commit: src/sys/dev/ieee1394

2013-09-15 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Sep 15 13:52:23 UTC 2013 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused variables To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/ieee1394/sbp.c Please note that diffs are

CVS commit: src/sys/dev/ieee1394

2013-09-15 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sun Sep 15 13:52:23 UTC 2013 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Remove unused variables To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/ieee1394/sbp.c Please note that diffs are

CVS commit: src/sys/dev/ieee1394

2013-09-12 Thread Martin Husemann
Module Name:src Committed By: martin Date: Thu Sep 12 20:16:51 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Make it compilable with gcc 4.8.1 To generate a diff of this commit: cvs rdiff -u -r1.134 -r1.135 src/sys/dev/ieee1394/fwohci.c Please

CVS commit: src/sys/dev/ieee1394

2013-09-12 Thread Martin Husemann
Module Name:src Committed By: martin Date: Thu Sep 12 20:16:51 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Make it compilable with gcc 4.8.1 To generate a diff of this commit: cvs rdiff -u -r1.134 -r1.135 src/sys/dev/ieee1394/fwohci.c Please

CVS commit: src/sys/dev/ieee1394

2013-04-07 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Sun Apr 7 07:42:20 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Add '\n' to tail of printing string. To generate a diff of this commit: cvs rdiff -u -r1.133 -r1.134 src/sys/dev/ieee1394/fwohci.c

CVS commit: src/sys/dev/ieee1394

2013-04-07 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Sun Apr 7 07:42:20 UTC 2013 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: Add '\n' to tail of printing string. To generate a diff of this commit: cvs rdiff -u -r1.133 -r1.134 src/sys/dev/ieee1394/fwohci.c

CVS commit: src/sys/dev/ieee1394

2012-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 5 02:36:16 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: Restore config pending stuff, adjusted to avoid the race. Leave a note about what this code probably should look like for anyone who

CVS commit: src/sys/dev/ieee1394

2012-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 5 02:47:52 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ...and be sure to config_pending_decr if kthread_create fails. This error branch looks suspect, though. Shouldn't we bail at this

CVS commit: src/sys/dev/ieee1394

2012-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 5 02:36:16 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: Restore config pending stuff, adjusted to avoid the race. Leave a note about what this code probably should look like for anyone who

CVS commit: src/sys/dev/ieee1394

2012-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Aug 5 02:47:52 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: ...and be sure to config_pending_decr if kthread_create fails. This error branch looks suspect, though. Shouldn't we bail at this

CVS commit: src/sys/dev/ieee1394

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 18:31:41 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwmem.c fwohcivar.h if_fwip.c Log Message: Change to consistently use M_FW for all malloc/free. It probably doesn't

CVS commit: src/sys/dev/ieee1394

2012-04-29 Thread David Laight
Module Name:src Committed By: dsl Date: Sun Apr 29 18:31:41 UTC 2012 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwmem.c fwohcivar.h if_fwip.c Log Message: Change to consistently use M_FW for all malloc/free. It probably doesn't

CVS commit: src/sys/dev/ieee1394

2011-04-24 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sun Apr 24 18:52:26 UTC 2011 Modified Files: src/sys/dev/ieee1394: firewirereg.h Log Message: Inclusion for malloc decls (missed in previous commit). To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/sys/dev/ieee1394

2011-04-24 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sun Apr 24 18:52:26 UTC 2011 Modified Files: src/sys/dev/ieee1394: firewirereg.h Log Message: Inclusion for malloc decls (missed in previous commit). To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16

CVS commit: src/sys/dev/ieee1394

2010-11-14 Thread Masao Uebayashi
Module Name:src Committed By: uebayasi Date: Sun Nov 14 15:47:20 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.h firewirereg.h Log Message: Include dependencies directly. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6

CVS commit: src/sys/dev/ieee1394

2010-11-14 Thread Masao Uebayashi
Module Name:src Committed By: uebayasi Date: Sun Nov 14 15:47:20 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.h firewirereg.h Log Message: Include dependencies directly. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6

CVS commit: src/sys/dev/ieee1394

2010-09-07 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Tue Sep 7 07:19:46 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: convert tsleep to kpause To generate a diff of this commit: cvs rdiff -u -r1.129 -r1.130 src/sys/dev/ieee1394/fwohci.c Please note that

CVS commit: src/sys/dev/ieee1394

2010-09-07 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Tue Sep 7 07:26:54 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h Log Message: do not assume all fw devices speak sbp. teach the fw attach code to deal with different fw device classes. this allows other

CVS commit: src/sys/dev/ieee1394

2010-09-07 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Tue Sep 7 07:26:54 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h Log Message: do not assume all fw devices speak sbp. teach the fw attach code to deal with different fw device classes. this allows other

Converting to condvar(9) [Was: Re: CVS commit: src/sys/dev/ieee1394]

2010-09-05 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c The right fix would be to use condvar(9). Generally, tsleep(9) should be replaced and

Re: CVS commit: src/sys/dev/ieee1394

2010-08-31 Thread Christoph Egger
On 26.08.10 16:31, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: cegger Date: Thu Aug 26 12:48:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs

CVS commit: src/sys/dev/ieee1394

2010-08-29 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sun Aug 29 21:14:16 UTC 2010 Modified Files: src/sys/dev/ieee1394: sbp.h Log Message: Confilict - Conflict To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ieee1394/sbp.h Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2010-08-29 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sun Aug 29 21:15:26 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: fix grammar in error message To generate a diff of this commit: cvs rdiff -u -r1.128 -r1.129 src/sys/dev/ieee1394/fwohci.c Please note

CVS commit: src/sys/dev/ieee1394

2010-08-29 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sun Aug 29 21:14:16 UTC 2010 Modified Files: src/sys/dev/ieee1394: sbp.h Log Message: Confilict - Conflict To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ieee1394/sbp.h Please note that diffs are not

CVS commit: src/sys/dev/ieee1394

2010-08-29 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sun Aug 29 21:15:26 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: fix grammar in error message To generate a diff of this commit: cvs rdiff -u -r1.128 -r1.129 src/sys/dev/ieee1394/fwohci.c Please note

Re: CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: cegger Date: Thu Aug 26 12:48:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24

CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Thu Aug 26 07:36:53 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwcrom.c iec13213.h Log Message: - print expected crc when it does not match - add and print secondary text leaf. This prints the model name of my webcam. - add

CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Thu Aug 26 08:56:16 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: fix crash when detaching/re-attaching a cable where three firewire devices are on the bus. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Thu Aug 26 07:36:53 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwcrom.c iec13213.h Log Message: - print expected crc when it does not match - add and print secondary text leaf. This prints the model name of my webcam. - add

CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Thu Aug 26 12:48:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c

CVS commit: src/sys/dev/ieee1394

2010-08-16 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Mon Aug 16 06:05:07 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: do not hold mutexes when calling tsleep(9). Fixes LOCKDEBUG panics To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23

CVS commit: src/sys/dev/ieee1394

2010-08-16 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Mon Aug 16 06:05:07 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: do not hold mutexes when calling tsleep(9). Fixes LOCKDEBUG panics To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23

CVS commit: src/sys/dev/ieee1394

2010-08-14 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sat Aug 14 10:39:36 UTC 2010 Modified Files: src/sys/dev/ieee1394: sbp.c Log Message: Fix sbp attach/detach. When plugging a firewire webcam, sbp attaches. sbpattach() calls sbp_alloc_target(). In sbp_alloc_target,

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Jun Ebihara
Hello Christos! From: chris...@zoulas.com (Christos Zoulas) Subject: Re: CVS commit: src/sys/dev/ieee1394 Date: Mon, 24 May 2010 10:36:49 -0400 | In many cases, there is a case that cannot be fixed in several days. For | instance, MIPS cannot be booted since merge mips64. This is not also

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Christos Zoulas
On May 25, 4:33pm, j...@soum.co.jp (Jun Ebihara) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hello Christos! | | From: chris...@zoulas.com (Christos Zoulas) | Subject: Re: CVS commit: src/sys/dev/ieee1394 | Date: Mon, 24 May 2010 10:36:49 -0400 | | | In many cases

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | Yes. It knows I was broken, too. However, it worked on my ofppc and | it booted my amd64. Try booting with DIAGNOSTIC. If you make any changes to the kernel you should be really compiling with DIAGNOSTIC. It should be tested both with DEBUG and

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Christos Zoulas
On May 24, 2:23pm, kiyoh...@kk.iij4u.or.jp (KIYOHARA Takashi) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hi! Christos, | | | From: Christos Zoulas chris...@netbsd.org | Date: Sun, 23 May 2010 14:56:59 -0400 | | Module Name:src | Committed By: christos | Date

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Izumi Tsutsui
Why you revert it all? Wasn't it broken? I had been investigating the problem of kmem since last week. Was not There is no reason to leave kernels broken even if you have some idea for proper fixes. You can put them even after you (or other guys) revert the previous changes, can't you? ---

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread KIYOHARA Takashi
Hi! From: Izumi Tsutsui tsut...@ceres.dti.ne.jp Date: Mon, 24 May 2010 22:08:21 +0900 Why you revert it all? Wasn't it broken? Yes. It knows I was broken, too. However, it worked on my ofppc and it booted my amd64. I had been investigating the problem of kmem since last week. Was not

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Izumi Tsutsui
In many cases, there is a case that cannot be fixed in several days. For In any case you should revert your changes first if you know you broke the tree and you can't fix it soon. --- Izumi Tsutsui

Re: CVS commit: src/sys/dev/ieee1394

2010-05-24 Thread Christos Zoulas
On May 24, 10:32pm, kiyoh...@kk.iij4u.or.jp (KIYOHARA Takashi) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hi! | | | From: Izumi Tsutsui tsut...@ceres.dti.ne.jp | Date: Mon, 24 May 2010 22:08:21 +0900 | | Why you revert it all? | | Wasn't it broken? | | Yes. It knows I

Re: CVS commit: src/sys/dev/ieee1394

2010-05-23 Thread KIYOHARA Takashi
Hi! Christos, From: Christos Zoulas chris...@netbsd.org Date: Sun, 23 May 2010 14:56:59 -0400 Module Name: src Committed By: christos Date: Sun May 23 18:56:59 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h fwdev.c fwdma.c fwmem.c

CVS commit: src/sys/dev/ieee1394

2010-05-22 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun May 23 02:24:40 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h Log Message: don't allocate rom scratch memory from an interrupt context: fwohci0: BUS reset panic: kernel diagnostic assertion

CVS commit: src/sys/dev/ieee1394

2010-05-22 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun May 23 02:24:40 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c firewirereg.h Log Message: don't allocate rom scratch memory from an interrupt context: fwohci0: BUS reset panic: kernel diagnostic assertion

CVS commit: src/sys/dev/ieee1394

2010-05-22 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun May 23 02:25:50 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c fwohcivar.h Log Message: Don't allocate sid scratch memory from an interrupt context: fwohci0: BUS reset fwohci0: node_id=0xc800ffc0, gen=1,

CVS commit: src/sys/dev/ieee1394

2010-05-15 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Sat May 15 10:42:51 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: Add mutex.h. To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/ieee1394/firewire.c Please note that diffs are

CVS commit: src/sys/dev/ieee1394

2010-05-14 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Fri May 14 12:10:07 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: Use kmem(9) instead of malloc(9). To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/ieee1394/fwdev.c Please note

CVS commit: src/sys/dev/ieee1394

2010-05-14 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Fri May 14 12:25:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c Log Message: May be easy to understand 'pay_len 0' more than 'paylaod != NULL'. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32

CVS commit: src/sys/dev/ieee1394

2010-05-14 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Fri May 14 12:10:07 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: Use kmem(9) instead of malloc(9). To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/ieee1394/fwdev.c Please note

CVS commit: src/sys/dev/ieee1394

2010-05-10 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Mon May 10 12:17:33 UTC 2010 Modified Files: src/sys/dev/ieee1394: firewire.c fwdev.c fwdma.c fwmem.c fwohci.c if_fwip.c sbp.c Log Message: Use kmem(9) instead of malloc(9). To generate a diff of this commit: cvs

Re: CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread Adam Hoka
On Thu, 29 Apr 2010 06:56:00 + KIYOHARA Takashi kiyoh...@netbsd.org wrote: Module Name: src Committed By: kiyohara Date: Thu Apr 29 06:56:00 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdma.c Log Message: Call malloc(M_ZERO) instead of malloc() and memset(). Why

Re: CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Hi! From: Adam Hoka adam.h...@gmail.com Date: Thu, 29 Apr 2010 09:38:31 +0200 On Thu, 29 Apr 2010 06:56:00 + KIYOHARA Takashi kiyoh...@netbsd.org wrote: Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:56:00 UTC 2010 Modified Files:

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:51:26 UTC 2010 Modified Files: src/sys/dev/ieee1394: sbp.c sbp.h Log Message: + Use structs scsipi_inquiry_data/scsi_sense_data instead of scsi3_inquiry_data/ scsi3_sense_data. + s/switch()/switch ()/. + Change

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:53:13 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: + Fix typo. + Call aprint_error_dev() instead of aprint_error(). To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:53:49 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: Remove unnecessary cast. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/dev/ieee1394/fwdev.c Please note that

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:56:00 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdma.c Log Message: Call malloc(M_ZERO) instead of malloc() and memset(). To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:51:26 UTC 2010 Modified Files: src/sys/dev/ieee1394: sbp.c sbp.h Log Message: + Use structs scsipi_inquiry_data/scsi_sense_data instead of scsi3_inquiry_data/ scsi3_sense_data. + s/switch()/switch ()/. + Change

CVS commit: src/sys/dev/ieee1394

2010-04-29 Thread KIYOHARA Takashi
Module Name:src Committed By: kiyohara Date: Thu Apr 29 06:53:13 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwohci.c Log Message: + Fix typo. + Call aprint_error_dev() instead of aprint_error(). To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125

CVS commit: src/sys/dev/ieee1394

2010-04-24 Thread Christoph Egger
Module Name:src Committed By: cegger Date: Sat Apr 24 21:34:29 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwcrom.c Log Message: ANSIfy, KNF To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ieee1394/fwcrom.c Please note that diffs are not

  1   2   >