CVS commit: src/sys/netinet

2018-05-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 18 18:58:51 UTC 2018 Modified Files: src/sys/netinet: dccp_usrreq.c ip_carp.c tcp_input.c tcp_sack.c udp_usrreq.c Log Message: IP6_EXTHDR_GET -> M_REGION_GET, no functional change. To generate a diff of this

CVS commit: src/sys/netinet

2018-05-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 18 18:28:40 UTC 2018 Modified Files: src/sys/netinet: ip6.h Log Message: Remove IP6_EXTHDR_GET0, remove pointless XXXs, and style. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/netinet/ip6.h

CVS commit: src/sys/netinet

2018-05-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 18 18:28:40 UTC 2018 Modified Files: src/sys/netinet: ip6.h Log Message: Remove IP6_EXTHDR_GET0, remove pointless XXXs, and style. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/netinet/ip6.h

CVS commit: src/sys/netinet

2018-05-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu May 17 07:30:14 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Remove reference to tcpiphdr in comment. To generate a diff of this commit: cvs rdiff -u -r1.207 -r1.208 src/sys/netinet/tcp_output.c Please

CVS commit: src/sys/netinet

2018-05-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu May 17 07:30:14 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Remove reference to tcpiphdr in comment. To generate a diff of this commit: cvs rdiff -u -r1.207 -r1.208 src/sys/netinet/tcp_output.c Please

CVS commit: src/sys/netinet

2018-05-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon May 14 17:26:16 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Don't crash if there is no inner IP header. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/netinet/ip_mroute.c

CVS commit: src/sys/netinet

2018-05-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon May 14 17:26:16 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Don't crash if there is no inner IP header. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/netinet/ip_mroute.c

CVS commit: src/sys/netinet

2018-05-13 Thread Pierre Pronchery
Module Name:src Committed By: khorben Date: Sun May 13 22:42:52 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Fix spello in a comment To generate a diff of this commit: cvs rdiff -u -r1.230 -r1.231 src/sys/netinet/in.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-05-13 Thread Pierre Pronchery
Module Name:src Committed By: khorben Date: Sun May 13 22:42:52 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Fix spello in a comment To generate a diff of this commit: cvs rdiff -u -r1.230 -r1.231 src/sys/netinet/in.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-05-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun May 13 18:39:06 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Clarify ESP-in-UDP. To generate a diff of this commit: cvs rdiff -u -r1.250 -r1.251 src/sys/netinet/udp_usrreq.c Please note that diffs are

CVS commit: src/sys/netinet

2018-05-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun May 13 18:39:06 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Clarify ESP-in-UDP. To generate a diff of this commit: cvs rdiff -u -r1.250 -r1.251 src/sys/netinet/udp_usrreq.c Please note that diffs are

CVS commit: src/sys/netinet

2018-05-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 11 14:07:58 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: Make sure we have at least an IP header, and remove pointless XXXs (there is no issue). To generate a diff of this commit: cvs rdiff -u -r1.176

CVS commit: src/sys/netinet

2018-05-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 11 14:07:58 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: Make sure we have at least an IP header, and remove pointless XXXs (there is no issue). To generate a diff of this commit: cvs rdiff -u -r1.176

CVS commit: src/sys/netinet

2018-05-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 11 13:56:43 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: static To generate a diff of this commit: cvs rdiff -u -r1.274 -r1.275 src/sys/netinet/if_arp.c Please note that diffs are not public domain;

CVS commit: src/sys/netinet

2018-05-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 11 13:56:43 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: static To generate a diff of this commit: cvs rdiff -u -r1.274 -r1.275 src/sys/netinet/if_arp.c Please note that diffs are not public domain;

CVS commit: src/sys/netinet

2018-05-07 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Mon May 7 23:42:13 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Fix unsigned wraparound on window size calculations. This is another instance where tp->rcv_adv - tp->rcv_nxt can wrap around after successful

CVS commit: src/sys/netinet

2018-05-07 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Mon May 7 23:42:13 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Fix unsigned wraparound on window size calculations. This is another instance where tp->rcv_adv - tp->rcv_nxt can wrap around after successful

CVS commit: src/sys/netinet

2018-05-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon May 7 19:34:04 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Fix possible buffer overflow. We need to make sure the inner IPv4 packet doesn't have options, because we validate only an option-less header.

CVS commit: src/sys/netinet

2018-05-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon May 7 19:34:04 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Fix possible buffer overflow. We need to make sure the inner IPv4 packet doesn't have options, because we validate only an option-less header.

CVS commit: src/sys/netinet

2018-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue May 1 08:42:41 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Remove unused argument from udp4_espinudp, and remove unused includes. To generate a diff of this commit: cvs rdiff -u -r1.249 -r1.250

CVS commit: src/sys/netinet

2018-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue May 1 08:42:41 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Remove unused argument from udp4_espinudp, and remove unused includes. To generate a diff of this commit: cvs rdiff -u -r1.249 -r1.250

CVS commit: src/sys/netinet

2018-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue May 1 07:03:33 UTC 2018 Modified Files: src/sys/netinet: tcp_debug.h Log Message: Redefine the structure, not to rely on tcpiphdr. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/netinet/tcp_debug.h

CVS commit: src/sys/netinet

2018-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue May 1 07:03:33 UTC 2018 Modified Files: src/sys/netinet: tcp_debug.h Log Message: Redefine the structure, not to rely on tcpiphdr. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/netinet/tcp_debug.h

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Le 29/04/2018 à 16:24, Christos Zoulas a écrit : In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: -=-=-=-=-=- Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src/sys/netinet:

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Christos Zoulas
In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: maxv >Date: Sun Apr 29 12:12:42 UTC 2018 > >Modified Files: > src/sys/netinet: tcp_var.h tcpip.h > >Log Message: >Move struct

CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src/sys/netinet: tcp_var.h tcpip.h Log Message: Move struct tcpiphdr from tcpip.h to tcp_var.h, to match UDP (udpiphdr in udp_var.h). tcpip.h is now empty, and can be removed. To

CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src/sys/netinet: tcp_var.h tcpip.h Log Message: Move struct tcpiphdr from tcpip.h to tcp_var.h, to match UDP (udpiphdr in udp_var.h). tcpip.h is now empty, and can be removed. To

CVS commit: src/sys/netinet

2018-04-23 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Tue Apr 24 01:32:30 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Fix sys/netinet/in.c:r1.229 problem. I have missed FALLTHROUGH, sorry. To generate a diff of this commit: cvs rdiff -u -r1.229 -r1.230

CVS commit: src/sys/netinet

2018-04-23 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Tue Apr 24 01:32:30 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Fix sys/netinet/in.c:r1.229 problem. I have missed FALLTHROUGH, sorry. To generate a diff of this commit: cvs rdiff -u -r1.229 -r1.230

CVS commit: src/sys/netinet

2018-04-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 21 13:22:06 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove #ifndef __vax__. The check enforces a 4-byte-aligned size for the option mbuf. If the size is not multiple of 4, the computation of

CVS commit: src/sys/netinet

2018-04-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 21 13:22:06 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove #ifndef __vax__. The check enforces a 4-byte-aligned size for the option mbuf. If the size is not multiple of 4, the computation of

CVS commit: src/sys/netinet

2018-04-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Apr 19 21:21:44 UTC 2018 Modified Files: src/sys/netinet: in.h in_var.h tcp_vtw.h Log Message: s/static inline/static __inline/g for consistency. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105

CVS commit: src/sys/netinet

2018-04-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Apr 19 21:21:44 UTC 2018 Modified Files: src/sys/netinet: in.h in_var.h tcp_vtw.h Log Message: s/static inline/static __inline/g for consistency. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 09:29:04 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Improve the check, we want to have len >= udphdr all the time, and not just when the packet size doesn't match the mbuf size. Normally that's

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 09:29:04 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Improve the check, we want to have len >= udphdr all the time, and not just when the packet size doesn't match the mbuf size. Normally that's

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 09:00:29 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove useless comment and style. To generate a diff of this commit: cvs rdiff -u -r1.301 -r1.302 src/sys/netinet/ip_output.c Please note

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 09:00:29 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove useless comment and style. To generate a diff of this commit: cvs rdiff -u -r1.301 -r1.302 src/sys/netinet/ip_output.c Please note

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 08:47:46 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Reduce the diff between similar blocks. To generate a diff of this commit: cvs rdiff -u -r1.300 -r1.301 src/sys/netinet/ip_output.c Please

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 08:47:46 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Reduce the diff between similar blocks. To generate a diff of this commit: cvs rdiff -u -r1.300 -r1.301 src/sys/netinet/ip_output.c Please

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 08:12:51 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Reorder a few instructions to clarify. Replace two bcopy by memcpy. To generate a diff of this commit: cvs rdiff -u -r1.299 -r1.300

CVS commit: src/sys/netinet

2018-04-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 13 08:12:51 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Reorder a few instructions to clarify. Replace two bcopy by memcpy. To generate a diff of this commit: cvs rdiff -u -r1.299 -r1.300

CVS commit: src/sys/netinet

2018-04-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Apr 12 07:45:29 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: Make 'opts' local to rip_sbappendaddr(). To generate a diff of this commit: cvs rdiff -u -r1.174 -r1.175 src/sys/netinet/raw_ip.c Please note

CVS commit: src/sys/netinet

2018-04-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Apr 12 07:45:29 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: Make 'opts' local to rip_sbappendaddr(). To generate a diff of this commit: cvs rdiff -u -r1.174 -r1.175 src/sys/netinet/raw_ip.c Please note

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:29:19 UTC 2018 Modified Files: src/sys/netinet: ip_flow.c Log Message: Remove whitespaces/tabs, and one non-ASCII character. To generate a diff of this commit: cvs rdiff -u -r1.81 -r1.82 src/sys/netinet/ip_flow.c

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:29:19 UTC 2018 Modified Files: src/sys/netinet: ip_flow.c Log Message: Remove whitespaces/tabs, and one non-ASCII character. To generate a diff of this commit: cvs rdiff -u -r1.81 -r1.82 src/sys/netinet/ip_flow.c

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:11:20 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Don't pass IP_ALLOWBROADCAST in ipsec4_input. The flag lands in ipsec_getpolicybyaddr, and only IP_FORWARDING is taken. In fact it would be good

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:11:20 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Don't pass IP_ALLOWBROADCAST in ipsec4_input. The flag lands in ipsec_getpolicybyaddr, and only IP_FORWARDING is taken. In fact it would be good

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:52:26 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Small changes in ip_dooptions: replace bcopy by memcpy, the areas can't overlap. To generate a diff of this commit: cvs rdiff -u -r1.376

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:52:26 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Small changes in ip_dooptions: replace bcopy by memcpy, the areas can't overlap. To generate a diff of this commit: cvs rdiff -u -r1.376

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:15:12 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add 'static', like the prototype. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/netinet/ip_reass.c Please note that

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:15:12 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add 'static', like the prototype. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/netinet/ip_reass.c Please note that

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 06:26:00 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 06:26:00 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:59:43 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.155 -r1.156 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:59:43 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.155 -r1.156 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:38:47 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273 src/sys/netinet/if_arp.c Please note that diffs are not public domain;

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:38:47 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273 src/sys/netinet/if_arp.c Please note that diffs are not public domain;

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:41:14 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Remove unused mbuf argument from arpcreate() and arplookup(). To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:41:14 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Remove unused mbuf argument from arpcreate() and arplookup(). To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:22:35 UTC 2018 Modified Files: src/sys/netinet: igmp.c Log Message: Replace comment by KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.66 -r1.67 src/sys/netinet/igmp.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:22:35 UTC 2018 Modified Files: src/sys/netinet: igmp.c Log Message: Replace comment by KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.66 -r1.67 src/sys/netinet/igmp.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-04-08 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Apr 8 13:52:22 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Protect ip_dad_count with if NARP > 0 to fix compilation To generate a diff of this commit: cvs rdiff -u -r1.227 -r1.228 src/sys/netinet/in.c

CVS commit: src/sys/netinet

2018-04-08 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Apr 8 13:52:22 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Protect ip_dad_count with if NARP > 0 to fix compilation To generate a diff of this commit: cvs rdiff -u -r1.227 -r1.228 src/sys/netinet/in.c

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 12:18:06 UTC 2018 Modified Files: src/sys/netinet: ip_var.h tcp_input.c Log Message: Remove the ipre_mlast field and the TRAVERSE macro. The goal was to store in ipre_mlast the last mbuf of the chain, so that m_cat

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 12:18:06 UTC 2018 Modified Files: src/sys/netinet: ip_var.h tcp_input.c Log Message: Remove the ipre_mlast field and the TRAVERSE macro. The goal was to store in ipre_mlast the last mbuf of the chain, so that m_cat

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 11:50:46 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused field, and sync comment with reality. To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/netinet/ip_var.h

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 11:50:46 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused field, and sync comment with reality. To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/netinet/ip_var.h

CVS commit: src/sys/netinet

2018-04-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 7 13:48:50 UTC 2018 Modified Files: src/sys/netinet: tcp_fsm.h tcp_usrreq.c Log Message: Remove dead code. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/netinet/tcp_fsm.h cvs rdiff -u -r1.217

CVS commit: src/sys/netinet

2018-04-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 7 13:48:50 UTC 2018 Modified Files: src/sys/netinet: tcp_fsm.h tcp_usrreq.c Log Message: Remove dead code. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/netinet/tcp_fsm.h cvs rdiff -u -r1.217

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 8:02 PM Roy Marples wrote: > On 06/04/2018 11:59, Ryota Ozaki wrote: > > On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > >> On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > >>> On 06/04/2018 10:19, Ryota

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 16:01:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Revert the previous two commits as per roy@'s request It broke the ip_dad_count > 0 case unexpectedly. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 16:01:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Revert the previous two commits as per roy@'s request It broke the ip_dad_count > 0 case unexpectedly. To generate a diff of this commit: cvs

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 11:59, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: >> On 06/04/2018 10:19, Ryota Ozaki wrote: >>> >>> Module Name:src >>> Committed By: ozaki-r >>> Date: Fri Apr 6 09:19:16 UTC 2018 >>>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > On 06/04/2018 10:19, Ryota Ozaki wrote: >> >> Module Name:src >> Committed By: ozaki-r >> Date: Fri Apr 6 09:19:16 UTC 2018 >> >> Modified Files: >> src/sys/netinet: in.c >> >> Log Message: >>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) This change is not right. You are clearing the flags

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:20:29 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't set IN_IFF_* flags to ia4_flags if DAD is disabled This fix allows that a GARP packet is sent when adding an IP address to an interface with

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:20:29 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't set IN_IFF_* flags to ia4_flags if DAD is disabled This fix allows that a GARP packet is sent when adding an IP address to an interface with

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) To generate a diff of this commit: cvs rdiff -u -r1.223 -r1.224 src/sys/netinet/in.c Please

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) To generate a diff of this commit: cvs rdiff -u -r1.223 -r1.224 src/sys/netinet/in.c Please

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:46:01 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused fields and outdated comment. To generate a diff of this commit: cvs rdiff -u -r1.122 -r1.123 src/sys/netinet/ip_var.h Please note

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:46:01 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused fields and outdated comment. To generate a diff of this commit: cvs rdiff -u -r1.122 -r1.123 src/sys/netinet/ip_var.h Please note

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:02:34 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: bcopy -> memcpy, it's obvious the areas don't overlap. To generate a diff of this commit: cvs rdiff -u -r1.204 -r1.205

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:02:34 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: bcopy -> memcpy, it's obvious the areas don't overlap. To generate a diff of this commit: cvs rdiff -u -r1.204 -r1.205

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:58:47 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Change the check to be <= instead of <. This fixes one occurrence of an apparently widespread division-by-zero bug in our TCP code: if a user

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:58:47 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Change the check to be <= instead of <. This fixes one occurrence of an apparently widespread division-by-zero bug in our TCP code: if a user

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:46:50 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Reorder and style, for clarity. To generate a diff of this commit: cvs rdiff -u -r1.202 -r1.203 src/sys/netinet/tcp_output.c Please note

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:46:50 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Reorder and style, for clarity. To generate a diff of this commit: cvs rdiff -u -r1.202 -r1.203 src/sys/netinet/tcp_output.c Please note

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Robert Elz
Date:Sat, 31 Mar 2018 15:33:30 +0100 From:Alexander Nasonov Message-ID: <20180331143330.GB22190@neva> | After looking at email archives I see that many active developers | are "guilty" of committing 'hi dev@' messages. It used to be common.

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Taylor R Campbell
> Date: Sat, 31 Mar 2018 14:53:36 +0100 > From: Alexander Nasonov > > Taylor R Campbell wrote: > > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be > > offputting -- and it's not really necessary to call them out publicly. > > Sometimes dev@ has a rapport with

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Robert Elz wrote: > I totally agree with this - and it is worse when included in commit logs > wherte it will remain, visible, and actually viewed, forever (unlike even > in a mailing list, which while archived forever, somewhere, usually > falls quickly out of view.) Searching for archived email

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Taylor R Campbell wrote: > They mean different things. > > `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. > > `ok dev@' means `dev@ reviewed and approved this change'. I'm well aware they mean different things. > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Robert Elz
Date:Sat, 31 Mar 2018 03:07:29 + From:Taylor R Campbell Message-ID: <20180331030950.2325d60...@jupiter.mumble.net> | but a passive observer can't tell the difference between | one colleague joshing another and

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Taylor R Campbell
> Date: Thu, 29 Mar 2018 23:53:42 +0100 > From: Alexander Nasonov > > m...@netbsd.org wrote: > > I seem to recall a discussion about wanting to avoid this type > > of commit message (hi dev-name), as it can be seen as excessively > > hostile. > > 'ok rmind@' would definitely be

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Christos Zoulas
In article , Maxime Villard wrote: >Le 30/03/2018 à 00:34, m...@netbsd.org a écrit : >> On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: >>> Module Name:src >>> Committed By: rmind >>>

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:57:32 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Remove dead code. It was introduced in rev1 (25 years ago), and is irrelevant today. To generate a diff of this commit: cvs rdiff -u -r1.201

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:57:32 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Remove dead code. It was introduced in rev1 (25 years ago), and is irrelevant today. To generate a diff of this commit: cvs rdiff -u -r1.201

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:53:51 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Style, use NULL for pointers, use KASSERT, and don't inline huge functions, we want to debug them with DDB (and not just with GPROF). To

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:53:51 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Style, use NULL for pointers, use KASSERT, and don't inline huge functions, we want to debug them with DDB (and not just with GPROF). To

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:25:06 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Fix the log. mtod never returns NULL, so 'ip' is always non-NULL, and the 'ip6' branch is never taken. As a result we log garbage on IPv6

<    1   2   3   4   5   6   7   8   9   10   >