Module Name:src
Committed By: maxv
Date: Fri Mar 30 08:25:06 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Fix the log. mtod never returns NULL, so 'ip' is always non-NULL, and the
'ip6' branch is never taken. As a result we log garbage on IPv6
Module Name:src
Committed By: maxv
Date: Fri Mar 30 07:11:40 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Use consttime_memequal instead of memcmp, to prevent side channels. This
functions returns 1 when the buffers are equal, contrary to memcmp,
Module Name:src
Committed By: maxv
Date: Fri Mar 30 07:11:40 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Use consttime_memequal instead of memcmp, to prevent side channels. This
functions returns 1 when the buffers are equal, contrary to memcmp,
Le 30/03/2018 à 00:34, m...@netbsd.org a écrit :
On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote:
Module Name:src
Committed By: rmind
Date: Thu Mar 29 21:40:53 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
tcp_urp_drop: fix
Le 29/03/2018 à 23:40, Mindaugas Rasiukevicius a écrit :
Module Name:src
Committed By: rmind
Date: Thu Mar 29 21:40:53 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@).
To generate a diff of
m...@netbsd.org wrote:
> I seem to recall a discussion about wanting to avoid this type
> of commit message (hi dev-name), as it can be seen as excessively
> hostile.
'ok rmind@' would definitely be better than 'hi maxv@'.
Hostile? I don't think so. I personally quite like it.
--
Alex
On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote:
> Module Name: src
> Committed By: rmind
> Date: Thu Mar 29 21:40:53 UTC 2018
>
> Modified Files:
> src/sys/netinet: tcp_input.c
>
> Log Message:
> tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@).
Module Name:src
Committed By: rmind
Date: Thu Mar 29 21:40:53 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@).
To generate a diff of this commit:
cvs rdiff -u -r1.400 -r1.401
Module Name:src
Committed By: rmind
Date: Thu Mar 29 21:40:53 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@).
To generate a diff of this commit:
cvs rdiff -u -r1.400 -r1.401
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:46:17 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Reorder/Fix comments to clarify.
To generate a diff of this commit:
cvs rdiff -u -r1.398 -r1.399 src/sys/netinet/tcp_input.c
Please note that
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:46:17 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Reorder/Fix comments to clarify.
To generate a diff of this commit:
cvs rdiff -u -r1.398 -r1.399 src/sys/netinet/tcp_input.c
Please note that
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:12:36 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove two more 'else' branches.
To generate a diff of this commit:
cvs rdiff -u -r1.397 -r1.398 src/sys/netinet/tcp_input.c
Please note that
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:12:36 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove two more 'else' branches.
To generate a diff of this commit:
cvs rdiff -u -r1.397 -r1.398 src/sys/netinet/tcp_input.c
Please note that
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:09:00 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Fix memory leak, we may reallocate 'tcp_saveti' after 'findpcb'. It's not
a tragic bug, because it happens only on sockets with debug enabled.
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:09:00 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Fix memory leak, we may reallocate 'tcp_saveti' after 'findpcb'. It's not
a tragic bug, because it happens only on sockets with debug enabled.
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:01:46 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove 'else', makes it clearer that we leave.
To generate a diff of this commit:
cvs rdiff -u -r1.395 -r1.396 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Thu Mar 29 17:01:46 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove 'else', makes it clearer that we leave.
To generate a diff of this commit:
cvs rdiff -u -r1.395 -r1.396 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Thu Mar 29 16:59:38 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Clarify with KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.394 -r1.395 src/sys/netinet/tcp_input.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Thu Mar 29 16:59:38 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Clarify with KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.394 -r1.395 src/sys/netinet/tcp_input.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Thu Mar 29 16:54:59 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Simplify the computation:
m->m_pkthdr.len - sizeof(struct tcphdr) - optlen - hlen
= m->m_pkthdr.len - (sizeof(struct tcphdr)
Module Name:src
Committed By: maxv
Date: Thu Mar 29 16:54:59 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Simplify the computation:
m->m_pkthdr.len - sizeof(struct tcphdr) - optlen - hlen
= m->m_pkthdr.len - (sizeof(struct tcphdr)
Module Name:src
Committed By: maxv
Date: Thu Mar 29 08:11:41 UTC 2018
Modified Files:
src/sys/netinet: tcp_subr.c
Log Message:
Misc changes; no real functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.274 -r1.275 src/sys/netinet/tcp_subr.c
Please
Module Name:src
Committed By: maxv
Date: Thu Mar 29 08:11:41 UTC 2018
Modified Files:
src/sys/netinet: tcp_subr.c
Log Message:
Misc changes; no real functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.274 -r1.275 src/sys/netinet/tcp_subr.c
Please
Module Name:src
Committed By: maxv
Date: Thu Mar 29 07:46:43 UTC 2018
Modified Files:
src/sys/netinet: tcp_congctl.c tcp_debug.c tcp_output.c tcp_sack.c
tcp_subr.c tcp_timer.c tcp_usrreq.c
Log Message:
Remove #ifdef INET. Same as tcp_input.c. Makes the code
Module Name:src
Committed By: maxv
Date: Thu Mar 29 07:46:43 UTC 2018
Modified Files:
src/sys/netinet: tcp_congctl.c tcp_debug.c tcp_output.c tcp_sack.c
tcp_subr.c tcp_timer.c tcp_usrreq.c
Log Message:
Remove #ifdef INET. Same as tcp_input.c. Makes the code
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:43:55 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Several changes in syn_cache_respond:
* Replace idiotic diagnostic check by KASSERT. max_linkhdr+tlen<=MCLBYTES
is a widespread assumption.
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:43:55 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Several changes in syn_cache_respond:
* Replace idiotic diagnostic check by KASSERT. max_linkhdr+tlen<=MCLBYTES
is a widespread assumption.
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:30:42 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove unused variable.
To generate a diff of this commit:
cvs rdiff -u -r1.391 -r1.392 src/sys/netinet/tcp_input.c
Please note that diffs
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:30:42 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove unused variable.
To generate a diff of this commit:
cvs rdiff -u -r1.391 -r1.392 src/sys/netinet/tcp_input.c
Please note that diffs
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:22:16 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_var.h
Log Message:
Remove two unused args from syn_cache_get().
To generate a diff of this commit:
cvs rdiff -u -r1.390 -r1.391
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:22:16 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_var.h
Log Message:
Remove two unused args from syn_cache_get().
To generate a diff of this commit:
cvs rdiff -u -r1.390 -r1.391
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:16:59 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Dedup: introduce tcp_urp_drop() and use it.
To generate a diff of this commit:
cvs rdiff -u -r1.389 -r1.390 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Wed Mar 28 14:16:59 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Dedup: introduce tcp_urp_drop() and use it.
To generate a diff of this commit:
cvs rdiff -u -r1.389 -r1.390 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Wed Mar 28 13:50:14 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Minor changes: style, improve comments (and put them at the correct place),
use NULL for pointers, and add {}s to prevent confusion.
To
Module Name:src
Committed By: maxv
Date: Wed Mar 28 13:50:14 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Minor changes: style, improve comments (and put them at the correct place),
use NULL for pointers, and add {}s to prevent confusion.
To
Module Name:src
Committed By: maxv
Date: Fri Mar 23 09:30:55 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove #ifdef INET. Nobody is doing that in the kernel, and there are
even IPv4 places that are not covered here.
To generate a diff of this
Module Name:src
Committed By: maxv
Date: Fri Mar 23 09:30:55 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove #ifdef INET. Nobody is doing that in the kernel, and there are
even IPv4 places that are not covered here.
To generate a diff of this
Module Name:src
Committed By: maxv
Date: Fri Mar 23 08:57:40 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Improve a bit here and there. Replace bcopy by memcpy/memmove.
To generate a diff of this commit:
cvs rdiff -u -r1.386 -r1.387
Module Name:src
Committed By: maxv
Date: Fri Mar 23 08:57:40 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Improve a bit here and there. Replace bcopy by memcpy/memmove.
To generate a diff of this commit:
cvs rdiff -u -r1.386 -r1.387
Module Name:src
Committed By: maxv
Date: Thu Mar 22 21:19:28 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Don't pass a pointer to tcp_reass, otherwise it looks like it can modify
tlen while it doesn't.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: maxv
Date: Thu Mar 22 21:19:28 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Don't pass a pointer to tcp_reass, otherwise it looks like it can modify
tlen while it doesn't.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: maxv
Date: Thu Mar 22 21:10:17 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Rearrange a bit. No real functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.384 -r1.385 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Thu Mar 22 21:10:17 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Rearrange a bit. No real functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.384 -r1.385 src/sys/netinet/tcp_input.c
Module Name:src
Committed By: maxv
Date: Thu Mar 22 20:48:38 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Don't call tcp_input_checksum again, it was already called earlier, no
need to checksum twice.
Then call tcp_fields_to_host a bit earlier, so
Module Name:src
Committed By: maxv
Date: Thu Mar 22 20:48:38 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Don't call tcp_input_checksum again, it was already called earlier, no
need to checksum twice.
Then call tcp_fields_to_host a bit earlier, so
Module Name:src
Committed By: maxv
Date: Wed Mar 21 15:33:25 UTC 2018
Modified Files:
src/sys/netinet: ip_carp.c
Log Message:
Fix an untriggerable memory leak. carp_prepare_ad does not fail, so switch
it to void.
To generate a diff of this commit:
cvs rdiff -u -r1.94
Module Name:src
Committed By: maxv
Date: Wed Mar 21 15:33:25 UTC 2018
Modified Files:
src/sys/netinet: ip_carp.c
Log Message:
Fix an untriggerable memory leak. carp_prepare_ad does not fail, so switch
it to void.
To generate a diff of this commit:
cvs rdiff -u -r1.94
Module Name:src
Committed By: khorben
Date: Sat Mar 10 23:28:13 UTC 2018
Modified Files:
src/sys/netinet: tcp_output.c
Log Message:
Fix spello in a comment
To generate a diff of this commit:
cvs rdiff -u -r1.198 -r1.199 src/sys/netinet/tcp_output.c
Please note that
Module Name:src
Committed By: khorben
Date: Sat Mar 10 23:28:13 UTC 2018
Modified Files:
src/sys/netinet: tcp_output.c
Log Message:
Fix spello in a comment
To generate a diff of this commit:
cvs rdiff -u -r1.198 -r1.199 src/sys/netinet/tcp_output.c
Please note that
Module Name:src
Committed By: ozaki-r
Date: Tue Mar 6 07:19:03 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Tweak sanity checks
Scheduling a timer of static entries is wrong.
To generate a diff of this commit:
cvs rdiff -u -r1.268 -r1.269
Module Name:src
Committed By: ozaki-r
Date: Tue Mar 6 07:19:03 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Tweak sanity checks
Scheduling a timer of static entries is wrong.
To generate a diff of this commit:
cvs rdiff -u -r1.268 -r1.269
Module Name:src
Committed By: roy
Date: Thu Mar 1 14:40:57 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Sprinkle some const.
To generate a diff of this commit:
cvs rdiff -u -r1.267 -r1.268 src/sys/netinet/if_arp.c
Please note that diffs are not
Module Name:src
Committed By: roy
Date: Thu Mar 1 14:40:57 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Sprinkle some const.
To generate a diff of this commit:
cvs rdiff -u -r1.267 -r1.268 src/sys/netinet/if_arp.c
Please note that diffs are not
Module Name:src
Committed By: maxv
Date: Thu Mar 1 06:08:44 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Revert rev1.183 (2003).
It was intended as an optimization, but it increases the attack surface:
the IPsec policy is not enforced on RST
Module Name:src
Committed By: maxv
Date: Thu Mar 1 06:08:44 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Revert rev1.183 (2003).
It was intended as an optimization, but it increases the attack surface:
the IPsec policy is not enforced on RST
Module Name:src
Committed By: maxv
Date: Wed Feb 28 11:10:22 UTC 2018
Modified Files:
src/sys/netinet: raw_ip.c
Log Message:
(just forgot to commit this file, the message was)
Remove duplicate IPSEC_STATINC(IPSEC_STAT_IN_POLVIO), ipsec_in_reject
already increases it.
Module Name:src
Committed By: maxv
Date: Wed Feb 28 11:10:22 UTC 2018
Modified Files:
src/sys/netinet: raw_ip.c
Log Message:
(just forgot to commit this file, the message was)
Remove duplicate IPSEC_STATINC(IPSEC_STAT_IN_POLVIO), ipsec_in_reject
already increases it.
Module Name:src
Committed By: christos
Date: Wed Feb 14 16:45:24 UTC 2018
Modified Files:
src/sys/netinet: raw_ip.c
Log Message:
join lines where they fit.
To generate a diff of this commit:
cvs rdiff -u -r1.167 -r1.168 src/sys/netinet/raw_ip.c
Please note that diffs
Module Name:src
Committed By: christos
Date: Wed Feb 14 16:45:24 UTC 2018
Modified Files:
src/sys/netinet: raw_ip.c
Log Message:
join lines where they fit.
To generate a diff of this commit:
cvs rdiff -u -r1.167 -r1.168 src/sys/netinet/raw_ip.c
Please note that diffs
I've reverted the change, I'll re-investigate this later.
Maxime
Le 13/02/2018 à 18:40, Frank Kardel a écrit :
This must be revisited - IKE/racoon breaks with 1.240.
racoon listens on port 500. packets for port 500 arrive at the interface
(tcpdump sees them), but racoon NEVER receives any
Module Name:src
Committed By: maxv
Date: Wed Feb 14 05:24:44 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
Revert my two last changes in this file. They are apparently causing
problems with racoon, I'll investigate this later.
To generate a diff of
Module Name:src
Committed By: maxv
Date: Wed Feb 14 05:24:44 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
Revert my two last changes in this file. They are apparently causing
problems with racoon, I'll investigate this later.
To generate a diff of
This must be revisited - IKE/racoon breaks with 1.240.
racoon listens on port 500. packets for port 500 arrive at the interface
(tcpdump sees them), but racoon NEVER receives any packets for port 500
(debug/ktuss sees nothing).
Frank
On 02/10/18 09:17, Maxime Villard wrote:
Module Name:
Module Name:src
Committed By: maxv
Date: Tue Feb 13 14:50:28 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Mmh. Add a missing check: if ARP was disabled on the interface, don't
process ARP packets. Otherwise the kernel will add ARP entries even if
Module Name:src
Committed By: maxv
Date: Tue Feb 13 14:50:28 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Mmh. Add a missing check: if ARP was disabled on the interface, don't
process ARP packets. Otherwise the kernel will add ARP entries even if
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:47:41 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Be tougher:
* In arpintr(), don't allow IEEE1394 packets on non-IEEE1394 interfaces.
* In revarpinput(), kick IEEE1394 packets right away. They
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:47:41 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Be tougher:
* In arpintr(), don't allow IEEE1394 packets on non-IEEE1394 interfaces.
* In revarpinput(), kick IEEE1394 packets right away. They
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:31:01 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Same change as rev1.258, but this time in revarpinput: use m_pullup.
To generate a diff of this commit:
cvs rdiff -u -r1.262 -r1.263
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:31:01 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Same change as rev1.258, but this time in revarpinput: use m_pullup.
To generate a diff of this commit:
cvs rdiff -u -r1.262 -r1.263
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:20:50 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Minor stylistic changes, and use C99 types.
To generate a diff of this commit:
cvs rdiff -u -r1.261 -r1.262 src/sys/netinet/if_arp.c
Please note
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:20:50 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Minor stylistic changes, and use C99 types.
To generate a diff of this commit:
cvs rdiff -u -r1.261 -r1.262 src/sys/netinet/if_arp.c
Please note
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:05:05 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Replace dead code by KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.260 -r1.261 src/sys/netinet/if_arp.c
Please note that diffs
Module Name:src
Committed By: maxv
Date: Tue Feb 13 10:05:05 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Replace dead code by KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.260 -r1.261 src/sys/netinet/if_arp.c
Please note that diffs
Module Name:src
Committed By: maxv
Date: Tue Feb 13 08:51:38 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Don't force ARPHRD_IEEE1394 on IEEE1394 interfaces. If it's not there, then
kick the packet. And do this earlier.
To generate a diff of this
Module Name:src
Committed By: maxv
Date: Tue Feb 13 08:51:38 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Don't force ARPHRD_IEEE1394 on IEEE1394 interfaces. If it's not there, then
kick the packet. And do this earlier.
To generate a diff of this
Module Name:src
Committed By: maxv
Date: Tue Feb 13 08:20:12 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Use only one label, clearer.
To generate a diff of this commit:
cvs rdiff -u -r1.258 -r1.259 src/sys/netinet/if_arp.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Tue Feb 13 08:20:12 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Use only one label, clearer.
To generate a diff of this commit:
cvs rdiff -u -r1.258 -r1.259 src/sys/netinet/if_arp.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Tue Feb 13 07:51:24 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Fix three things in arpintr():
* mtod can't return NULL.
* It is wrong to kick the packet if m->m_len < arplen. While this check
always
Module Name:src
Committed By: maxv
Date: Tue Feb 13 07:51:24 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Fix three things in arpintr():
* mtod can't return NULL.
* It is wrong to kick the packet if m->m_len < arplen. While this check
always
Module Name:src
Committed By: maxv
Date: Tue Feb 13 07:44:25 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Style, no functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.256 -r1.257 src/sys/netinet/if_arp.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Tue Feb 13 07:44:25 UTC 2018
Modified Files:
src/sys/netinet: if_arp.c
Log Message:
Style, no functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.256 -r1.257 src/sys/netinet/if_arp.c
Please note that diffs are
Module Name:src
Committed By: christos
Date: Mon Feb 12 18:19:12 UTC 2018
Modified Files:
src/sys/netinet: ip_output.c
Log Message:
Keep a pointer to the interface of the multicast membership, because the
multicast element itself might go away in in_delmulti (but the
Module Name:src
Committed By: christos
Date: Mon Feb 12 18:19:12 UTC 2018
Modified Files:
src/sys/netinet: ip_output.c
Log Message:
Keep a pointer to the interface of the multicast membership, because the
multicast element itself might go away in in_delmulti (but the
Module Name:src
Committed By: maxv
Date: Mon Feb 12 09:31:06 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
Don't rebase the pointers. 'm' is only allowed to become NULL (which
means 'processed').
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: maxv
Date: Mon Feb 12 09:31:06 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
Don't rebase the pointers. 'm' is only allowed to become NULL (which
means 'processed').
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:22:27 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_output.c tcp_var.h
Log Message:
Remove unused argument from tcp_signature_getsav.
To generate a diff of this commit:
cvs rdiff -u -r1.378 -r1.379
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:22:27 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_output.c tcp_var.h
Log Message:
Remove unused argument from tcp_signature_getsav.
To generate a diff of this commit:
cvs rdiff -u -r1.378 -r1.379
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:13:08 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Add a KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.377 -r1.378 src/sys/netinet/tcp_input.c
Please note that diffs are not
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:13:08 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Add a KASSERT.
To generate a diff of this commit:
cvs rdiff -u -r1.377 -r1.378 src/sys/netinet/tcp_input.c
Please note that diffs are not
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:08:28 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_var.h
Log Message:
Remove the 'm' argument from syn_cache_respond(); all it does with it is
freeing it, so free in the caller instead.
To generate a
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:08:28 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c tcp_var.h
Log Message:
Remove the 'm' argument from syn_cache_respond(); all it does with it is
freeing it, so free in the caller instead.
To generate a
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:03:42 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove this multicast check. Multicast packets are already dropped at
the beginning of the function.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: maxv
Date: Mon Feb 12 08:03:42 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Remove this multicast check. Multicast packets are already dropped at
the beginning of the function.
To generate a diff of this commit:
cvs
Le 10/02/2018 à 23:49, David H. Gutteridge a écrit :
On Mon, 05 Feb 2018, at 13:23:11 +, Maxime Villard wrote:
Module Name:src
Committed By: maxv
Date: Mon Feb 5 13:23:11 UTC 2018
Modified Files:
src/sys/netinet: ip_input.c
Log Message:
Disable ip_allowsrcrt and
On Mon, 05 Feb 2018, at 13:23:11 +, Maxime Villard wrote:
>Module Name:src
>Committed By: maxv
>Date: Mon Feb 5 13:23:11 UTC 2018
>
>Modified Files:
>src/sys/netinet: ip_input.c
>
>Log Message:
>Disable ip_allowsrcrt and ip_forwsrcrt. Enabling them by default was a
Module Name:src
Committed By: maxv
Date: Sat Feb 10 08:17:00 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
If the socket wants a ESP-over-UDP packet, and the packet is incorrect,
stop processing it instead of giving it to udp4_sendup. It just doesn't
Module Name:src
Committed By: maxv
Date: Sat Feb 10 08:17:00 UTC 2018
Modified Files:
src/sys/netinet: udp_usrreq.c
Log Message:
If the socket wants a ESP-over-UDP packet, and the packet is incorrect,
stop processing it instead of giving it to udp4_sendup. It just doesn't
Module Name:src
Committed By: maxv
Date: Fri Feb 9 14:06:18 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Style, and move the 'ip_srcroute' call after 'tcp_dooptions', otherwise
we're leaking 'ipopts'. (Harmless, since TCP_SIGNATURE is disabled.)
Module Name:src
Committed By: maxv
Date: Fri Feb 9 14:06:18 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Style, and move the 'ip_srcroute' call after 'tcp_dooptions', otherwise
we're leaking 'ipopts'. (Harmless, since TCP_SIGNATURE is disabled.)
Module Name:src
Committed By: maxv
Date: Fri Feb 9 08:03:33 UTC 2018
Modified Files:
src/sys/netinet: ip_mroute.c
Log Message:
Style (realign everything correctly), and fix a typo.
To generate a diff of this commit:
cvs rdiff -u -r1.153 -r1.154
401 - 500 of 1479 matches
Mail list logo
