CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Feb 9 08:03:33 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style (realign everything correctly), and fix a typo. To generate a diff of this commit: cvs rdiff -u -r1.153 -r1.154

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:50:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, rename a variable, and remove an unreachable case. To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:50:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, rename a variable, and remove an unreachable case. To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:41:36 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the IPv4 multicast check earlier; we want to kick multicast packets all the time, and not just when they are SYNs. The IPv6 multicast

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:41:36 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the IPv4 multicast check earlier; we want to kick multicast packets all the time, and not just when they are SYNs. The IPv6 multicast

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:19:30 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the unused 'multicast' argument from tcp_vtw_input, and remove the now-unused multicast detection code. It couldn't have been correct on

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:19:30 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the unused 'multicast' argument from tcp_vtw_input, and remove the now-unused multicast detection code. It couldn't have been correct on

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:10:56 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the default case, the beginning of the function already ensures af == AF_INET || af == AF_INET6. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:10:56 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the default case, the beginning of the function already ensures af == AF_INET || af == AF_INET6. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:06:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Dedup code. To generate a diff of this commit: cvs rdiff -u -r1.369 -r1.370 src/sys/netinet/tcp_input.c Please note that diffs are not public

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 20:06:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Dedup code. To generate a diff of this commit: cvs rdiff -u -r1.369 -r1.370 src/sys/netinet/tcp_input.c Please note that diffs are not public

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 19:38:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, and remove outdated comments. To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368 src/sys/netinet/tcp_input.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 19:38:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, and remove outdated comments. To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368 src/sys/netinet/tcp_input.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 19:25:48 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove this check, it is already done at the beginning of the function. To generate a diff of this commit: cvs rdiff -u -r1.366 -r1.367

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 19:25:48 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove this check, it is already done at the beginning of the function. To generate a diff of this commit: cvs rdiff -u -r1.366 -r1.367

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 18:59:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Reduce the indentation level of this huge block (without realigning yet, for proofreadability). No functional change. To generate a diff of

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 18:59:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Reduce the indentation level of this huge block (without realigning yet, for proofreadability). No functional change. To generate a diff of

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 18:55:11 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the SO_DEBUG block earlier, to reduce the indentation level. To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 18:55:11 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the SO_DEBUG block earlier, to reduce the indentation level. To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:42:12 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.h Log Message: Use C99 types - in particular, stop using n_time and n_short -, style, and remove prototype of icmp_sysctl (does not exist). No functional change.

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:42:12 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.h Log Message: Use C99 types - in particular, stop using n_time and n_short -, style, and remove prototype of icmp_sysctl (does not exist). No functional change.

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:30:30 UTC 2018 Modified Files: src/sys/netinet: udp_var.h Log Message: Style, and remove prototype of udp_sysctl (does not exist). To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:30:30 UTC 2018 Modified Files: src/sys/netinet: udp_var.h Log Message: Style, and remove prototype of udp_sysctl (does not exist). To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:24:46 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: More style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.238 -r1.239 src/sys/netinet/udp_usrreq.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:24:46 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: More style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.238 -r1.239 src/sys/netinet/udp_usrreq.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: ozaki-r Date: Thu Feb 8 10:11:38 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't call lltable_purge_entries from in_if_down if ARP isn't enabled Reported by bouyer@ To generate a diff of this commit: cvs rdiff -u -r1.216

CVS commit: src/sys/netinet

Module Name:src Committed By: ozaki-r Date: Thu Feb 8 10:11:38 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't call lltable_purge_entries from in_if_down if ARP isn't enabled Reported by bouyer@ To generate a diff of this commit: cvs rdiff -u -r1.216

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:03:52 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Change the error stat from IP_STAT_BADFRAGS to IP_STAT_TOOLONG. The ping_of_death ATF test expects this counter to get increased. To generate a

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 10:03:52 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Change the error stat from IP_STAT_BADFRAGS to IP_STAT_TOOLONG. The ping_of_death ATF test expects this counter to get increased. To generate a

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 09:32:02 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Fix a possible buffer overflow in the IPv4 _ctlinput functions. In _icmp_input we are guaranteeing that the ICMP_ADVLENMIN-byte area starting

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 09:32:02 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Fix a possible buffer overflow in the IPv4 _ctlinput functions. In _icmp_input we are guaranteeing that the ICMP_ADVLENMIN-byte area starting

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 07:11:20 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Style, and remove printfs. To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/sys/netinet/udp_usrreq.c Please note that

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 07:11:20 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Style, and remove printfs. To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/sys/netinet/udp_usrreq.c Please note that

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 06:50:38 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Fix three pretty bad mistakes in NAT-T: * If we got a keepalive packet, we need to call m_freem, not m_free. Here the next mbufs in the

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Thu Feb 8 06:50:38 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Fix three pretty bad mistakes in NAT-T: * If we got a keepalive packet, we need to call m_freem, not m_free. Here the next mbufs in the

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 13:22:42 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and constify. To generate a diff of this commit: cvs rdiff -u -r1.152 -r1.153 src/sys/netinet/ip_mroute.c Please note that diffs are

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 13:22:42 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and constify. To generate a diff of this commit: cvs rdiff -u -r1.152 -r1.153 src/sys/netinet/ip_mroute.c Please note that diffs are

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:15:32 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: More style. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.151 -r1.152 src/sys/netinet/ip_mroute.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:15:32 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: More style. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.151 -r1.152 src/sys/netinet/ip_mroute.c Please note

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:09:55 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Remove parentheses in return statements. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.150 -r1.151

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:09:55 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Remove parentheses in return statements. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.150 -r1.151

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:04:50 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and remove unused macros. More to come. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/sys/netinet/ip_mroute.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 12:04:50 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and remove unused macros. More to come. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/sys/netinet/ip_mroute.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 11:42:58 UTC 2018 Modified Files: src/sys/netinet: igmp.c ip_mroute.c ip_mroute.h Log Message: Remove RSVP_ISI, that's mostly dead code. FreeBSD and OpenBSD too removed it; FreeBSD kept some pieces but they are mostly

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 11:42:58 UTC 2018 Modified Files: src/sys/netinet: igmp.c ip_mroute.c ip_mroute.h Log Message: Remove RSVP_ISI, that's mostly dead code. FreeBSD and OpenBSD too removed it; FreeBSD kept some pieces but they are mostly

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 08:12:25 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Remove null check on ip, it can't be null. (Confuses code scanners.) To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Wed Feb 7 08:12:25 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Remove null check on ip, it can't be null. (Confuses code scanners.) To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

Module Name:src Committed By: mrg Date: Wed Feb 7 06:21:23 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: ip_add_membership() has an missing {} issue, but solve it by dropping the "goto out" that would have happened immediately next anyway, ie, should

CVS commit: src/sys/netinet

Module Name:src Committed By: mrg Date: Wed Feb 7 06:21:23 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: ip_add_membership() has an missing {} issue, but solve it by dropping the "goto out" that would have happened immediately next anyway, ie, should

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 17:08:19 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Several changes, mostly cosmetic: * Add a KASSERT in ip_output(), we expect (at least) the IP header to be here. * In ip_fragment(),

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 17:08:19 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Several changes, mostly cosmetic: * Add a KASSERT in ip_output(), we expect (at least) the IP header to be here. * In ip_fragment(),

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 15:48:02 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add one more check in ip_reass_packet(): make sure that the end of each fragment does not exceed IP_MAXPACKET. In ip_reass(), we only check the

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 15:48:02 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add one more check in ip_reass_packet(): make sure that the end of each fragment does not exceed IP_MAXPACKET. In ip_reass(), we only check the

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 06:36:40 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Typos and style a bit, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.372 -r1.373 src/sys/netinet/ip_input.c Please

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Feb 6 06:36:40 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Typos and style a bit, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.372 -r1.373 src/sys/netinet/ip_input.c Please

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 15:23:14 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Exterminate IPSENDREDIRECTS and IPMTUDISCTIMEOUT, neither is documented. To generate a diff of this commit: cvs rdiff -u -r1.371 -r1.372

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 15:23:14 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Exterminate IPSENDREDIRECTS and IPMTUDISCTIMEOUT, neither is documented. To generate a diff of this commit: cvs rdiff -u -r1.371 -r1.372

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 14:52:42 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Clean up this mess. This is typically the kind of places where we need to seriously cut the bullshit. These things are unreadable, undocumented,

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 14:52:42 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Clean up this mess. This is typically the kind of places where we need to seriously cut the bullshit. These things are unreadable, undocumented,

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 14:23:38 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Be tougher, and don't allow LSRR+SSRR (RFC7126). To generate a diff of this commit: cvs rdiff -u -r1.368 -r1.369 src/sys/netinet/ip_input.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 14:23:38 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Be tougher, and don't allow LSRR+SSRR (RFC7126). To generate a diff of this commit: cvs rdiff -u -r1.368 -r1.369 src/sys/netinet/ip_input.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:52:40 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Kick duplicate options, they are not allowed (RFC791). To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:52:40 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Kick duplicate options, they are not allowed (RFC791). To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:34:20 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Remove unused variable. To generate a diff of this commit: cvs rdiff -u -r1.366 -r1.367 src/sys/netinet/ip_input.c Please note that diffs are

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:34:20 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Remove unused variable. To generate a diff of this commit: cvs rdiff -u -r1.366 -r1.367 src/sys/netinet/ip_input.c Please note that diffs are

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:23:11 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Disable ip_allowsrcrt and ip_forwsrcrt. Enabling them by default was a completely dumb idea, because they have security implications. By sending

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:23:11 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Disable ip_allowsrcrt and ip_forwsrcrt. Enabling them by default was a completely dumb idea, because they have security implications. By sending

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:04:56 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365 src/sys/netinet/ip_input.c Please note that diffs

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 13:04:56 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365 src/sys/netinet/ip_input.c Please note that diffs

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 08:38:06 UTC 2018 Modified Files: src/sys/netinet: in_proto.c ip_icmp.c Log Message: Declare icmperrppslim in ip_icmp.c, it shouldn't be used elsewhere. To generate a diff of this commit: cvs rdiff -u -r1.125 -r1.126

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Feb 5 08:38:06 UTC 2018 Modified Files: src/sys/netinet: in_proto.c ip_icmp.c Log Message: Declare icmperrppslim in ip_icmp.c, it shouldn't be used elsewhere. To generate a diff of this commit: cvs rdiff -u -r1.125 -r1.126

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Jan 23 07:33:49 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Don't use global variables, that's obviously incorrect on MP systems. One remains, because it is imported in tcp_timer.c, and I'm not totally sure

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Jan 23 07:33:49 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Don't use global variables, that's obviously incorrect on MP systems. One remains, because it is imported in tcp_timer.c, and I'm not totally sure

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Jan 23 07:15:04 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c ip_icmp.h Log Message: Style, localify icmp_send, and add a clear KASSERT (that replaces a vague comment). To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Tue Jan 23 07:15:04 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c ip_icmp.h Log Message: Style, localify icmp_send, and add a clear KASSERT (that replaces a vague comment). To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Jan 22 09:51:06 UTC 2018 Modified Files: src/sys/netinet: in_l2tp.c Log Message: Fix null deref, m could be NULL if M_PREPEND fails. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/netinet/in_l2tp.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Jan 22 09:51:06 UTC 2018 Modified Files: src/sys/netinet: in_l2tp.c Log Message: Fix null deref, m could be NULL if M_PREPEND fails. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/netinet/in_l2tp.c

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Jan 22 06:56:25 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Adapt previous, reintroduce MH_ALIGN. It's used as an optimization - we can later prepend something to the current mbuf without having to allocate

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Mon Jan 22 06:56:25 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Adapt previous, reintroduce MH_ALIGN. It's used as an optimization - we can later prepend something to the current mbuf without having to allocate

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 13:17:29 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Fix a buffer overflow in icmp_error. We create in 'm' a packet that must contain: IPv4 header | Fixed part of ICMP header | Variable part of

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 13:17:29 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Fix a buffer overflow in icmp_error. We create in 'm' a packet that must contain: IPv4 header | Fixed part of ICMP header | Variable part of

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 12:50:27 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Clarify icmp_error: * Rename (and constify) oiplen -> oiphlen. * Rename icmplen -> datalen, it's the size of the variable part of the ICMP

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 12:50:27 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Clarify icmp_error: * Rename (and constify) oiplen -> oiphlen. * Rename icmplen -> datalen, it's the size of the variable part of the ICMP

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 10:21:24 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.h Log Message: Style, explain a bit, and fix icmp_radv, it should be icmp_dun.id_radv. To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Fri Jan 19 10:21:24 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.h Log Message: Style, explain a bit, and fix icmp_radv, it should be icmp_dun.id_radv. To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36

CVS commit: src/sys/netinet

Module Name:src Committed By: ozaki-r Date: Fri Jan 19 07:53:01 UTC 2018 Modified Files: src/sys/netinet: tcp_subr.c tcp_timer.c tcp_timer.h tcp_var.h Log Message: Run tcp_slowtimo in workqueue if NET_MPSAFE If NET_MPSAFE is enabled, we have to avoid taking softnet_lock

CVS commit: src/sys/netinet

Module Name:src Committed By: ozaki-r Date: Fri Jan 19 07:53:01 UTC 2018 Modified Files: src/sys/netinet: tcp_subr.c tcp_timer.c tcp_timer.h tcp_var.h Log Message: Run tcp_slowtimo in workqueue if NET_MPSAFE If NET_MPSAFE is enabled, we have to avoid taking softnet_lock

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Sun Jan 14 16:18:11 UTC 2018 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix memory leak, found by Mootja. To generate a diff of this commit: cvs rdiff -u -r1.66 -r1.67 src/sys/netinet/ip_encap.c Please note that

CVS commit: src/sys/netinet

Module Name:src Committed By: maxv Date: Sun Jan 14 16:18:11 UTC 2018 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix memory leak, found by Mootja. To generate a diff of this commit: cvs rdiff -u -r1.66 -r1.67 src/sys/netinet/ip_encap.c Please note that

Re: CVS commit: src/sys/netinet

On Thu, Jan 11, 2018 at 3:51 AM, Christos Zoulas wrote: > Module Name:src > Committed By: christos > Date: Wed Jan 10 18:51:31 UTC 2018 > > Modified Files: > src/sys/netinet: ip_output.c > > Log Message: > from ozaki-r: use the proper ifp. > XXX:

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Wed Jan 10 18:51:31 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: from ozaki-r: use the proper ifp. XXX: perhaps push the lock in in_delmulti()? To generate a diff of this commit: cvs rdiff -u -r1.291

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Wed Jan 10 18:51:31 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: from ozaki-r: use the proper ifp. XXX: perhaps push the lock in in_delmulti()? To generate a diff of this commit: cvs rdiff -u -r1.291

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Wed Jan 10 17:36:06 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: - this is not python, we need braces - protect ifp locking against NULL To generate a diff of this commit: cvs rdiff -u -r1.290 -r1.291

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Wed Jan 10 17:36:06 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: - this is not python, we need braces - protect ifp locking against NULL To generate a diff of this commit: cvs rdiff -u -r1.290 -r1.291

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Mon Jan 1 16:14:30 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove comment now that the getsockopt code passes the size. To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290

CVS commit: src/sys/netinet

Module Name:src Committed By: christos Date: Mon Jan 1 16:14:30 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Remove comment now that the getsockopt code passes the size. To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290

Re: CVS commit: src/sys/netinet

Ryota Ozaki writes: > Yeah, so I hoped a better fix. For now, I'm running with yours, and it seems to have solved the problem. If a more correct solution is in place, I'm looking forward to testing that on my susceptible system, but it'll take a few days before I can: I'm

Re: CVS commit: src/sys/netinet

On Fri, Dec 29, 2017 at 4:37 AM, Chuck Silvers wrote: > On Thu, Dec 28, 2017 at 05:34:27PM +0900, Ryota Ozaki wrote: >> On Thu, Dec 28, 2017 at 5:05 PM, Tom Ivar Helbekkmo >> wrote: >> > Ryota Ozaki writes: >> > >> >> I think the below

Re: CVS commit: src/sys/netinet

On Thu, Dec 28, 2017 at 05:34:27PM +0900, Ryota Ozaki wrote: > On Thu, Dec 28, 2017 at 5:05 PM, Tom Ivar Helbekkmo > wrote: > > Ryota Ozaki writes: > > > >> I think the below patch fixes the above issue, but probably > >> there is a better solution. > >

Re: CVS commit: src/sys/netinet

Ryota Ozaki writes: > Oh, my patch failed to keep SPL at IPL_VM because mutex_exit > tries to restore an SPL where mutex_enter is called. So I had to > put splvm before mutex_enter. Could you try the 2nd patch: > http://www.netbsd.org/~ozaki-r/fix-pool_catchup.diff Will

<    1   2   3   4   5   6   7   8   9   10   >