Module Name:src
Committed By: christos
Date: Sun May 12 18:02:16 UTC 2024
Modified Files:
src/sbin/cgdconfig: Makefile cgdconfig.8 cgdconfig.c params.c params.h
Log Message:
PR/58212: Malte Dehling: Add zfs verification method
To generate a diff of this commit:
cvs
Module Name:src
Committed By: christos
Date: Sun May 12 18:02:16 UTC 2024
Modified Files:
src/sbin/cgdconfig: Makefile cgdconfig.8 cgdconfig.c params.c params.h
Log Message:
PR/58212: Malte Dehling: Add zfs verification method
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Mon Apr 29 00:28:18 UTC 2024
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): KNF in cgdconfig.c.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.61 -r1.62
Module Name:src
Committed By: riastradh
Date: Mon Apr 29 00:28:18 UTC 2024
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): KNF in cgdconfig.c.
No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.61 -r1.62
Module Name:src
Committed By: riastradh
Date: Tue Sep 13 10:14:32 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Restore loop for password re-entry for non-shared keys.
Fixes mistake in previous which changed the semantics in the case
Module Name:src
Committed By: riastradh
Date: Tue Sep 13 10:14:32 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Restore loop for password re-entry for non-shared keys.
Fixes mistake in previous which changed the semantics in the case
Module Name:src
Committed By: riastradh
Date: Tue Aug 30 08:48:42 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Gracefully handle failed verification with shared keys.
The first time each key is verified, if verification fails, we
Module Name:src
Committed By: riastradh
Date: Tue Aug 30 08:48:42 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Gracefully handle failed verification with shared keys.
The first time each key is verified, if verification fails, we
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 10:49:47 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
cgdconfig(8): Handle -P/-S for shared keys with -G too.
This way you can convert an existing parameters file to one that is
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 10:49:47 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
cgdconfig(8): Handle -P/-S for shared keys with -G too.
This way you can convert an existing parameters file to one that is
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 10:49:35 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c params.c params.h
Log Message:
cgdconfig(8): Add support for generating shared-key parameters files.
Usage model:
- Generate a
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 10:49:35 UTC 2022
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c params.c params.h
Log Message:
cgdconfig(8): Add support for generating shared-key parameters files.
Usage model:
- Generate a
Module Name:src
Committed By: christos
Date: Tue May 17 18:56:30 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Use the Makefile.inc from libargon2 (fixes the vax build that requires
a compiler hack).
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: christos
Date: Tue May 17 18:56:30 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Use the Makefile.inc from libargon2 (fixes the vax build that requires
a compiler hack).
To generate a diff of this commit:
cvs rdiff -u
Please test it. In HEAD today, and last week, and for probably
a long time back into the past, /sbin/cgdconfig has threads, and
/rescue/cgdconfig does not.
I don"t know when argon2 support was added, or how to use it,
but if you do, it should be simple to create an cgd in vnd using
one, and then
On Mon, May 16, 2022 at 09:10:40AM +, Taylor R Campbell wrote:
> Surely `disabling threads' just means cgdconfig can't take advantage
> of parallelism to compute the same function in less time, not that
> cgdconfig computes a different function or fails to compute the same
> function, no?
>
Module Name:src
Committed By: christos
Date: Mon May 16 14:57:44 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
make things behave just like before the libcrypt symbol renaming:
The normal cgdconfig binary is built with threads and the crunched one
in
Module Name:src
Committed By: christos
Date: Mon May 16 14:57:44 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
make things behave just like before the libcrypt symbol renaming:
The normal cgdconfig binary is built with threads and the crunched one
in
Date:Mon, 16 May 2022 09:10:40 +
From:Taylor R Campbell
Message-ID: <20220516090946.a3c4660...@jupiter.mumble.net>
| > Please re-enable threads. They influence the output hash
| > so by disabling threads you stop people from being able
| > to decrypt their
> On May 16, 2022, at 5:10 AM, Taylor R Campbell wrote:
>
>> Date: Mon, 16 May 2022 04:49:22 +
>> From: nia
>>
>> On Sun, May 15, 2022 at 03:53:27PM -0400, Christos Zoulas wrote:
>>> Log Message:
>>> Build argon2 inline so that crunched programs work. I also disabled threads
>>> for now;
Module Name:src
Committed By: christos
Date: Mon May 16 10:44:06 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Re-enable threads; apparently we get different results depending if we are
threaded or not... This tastes like a bug.
To generate a diff
Module Name:src
Committed By: christos
Date: Mon May 16 10:44:06 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Re-enable threads; apparently we get different results depending if we are
threaded or not... This tastes like a bug.
To generate a diff
> Date: Mon, 16 May 2022 04:49:22 +
> From: nia
>
> On Sun, May 15, 2022 at 03:53:27PM -0400, Christos Zoulas wrote:
> > Log Message:
> > Build argon2 inline so that crunched programs work. I also disabled threads
> > for now; we can put them back if needed.
>
> Please re-enable threads.
On Sun, May 15, 2022 at 03:53:27PM -0400, Christos Zoulas wrote:
> Log Message:
> Build argon2 inline so that crunched programs work. I also disabled threads
> for now; we can put them back if needed.
Please re-enable threads. They influence the output hash
so by disabling threads you stop people
Module Name:src
Committed By: christos
Date: Sun May 15 19:53:27 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Build argon2 inline so that crunched programs work. I also disabled threads
for now; we can put them back if needed.
To generate a diff of
Module Name:src
Committed By: christos
Date: Sun May 15 19:53:27 UTC 2022
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
Build argon2 inline so that crunched programs work. I also disabled threads
for now; we can put them back if needed.
To generate a diff of
Module Name:src
Committed By: nia
Date: Sat Dec 4 15:03:58 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: Use argon2id in examples
To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52 src/sbin/cgdconfig/cgdconfig.8
Please
On Sun, Nov 28, 2021 at 07:42:55AM -0800, Jason Thorpe wrote:
>
>
> > On Nov 27, 2021, at 6:01 PM, Christos Zoulas wrote:
> >
> > Module Name:src
> > Committed By: christos
> > Date: Sun Nov 28 02:01:30 UTC 2021
> >
> > Modified Files:
> > src/sbin/cgdconfig:
> On Nov 28, 2021, at 11:57 AM, Roland Illig wrote:
>
> Am 28.11.2021 um 17:37 schrieb Jason Thorpe:
>>> On Nov 28, 2021, at 8:05 AM, Christos Zoulas
>>> wrote:
>>>
>>> 1. which compilation flag should we add -pthread to? CFLAGS or
>>> COPTS? What about c++?
>>
>> GCC defines some preprocessor
Am 28.11.2021 um 17:37 schrieb Jason Thorpe:
On Nov 28, 2021, at 8:05 AM, Christos Zoulas
wrote:
1. which compilation flag should we add -pthread to? CFLAGS or
COPTS? What about c++?
GCC defines some preprocessor macros in response to -pthread, so …
CPPFLAGS? Perhaps a better choice is to
> On Nov 28, 2021, at 8:05 AM, Christos Zoulas wrote:
>
> The change is correct; this is how it is done everywhere else in the tree.
> You are right about -pthread doing more than adding -lpthread, but
> in that case, the -pthread should be added to CFLAGS/COPTS etc,
> not LDADD so that it
The change is correct; this is how it is done everywhere else in the tree.
You are right about -pthread doing more than adding -lpthread, but
in that case, the -pthread should be added to CFLAGS/COPTS etc,
not LDADD so that it is effective during the compilation phase too,
not just the link
> On Nov 27, 2021, at 6:01 PM, Christos Zoulas wrote:
>
> Module Name: src
> Committed By: christos
> Date: Sun Nov 28 02:01:30 UTC 2021
>
> Modified Files:
> src/sbin/cgdconfig: Makefile
>
> Log Message:
> -lpthread to LDADD (fixes lint build)
This change is wrong. The
Module Name:src
Committed By: christos
Date: Sun Nov 28 02:01:30 UTC 2021
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
-lpthread to LDADD (fixes lint build)
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sbin/cgdconfig/Makefile
Please
Module Name:src
Committed By: christos
Date: Sun Nov 28 02:01:30 UTC 2021
Modified Files:
src/sbin/cgdconfig: Makefile
Log Message:
-lpthread to LDADD (fixes lint build)
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sbin/cgdconfig/Makefile
Please
Module Name:src
Committed By: nia
Date: Mon Nov 22 16:04:03 UTC 2021
Modified Files:
src/sbin/cgdconfig: pkcs5_pbkdf2.c
Log Message:
cgdconfig(8): add some console feedback when calculating the number
of pkcs5_pbkdf2 iterations
To generate a diff of this commit:
cvs
Module Name:src
Committed By: nia
Date: Mon Nov 22 16:04:03 UTC 2021
Modified Files:
src/sbin/cgdconfig: pkcs5_pbkdf2.c
Log Message:
cgdconfig(8): add some console feedback when calculating the number
of pkcs5_pbkdf2 iterations
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Wed Jun 16 23:22:08 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Fail more gracefully than SIGSEGV if shell_cmd fails.
To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52
Module Name:src
Committed By: riastradh
Date: Wed Jun 16 23:22:08 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
cgdconfig(8): Fail more gracefully than SIGSEGV if shell_cmd fails.
To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52
Module Name:src
Committed By: prlw1
Date: Thu Jun 3 15:40:27 UTC 2021
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Make adiantum a first class citizen
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sbin/cgdconfig/params.c
Please note
Module Name:src
Committed By: prlw1
Date: Thu Jun 3 15:40:27 UTC 2021
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Make adiantum a first class citizen
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sbin/cgdconfig/params.c
Please note
Module Name:src
Committed By: nia
Date: Fri Apr 30 21:07:34 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: use gpt in examples, it's more versatile for this use case
To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50
Module Name:src
Committed By: nia
Date: Fri Apr 30 21:07:34 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: use gpt in examples, it's more versatile for this use case
To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50
Module Name:src
Committed By: maya
Date: Sun Apr 18 19:56:10 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
The -n flag is useless with -g, don't mention it.
>From rudolf in PR misc/36243
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: maya
Date: Sun Apr 18 19:56:10 UTC 2021
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
The -n flag is useless with -g, don't mention it.
>From rudolf in PR misc/36243
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Fri Dec 11 21:52:19 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Touch up cgdconfig(8) man page.
- Suggest adiantum first.
- Remove references to Blowfish.
- Clarify that ivmethod is relevant only for
Module Name:src
Committed By: riastradh
Date: Fri Dec 11 21:52:19 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Touch up cgdconfig(8) man page.
- Suggest adiantum first.
- Remove references to Blowfish.
- Clarify that ivmethod is relevant only for
Module Name:src
Committed By: wiz
Date: Tue Jun 23 14:08:01 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Use Nm.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not public
Module Name:src
Committed By: wiz
Date: Tue Jun 23 14:08:01 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Use Nm.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not public
Module Name:src
Committed By: nia
Date: Tue Jun 23 13:23:56 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: remove references to using cgd for swap
this is potentially misleading now that the kernel does swap encryption
To generate a
Module Name:src
Committed By: nia
Date: Tue Jun 23 13:23:56 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: remove references to using cgd for swap
this is potentially misleading now that the kernel does swap encryption
To generate a
Module Name:src
Committed By: nia
Date: Tue Jun 23 13:20:14 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: Reflect actual behaviour of /dev/(u)random
To generate a diff of this commit:
cvs rdiff -u -r1.44 -r1.45
Module Name:src
Committed By: nia
Date: Tue Jun 23 13:20:14 UTC 2020
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
cgdconfig.8: Reflect actual behaviour of /dev/(u)random
To generate a diff of this commit:
cvs rdiff -u -r1.44 -r1.45
Module Name:src
Committed By: kre
Date: Wed Apr 10 06:11:37 UTC 2019
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
KNF, 80 column police, a few other tidy ups (use if (ret == 0) rather
than if (!ret) when ret is not a boolean, and test fopen result against
Module Name:src
Committed By: kre
Date: Wed Apr 10 06:11:37 UTC 2019
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
KNF, 80 column police, a few other tidy ups (use if (ret == 0) rather
than if (!ret) when ret is not a boolean, and test fopen result against
Module Name:src
Committed By: mlelstv
Date: Sun Dec 30 12:05:48 UTC 2018
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Avoid crash when no algorithm is specified in parameter file.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30
Module Name:src
Committed By: mlelstv
Date: Sun Dec 30 12:05:48 UTC 2018
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Avoid crash when no algorithm is specified in parameter file.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30
Module Name:src
Committed By: wiz
Date: Sat Dec 29 18:34:01 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Sort SEE ALSO.
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not
Module Name:src
Committed By: wiz
Date: Sat Dec 29 18:34:01 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Sort SEE ALSO.
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not
On Sat, Dec 29, 2018 at 01:33:23PM +, Alexander Nasonov wrote:
> Christoph Badura wrote:
> > On Thu, Dec 27, 2018 at 10:41:55PM +, Alexander Nasonov wrote:
> > > Perhaps the simplest change would be to pass an unresolved (original)
> > > name when composing a paramsfile. E.g.
> > >
> > >
On Thu, Dec 27, 2018 at 10:41:55PM +, Alexander Nasonov wrote:
> Perhaps the simplest change would be to pass an unresolved (original)
> name when composing a paramsfile. E.g.
>
> /etc/cgd/NAME=mylabel
> /etc/cgd/ROOT.e
Alas, this will break existing installations that e.g. use /etc/cgd/dkNN
Module Name:src
Committed By: alnsn
Date: Fri Dec 28 18:33:54 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
s/Dec/December/.
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are
Module Name:src
Committed By: alnsn
Date: Fri Dec 28 18:33:54 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
s/Dec/December/.
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are
Christoph Badura wrote:
> Using /etc/cgd/ROOT. has the advantage that the cgd will configure
> if the root device changes name, thus upholding POLA.
>
> E.g. moving disks from a controller that attaches sd(4)s to one that
> attaches ld(4)s. I believe you can see that when dd'ing an image from
>
On Thu, Dec 27, 2018 at 09:53:44PM +, Alexander Nasonov wrote:
> Alexander Nasonov wrote:
> > XXX Default paramsfile for NAME=label is /etc/cgd/dkNN (resolved wedge
> > partition) and /etc/cgd/ROOT. for ROOT.. This isn't yet
> > documented. IMO, it should be the other way around:
Module Name:src
Committed By: alnsn
Date: Thu Dec 27 21:17:08 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Document that cgd.conf supports NAME=label and ROOT. targets.
XXX Default paramsfile for NAME=label is /etc/cgd/dkNN (resolved wedge
Module Name:src
Committed By: alnsn
Date: Thu Dec 27 21:17:08 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Document that cgd.conf supports NAME=label and ROOT. targets.
XXX Default paramsfile for NAME=label is /etc/cgd/dkNN (resolved wedge
Module Name:src
Committed By: prlw1
Date: Sat Sep 1 11:46:52 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
typo
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not public
Module Name:src
Committed By: prlw1
Date: Sat Sep 1 11:46:52 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
typo
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sbin/cgdconfig/cgdconfig.8
Please note that diffs are not public
Robert Elz wrote:
> Module Name: src
> Committed By: kre
> Date: Sat May 5 11:28:44 UTC 2018
>
> Modified Files:
> src/sbin/cgdconfig: cgdconfig.c
>
> Log Message:
> Check whether the cgd device selected is available to be
> configured,that is, not already in use, before
Module Name:src
Committed By: kre
Date: Wed May 9 20:23:35 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
With the change to use getpass_r the 128 byte passphrase limit no
longer applies, so update the BUGS section here to reflect that change.
The
Module Name:src
Committed By: kre
Date: Wed May 9 20:23:35 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
With the change to use getpass_r the 128 byte passphrase limit no
longer applies, so update the BUGS section here to reflect that change.
The
Module Name:src
Committed By: alnsn
Date: Wed May 9 19:38:46 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
use explicit_memset(3)
To generate a diff of this commit:
cvs rdiff -u -r1.47 -r1.48 src/sbin/cgdconfig/cgdconfig.c
Please note that
Module Name:src
Committed By: alnsn
Date: Wed May 9 19:38:46 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
use explicit_memset(3)
To generate a diff of this commit:
cvs rdiff -u -r1.47 -r1.48 src/sbin/cgdconfig/cgdconfig.c
Please note that
matthew green wrote:
> "Alexander Nasonov" writes:
> > XXX Using memset for wiping isn't a good idea because memset is likely
> > optimised away by gcc. This should be revisited.
>
> use explicit_memset(3)?
Yes, we should change memsets of sensitive buffers to explicit_memset
but we also should
"Alexander Nasonov" writes:
> Module Name: src
> Committed By: alnsn
> Date: Wed May 9 18:11:56 UTC 2018
>
> Modified Files:
> src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
>
> Log Message:
> Add '-e' option (echo the passphrase) and wipe the passphrase after use.
>
> XXX Using
Module Name:src
Committed By: alnsn
Date: Wed May 9 18:18:11 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Missed one change when doing a manual merge of my patch with kre's commit.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47
Module Name:src
Committed By: alnsn
Date: Wed May 9 18:18:11 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Missed one change when doing a manual merge of my patch with kre's commit.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47
Module Name:src
Committed By: alnsn
Date: Wed May 9 18:11:56 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
Add '-e' option (echo the passphrase) and wipe the passphrase after use.
XXX Using memset for wiping isn't a good idea because
Module Name:src
Committed By: alnsn
Date: Wed May 9 18:11:56 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
Add '-e' option (echo the passphrase) and wipe the passphrase after use.
XXX Using memset for wiping isn't a good idea because
Module Name:src
Committed By: wiz
Date: Wed May 9 17:35:03 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Add commas in enumeration.
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sbin/cgdconfig/cgdconfig.8
Please note that
Module Name:src
Committed By: wiz
Date: Wed May 9 17:35:03 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8
Log Message:
Add commas in enumeration.
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sbin/cgdconfig/cgdconfig.8
Please note that
Module Name:src
Committed By: kre
Date: Wed May 9 14:27:41 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
Fix missing -p in usage message (noted by Christoph Badura, thanks),
and update -l usage as well.
While here fix man page
Module Name:src
Committed By: kre
Date: Wed May 9 14:27:41 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.8 cgdconfig.c
Log Message:
Fix missing -p in usage message (noted by Christoph Badura, thanks),
and update -l usage as well.
While here fix man page
Module Name:src
Committed By: kre
Date: Wed May 9 13:19:33 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Check arg count in configure() at entry, rather than later.
This avoids the stupid null deref I added a couple of commits
ago (on bad usage)
Module Name:src
Committed By: kre
Date: Wed May 9 13:19:33 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Check arg count in configure() at entry, rather than later.
This avoids the stupid null deref I added a couple of commits
ago (on bad usage)
Date:Wed, 9 May 2018 08:59:55 +0100
From:Alexander Nasonov
Message-ID: <20180509075955.GA7743@neva>
| Adding (argc > 0) check before calling opendisk1 fixes the crash.
Thanks - and I see what is wrong now, but (for whatever reason) that did
not
Alexander Nasonov wrote:
> (gdb) b opendisk1
> (gdb) run -p
> Starting program:
> /home/alnsn/netbsd-current/clean/src/sbin/cgdconfig/obj/cgdconfig -p
>
> Breakpoint 1, 0x7f7ff78111f6 in opendisk1 () from /lib/libutil.so.7
> (gdb) x/s $rdi
> 0x0: # path=NULL
Adding (argc > 0) check
Robert Elz wrote:
> Date:Tue, 8 May 2018 19:15:28 +0100
> From:Alexander Nasonov
> Message-ID: <20180508180815.GA5990@neva>
>
> | I think it broke the tool. If you run
> |
> | cgdconfig -p
> |
> | it will crash.
>
> Sorry, I cannot
Date:Tue, 8 May 2018 19:15:28 +0100
From:Alexander Nasonov
Message-ID: <20180508180815.GA5990@neva>
| I think it broke the tool. If you run
|
| cgdconfig -p
|
| it will crash.
Sorry, I cannot reproduce this, it looks to work OK to me.
Can
Date:Tue, 8 May 2018 19:15:28 +0100
From:Alexander Nasonov
Message-ID: <20180508180815.GA5990@neva>
| I think it broke the tool. If you run
| cgdconfig -p
| it will crash.
I shall take a look.
kre
Robert Elz wrote:
> Module Name: src
> Committed By: kre
> Date: Sat May 5 11:28:44 UTC 2018
>
> Modified Files:
> src/sbin/cgdconfig: cgdconfig.c
>
> Log Message:
> Check whether the cgd device selected is available to be
> configured,that is, not already in use, before
Module Name:src
Committed By: kre
Date: Sun May 6 20:55:42 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Fix usage for rump. Fixes test breakage caused by previous commit.
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43
Module Name:src
Committed By: kre
Date: Sun May 6 20:55:42 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Fix usage for rump. Fixes test breakage caused by previous commit.
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43
Module Name:src
Committed By: kre
Date: Sat May 5 11:28:44 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Check whether the cgd device selected is available to be
configured,that is, not already in use, before requesting
passwords from the user (or
Module Name:src
Committed By: kre
Date: Sat May 5 11:28:44 UTC 2018
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Check whether the cgd device selected is available to be
configured,that is, not already in use, before requesting
passwords from the user (or
Module Name:src
Committed By: christos
Date: Tue Jan 10 20:45:19 UTC 2017
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Need for S_IFBLK.
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sbin/cgdconfig/cgdconfig.c
Please note that diffs
Module Name:src
Committed By: christos
Date: Tue Jan 10 20:45:19 UTC 2017
Modified Files:
src/sbin/cgdconfig: cgdconfig.c
Log Message:
Need for S_IFBLK.
To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sbin/cgdconfig/cgdconfig.c
Please note that diffs
Module Name:src
Committed By: alnsn
Date: Sun Dec 11 00:34:39 UTC 2016
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Add aes-xts to cgdconfig(8).
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sbin/cgdconfig/params.c
Please note that
Module Name:src
Committed By: alnsn
Date: Sun Dec 11 00:34:39 UTC 2016
Modified Files:
src/sbin/cgdconfig: params.c
Log Message:
Add aes-xts to cgdconfig(8).
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sbin/cgdconfig/params.c
Please note that
1 - 100 of 138 matches
Mail list logo