CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 12:44:04

Modified files:
lib/libcrypto/bio: bio_lib.c bio_local.h 

Log message:
Revert bio_prev removal

As schwarze points out, you can pop any BIO in a chain, not just the first
one (bonus points for a great name for this API).

The internal doubly linked was used to fix up the BIO chain bio was part
of when you BIO_pop() a bio that wasn't in the first position, which is
explicitly allowed in our documentation and implied by OpenSSL's.



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 10:33:38

Modified files:
regress/lib/libcrypto/bn: bn_mod_exp.c 
Added files:
regress/lib/libcrypto/bn: bn_mod_exp_zero.c 

Log message:
Rewrite the tests that various modular exponentiation functions
compute a^0 = 0 (mod 1) for all a from scratch.



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 10:34:26

Modified files:
regress/lib/libcrypto/bn: Makefile 

Log message:
Link new bn_mod_exp_zero test to build



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 11:24:01

Modified files:
regress/lib/libcrypto/bn: bn_mod_exp.c 

Log message:
bn_mod_exp: we have a BN_CTX available...

Use BN_CTX_get() instead of BN_new()/BN_free().



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 10:42:45

Modified files:
regress/lib/libcrypto/bn: bn_mod_exp.c 

Log message:
Check BN_rand() and BN_mod() return values

CID 430848
CID 430849



CVS: cvs.openbsd.org: www

2022-12-02 Thread Darren Tucker
CVSROOT:/cvs
Module name:www
Changes by: dtuc...@cvs.openbsd.org 2022/12/02 14:34:49

Modified files:
build/openssh  : releases.pl 
openssh: releasenotes.html 

Log message:
Mark up GHPRnnn links in full instead of only half of them.



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 11:31:40

Modified files:
regress/lib/libcrypto/bn: bn_mod_exp.c 

Log message:
bn_mod_exp.c: printing to stdout needs no BIO



CVS: cvs.openbsd.org: src

2022-12-02 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2022/12/02 08:35:35

Modified files:
sys/netinet6   : nd6.c nd6.h nd6_nbr.c 
usr.sbin/ndp   : ndp.c 

Log message:
Remove constant basereachable and retrans members from struct nd_ifinfo

Both are initalised with compile-time constants and never written to.

They are part of the Neighbour Discovery machinery and only surface
through the single-user SIOCGIFINFO_IN6:
$ ndp -i lo0
basereachable=30s0ms, reachable=39s, retrans=1s0ms

These values are read-only since 2017
sys/netinet6/nd6.c r1.217
usr.sbin/ndp/ndp.c r1.85
Remove knob and always do neighbor unreachable detection

Inline the macros (to keep meaningful names), shrink the per-interface
allocated struct nd_ifinfo to what is actually needed and inline
nd6_dad_starttimer()'s constant `msec' argument.

Nothing else in base, incl. regress, uses SIOCGIFINFO_IN6 or `ndp -i'.

OK bluhm



CVS: cvs.openbsd.org: src

2022-12-02 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2022/12/02 15:36:34

Modified files:
usr.bin/midicat: midicat.c 

Log message:
midicat(1): use err(3) everywhere

This is consistent with style(9) and makes the program shorter, too.

Tweaked by ratchov@.

Link: https://marc.info/?l=openbsd-tech=166982129428027=2

ok millert@ kn@ ratchov@



CVS: cvs.openbsd.org: src

2022-12-02 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2022/12/02 15:29:59

Modified files:
usr.bin/midicat: midicat.c 

Log message:
midicat(1): set ifile/ofile to "stdin"/"stdout" if it is an en-dash ("-")

This makes error messages a little bit more intuitive.  Instead of, e.g.:

midicat: -: No space left on device

you get:

midicat: stdout: No space left on device

Link: https://marc.info/?l=openbsd-tech=166982129428027=2

ok millert@ kn@ ratchov@



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 15:58:56

Modified files:
lib/libcrypto/man: BIO_push.3 

Log message:
Drop 'perhaps a little', plus grammar and spelling nits

BIO_push() and BIO_pop() are misnamed. No need to gently and politely
suggest that their 'names [...] are perhaps a little misleading'.



CVS: cvs.openbsd.org: src

2022-12-02 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2022/12/02 18:18:03

Modified files:
sys/dev/pci/drm/i915/gt: intel_gt.c 

Log message:
drm/i915: fix TLB invalidation for Gen12 video and compute engines

>From Andrzej Hajda
ee2d04f23bbb16208045c3de545c6127aaa1ed0e in linux 5.15.y/5.15.81
04aa64375f48a5d430b5550d9271f8428883e550 in mainline linux



CVS: cvs.openbsd.org: src

2022-12-02 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2022/12/02 20:04:36

Modified files:
sys/dev/pci: pcidevs 

Log message:
add AMD family 19h model 61h (Raphael) ids
initial diff from Laurence Tratt; ok mlarkin@



CVS: cvs.openbsd.org: src

2022-12-02 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2022/12/02 20:05:13

Modified files:
sys/dev/pci: pcidevs.h pcidevs_data.h 

Log message:
regen



CVS: cvs.openbsd.org: src

2022-12-02 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2022/12/02 15:21:35

Modified files:
usr.bin/midicat: midicat.c 

Log message:
midicat(1): add a usage() function

Tweaked by millert@.

Link: https://marc.info/?l=openbsd-tech=166982129428027=2

ok millert@ kn@ ratchov@



CVS: cvs.openbsd.org: www

2022-12-02 Thread Tobias Heider
CVSROOT:/cvs
Module name:www
Changes by: to...@cvs.openbsd.org   2022/12/02 07:41:46

Modified files:
openiked   : index.html releases.html 

Log message:
OpenIKED 7.2



CVS: cvs.openbsd.org: src

2022-12-02 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/12/02 01:30:54

Modified files:
regress/lib/libcrypto/bn: Makefile 

Log message:
libcrypto/bn: switch back to manual regress targets

The previous change had the undesired side effect of running the super
verbose run-regress-bn_test.



CVS: cvs.openbsd.org: src

2022-12-02 Thread Martijn van Duren
CVSROOT:/cvs
Module name:src
Changes by: mart...@cvs.openbsd.org 2022/12/02 03:57:12

Modified files:
lib/libagentx  : agentx.c 

Log message:
When checking if we're implied we must also check if we're working on a
string or an oid, else we can generate invalid OIDs.

Found by bluhm@ on powerpc64
OK bluhm@



CVS: cvs.openbsd.org: src

2022-12-02 Thread Jeremie Courreges-Anglas
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2022/12/02 05:27:08

Modified files:
sys/arch/riscv64/include: asm.h 
sys/arch/riscv64/riscv64: cpuswitch.S exception.S locore.S 
lib/libc/arch/riscv64: SYS.h 
lib/libc/arch/riscv64/sys: brk.S sbrk.S 

Log message:
Drop _C_LABEL() uses in riscv64-specific code

_C_LABEL() was useful in the a.out->ELF transition days, way before
RISC-V was a thing.

Also drop uses of _ASM_LABEL() while here, suggested by guenther@
ok guenther@



CVS: cvs.openbsd.org: src

2022-12-02 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2022/12/02 05:56:51

Modified files:
sys/netinet6   : in6.c 

Log message:
Unlock in6_ioctl_get() aka. SIOCGIF{DSTADDR,NETMASK,AFLAG,ALIFETIME}_IN6

First the right address is picked from the net lock protected if_addrlist.
Then all ioctls just copy out the address, nothing requires the kernel lock.

SIOCGIFDSTADDR_IN6 checks the net lock protected if_flags,
SIOCGIFALIFETIME_IN6 computes lifetimes which only need the address.

This removes the last kernel lock from IPv6 read ioctls (multicast being
the untouched exception here).

Users of these ioctl(2)s are route6d(8), rad(8), slaacd(8), isakmpd(8) and
of course ifconfig(8).

OK mvs



CVS: cvs.openbsd.org: src

2022-12-02 Thread Stuart Henderson
CVSROOT:/cvs
Module name:src
Changes by: st...@cvs.openbsd.org   2022/12/02 05:51:22

Modified files:
distrib/sets/lists/base: mi 

Log message:
sync



CVS: cvs.openbsd.org: src

2022-12-02 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2022/12/02 05:58:37

Modified files:
sys/netinet6   : nd6_nbr.c 

Log message:
Remove useless variable, simplify code

Using a local `duplicate' variable to defer the actual checks by a few
lines, interleaved with comments (saying the same thing but negated),
is harder to follow that neccessary.

Fold the logic and merge comments (remove the last obvious one missing
a negation) to save 20 LOC.

OK bluhm