CVS: cvs.openbsd.org: src

2021-07-20 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2021/07/20 21:53:50

Modified files:
distrib/miniroot: dot.profile 
sbin/resolvd   : resolvd.c 
sbin/slaacd: slaacd.c slaacd.h 
sbin/dhcpleased: dhcpleased.c dhcpleased.h 

Log message:
Use exclusive lock under /dev/, silence expected errors in installer

resolvd(8), slaacd(8) and dhcpleased(8) are different from other daemons
in that there must only be a single instance.

resolvd already does this, adjust slaacd and dhcpleased accordingly while
moving the lockfile paths under /dev/ such that they work early on boot and
don't run into races should /var be (un)mounted between daemon starts.

Locking is especially required in the installer where all three daemons are
started every time the "(I)nstall, (U)pgrade, (A)utoinstall or (S)hell? "
prompt is entered, i.e. restarting installation or dropping into a shell
and back into the prompt again would start multiple instances.

To avoid expected lockfile error messages in between installer prompts,
discard standard error when starting the autoconf daemons;  none of them
has other potential failure cases in installer mode before daemon(3)izing.

Input sthen deraadt
OK deraadt



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 19:03:49

Modified files:
sys/dev/pci/drm/amd/amdkfd: kfd_process.c 
kfd_process_queue_manager.c 

Log message:
drm/amdkfd: fix sysfs kobj leak

>From Philip Yang
b3205768cd1a3a9869500ec27e129f8a71d2152a in linux 5.10.y/5.10.52
dcdb4d904b4bd3078fe8d4d24b1658560d6078ef in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 19:01:21

Modified files:
sys/dev/pci/drm: drm_dp_mst_topology.c 

Log message:
drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()

>From Jose Souza
cae871baa4f30608dc2084ca8ddc8f7e49913721 in linux 5.10.y/5.10.52
24ff3dc18b99c4b912ab1746e803ddb3be5ced4c in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 18:59:32

Modified files:
sys/dev/pci/drm: drm_dp_mst_topology.c 

Log message:
drm/dp_mst: Avoid to mess up payload table by ports in stale topology

>From Wayne Lin
16fb4e9c39b9543efd0c3dbc3dbb8865d090646a in linux 5.10.y/5.10.52
3769e4c0af5b82c8ea21d037013cb9564dfaa51f in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 18:57:36

Modified files:
sys/dev/pci/drm: drm_dp_mst_topology.c 

Log message:
drm/dp_mst: Do not set proposed vcpi directly

>From Wayne Lin
3462bc8b1a1f1b507804d33d118402235e8a1fab in linux 5.10.y/5.10.52
35d3e8cb35e75450f87f87e3d314e2d418b6954b in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 18:53:30

Modified files:
sys/dev/pci/drm/i915/gt: intel_ggtt_fencing.c 

Log message:
drm/i915/gt: Fix -EDEADLK handling regression

>From Ville Syrjala
0728df8048060e9bdedb9dd38c62782ee97184ba in linux 5.10.y/5.10.52
2feeb52859fc1ab94cd35b61ada3a6ac4ff24243 in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 18:50:05

Modified files:
sys/dev/pci/drm/i915/gt: gen8_ppgtt.c 

Log message:
drm/i915/gtt: drop the page table optimisation

>From Matthew Auld
81dd2d60f677bbab622c52711a711f0f43d37458 in linux 5.10.y/5.10.52
0abb33bfca0fb74df76aac03e90ce685016ef7be in mainline linux



CVS: cvs.openbsd.org: src

2021-07-20 Thread joshua stein
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/07/20 12:33:59

Modified files:
sys/dev/pci: ksmn.c 

Log message:
add AMD 17h/6xh Root Complex

ok brynet



CVS: cvs.openbsd.org: src

2021-07-20 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2021/07/20 11:31:32

Modified files:
lib/libcrypto/man: Makefile X509_NAME_new.3 d2i_X509_NAME.3 
Added files:
lib/libcrypto/man: X509_NAME_hash.3 

Log message:
Split X509_NAME_hash(3) out of d2i_X509_NAME(3) and document
X509_issuer_name_hash(3), X509_subject_name_hash(3), and the _old variants.

Even though this is only tangentially related to decoding and encoding,
including a single function in d2i_X509_NAME(3) was probably OK,
but let's not bog down that page with six functions that are likely
to become obsolete at some point - even though right now, they are
still being used both internally and by external software.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Vitaliy Makkoveev
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2021/07/20 10:44:55

Modified files:
sys/net: if_pppx.c pipex.c pipex_local.h 

Log message:
Turn pipex(4) session statistics to per-CPU counters. This makes pipex(4)
more compliant to bluhm@'s work on traffic forwarding parallelization.

ok yasuoka@ bluhm@



CVS: cvs.openbsd.org: src

2021-07-20 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2021/07/20 10:32:28

Modified files:
sys/net: if.c pfkeyv2.c 

Log message:
The current workaround to disable parallel IPsec did not work.
Variable nettaskqs must not change at runtime.  Interface input
queues choose the thread during init with ifiq_softnet = net_tq().
So it cannot be modified after pfkeyv2_send() sets the first SA in
kernel.  Also changing the calculation in net_tq() may call task_del()
with a different taskq than task_add().
Instead of restricting the index to the first softnet task, use an
exclusive lock.  For now just move the comment.  We can later decide
if a write net lock or kernel lock is better.
OK mvs@



CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/07/20 10:01:53

Modified files:
share/man/man4 : iwm.4 

Log message:
Add the 7265-17 image back into the list of firmware used by iwm(4).



CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/07/20 10:00:47

Modified files:
sys/dev/pci: if_iwm.c 

Log message:
Do not attempt to load 7265D iwm(4) firmware on all 7265 devices.

There are several variants of 7265 devices, all of which share a PCI ID.
7265D devices can be told apart by looking at the hardware revision number.
Non-D 7265 devices won't load 7265D firmware. Load the 7265-17 image instead.

Problem reported and fix tested on a non-D 7265 by Tilo Stritzky.
Tested on a 7265D by myself.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2021/07/20 09:25:48

Modified files:
distrib/arm64/ramdisk: install.md 

Log message:
Use installboot -p such that the right partition will be newfs'ed.

ok krw@, deraadt@



CVS: cvs.openbsd.org: src

2021-07-20 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2021/07/20 08:51:56

Modified files:
usr.sbin/installboot: armv7_installboot.c hppa_installboot.c 
  i386_installboot.c i386_installboot.h 
  installboot.8 installboot.c installboot.h 
  landisk_installboot.c 
  loongson_installboot.c 
  macppc_installboot.c octeon_installboot.c 
  powerpc64_installboot.c 
  sparc64_installboot.c stubs.c 

Log message:
Add -p option to "prepare" (newfs) a filesystem that will be used for
the bootloader.  This is a no-op on architectures where such a filesystem
isn't needed.

ok krw@, deraadt@



CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/07/20 08:44:37

Modified files:
sys/dev/pci: if_iwm.c 

Log message:
Make iwm_init() call iwm_stop() if we fail to move into SCAN state.

Generally, iwm_init() must either succeed or reset everything. In the case
I observed, the missing call to iwm_stop() left us with a non-zero refcount
for the newstate task which failed to perform the INIT -> SCAN transition.
The next ioctl request from userspace would then trigger a KASSERT in
iwm_init() which checks for old tasks that haven't run to completion.

This problem won't happen under normal conditions. It will happen if
the firmware crashes in response to a bad scan command, for instance.
I ran into this while working on support for newer iwx(4) firmware.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/07/20 08:44:09

Modified files:
sys/dev/pci: if_iwx.c 

Log message:
Make iwx_init() call iwx_stop() if we fail to move into SCAN state.

Generally, iwx_init() must either succeed or reset everything. In the case
I observed, the missing call to iwx_stop() left us with a non-zero refcount
for the newstate task which failed to perform the INIT -> SCAN transition.
The next ioctl request from userspace would then trigger a KASSERT in
iwx_init() which checks for old tasks that haven't run to completion.

This problem won't happen under normal conditions. It will happen if
the firmware crashes in response to a bad scan command, for instance.
I ran into this while working on support for newer iwx(4) firmware.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2021/07/20 07:36:42

Modified files:
distrib/sets/lists/comp: mi 

Log message:
sync



CVS: cvs.openbsd.org: src

2021-07-20 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2021/07/20 06:08:53

Modified files:
usr.sbin/bgpctl: bgpctl.c 

Log message:
Also add missing -V to usage



CVS: cvs.openbsd.org: src

2021-07-20 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2021/07/20 06:07:46

Modified files:
usr.sbin/bgpd  : bgpd.c 

Log message:
Add -V to usage. Reported by Pier Carlo Chiodi.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Inoguchi Kinichiro
CVSROOT:/cvs
Module name:src
Changes by: inogu...@cvs.openbsd.org2021/07/20 06:04:53

Modified files:
usr.bin/openssl: ca.c 

Log message:
Check pointer variable if it is NULL in ca.c

missed with r1.32



CVS: cvs.openbsd.org: src

2021-07-20 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2021/07/20 05:20:09

Modified files:
distrib/miniroot: install.sub 

Log message:
Simplify DHCP lease file parer after switch to dhcpleased

dhcpleased(8)'s lease files are much simpler than dhclient.leases(5):
- exactly one lease per file (not many)
- only option lines (not statement, declaration, etc.)
- every option/value is separated by a single ": " (no optional leading
"option ")
- values are not quoted or escaped (like dhclient does)

lease_value() is hard to read, mostly because it strips optional double
quotes around option values as was required with dhclient.

dhclient VIS_ALL's values if they contain backticks, backslashes and
other characters, otherwise it VIS_SAFE's (and optionally quotes them).

dhcpleased VIS_SAFE's all value strings equally.

All install.sub users of lease_value() quote its output so they should
be safe without any special unescaping as previously done.

OK florian



CVS: cvs.openbsd.org: src

2021-07-20 Thread Visa Hankala
CVSROOT:/cvs
Module name:src
Changes by: v...@cvs.openbsd.org2021/07/20 01:53:39

Modified files:
sys/arch/mips64/mips64: ipifuncs.c 

Log message:
Remove bogus use of CPU_MAXID and get cpu_info only once.



CVS: cvs.openbsd.org: src

2021-07-20 Thread Visa Hankala
CVSROOT:/cvs
Module name:src
Changes by: v...@cvs.openbsd.org2021/07/20 01:51:08

Modified files:
sys/arch/mips64/conf: files.mips64 
Removed files:
sys/lib/libkern/arch/mips64: sync.S 

Log message:
Remove unneeded __sync_* library functions from the kernel.

These library functions were added as stopgaps because GCC 4.2.1
lacks the corresponding __sync_* builtins on mips64. However,
the builtins are now provided by Clang.