CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: aoy...@cvs.openbsd.org 2022/01/28 23:25:33 Modified files: sys/uvm: uvm_page.h Log message: Fix macro name in comment. ok visa@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/01/28 22:47:36 Modified files: sys/lib/libkern/arch/mips64: bcmp.S bzero.S memmove.S strcmp.S Log message: Use local symbols in libkern mips64 assembly routines. OK miod@
CVS: cvs.openbsd.org: www
CVSROOT:/cvs Module name:www Changes by: k...@cvs.openbsd.org2022/01/28 20:05:54 Modified files: . : want.html Log message: My X230 sadly isn't up to speed these days anymore and keeps falling apart. I would appreciate a faster non-Intel machine for the next years to come.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: inogu...@cvs.openbsd.org2022/01/28 19:03:19 Modified files: lib/libtls : tls_signer.c Log message: Add limits.h for INT_MAX in tls_signer.c ok jsing@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: chel...@cvs.openbsd.org 2022/01/28 17:19:04 Modified files: usr.bin/head : head.c Log message: head(1): refactor main loop The main loop here is horribly obfuscated. In particular, the path through the loop to exit(3) is very complex. Refactor the open/read/write/close portions of the loop out of main() into a separate function, head_file(). The result is a lot easier to understand at a glance. In particular, the path to the end of main() is now dead simple. Thread: https://marc.info/?l=openbsd-tech=164325900400701=2 ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: chel...@cvs.openbsd.org 2022/01/28 17:11:54 Modified files: usr.bin/rev: rev.c Log message: rev(1): refactor main loop The main loop here is obfuscated. Refactor the open/read/write/close portion of the loop out of main () and into a new function, rev_file(). Move "multibyte" out into global storage. The result is much easier to understand at a glance. Thread: https://marc.info/?l=openbsd-tech=164329515201417=2 ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: chel...@cvs.openbsd.org 2022/01/28 17:06:26 Modified files: usr.bin/touch : touch.c Log message: touch(1): don't leak file descriptor if futimens(2) fails This conditional chain short-circuits if futimens(2) fails, leaving the file descriptor open. We need to evaluate each system call in the chain separately to ensure we attempt to close(2) the descriptor. With input from guenther@ and millert@. Thread: https://marc.info/?l=openbsd-tech=164332809900558=2 ok millert@, probably ok guenther@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: gkoeh...@cvs.openbsd.org2022/01/28 11:37:40 Modified files: sys/arch/powerpc/ddb: db_interface.c db_trace.c sys/arch/powerpc/include: db_machdep.h sys/arch/powerpc64/powerpc64: db_trace.c Log message: Give ddb more access to registers on macppc, powerpc64 Edit db_regs[] in db_trace.c on both powerpc and powerpc64, so ddb can access $r14, $r15, $r16, $dar, $dsisr. Only for powerpc: change db_trap_glue to copy all registers to and from ddb_regs (it was skipping some); change db_set_single_step and db_clear_single_step to flip the correct bit of srr1; delete FIXUP_PC_AFTER_BREAK, which was off by 1 instruction. "ddb{1}> s" on my PowerMac7,3 (dual G5 at 2700 MHz) began to panic like, "*cpu0: mutex 0xa7d0a0 not held in tc_update_timekeep". Add an arbitrary delay(100) after sending PPC_IPI_DDB; I want cpu0 to get the ipi before it can see db_active == 1 and skip acquiring a mutex. ok kettenis@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/01/28 09:20:09 Modified files: sys/arch/mips64/include: cpu.h trap.h sys/arch/mips64/mips64: lcore_access.S Log message: Remove unused guarded read and write routines. No objection from miod@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: clau...@cvs.openbsd.org 2022/01/28 08:30:23 Modified files: usr.sbin/rpki-client: extern.h main.c mft.c parser.c Log message: Properly handle .mft files as intended by the RFC. Instead of always selecting the newest file this opens both the new (from rrdp or rsync) and old (valid) MFT. It then compares the manifest number and based on that the 'newer' MFT is selected. The MFT file and hash check is also changed to always try both locations and selecting whatever matches up with the hash. The selction is passed back to the the main process and used later on to open exactly the same file as was checked against the hash. The MFT parsing code has been split up into multiple steps so that the files can be parsed, compared and then fully validated. In most cases this makes no difference but it prevents replay attacks using old but still valid files. With and OK tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: clau...@cvs.openbsd.org 2022/01/28 07:11:27 Modified files: usr.sbin/rpki-client: repo.c Log message: Do not skip .rrdp cache cleanup if rrdp is off (option -R). The sync via rsync alters the cache and rrdp can only recover by downloading a snapshot. By doing the cleanup here it will make sure this happens. Noticed by job@ OK tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: inogu...@cvs.openbsd.org2022/01/28 06:14:48 Modified files: lib/libssl : ssl_cert.c Log message: Error check for sk_push in libssl CID 118976 118979 ok tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: inogu...@cvs.openbsd.org2022/01/28 06:11:56 Modified files: lib/libssl : d1_srtp.c Log message: Error check for sk_push in libssl CID 24838 comment and ok tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: clau...@cvs.openbsd.org 2022/01/28 03:41:44 Modified files: lib/libutil: imsg.c Log message: Only memcpy() into imsg->data if datalen is not 0. Passing a NULL pointer to memcpy() is UB no matter if len is 0. Reported by fouzhe on openbgpd-portable github page. OK tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: clau...@cvs.openbsd.org 2022/01/28 03:37:23 Modified files: usr.sbin/bgpd : rde_trie.c Log message: Must use unsigned 1 here since modern compilers can't shift a signed 1 by 31. OK tb@ kettenis@