CVS: cvs.openbsd.org: src

2022-04-28 Thread Damien Miller
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2022/04/28 22:55:08

Modified files:
usr.bin/ssh: addr.c 

Log message:
be stricter in which characters will be accepted in specifying a mask
length; allow only 0-9. From khaleesicodes via GHPR#278; ok dtucker@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Damien Miller
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2022/04/28 21:24:30

Modified files:
usr.bin/ssh: ssh-pkcs11-helper.8 ssh-sk-helper.8 

Log message:
mention that the helpers are used by ssh(1), ssh-agent(1) and
ssh-keygen(1). Previously only ssh(1) was mentioned.
>From Pedro Martelletto



CVS: cvs.openbsd.org: src

2022-04-28 Thread Darren Tucker
CVSROOT:/cvs
Module name:src
Changes by: dtuc...@cvs.openbsd.org 2022/04/28 21:16:48

Modified files:
usr.bin/ssh: sk-usbhid.c ssh-sk-helper.c 

Log message:
Don't leak SK device.  Patch from Pedro Martelletto via github PR#316.
ok djm@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Damien Miller
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2022/04/28 21:13:32

Modified files:
usr.bin/ssh: ssh-agent.c 

Log message:
fix memleak on session-bind path; from Pedro Martelletto, ok dtucker@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Jeremie Courreges-Anglas
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2022/04/28 16:11:59

Modified files:
regress/sys/ffs: run 
regress/sys/ffs/tests/link: 05.t 15.t 
regress/sys/ffs/tests/mkdir: 11.t 
regress/sys/ffs/tests/mkfifo: 11.t 
regress/sys/ffs/tests/open: 19.t 
regress/sys/ffs/tests/symlink: 11.t 
regress/sys/ffs/tests/truncate: 12.t 

Log message:
Use $(( )) arithmetic expansion instead of `expr something`

No need to use an external tool when the shell can handle this basic task.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Dave Voutila
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2022/04/28 15:04:24

Modified files:
usr.sbin/btrace: bt_parse.y 

Log message:
btrace(8): fix lexer to allow whitespace after filters.

Whitespace is allowed after the closing slash of a filter and before
the opening brace of an action. This makes the lexer scan ahead and
collect any whitespace and newlines into the end of filter token.

ok mpi@



Re: CVS: cvs.openbsd.org: src

2022-04-28 Thread Martin Pieuchot
On 28/04/22(Thu) 12:12, Martin Pieuchot wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   m...@cvs.openbsd.org2022/04/28 12:12:33
> 
> Modified files:
>   sys/uvm: uvm_vnode.c 
> 
> Log message:
> Always acquire the `vmobjlock' before incrementing an object's reference.

With and ok semarie.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Joel Sing
CVSROOT:/cvs
Module name:src
Changes by: js...@cvs.openbsd.org   2022/04/28 12:36:38

Modified files:
regress/lib/libcrypto/asn1: asn1complex.c 

Log message:
Add tests that decode sequences into ASN.1 strings.

Test decoding of sequences with length and indefinite length into an ASN.1
string - in this case the ASN.1 is not decoded, rather the octets are
stored directly as the content of the string.

This exercises a specific path through the ASN.1 decoder.

(you know asn1complex is living up to its name when you have to import
openssl/asn1t.h directly...)



CVS: cvs.openbsd.org: src

2022-04-28 Thread Joel Sing
CVSROOT:/cvs
Module name:src
Changes by: js...@cvs.openbsd.org   2022/04/28 12:30:57

Modified files:
lib/libcrypto/asn1: asn1_lib.c asn1_locl.h tasn_dec.c 

Log message:
Rewrite asn1_check_tlen() using CBS.

Rather than calling asn1_get_object_cbs(), call asn1_get_identifier_cbs(),
then immediately proceed with the tag number and tag class check. Only if
that succeeds (or it is not required) do we call asn1_get_length_cbs().
This avoids incurring the overhead of decoding the length in the case where
the tag number and tag class do not match.

While here rename asn1_check_tlen() to asn1_check_tag() - while we decode
the length, what we are normally checking is the tag number and tag class.
Also rename the arguments for readability. For now the argument types
and encoding remain unchanged.

ok inoguchi@ tb@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2022/04/28 12:12:33

Modified files:
sys/uvm: uvm_vnode.c 

Log message:
Always acquire the `vmobjlock' before incrementing an object's reference.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2022/04/28 11:47:42

Modified files:
sys/net: route.c route.h 

Log message:
Route timers were not MP safe.  Protect the global lists with a
mutex and move the rttimer entries into a temporary list.  Then the
callback and pool put can be called later without holding the mutex.
tested by Hrvoje Popovski; OK claudio@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2022/04/28 11:31:29

Modified files:
lib/libcrypto/asn1: a_time_tm.c 

Log message:
Refactor ASN1_TIME_adj_internal()

ASN1_TIME_adj_internal() does some strange dances with remembering
allocations in a boolean and using strlen(p) to deduce what happened
inside *_string_from_tm(). It also (mis)translates a NULL p to an
illegal time value error.

This can be streamlined by converting directly from a struct tm into an
ASN1_TIME and setting the errors when they occur instead of trying to
deduce them from a NULL return. This is made a bit uglier than necessary
due to the reuse-or-allocate semantics of the public API.

At the cost of a little code duplication, ASN1_TIME_adj_internal()
becomes very easy and ASN1_TIME_to_generalizedtime() is also simplified
somewhat.

ok inoguchi jsing



CVS: cvs.openbsd.org: src

2022-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2022/04/28 11:27:14

Modified files:
sys/netinet: ip_input.c ip_mroute.c ip_mroute.h 
sys/netinet6   : ip6_input.c ip6_mroute.c ip6_mroute.h 

Log message:
In the multicast router code don't allocate a rt timer queue for each
rdomain. The rttimer API is rtable/rdomain aware and so there is no need
to have so many queues.
Also init the two queues (one for IPv4 and one for IPv6) early on. This
will allow the rttable code to become simpler.
OK bluhm@



CVS: cvs.openbsd.org: www

2022-04-28 Thread T . J . Townsend
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2022/04/28 11:01:56

Removed files:
.  : art1.html art2.html art3.html art4.html 

Log message:
almost all of the images on these pages give a 404 error since they're not
stored in the www repo. remove them for now so people stop finding them on
search engines.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2022/04/28 10:56:39

Modified files:
sys/net: if.c netisr.h 
sys/netinet: ip_input.c ip_var.h 
sys/netinet6   : ip6_input.c 

Log message:
Decouple IP input and forwarding from protocol input.  This allows
to have parallel IP processing while the upper layers are still not
MP safe.  Introduce ip_ours() that enqueues the packets and ipintr()
that dequeues and processes them with an exclusive netlock.
Note that we still have only one softnet task.  Running IP processing
on multiple CPU will be the next step.
lots of testing Hrvoje Popovski; OK sashan@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2022/04/28 10:16:46

Modified files:
regress/usr.bin/mandoc/roff: Makefile 
usr.bin/mandoc : mandoc.1 mandoc.h mandoc_msg.c roff.c 
Added files:
regress/usr.bin/mandoc/roff/mc: Makefile args.in args.out_ascii 
args.out_lint 

Log message:
The syntax of the roff(7) .mc request is quite special
and the roff_onearg() parsing function is too generic,
so provide a dedicated parsing function instead.

This fixes an assertion failure when an \o escape sequence is
passed as the argument; the bug was found by tb@ using afl(1).
It also makes mandoc output more similar to groff in various cases.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Inoguchi Kinichiro
CVSROOT:/cvs
Module name:src
Changes by: inogu...@cvs.openbsd.org2022/04/28 09:42:10

Modified files:
usr.bin/openssl: pkcs12.c 

Log message:
Fix comparison in openssl(1) pkcs12

comment from tb@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Anton Lindqvist
CVSROOT:/cvs
Module name:src
Changes by: an...@cvs.openbsd.org   2022/04/28 09:37:01

Modified files:
regress/sys/net/pf_opts: Makefile 

Log message:
Environment variables must be passed through env(1) while using sudo.

ok bluhm@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Inoguchi Kinichiro
CVSROOT:/cvs
Module name:src
Changes by: inogu...@cvs.openbsd.org2022/04/28 09:29:10

Modified files:
usr.bin/openssl: pkcs12.c 

Log message:
Compare pointer value with NULL in openssl(1) pkcs12

ok tb@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2022/04/28 08:58:11

src/regress/usr.bin/mandoc/roff/mc

Update of /cvs/src/regress/usr.bin/mandoc/roff/mc
In directory cvs.openbsd.org:/tmp/cvs-serv19608/mc

Log Message:
Directory /cvs/src/regress/usr.bin/mandoc/roff/mc added to the repository



CVS: cvs.openbsd.org: src

2022-04-28 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2022/04/28 07:22:19

Modified files:
sbin/fdisk : cmd.c gpt.c part.c 

Log message:
Convert the internal GPT partition entries into host-endian form
on input/initialization and back to little-endian when writing to
disk.

Easier to read the code when letoh*() and uuid_[enc|dec]_*
invocations are minimized.

No intentional functional change.

ok jmatthew@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2022/04/28 04:23:32

Modified files:
regress/usr.bin/mandoc/man/B: nest.in nest.out_ascii 

Log message:
oops, fix wrong .TH name



CVS: cvs.openbsd.org: src

2022-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2022/04/28 04:17:38

Modified files:
usr.bin/mandoc : man.c 
regress/usr.bin/mandoc/man/B: Makefile 
Added files:
regress/usr.bin/mandoc/man/B: nest.in nest.out_ascii 
  nest.out_lint 

Log message:
Element next-line scopes may nest, so man_breakscope() may have to
break multiple element next-line scopes at the same time, similar to
what man_descope() already does for unconditional rewinding.

This fixes an assertion failure that tb@ found with afl(1), caused
by .SH .I .I .BI and similar sequences of macros without arguments.



CVS: cvs.openbsd.org: src

2022-04-28 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2022/04/28 03:59:28

Modified files:
sys/uvm: uvm_page.c 

Log message:
Call uvm_pageactivate() from uvm_pageunwire() instead of rerolling it.

Having fewer places manipulating the global list of active/inactive pages
will help future LRU improvements.

ok kettenis@, kn@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2022/04/28 03:58:11

Modified files:
sys/uvm: uvm_swap.c 

Log message:
Update uvmexp.swpgonly only once in uvm_swap_get().

Prevent a small window where a check could be incorrect in case an error
occurs in uvm_swap_io().

ok kettenis@, kn@



CVS: cvs.openbsd.org: src

2022-04-28 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2022/04/28 02:39:18

Modified files:
usr.sbin/pkg_add/OpenBSD/PackageRepository: Installed.pm 

Log message:
glue for 7.2