Re: CVS: cvs.openbsd.org: src
On Sat, Jul 09, 2022 at 05:24:44PM -0600, Alexander Hall wrote: > CVSROOT: /cvs > Module name: src > Changes by: ha...@cvs.openbsd.org 2022/07/09 17:24:44 > > Modified files: > usr.sbin/tcpdump: tcpdump.c > > Log message: > Explicitly set the default value for Bflag to BPF_FILDROP_PASS > > Technically a nop since the value of the initial constant is 0 anyway > but we should not rely on that. This was OK kn@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2022/07/09 17:24:44 Modified files: usr.sbin/tcpdump: tcpdump.c Log message: Explicitly set the default value for Bflag to BPF_FILDROP_PASS Technically a nop since the value of the initial constant is 0 anyway but we should not rely on that.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2021/10/09 15:38:00 Modified files: bin/ksh: emacs.c Log message: In ksh(1) emacs search-history mode, emitting a NUL character causes invalid matches and unexpected behaviour. Fix this by instead making a NUL character abort the search-history mode, leaving the handling of said input to the "ordinary" command editing. ok tb@
Re: CVS: cvs.openbsd.org: src
[I failed to cc djm@] On September 7, 2021 10:39:05 PM GMT+02:00, Alexander Hall wrote: >Hi, > >from the diff: > >+ if (print_pubkey == NULL) >+ *print_pubkey = 0; > >That looks like a terrible fix to me. No? > >/Alexander > >On September 7, 2021 8:03:51 AM GMT+02:00, Damien Miller > wrote: >>CVSROOT: /cvs >>Module name: src >>Changes by: d...@cvs.openbsd.org2021/09/07 00:03:51 >> >>Modified files: >> usr.bin/ssh: ssh-keygen.c >> >>Log message: >>avoid NULL deref in -Y find-principals. Report and fix from >>Carlo Marcelo Arenas Bel��n >> >> >
Re: CVS: cvs.openbsd.org: src
Hi, from the diff: + if (print_pubkey == NULL) + *print_pubkey = 0; That looks like a terrible fix to me. No? /Alexander On September 7, 2021 8:03:51 AM GMT+02:00, Damien Miller wrote: >CVSROOT: /cvs >Module name: src >Changes by:d...@cvs.openbsd.org2021/09/07 00:03:51 > >Modified files: > usr.bin/ssh: ssh-keygen.c > >Log message: >avoid NULL deref in -Y find-principals. Report and fix from >Carlo Marcelo Arenas Bel��n > >
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2021/09/01 12:16:52 Modified files: usr.bin/diff : diffreg.c Log message: consider two files sharing the same inode identical This gives a substantial speedup when comparing directory structures with many hardlinked files, e.g. when using rsnapshot for incremental backup. ok stsp@ millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs
Module name:src
Changes by: ha...@cvs.openbsd.org 2020/11/22 23:21:52
Modified files:
usr.bin/find : function.c
Log message:
The -exec primary is terminated by either ';' or '+', but the latter
only if immediately following a '{}' placeholder. Slightly modify the
error message to indicate so.
Brought up by and discussed with Paul de Weerd, thanks!
ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2018/08/03 05:21:27 Modified files: sbin/ifconfig : ifconfig.8 Log message: document that wpakey needs a preceeding nwid OR join specification ok phessler@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2018/07/10 03:33:34 Modified files: distrib/miniroot: install.sub Log message: simplify and properly quote the loading of soii key generation material, and move it into enable_network() ok florian tb, long ago
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2018/01/21 12:58:37 Modified files: distrib/miniroot: install.sub Log message: fix error handling while fetching sets reported by naddy@ long ago ok rpe@
Re: CVS: cvs.openbsd.org: src
On November 19, 2017 1:11:54 PM GMT+01:00, Job Snijders wrote: >CVSROOT: /cvs >Module name: src >Changes by:j...@cvs.openbsd.org2017/11/19 05:11:54 > >Modified files: > distrib/alpha/bsd.rd: list.local > distrib/amd64/ramdisk_cd: list.local > distrib/arm64/ramdisk: list > distrib/armv7/ramdisk: list > distrib/hppa/ramdisk: list.local > distrib/i386/ramdisk_cd: list.local > distrib/landisk/ramdisk: list > distrib/loongson/ramdisk: list > distrib/luna88k/ramdisk: list > distrib/macppc/ramdisk: list > distrib/octeon/ramdisk: list > distrib/sgi/ramdisk: list > distrib/socppc/ramdisk: list > distrib/sparc64/ramdisk: list > distrib/special: Makefile >Added files: > distrib/special/growfs: Makefile > >Log message: >add growfs(8) to ramdisk Hah, I first thought you had added growfs capability to mfs, which made me raise an eyebrow or two. :-D /Alexander > >Some resizing scenarios can be done from within single user mode, but >resizing the root partition required you to bring your own growfs(8) >binary into the ramdisk environment. This commit adds growfs(8) to the >ramdisks (the ones that don't have space constraints) to simplify such >operations. > >OK deraadt@
Re: CVS: cvs.openbsd.org: src
Hi, - } = 0 + } =0x Innocent spaces were sacrificed, supposedly unintentionally. /Alexander On June 22, 2017 1:21:35 AM GMT+02:00, Theo de Raadt wrote: >CVSROOT: /cvs >Module name: src >Changes by:dera...@cvs.openbsd.org 2017/06/21 17:21:35 > >Modified files: > sys/arch/hppa/conf: ld.script > >Log message: >Better off padding with 0x0. 0x0 = "break 0,0". > >(BTW, the binutils disasm cannot handle that instruction with those >parameters, because the decoder logic is wrong..)
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2017/06/02 18:22:34 Modified files: share/misc : airport Log message: use proper name for LPI
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2017/06/02 18:10:20 Modified files: share/misc : inter.phone Log message: fix spelling in a handful of the Swedish entries
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/11/12 15:22:25 Modified files: usr.sbin/syspatch: syspatch.sh Log message: Improve the cleanup error handling to make sure the exit code is really preserved. Noticed by, discussed with, and fix approved tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/11/06 12:12:58 Modified files: usr.sbin/syspatch: syspatch.sh Log message: Rework the cleanup trap handling using the EXIT trap; trap 'cleanup; goes; here' EXIT trap exit HUP INT TERM ERR FOO BAR BAZ This makes sure the cleanup is always done (unless we exec), and preserves the exit code, such as SIGINT => 130. Also trap less signals. Special signals are special. tested and OK ajacoutot@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/09/13 15:25:29 Modified files: distrib/miniroot: install.sub Log message: "Make disk selection dumb again", or at least make the change less intrusive. Default to the first available disk, skipping to the next (and so on), should the selected one be determined unsuitable for the install or upgrade taking place. "please commit" deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/09/04 06:36:34 Modified files: distrib/miniroot: install.sub Log message: Not having the root filesystem on the 'a' partition is stupi^Wunfortunate, so stop asking. deraadt@ and krw@ agrees ok rpe@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs
Module name:src
Changes by: ha...@cvs.openbsd.org 2016/09/04 04:15:04
Modified files:
distrib/miniroot: install.sub
Log message:
Improve the auto disk selection and also apply it for installs as well
as for upgrades.
- For installs, find all and any disks available.
- For upgrades, look for 'a' partitions with the typical root filesystem
directories in them.
In both cases, if one and only one match is found, it will be selected.
If no disk or multiple disks are found, the installer will require you
to specify a disk, be it by hand or by auto{install,upgrade}.conf.
ok rpe@ krw@ "Innovative." deraadt@
Re: CVS: cvs.openbsd.org: src
On Fri, Sep 02, 2016 at 03:42:28PM -0600, Alexander Hall wrote: > CVSROOT: /cvs > Module name: src > Changes by: ha...@cvs.openbsd.org 2016/09/02 15:42:28 > > Modified files: > distrib/miniroot: install.sub > > Log message: > for an upgrade disk selection, present a default alternative of 'auto', > which will scan the available disks, selecting the first disk with an > 'a' partition of type 4.2BSD > > ok deraadt@ krw@ phessler@ and ok rpe@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/09/02 15:42:28 Modified files: distrib/miniroot: install.sub Log message: for an upgrade disk selection, present a default alternative of 'auto', which will scan the available disks, selecting the first disk with an 'a' partition of type 4.2BSD ok deraadt@ krw@ phessler@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/08/21 13:22:15 Modified files: distrib/miniroot: install.sub Log message: Make lease_value() unescape quoted strings. To be fully compliant, we should unvis() it too, but I think this is enough, at least for now. ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/08/09 15:24:32 Modified files: etc: Makefile etc/mtree : special Removed files: etc: csh.cshrc csh.login csh.logout Log message: remove pointless csh placeholder files from /etc ok jung@ (some time ago) phessler@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/07/30 16:04:04 Modified files: usr.bin/nc : netcat.c Log message: use the style from the man page examples for getaddrinfo, which makes a bit more sense ok jung@ deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2016/02/03 05:23:57 Modified files: usr.bin/tail : tail.c Log message: fix off-by-one in argument parsing ok martijn@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/12/27 02:24:00 Modified files: bin/ksh: main.c Log message: unconditionally duplicate the argv array on initialization, to make it resilient against being altered by a subsequent shift operation tweak and ok semarie@
Re: CVS: cvs.openbsd.org: src
On Wed, Dec 02, 2015 at 02:20:42AM -0700, Reyk Floeter wrote: > CVSROOT: /cvs > Module name: src > Changes by: r...@cvs.openbsd.org2015/12/02 02:20:42 > > Modified files: > usr.sbin/vmmctl: parse.y > > Log message: > The earlier "nifs" change broke the configuration file; unbreak it by > adding a missing bit. Indeed, I missed that. Thanks. /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/12/01 13:52:45 Modified files: usr.sbin/vmmctl: main.c parse.y parser.h Log message: Fix -i option handling. ok reyk@
Re: CVS: cvs.openbsd.org: src
Hi Michael, On November 21, 2015 10:58:46 PM GMT+01:00, Michael McConville wrote: >CVSROOT: /cvs >Module name: src >Changes by:m...@cvs.openbsd.org2015/11/21 14:58:46 > >Modified files: > bin/ksh: ksh.1 > >Log message: >"one" -> "one or more" Wouldn't "any" be a better choice? "one or more" makes it sound like ?(a|b) would match "ab". /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/11/20 16:04:01 Modified files: usr.bin/ssh: ssh-keygen.c Log message: allow comment change for all supported formats ok djm@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/09/27 13:00:32 Modified files: distrib/miniroot: install.sub Log message: HEAD is past 5.8 now, so remove /var/tmp removal tweak. ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/09/20 04:05:48 Modified files: usr.sbin/rmt : rmt.8 rmt.c Log message: Add a set of flags to rmt(8) to make it run in a restricted mode, designed to work with rdump(8) to remote disk. -dconfines rmt to operate within a single directory. -r enforces read-only mode. -w enforces write-only mode. This is quite usable with public ssh key setup, e.g. having the following in .ssh/authorized/keys: command="/etc/rmt -rd /backups/machine.example.conf",no-agent-forwarding,... ssh-rsa B3... ok semarie@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/09/09 17:07:10 Modified files: distrib/miniroot: install.sh install.sub Log message: zap trailing whitespace
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/09/09 09:04:54 Modified files: distrib/miniroot: install.sub Log message: At some point back in time, the disk info (obtained by responding '?' at the root disk question) got some extra linefeeds in it. This fixes the output to be one line per disk again. ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/07/26 22:11:58 Modified files: sys/dev: softraid.c softraid_crypto.c Log message: zap trailing linefeeds from sr_error() and panic() calls ok jsing@
Re: CVS: cvs.openbsd.org: src
On 07/19/15 21:52, Robert Peichaer wrote: CVSROOT:/cvs Module name:src Changes by: r...@cvs.openbsd.org2015/07/19 13:52:36 Modified files: etc: netstart Log message: Always source rc.subr to be able to use the rc.conf parsing routine to get the network related vars from rc.conf. This is even necessary if netstart is run from within /etc/rc. Remove test of $INRC which unintentionally evaluated always to true. rev. 1.435 and 1.439 of /etc/rc did this to us, where we stopped sourcing netstat (thereby running in the same environment) and instead called them via sh(1), only exposing the exported INRC. I'm quite positive this now removed INRC check construct predated them. /Alexander problem with previous change found by nigel@ OK sthen@ aja@ halex@ Affected files: http://o.beard.se/src/etc/netstart
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/07/18 17:23:20 Modified files: sbin/bioctl: bioctl.c Log message: remove the restriction to disallow the use of a passphrase file during initial creation of a crypto volume ok phessler
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/07/16 15:05:08 Modified files: distrib/miniroot: install.sub Log message: zap trailing whitespace with rpe's blessing
Re: CVS: cvs.openbsd.org: www
On June 26, 2015 5:37:25 PM GMT+02:00, Antoine Jacoutot wrote: >CVSROOT: /cvs >Module name: www >Changes by:ajacou...@cvs.openbsd.org 2015/06/26 09:37:25 > >Modified files: > build : mirrors.dat > >Log message: >As off tomorrow, ftp.fr will stop serving files over ftp. >Welcome to the modern age! FTP is dead! Long live^W^W Period.
Re: CVS: cvs.openbsd.org: src
On 06/18/15 00:35, Theo de Raadt wrote: CVSROOT:/cvs Module name:src Changes by: dera...@cvs.openbsd.org 2015/06/17 16:35:08 Modified files: sys/sys: param.h Log message: my keyboard is conspiring against me You should zap those keyboard controller firmware patches from your tree or they'll keep biting you. :-)
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/04/28 18:10:44 Modified files: etc: daily Log message: VERBOSESTATUS or no VERBOSESTATUS, failed or missing dumps are still worth noting "go ahead" schwarze@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/03/23 16:29:32 Modified files: lib/libc/net : rcmd.3 rcmdsh.3 rcmdsh.c Log message: Make rcmdsh(3) not fail if it is passed a non resolvable hostname. Instead, silently ignore the fact and instead let the underlying ssh (or $RSH) command handle it. ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/03/22 16:32:03 Modified files: lib/libc/net : rcmd.c Log message: differentiate between a failed read, returning -1, and encountering end-of-file, returning 0, in order not to print an unrelated strerror(errno) in the latter case ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/03/21 18:58:16 Modified files: lib/libc/net : rcmd.c Log message: unmute rcmd hostname lookup failure ok millert@ jung@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/03/19 16:05:28 Modified files: lib/libc/net : rcmd.c Log message: zap #if 0'd code that's been dead since '96 ok todd@
Re: CVS: cvs.openbsd.org: src
On March 18, 2015 11:18:19 PM GMT+01:00, Jason McIntyre wrote: >CVSROOT: /cvs >Module name: src >Changes by:j...@cvs.openbsd.org2015/03/18 16:18:19 > >Modified files: > bin/ksh: sh.1 > >Log message: >remove ambiguity from the COMMANDS section, after discussion with zhuk; Did I mention I love you guys for doing this?
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/02/21 14:46:57 Modified files: usr.bin/ssh: ssh-add.c Log message: make "ssh-add -d" properly remove a corresponding certificate, and also not whine and fail if there is none ok djm@
Re: CVS: cvs.openbsd.org: src
On February 10, 2015 2:50:58 PM CET, Ted Unangst wrote: >CVSROOT: /cvs >Module name: src >Changes by:t...@cvs.openbsd.org2015/02/10 06:50:58 > >Modified files: > games/banner : banner.c > >Log message: >the stem of the b was not descending all the way to the baseline. >now `/usr/games/banner libressl` is extra purty. >i should credit miod for reminding me of this program's existence >by requesting that i not paste its output into chat. I wonder if he'd prefer /usr/bin/banner... /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/02/02 17:34:14 Modified files: usr.bin/ssh: ssh-add.c Log message: slightly extend the passphrase prompt if running with -c in order to give the user a chance to notice if unintentionally running without it wording tweak and ok djm@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2015/01/23 07:38:24 Removed files: usr.sbin/fw_update: Makefile fw_update.1 fw_update.sh Log message: Killing my darling. Functionality and binary name moved to pkg_* and friends. So long and thanks for all the fish. ok deraadt@
Re: CVS: cvs.openbsd.org: src
On 01/22/15 20:00, Kenneth R Westerback wrote: CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2015/01/22 12:00:24 Modified files: etc: rc Log message: Use /etc/services names in all the default pf rules (most already did). This allows any local changes to /etc/services to be effective if all you have is the default. Please note, however, that local changes to /etc/services will be overwritten on upgrades! /Alexander Issue pointed out by Brian S. Vangsgaard on bugs@. Thanks! ok phessler@ deraadt@
Re: CVS: cvs.openbsd.org: src
On December 8, 2014 1:12:16 AM CET, Theo de Raadt wrote: >> On December 8, 2014 12:05:30 AM CET, Ingo Schwarze > wrote: >> >CVSROOT:/cvs >> >Module name:src >> >Changes by: schwa...@cvs.openbsd.org2014/12/07 16:05:30 >> > >> >Modified files: >> >share/man/man8 : afterboot.8 >> > >> >Log message: >> >Since rev. 1.1, we discouraged space characters in passwords >> >but even after repeated enquiries on misc@, nobody can explain why, >> >so tedu the two confusing words; ok tedu@. >> >> Why do we recommend changing the root password there at all? I >suspect some horribly outdated historical reason, but I don't see the >point of that part at all. > >Why recommend anything at all? Rereading the page (it's been a looong time since, if ever) I feel a lot of it is already handled in the installer (nowadays anyway). However, if this isn't relevant to the purpose of the page, I'll drop the subject. /Alexander > >The idea behind this page is to have (1) a page we can point at which >(2) contains a few recommendations, so that (3) the users of the >system can start thinking about management, and maybe we can pray they >think there are best practices... > >The main problem with this page is ensuring that developers don't add >fluff to it as time goes by.
Re: CVS: cvs.openbsd.org: src
On December 8, 2014 12:05:30 AM CET, Ingo Schwarze wrote: >CVSROOT: /cvs >Module name: src >Changes by:schwa...@cvs.openbsd.org2014/12/07 16:05:30 > >Modified files: > share/man/man8 : afterboot.8 > >Log message: >Since rev. 1.1, we discouraged space characters in passwords >but even after repeated enquiries on misc@, nobody can explain why, >so tedu the two confusing words; ok tedu@. Why do we recommend changing the root password there at all? I suspect some horribly outdated historical reason, but I don't see the point of that part at all. /Alexander
Re: CVS: cvs.openbsd.org: src
> CVSROOT: /cvs > Module name: src > Changes by: clau...@cvs.openbsd.org 2014/09/28 06:58:02 > > Modified files: > etc: netstart > > Log message: > Revert 1.142. Without the down netstart will just print the ifconfig > output because it may end up just calling 'ifconfig $if'. This needs > to be done better and properly tested. How the hell could I miss that? Bah. Thanks. /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/09/26 09:18:01 Modified files: etc: netstart Log message: remove explicit 'down' of an interface before starting a dhcp request, thereby avoiding annoying delays for some switch configurations ok claudio@ deraadt@ i would add ok phessler@, but it was not valid without an ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/09/08 05:27:49 Modified files: usr.sbin/sysmerge: sysmerge.sh Log message: strip excess verbiage from sed expressions ok and prodding ajacoutot@
Re: CVS: cvs.openbsd.org: src
On September 6, 2014 11:46:15 PM CEST, Robert Peichaer wrote: >CVSROOT: /cvs >Module name: src >Changes by:r...@cvs.openbsd.org2014/09/06 15:46:15 > >Modified files: > usr.sbin/sysmerge: sysmerge.sh > >Log message: >Replace awk with either sed or shell equivalents. Two cases of excess verbiage. sed -n '/OK$/s/^(SHA256) \(.*\): OK$/\1/p' is equivalent to sed -n 's/^(SHA256) \(.*\): OK$/\1/p' /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/08/25 06:08:55 Modified files: etc/rc.d : snmpd Log message: snmpd cannot reload ok reyk@
Re: CVS: cvs.openbsd.org: src
On 08/17/14 20:28, Antoine Jacoutot wrote: On Sun, Aug 17, 2014 at 08:21:26PM +0200, Alexander Hall wrote: On 08/17/14 16:43, Antoine Jacoutot wrote: CVSROOT:/cvs Module name:src Changes by: ajacou...@cvs.openbsd.org 2014/08/17 08:43:34 Modified files: etc: rc Log message: Execute /etc/netstart using sh(1) instead of sourcing it. Committing early to make sure we have time to fix any side-effect. ok deraadt@ One change this brings is that the 'trap : 2' from /etc/rc is no longer propagated into the rc script, so pressing ^C while in will abort the entire Er, that should of course be "propagated into the *netstart* script" netstart script instead of the currently running part of it. That said, I don't know if it was ever intentional, and I'm not sure we want it back. Not sure either. But it's exactly to get that kind of feedback that it got committed :-)
Re: CVS: cvs.openbsd.org: src
On 08/17/14 16:43, Antoine Jacoutot wrote: CVSROOT:/cvs Module name:src Changes by: ajacou...@cvs.openbsd.org 2014/08/17 08:43:34 Modified files: etc: rc Log message: Execute /etc/netstart using sh(1) instead of sourcing it. Committing early to make sure we have time to fix any side-effect. ok deraadt@ One change this brings is that the 'trap : 2' from /etc/rc is no longer propagated into the rc script, so pressing ^C while in will abort the entire netstart script instead of the currently running part of it. That said, I don't know if it was ever intentional, and I'm not sure we want it back. /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/08/09 15:51:29 Modified files: distrib/miniroot: install.sh install.sub Log message: After a cleanup by deraadt I noticed the four-space-indent had started infesting the scripts. As we generally use a single tab for line continuation indent in the scripts, let's reclaim 30 precious bytes! ok rpe@ krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/11 15:12:39 Modified files: etc: ksh.kshrc Log message: Introducing a nifty _ignore function makes the file neater and easier to maintain. The eval's must stay to make the aliases expand at run time instead of at parse time. ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/11 12:19:45 Modified files: usr.bin/ftp: fetch.c main.c Log message: simplify and slightly tweak user agent handling ok lteo@
Re: CVS: cvs.openbsd.org: src
On 07/09/14 17:41, Alexander Hall wrote: CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/09 09:41:16 Modified files: etc: ksh.kshrc Log message: I hate eval. Apart from when it's really needed. Eval'ing constant expressions is not such a case. This was untrue since the eval delayed the alias expansion. It is now reverted and a better diff is on its way. /Alexander "...fine with me" krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/11 10:41:16 Modified files: etc: ksh.kshrc Log message: revert last commit eval seems to be needed for reaching the aliases which otherwise aren't available from within functions...
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/11 10:01:41 Modified files: include/protocols: dumprestore.h sbin/dump : Makefile dump.8 dump.h itime.c main.c Log message: make dump support DUIDs for command line arguments and /etc/dumpdates (using the new shiny -U switch) dumpdates part originating from, and discussed with, Maximilian Fillinger seems reasonable to krw@, "get it in" deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/07/09 09:41:16 Modified files: etc: ksh.kshrc Log message: I hate eval. Apart from when it's really needed. Eval'ing constant expressions is not such a case. "...fine with me" krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/05/26 13:37:27 Modified files: etc/mtree : special Log message: remove /usr/src. avoids useless whining from daily security mail. ok landry@ ajacoutot@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/05/20 16:49:43 Modified files: sys/arch/amd64/stand/pxeboot: pxeboot.8 sys/arch/i386/stand/pxeboot: pxeboot.8 Log message: remove irrelevant, outdated, and misleading sentence suggesting that you need to set up a local mirror for the install sets brought to attention by pascal@ ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/05/11 15:25:07 Modified files: sbin/ncheck_ffs: ncheck_ffs.c Log message: replace realloc(p, N * M) with reallocarray(p, N, M) and remove some pointless cleanup if we're obviously going to die anyway ok guenther@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/05/07 14:07:59 Modified files: lib/libc/stdlib: malloc.c Log message: comment style fix ok crickets@
Re: CVS: cvs.openbsd.org: src
On May 7, 2014 6:00:20 PM CEST, Ted Unangst wrote: >On Tue, Apr 22, 2014 at 14:38, Ted Unangst wrote: >> CVSROOT: /cvs >> Module name: src >> Changes by: t...@cvs.openbsd.org2014/04/22 14:38:03 >> >> Modified files: >> lib/libssl/src/crypto/asn1: a_bytes.c >> >> Log message: >> null a pointer to prevent double free. from Dirk Engling > >Belated champagne for me! This was commit number 2000. \o/
Re: CVS: cvs.openbsd.org: src
On April 29, 2014 10:41:53 PM CEST, Gilles Chehade wrote: >On Tue, Apr 29, 2014 at 09:21:24PM +0200, Alexander Hall wrote: >> >> On April 29, 2014 7:32:42 PM CEST, Gilles Chehade > wrote: >> >CVSROOT:/cvs >> >Module name:src >> >Changes by: gil...@cvs.openbsd.org 2014/04/29 11:32:42 >> > >> >Modified files: >> >usr.sbin/smtpd : mta_session.c >> > >> >Log message: >> >when a session fails due to a TLS error in a smtp+tls:// connection, >> >try >> >plain before giving up >> >> Maybe I'm just misreading the commit message, but this sounds >surprising. Can you please elaborate on why and when this behavior >makes sense? >> > >Yes, I think you misunderstood the commit, but I'll explain. > >Imagine you have the following rule: > > accept from local for any relay > >It is supposed to relay mail from your local users to the world. > >It does not explicitely request any kind of security[0] and it should >be >able to deliver to any correctly configured peer accepting mail, with >or >without TLS enabled. > >OpenSMTPD does opportunistic TLS so when it establishes a session, >it'll >always try to negotiate TLS before deciding to go without encryption. > >Now what happened is that this opportunistic TLS code had a logic >error: > >If STARTTLS was advertised, we relayed over TLS. >If STARTTLS was not advertised, we relayed anyways. > >If STARTTLS was advertised but we failed to negotiate for some >reason... >instead of trying plain which might just work fine, we did just as if >we >were in a strict TLS mode and failed the relay. > >[0] unlike "relay via tls://", "via smtps://" or even "relay tls" Ok. I just didn't parse the tls in "smtp+tls://" part as non mandatory. Thanks for the explanation! /Alexander
Re: CVS: cvs.openbsd.org: src
On April 29, 2014 7:32:42 PM CEST, Gilles Chehade wrote: >CVSROOT: /cvs >Module name: src >Changes by:gil...@cvs.openbsd.org 2014/04/29 11:32:42 > >Modified files: > usr.sbin/smtpd : mta_session.c > >Log message: >when a session fails due to a TLS error in a smtp+tls:// connection, >try >plain before giving up Maybe I'm just misreading the commit message, but this sounds surprising. Can you please elaborate on why and when this behavior makes sense? /Alexander > >ok eric@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/04/25 13:34:24 Modified files: distrib/miniroot: install.sub Log message: filter excess data from autoinstall output *before* it ends up in the log file on the ramdisk, in order not to run out of its precious space reported by, tested and ok sebastia@
Re: CVS: cvs.openbsd.org: src
On 04/25/14 02:37, Ted Unangst wrote: On Thu, Apr 24, 2014 at 22:17, Alexander Hall wrote: On 04/23/14 23:01, Ted Unangst wrote: CVSROOT:/cvs Module name:src Changes by: t...@cvs.openbsd.org2014/04/23 15:01:15 Modified files: lib/libssl/src/ssl: kssl.c Log message: null pointers after free to prevent double frees and worse. also fix a Looking at the code, this looks like an effort in being proactive: free(*princ); *princ = NULL; ... nothing about 'princ'... if ((*princ = calloc(1, length)) == NULL) return KSSL_CTX_ERR; However, would that not rather risk hiding potential use-after-free's by not exposing a second free() later on? Now if you try to use it, you will get an immediate crash. I Ah, indeed. I was too focused on the free() and my mind was still set on that the pointer still addressed the already free'd memory. D'oh. think free then NULL is the best idiom to use anywhere it's not obvious what the pointer's lifetime will be. In some cases, this is unnecessary, but it's not burdensome in my opinion. I'm not going crazy and adding null after every free, just the ones that look suspicious. Indeed. I withdraw my comments. :-) /Alexander (This one looked a lot more suspicious than it really was because of the use of '\0' for null. It was in effect already doing what I changed it to, just in an obfuscated manner.)
Re: CVS: cvs.openbsd.org: src
On 04/24/14 22:17, Alexander Hall wrote: On 04/23/14 23:01, Ted Unangst wrote: CVSROOT:/cvs Module name:src Changes by:t...@cvs.openbsd.org2014/04/23 15:01:15 Modified files: lib/libssl/src/ssl: kssl.c Log message: null pointers after free to prevent double frees and worse. also fix a Looking at the code, this looks like an effort in being proactive: free(*princ); *princ = NULL; ... nothing about 'princ'... if ((*princ = calloc(1, length)) == NULL) return KSSL_CTX_ERR; However, would that not rather risk hiding potential use-after-free's by not exposing a second free() later on? (Note that I'm not talking about this specific example, in which the NULL'ification of *princ appears totally pointless) Or did I miss something here? Still holds. :)
Re: CVS: cvs.openbsd.org: src
On 04/23/14 23:01, Ted Unangst wrote: CVSROOT:/cvs Module name:src Changes by: t...@cvs.openbsd.org2014/04/23 15:01:15 Modified files: lib/libssl/src/ssl: kssl.c Log message: null pointers after free to prevent double frees and worse. also fix a Looking at the code, this looks like an effort in being proactive: free(*princ); *princ = NULL; ... nothing about 'princ'... if ((*princ = calloc(1, length)) == NULL) return KSSL_CTX_ERR; However, would that not rather risk hiding potential use-after-free's by not exposing a second free() later on? I can see the point in some code paths, where we later on cannot know whether it's allocated or not, e.g. ptr = malloc(100); if(foo) goto cleanup; free(ptr); ptr=NULL; ... cleanup: free(ptr); but in general, I'm not convinced this is a good thing. Or did I miss something here? /Alexander very obvious use after free. this file may still be a total loss.
Re: CVS: cvs.openbsd.org: src
On April 1, 2014 2:15:44 PM CEST, Gilles Chehade wrote: >CVSROOT: /cvs >Module name: src >Changes by:gil...@cvs.openbsd.org 2014/04/01 06:14:47 > >Added files: > usr.sbin/smtpd : gotmail.mp3 > >Modified files: > usr.sbin/smtpd : mda.c > >Log message: >play "you've got mail" notifications when local users receive messages, >requires a running sndiod. Awesome. Obviously you also embed the mp3 file in the binary since you don't alter the Makefile. I've so been looking forward to this! :-) > >ok eric@, chl@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/03/13 23:27:00 Modified files: usr.sbin/smtpd : queue_backend.c Log message: print the correct user name if SMTPD_QUEUE_USER is missing ok tedu@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/23 15:22:16 Modified files: usr.sbin/fw_update: fw_update.1 fw_update.sh Log message: - add a -p switch for specifying the location of firmware packages - reword 'firmware files' to 'firmware' - pick some style and whitespace nits ok deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/23 13:09:59 Modified files: usr.sbin/fw_update: fw_update.sh Log message: print out the path to the firmware packages in verbose mode, for use with the upcoming -p flag
Re: CVS: cvs.openbsd.org: src
On 02/13/14 06:51, Alexander Hall wrote: CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/12 22:51:07 Modified files: sys/scsi : sd.c Log message: if an attached sd(4) is readonly, make sure it's noticable in the dmesg, or write operations just fail with EACCES for no obvious reason ok krw@ tedu@ ...and thanks to krw@ for pointing me in the right direction! /Alexander
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/12 22:51:07 Modified files: sys/scsi : sd.c Log message: if an attached sd(4) is readonly, make sure it's noticable in the dmesg, or write operations just fail with EACCES for no obvious reason ok krw@ tedu@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/07 16:28:21 Modified files: distrib/miniroot: install.sub Log message: make sure a free bpf exists before dhclient is run, and remove some prior workarounds until we have clonable bpfs ok rpe@ krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/02/05 13:35:42 Modified files: bin/pax: ar_subs.c options.c Log message: make pax cope with a stripped down format list, e.g. when compiled with -DNOCPIO - ignore empty entries (millert@, halex@) - replace bsort with linear scan (guenther@) ok millert@ guenther@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/29 17:12:09 Modified files: usr.sbin/fw_update: fw_update.1 fw_update.sh Log message: add a -d flag to remove the specified firmware packages ok espie@
Re: CVS: cvs.openbsd.org: src
On 01/28/14 22:34, Alexander Hall wrote: CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/28 14:34:44 Modified files: distrib/miniroot: install.sub Log message: trim sane_sets() Eh, or rather, sane_install(). /Alexander ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/28 14:34:44 Modified files: distrib/miniroot: install.sub Log message: trim sane_sets() ok krw@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/23 18:12:10 Modified files: distrib/miniroot: install.sub Log message: don't ever use an unsigned SHA256 ok rpe@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/18 15:28:18 Modified files: usr.sbin/pkg_add: package.5 Log message: use the standard notation of XX.tgz for the install sets from frantisek holop, thanks! "Go ahead" espie@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/16 18:15:27 Modified files: distrib/miniroot: install.sub Log message: add signature checking and make checksum procedure more robust by prefetching sets to a temporary directory within /home, iff it is a separate mount point with rpe@ and deraadt@, "ffiinaayyy OK" rpe@ (r.i.p. progress bars)
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2014/01/11 16:28:03 Modified files: distrib/miniroot: install.sub Log message: when selecting sets to install, postpone the xbase/comp check so the comp set does not get readded if the xbase set is being removed later on the same input line "nice semantics" deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/23 17:18:46 Modified files: sys/msdosfs: msdosfs_denode.c Log message: fix error checking oddity in msdosfs code, as noted by kettenis@ ok mikeb@ espie@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/18 01:11:25 Modified files: share/man/man8 : autoinstall.8 Log message: update sample install.conf; - use http for fetching sets - use password hashes - set up alternative user, with ssh pubkey - update question part to match installer changes
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/18 01:04:16 Modified files: distrib/miniroot: install.sh install.sub Log message: change password prompts (for the good of install.conf) add autoinstall question for root ssh pubkey make pubkey prompts appear in autoinstall log ideas from and ok deraaddt@, ok rpe@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/17 16:06:20 Modified files: share/man/man8 : autoinstall.8 Log message: mention mac address being in lowercase hex add dhcpd.conf(5) host entry example start a SEE ALSO section nice deraadt@, ok jmc@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/17 02:19:45 Modified files: etc: rc etc/rc.d : spamd Log message: Run spamd-setup from within /etc/rc.d/spamd, and take $spamd_black into consideration. Diff from Maurice Janssen, thanks! ok rpe@ giovanni@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/16 09:58:22 Modified files: distrib/miniroot: dot.profile install.sub Log message: Replace `[RESPONSEFILE=...] install auto` voodoo with plain'ol getopts, as discussed with uwe@ at some point. ok krw@, rpe@, "Cool" uwe@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: ha...@cvs.openbsd.org 2013/12/16 01:15:21 Modified files: distrib/miniroot: install.sub Log message: Change subject of install|upgrade log to match periodic maintenance email subjects better. ok deraadt@ rpe@ Suggested by, and "Lovely" deraadt@, "Sure" rpe@,
