CVS: cvs.openbsd.org: src

2024-04-24 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/04/24 15:31:31

Modified files:
usr.sbin/smtpd : smtpd.c 

Log message:
fix error return in fork_proc_backend(); ok gilles@



CVS: cvs.openbsd.org: www

2024-04-10 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2024/04/10 02:34:23

Modified files:
opensmtpd  : index.html 
Added files:
opensmtpd/announces: release-7.5.0p0.txt 

Log message:
release opensmtpd 7.5.0p0

ok gilles@



CVS: cvs.openbsd.org: src

2024-03-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/25 13:11:52

Modified files:
usr.bin/whois  : whois.c 

Log message:
remove possibly bogus length check

len is initially the line length, but then the two go out of sync.
ok millert@



CVS: cvs.openbsd.org: src

2024-03-20 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/20 11:52:43

Modified files:
usr.sbin/smtpd : smtp_session.c 

Log message:
fix ORCPT handling

due to a swapped strlcpy() arguments we don't save the ORCPT argument
after validation.  There's no buffer overflow since dsn_orcpt is zeroed.
Spotted by Tassilo Philipp, thanks!

ok millert gilles



CVS: cvs.openbsd.org: src

2024-03-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/18 02:50:54

Modified files:
lib/libc/gen   : login_cap.3 

Log message:
fix markup of _PATH_DEFPATH (Li -> Dv); ok jmc



CVS: cvs.openbsd.org: src

2024-03-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/18 02:48:50

Modified files:
usr.sbin/smtpd : smtpd.conf.5 

Log message:
improve the MDA documentation

- add a pointer to the section when documenting the `mda' keyword
- rename the section to MDA COMMANDS
- document also what happens when the MDA doesn't exit with status 0
- add the missing environment variables
- sort the variables
- minor other tweaks to the text

with several improvements from jmc, ok jmc



CVS: cvs.openbsd.org: src

2024-03-15 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/15 15:56:22

Modified files:
usr.sbin/smtpd : smtpd.conf.5 

Log message:
add some initial documentation regarding MDAs

this adds some initial commentary for how MDAs should behave and
in what environment they are executed.

diff from Philipp (philipp+openbsd [at] bureaucracy [dot] de) with
some tweaks from Richard Toohey and me.

ok gilles@



CVS: cvs.openbsd.org: src

2024-03-15 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/15 15:52:20

Modified files:
usr.sbin/smtpd : mda_unpriv.c 

Log message:
set ORIGINAL_RECIPIENT in the environment of mda scripts

mostly for compatibility with postfix since some mdas (like
public-inbox) make use of it.

diff from Philipp (philipp+openbsd [at] bureaucracy [dot] de)
ok gilles@



CVS: cvs.openbsd.org: www

2024-03-13 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2024/03/13 13:58:20

Modified files:
.  : 75.html 

Log message:
smtpd changes



CVS: cvs.openbsd.org: src

2024-03-02 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/03/02 15:40:28

Modified files:
usr.sbin/smtpd : smtpd.h 

Log message:
bump version to 7.5.0



CVS: cvs.openbsd.org: www

2024-02-11 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2024/02/11 02:33:38

Modified files:
.  : want.html 

Log message:
remove my request for a laptop, generously taken care of by Cage



CVS: cvs.openbsd.org: src

2024-02-11 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/02/11 02:24:26

Modified files:
usr.sbin/smtpd : makemap.c smtpd.h table_static.c util.c 

Log message:
unify smtpd and makemap table parser

These are supposed to parse the same file format but have subtle
difference in the handling of comments, continuation lines and escaping.

Converge both to the simpler smtpd parser which doesn't handle
continuation lines nor escaping, and support comments only at the start
of the line.

improvements and ok millert@



CVS: cvs.openbsd.org: src

2024-02-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/02/03 08:50:00

Modified files:
usr.sbin/smtpd : parse.y smtpd.c 

Log message:
leave the command for mbox delivery unset

The mbox delivery is handled apart from the other delivery methods.
Since the mda is already hardcoded in mda_mbox(), there's no need to
fill the command string in parse.y.  While here also assess that for
mbox deliveries the command is unset at delivery time too.

based on a diff by gilles

ok gilles@, millert@



CVS: cvs.openbsd.org: src

2024-02-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/02/03 08:41:02

Modified files:
usr.sbin/smtpd : smtpd.conf.5 

Log message:
document that when an alternate delivery user is provided in a
dispatcher, no .forward file except that of the alternate delivery user
is processed.

ok gilles@, millert@



CVS: cvs.openbsd.org: src

2024-01-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/01/28 10:23:17

Modified files:
usr.sbin/smtpd : smtp_session.c 

Log message:
allow escaping inside quotes

RFC5322 allows for escapes using \ inside quotes.  Otherwise, headers
such as

From: "\"Doe, John\"" 

get mangled as "\"Doe@localhost, John\"  since \ would be treated as
ordinary character and not the escape for the quote.

Bug reported by TobiasEgg on the OpenSMTPD-portable github repository.

ok millert@



CVS: cvs.openbsd.org: www

2024-01-11 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2024/01/11 10:12:58

Modified files:
.  : want.html 

Log message:
add a request for a laptop



CVS: cvs.openbsd.org: src

2024-01-04 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/01/04 02:34:03

Modified files:
usr.sbin/smtpd : table.c 

Log message:
fix IPv6 addresses table lookups

Rework parse_sockaddr() to not reach inet_pton() with a brace-wrapped
IPv6 address.

Issue reported by Kirill Miazine.
ok millert@



CVS: cvs.openbsd.org: src

2024-01-04 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/01/04 02:30:09

Modified files:
usr.sbin/smtpd : config.c 

Log message:
set_localaddrs(): don't wrap IPv6s address with braces twice

ss_to_text() already wraps ipv6 addresses in braces, so no need to do it
again and no need to do that for IPv4 addresses too.

ok millert@



CVS: cvs.openbsd.org: src

2024-01-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2024/01/03 01:11:15

Modified files:
usr.sbin/smtpd : envelope.c mta.c mta_session.c smtp_session.c 
 smtpd.h util.c 

Log message:
relax ORCPT syntax validation

We expected the ORCPT parameter to be a valid rfc822 address.  This is
wrong on multiple levels:

- any other IANA-registered "addr-type" can be used
- the parameter may be encoded and we didn't decode it prior validation
- RFC3461 explicitly states that "[..] the address associated with the
ORCPT keyword is NOT constrained to conform to the syntax rules for
that 'addr-type'".

Instead, just validate the xtext and preserve the ORCPT value as-is.

Issue originally reported by Tim Kuijsten, Tassilo Philipp and others.

ok millert@



CVS: cvs.openbsd.org: src

2023-12-27 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/27 04:29:56

Modified files:
usr.sbin/smtpd : table.5 

Log message:
sync table(5) with reality

There are two different parser for table(5)s with different edge cases.
Adjust the documentation to what the strictier of the two (smtpd
internal parser) accepts, even if makemap(8) allows for more.

In particular, adjust the description for the comments (that cannot be
'anywhere in the file'), document the special comment @list and mention
that splitting is done on the colon character too.

ok and many improvements from jmc@



CVS: cvs.openbsd.org: src

2023-12-23 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/23 03:29:05

Modified files:
usr.sbin/smtpd : smtp_session.c 

Log message:
remove trailing whitespaces



CVS: cvs.openbsd.org: src

2023-12-05 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/05 06:38:25

Modified files:
usr.sbin/smtpd : rfc5322.c 

Log message:
reject headers that start with a space or tab

If the first header starts with a space but still contains a colon
character, it is added to the body mail effectively appending it to the
Received header due to the folding rules.

Issue reported by Crystal Kolipe

ok millert@, giovanni@



CVS: cvs.openbsd.org: src

2023-12-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/03 04:52:16

Modified files:
usr.sbin/smtpd : parse.y smtpd.conf.5 

Log message:
add the `no-dsn' option to `listen on socket' too

ok millert@



CVS: cvs.openbsd.org: src

2023-12-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/03 04:50:50

Modified files:
usr.sbin/smtpd : parse.y 

Log message:
set the socket family too to mirror the LISTEN case; no-op in practice
since AF_UNSPEC is zero.



CVS: cvs.openbsd.org: src

2023-12-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/03 04:48:52

Modified files:
usr.sbin/smtpd : parse.y 

Log message:
enable DSN (Delivery Status Notification) for the implicit socket too

DSN is implicitly enabled when using `listen on sock' but it's not for
the implicit socket, avoid this incoherence by enabling it on the
implicit socket too.

Report and diff by Tassilo Philipp (tphilipp at potion-studios dot com)
ok millert@



CVS: cvs.openbsd.org: src

2023-12-01 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/01 02:25:49

Modified files:
usr.sbin/smtpd : parse.y 

Log message:
allow tables and filter over multiple lines

This augments the grammar for tables and filter listing so that a
newline is allowed after a comma.  i.e. these now works as expected:

table foo {
"one",
"two"
}

listen on socket filter {
"foo",
"bar"
}

based on a diff from tim@
ok millert@, tim@



CVS: cvs.openbsd.org: src

2023-11-22 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/11/22 11:23:09

Modified files:
lib/libtls : tls_verify.c 

Log message:
typo: mutiple -> multiple

from Ryan Kavanagh (rak [at] debian [dot] org), ok tb@



CVS: cvs.openbsd.org: src

2023-11-16 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/11/16 03:23:21

Modified files:
usr.sbin/smtpd : dns.c 

Log message:
consider an MX of "localhost" as it were a "Null MX"

diff from Philipp (philipp+openbsd [at] bureaucracy [dot] de), thanks!

ok sthen@



CVS: cvs.openbsd.org: www

2023-11-16 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/11/16 03:06:22

Modified files:
opensmtpd  : index.html 

Log message:
release opensmtpd 7.4.0p1



CVS: cvs.openbsd.org: src

2023-11-13 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/11/13 03:11:41

Modified files:
share/man/man5 : bsd.regress.mk.5 

Log message:
adjust `regress' description since REGRESS_FAIL_EARLY is yes now

ok plus various improvements to the text by tb@



CVS: cvs.openbsd.org: src

2023-11-08 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/11/08 01:46:35

Modified files:
usr.sbin/smtpd : dns.c mta.c smtpd.h 

Log message:
RFC 7505 ("Null MX") handling

mail delivery will not be attempted if a domain advertises a single MX
record with preference 0 and a zero-length label.

based on an initial diff from Philipp (philipp+openbsd [at] bureaucracy
[dot] de), thanks!

ok jung@



CVS: cvs.openbsd.org: src

2023-11-05 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/11/05 01:39:16

Modified files:
gnu/usr.bin/texinfo/makeinfo: makeinfo.c 

Log message:
fix bad path allocation in makeinfo

In one branch of the image handling, the wrong malloc() call was
copied-pasted making the allocation possibly smaller than needed.
Spotted while building the gcc11 port, libgccjit.info exercise that
branch and the write out of bounds was discovered by malloc().

Convert the malloc + strlcpy/cat dance to an asprintf, and while here
also fix the leak of the two paths.

ok tb@



CVS: cvs.openbsd.org: www

2023-10-25 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/25 01:44:12

Modified files:
opensmtpd/announces: release-7.4.0p0.txt 

Log message:
oops, it should be OpenSSL >= 1.1; spotted by tb@, thanks!



CVS: cvs.openbsd.org: www

2023-10-25 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/25 01:30:21

Modified files:
opensmtpd  : index.html 
Added files:
opensmtpd/announces: release-7.4.0p0.txt 

Log message:
release opensmtpd 7.4.0p0



CVS: cvs.openbsd.org: src

2023-10-24 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/10/24 04:26:02

Modified files:
usr.bin/mg : main.c 

Log message:
call vttidy() in the exit path for the batch mode

Diff by Mark Willson (mark [at] hydrus.org.uk), thank you!



CVS: cvs.openbsd.org: www

2023-10-21 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/21 02:56:00

Modified files:
faq: current.html 

Log message:
typo: ususal -> usual



CVS: cvs.openbsd.org: src

2023-10-16 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/10/16 02:33:16

Modified files:
usr.bin/mg : mg.1 

Log message:
reinstate space-to-tabstop entry in the manpage

removed in rev 1.95 since was hidden behind NOTAB, and forgot to be
re-added when no-tab-mode was resurrected.



CVS: cvs.openbsd.org: www

2023-10-15 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/15 08:07:39

Modified files:
.  : 74.html 

Log message:
link mg no-tab-mode and set-default-mode commands



CVS: cvs.openbsd.org: www

2023-10-13 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/13 00:41:06

Modified files:
.  : 74.html 

Log message:
add smtpd entries



CVS: cvs.openbsd.org: www

2023-10-04 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/10/04 09:06:06

Modified files:
.  : plus74.html 

Log message:
clarify smtpd link-auth change and split into two (swap arguments
and bump protocol version).

suggestion and 'go for it' pamela@, thanks!



CVS: cvs.openbsd.org: src

2023-09-29 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/09/29 12:30:15

Modified files:
usr.sbin/smtpd : smtpd.h 

Log message:
bump version to 7.4.0



CVS: cvs.openbsd.org: src

2023-09-24 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/09/24 03:15:43

Modified files:
share/man/man5 : bsd.port.mk.5 

Log message:
bsd.port.mk.5: GC the misp64 *pic.a fragment handling documentation

More than ten years ago, bsd.lib.mk stopped creating lib*_pic.a files
and the corresponding PFRAG.no_mips64 were removed from the ports tree.
Last year the -Dno_mips64 handling in bsd.port.mk was GC'd too, but the
note in the bsd.port.mk manpage was left.

ok espie@



CVS: cvs.openbsd.org: www

2023-09-20 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/09/20 08:00:35

Modified files:
opensmtpd  : index.html 

Log message:
release opensmtpd-7.3.0p2



Re: CVS: cvs.openbsd.org: src

2023-09-16 Thread Omar Polo
On 2023/09/16 01:59:44 -0600, Omar Polo  wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   o...@cvs.openbsd.org2023/09/16 01:59:44
> 
> Modified files:
>   share/man/man5 : bsd.port.mk.5 
> 
> Log message:
> document CHECK_LIB_DEPENDS_ARGS

sigh, and this improved and okay'd espie@ too.  sorry...



CVS: cvs.openbsd.org: src

2023-09-16 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/09/16 02:01:31

Modified files:
share/man/man5 : bsd.port.mk.5 

Log message:
remove empty line in PORTHOME description



CVS: cvs.openbsd.org: src

2023-09-16 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/09/16 01:59:44

Modified files:
share/man/man5 : bsd.port.mk.5 

Log message:
document CHECK_LIB_DEPENDS_ARGS



CVS: cvs.openbsd.org: src

2023-08-29 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/08/29 08:44:53

Modified files:
usr.sbin/acme-client: acctproc.c key.c 

Log message:
acme-client: drop ecdsa.h, fix spacing and a typo in error message

While here drop EC_KEY_set_asn1_flag(OPENSSL_EC_NAMED_CURVE).
EC_KEY_new_by_curve_name() ends up calling EC_GROUP_new() which already
sets the OPENSSL_EC_NAMED_CURVE flag on the group.  (suggested by tb@)

ok tb@



CVS: cvs.openbsd.org: src

2023-08-17 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/08/17 01:25:57

Modified files:
usr.sbin/httpd : httpd.conf.5 

Log message:
use "example.com" instead of "default" as server name in the various
examples: it matches the sample config and avoids tricking the user into
thinking that "default" as server name has a special meaning.

While here, document also that http uses the first server matching the
listening port when there's no match on the server name.
(was corrected on this by Crystal Kolipe, thanks)

ok kn on a previous version, improvements from sthen and jmc, ok sthen



CVS: cvs.openbsd.org: src

2023-07-11 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/07/11 10:40:23

Modified files:
usr.sbin/smtpd : ca.c 

Log message:
drop engine support

diff originally by tb@, tweaked to apply after the useless logging
methods removal.

ok tb



CVS: cvs.openbsd.org: src

2023-07-11 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/07/11 10:39:41

Modified files:
usr.sbin/smtpd : ca.c 

Log message:
remove the useless logging methods

Instead of wrapping all the methods of the RSA and ECDSA ENGINE,
duplicate the default and override only the ones that are actually
needed for the privsep crypto engine.

part of a larger diff that's ok tb@



CVS: cvs.openbsd.org: src

2023-07-07 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/07/07 08:52:00

Modified files:
usr.sbin/smtpd : lka_filter.c smtpd-filters.7 

Log message:
swap link-auth filter arguments

Fields which can contain a '|' character are kept last to avoid
ambiguities so move result before username; link-auth was likely forgot
in r1.61 of lka_filter.c when the same treatment was applied to other
events.

Discovered after a report on -portable due to filter-rspamd crashing.

ok millert@



CVS: cvs.openbsd.org: www

2023-06-30 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/06/30 10:59:04

Modified files:
opensmtpd  : index.html 

Log message:
release opensmtpd-7.3.0p1



CVS: cvs.openbsd.org: src

2023-06-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/28 11:36:51

Modified files:
usr.bin/ftp: Makefile 

Log message:
revert makefile change included by mistake in previous



CVS: cvs.openbsd.org: src

2023-06-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/28 11:36:09

Modified files:
usr.sbin/rpki-client: http.c 

Log message:
drop needless strcspn in the header parsing

like done in ftp' fetch.c revision 1.216.

ok tb



CVS: cvs.openbsd.org: src

2023-06-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/28 11:35:06

Modified files:
usr.bin/ftp: Makefile fetch.c 

Log message:
drop needless strcspn in the header parsing

since fetch.c revision 1.211, ftp removes trailingwhitespaces early so
there's no need to re-do that when parsing a header.

while here, remove an unused variable too.

ok tb, millert



CVS: cvs.openbsd.org: src

2023-06-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/28 05:07:29

Modified files:
usr.bin/ftp: fetch.c 

Log message:
fix parsing of the Last-Modified header

Was overlooked in r1.209.

diff from 'a dog' (OpenBSD [at] anthropomorphic [dot] dog)
ok tb, sthen



CVS: cvs.openbsd.org: src

2023-06-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/28 02:37:52

Modified files:
usr.bin/mg : mg.1 

Log message:
add `notab' to the list of modes that can be set with set-default-mode

specify also that it can be set globally with set-default-mode, as done
in the description of the other built-in modes.

Diff from Simon Branch (that I got via jmc@), thanks!



CVS: cvs.openbsd.org: src

2023-06-26 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/26 01:10:17

Modified files:
bin/pax: pat_rep.c 

Log message:
fix grammar of the comment describing pat_chk(); ok millert@



CVS: cvs.openbsd.org: src

2023-06-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/25 02:08:03

Modified files:
sbin/iked  : ca.c iked.c iked.h 

Log message:
remove ca_sslinit()

it's a noop; nowadays both LibreSSL and OpenSSL libcrypto and libssl
initialize themselves automatically before doing anything.

spotted by tb, ok tb tobhe

Modified files:
usr.sbin/relayd: config.c relayd.c relayd.h ssl.c 

Log message:
remove ssl_init()

it's a noop; nowadays both LibreSSL and OpenSSL libcrypto and libssl
initialize themselves automatically before doing anything.

ok tb

Modified files:
usr.sbin/smtpd : ssl.c ssl.h 

Log message:
remove ssl_init()

it's a noop; nowadays both LibreSSL and OpenSSL libcrypto and libssl
initialize themselves automatically before doing anything.

noticed by jsing, ok tb



CVS: cvs.openbsd.org: src

2023-06-23 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/23 12:32:28

Modified files:
usr.sbin/smtpd : smtp_session.c 

Log message:
smtpd: allow arguments on NOOP

per RFC3521 § 4.1.1.9 the NOOP command allows optionally one argument
that SHOULD be ignored.  For semplicity, relax it to allow anything after it.

Original diff by Sebastian J. Bronner, GitHub PR 1150, tweaked by me to
add smtp_check_noop().

Gilles agrees, ok millert@



CVS: cvs.openbsd.org: src

2023-06-21 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/21 11:59:24

Modified files:
usr.sbin/smtpd : lka_filter.c 

Log message:
clear errno before strtoull as it may already be set to ERANGE

noticed and ok millert@



CVS: cvs.openbsd.org: src

2023-06-21 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/21 11:56:26

Modified files:
usr.sbin/smtpd : lka_filter.c 

Log message:
avoid truncation of filtered data lines

Don't copy in a buffer the filter' output for parsing as we may truncate
filter-dataline (i.e. the mail body).  Instead, parse the string by
advancing the pointer without copying or modifications.

Issue reported by Joachim Schneider on the OpenSMTPD-portable
repository.

ok millert@



CVS: cvs.openbsd.org: src

2023-06-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/18 13:08:52

Modified files:
usr.sbin/smtpd : ca.c 

Log message:
remove ca_verify_cb().  was initially used for debugging, then the
logging went away but the no-op callback remained.

noticed by tb@



CVS: cvs.openbsd.org: src

2023-06-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/18 11:28:42

Modified files:
usr.sbin/smtpd : smtpd.c 

Log message:
sync imsg_to_str() with the list of imsg types in smtpd.h

ok millert@



CVS: cvs.openbsd.org: src

2023-06-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/18 05:45:11

Modified files:
usr.sbin/vmd   : vmd.c 

Log message:
relax absolute path requirement for configtest (-n)

ok dv@



CVS: cvs.openbsd.org: src

2023-06-18 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/18 05:43:49

Modified files:
lib/libtls : tls.c tls_internal.h tls_signer.c 

Log message:
libtls: switch ECDSA_METHOD usage to EC_KEY_METHOD

smtpd and the bits it needs in libtls are the only consumer left of
ECDSA_METHOD, which is long deprecated.  This paves the way for the
removal in libcrypto.

The diff is from gilles' work on OpenSMTPD-portable, libretls had a
similar diff.

ok tb@, jsing@

Modified files:
usr.sbin/smtpd : ca.c 

Log message:
smtpd: switch ECDSA_METHOD usage to EC_KEY_METHOD

smtpd and the bits it needs in libtls are the only consumer left of
ECDSA_METHOD, which is long deprecated.  This paves the way for the
removal in libcrypto.

The diff is from gilles' work on OpenSMTPD-portable, with minor changes
by me.

ok tb@, jsing@



CVS: cvs.openbsd.org: src

2023-06-17 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/17 02:32:48

Modified files:
usr.sbin/smtpd : smtpd.h 

Log message:
bump version to 7.3.0



CVS: cvs.openbsd.org: www

2023-06-17 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/06/17 01:46:39

Modified files:
opensmtpd  : index.html 

Log message:
readd links to the tarball and signature mistakenly removed in previous

spotted by Gilles, thanks!



CVS: cvs.openbsd.org: www

2023-06-17 Thread Omar Polo
CVSROOT:/cvs
Module name:www
Changes by: o...@cvs.openbsd.org2023/06/17 01:28:33

Modified files:
opensmtpd  : index.html 
Added files:
opensmtpd/announces: release-7.3.0p0.txt 

Log message:
release opensmtpd 7.3.0p0



CVS: cvs.openbsd.org: src

2023-06-11 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/11 04:30:26

Modified files:
usr.sbin/smtpd : ssl.c 
usr.sbin/relayd: ca.c 

Log message:
fix typo: 'hash buffer to small' -> too small



CVS: cvs.openbsd.org: src

2023-06-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/10 01:24:22

Modified files:
bin/ksh: c_test.c ksh.1 

Log message:
ksh: remove broken special handling of test -t

Drop the vestiges of the pre-POSIX support of `test -t' defaulting to fd
1.  It doesn't work and it always succeed since "-t" is treated as a
string by default when no argument (fd) is specified.

diff by Lucas (lucas [at] sexy [dot] is) with minor change by me.
ok millert@



CVS: cvs.openbsd.org: src

2023-06-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/10 01:19:39

Modified files:
bin/test   : test.1 

Log message:
test: fix description of -t: it has no default

-t always requires the fd number as argument, there's no default.  With
only one argument -t is equivalent to `test -n -t' and so banally always
true.

diff from Lucas (lucas [at] sexy [dot] is)
ok millert@



CVS: cvs.openbsd.org: src

2023-06-05 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/05 02:07:18

Modified files:
libexec/mail.local: mail.local.c 

Log message:
use getline(3) instead of fgetln(3)

while here simplify the "From " check too.
ok millert@



CVS: cvs.openbsd.org: src

2023-06-03 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/06/03 09:19:38

Modified files:
games/hack : hack.bones.c hack.h hack.main.c hack.unix.c 

Log message:
drop `uptodate()' check from hack(6)

hack(6) scrapes $PATH to find its executable and compare the mtime to
the save file and bone file.  If the game is newer than those, they're
not loaded.

Drop this feature.  /usr/games is not in the default $PATH anymore, and
the format for those file didn't change since the import.

Diff from Anton Konyahin (me [at] konyahin [dot] xyz)



CVS: cvs.openbsd.org: src

2023-05-31 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/31 10:51:47

Modified files:
usr.sbin/smtpd : bounce.c control.c enqueue.c mda.c mta.c 
 mta_session.c queue.c queue_backend.c 
 queue_fs.c runq.c scheduler_ramqueue.c 
 smtp_session.c smtpctl.c smtpd.c smtpd.h to.c 

Log message:
add missing include of time.h

spotted after a report on OpenSMTPD-portable.  While here include
sys/time.h in smtpd.h, as noted in event_init(3), since it includes
event.h.

ok millert@



CVS: cvs.openbsd.org: src

2023-05-30 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/30 10:44:16

Modified files:
usr.bin/id : id.c 

Log message:
fail when an argument is given on 'id -R'

from Lucas (lucas [at] sexy [dot] is).
ok millert@



CVS: cvs.openbsd.org: src

2023-05-30 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/30 01:37:34

Modified files:
lib/libcrypto/man: X509_STORE_CTX_set_verify_cb.3 

Log message:
fix some nits on previous

- move a sentence out of a Bd block
- add some .Pp for spacing
- avoid a double colon on a sentence and the usage of second person
- mark STORE_CTX with .Vt
- change one Vt -> Dv (done after this has been ok'd by beck)

ok beck@



CVS: cvs.openbsd.org: src

2023-05-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/25 05:37:58

Modified files:
usr.sbin/smtpd : smtpd.h 

Log message:
remove two unused defines

last PROC_COUNT use was removed with the switch to fork+exec by eric@ in
2016, CA_FILE with the removal of cert.c two years ago.

ok tb@, kn@



CVS: cvs.openbsd.org: src

2023-05-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/25 01:46:21

Modified files:
lib/libtls : tls.c 

Log message:
Forcibly update the EVP_PKEY's internal key

To aid privilege separation, libtls maintains application-specific data
on the key inside the EVP_PKEY abstraction because the EVP API doesn't
provide a way to do that on the EVP_PKEY itself.

OpenSSL 3 changed behavior of EVP_PKEY_get1_RSA() and related functions.
These now return a struct from some cache.  Thus, modifying the RSA will
no longer modify the EVP_PKEY like it did previously, which was clearly
implied to be the case in the older documentation.
This is a subtle breaking change that affects several applications.

While this is documented, no real solution is provided.  The transition
plan from one OpenSSL major version to the next one tends to involve
many #ifdef in the ecosystem, and the only suggestion provided by the
new documentation is to switch to a completely unrelated, new API.

Instead, forcibly reset the internal key on EVP_PKEY after modification,
this way the change is picked up also by OpenSSL 3.

Fixes issue 1171 in OpenSMTPD-portable

ok tb@, jsing@



CVS: cvs.openbsd.org: src

2023-05-24 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/24 09:48:11

Modified files:
share/man/man8 : sticky.8 

Log message:
mark S_ISVTX with Dv in sticky(8); makes `man -k any=S_ISVTX' more useful

ok millert@



CVS: cvs.openbsd.org: src

2023-05-19 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/19 09:18:06

Modified files:
usr.sbin/smtpd : smtpd.conf.5 

Log message:
fix markup for `maildir' in smtpd.conf(5)

pathname and junk are both optional, but indipendently so.

ok aisha, millert



CVS: cvs.openbsd.org: src

2023-05-16 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/16 11:48:52

Modified files:
usr.sbin/smtpd : mta.c smtp.c smtpc.c 

Log message:
some fatal -> fatalx to improved logging

errno doesn't generally contains anything useful after libtls functions,
and in most cases it's explicitly cleared to avoid misuse, so change a
few fatal() calls to fatalx() when logging libtls failures.  Also, add
the real error string, via tls_error() or tls_config_error(), that was
missing before.

ok millert@



CVS: cvs.openbsd.org: src

2023-05-15 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/15 06:03:04

Modified files:
libexec/mail.local: mail.local.c 

Log message:
cast to '(long long)' instead of '(long long int)'

requested by deraadt@, ok tb@

Modified files:
usr.sbin/smtpd : bounce.c lka_filter.c mail.maildir.c 
 mta_session.c smtpctl.c 

Log message:
cast to '(long long)' instead of '(long long int)'

while here adjust the spacing in some of the touched lines.
requested by deraadt@, ok tb@



CVS: cvs.openbsd.org: src

2023-05-14 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/14 01:26:25

Modified files:
lib/libtls : tls.c tls_bio_cb.c tls_client.c tls_config.c 
 tls_conninfo.c tls_ocsp.c tls_server.c 
 tls_util.c 

Log message:
add missing #include ; ok tb@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 07:48:54

Modified files:
lib/libtls : tls_verify.c 

Log message:
switch two ASN1_STRING_data() to ASN1_STRING_get0_data()

and while here mark as const data.

This diff is actually from gilles@, in OpenSMTPD-portable bundled
libtls.

ok tb@, jsing@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 02:03:49

Modified files:
libexec/mail.local: mail.local.c 

Log message:
cast off_t to long long int for printing

reduces the diff with opensmtpd-portable.
ok tb@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 02:02:10

Modified files:
usr.sbin/smtpd : to.c 

Log message:
constify day, month and tz

spotted while diffing with -portable, where tz is marked as const.
ok tb@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 01:20:20

Modified files:
usr.sbin/smtpd : lka_filter.c 

Log message:
cast time_t to long long for printf, reduces the diff with -portable

ok millert@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 01:19:50

Modified files:
usr.sbin/smtpd : mail.maildir.c parse.y 

Log message:
add a few missing headers, reduces the diff with -portable

ok millert@



CVS: cvs.openbsd.org: src

2023-05-10 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/05/10 01:19:08

Modified files:
usr.sbin/smtpd : mda.c 

Log message:
remove trailing whitespace



CVS: cvs.openbsd.org: src

2023-04-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/28 04:02:03

Modified files:
usr.bin/mg : mg.1 util.c 

Log message:
fix lfindent (newline-and-indent) comment and description in the man page

for a while it has used only spaces when no-tab-mode is enabled and respected
the current buffer tab width.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/28 03:50:50

Modified files:
usr.bin/mg : mg.1 

Log message:
mark up all commands in the man page



CVS: cvs.openbsd.org: src

2023-04-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/25 07:36:01

Modified files:
usr.sbin/snmpd : snmpd.conf.5 

Log message:
tiny markup fix: add missing Ic before `group' in the `agentx' rule

OK martijn@



CVS: cvs.openbsd.org: src

2023-04-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/25 07:32:20

Modified files:
usr.bin/mg : mg.1 

Log message:
mark up `mode' in -f description



CVS: cvs.openbsd.org: src

2023-04-25 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/25 02:37:24

Modified files:
usr.bin/mg : mg.1 

Log message:
document that prefix-region with a prefix argument prompts for the string



CVS: cvs.openbsd.org: src

2023-04-21 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/21 08:14:13

Modified files:
usr.bin/mg : util.c 

Log message:
mg: fix space_to_tabstop

Since the import of mg in the tree, space_to_tabstop used curbp->w_doto
(the byte offset in the current line) as mean to deduce the current
column for indentation.  This is wrong because it doesn't account for
tab, control characters and octets > 127 (which are all rendered with
more than one column.)  Use instead getcolpos().

ok tb@



CVS: cvs.openbsd.org: src

2023-04-21 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/21 07:39:37

Modified files:
usr.bin/mg : basic.c buffer.c cmode.c def.h display.c 
 funmap.c match.c mg.1 paragraph.c util.c 

Log message:
mg: allow to change the tab width

This makes the tab width customizable per-buffer.  The new function
`set-tab-width' changes it for the current buffer or the default value
for new buffers if called with a prefix argument (or from the startup
file.)

The default tab width is still 8 column.

Together with the newly resurrected no-tab-mode, allows to use mg for a
variety of programming languages and coding styles.

Note that it's not possible to call set-tab-width with auto-execute in
the startup file due to limitations in how auto-execute and the parser
work.

ok tb@



CVS: cvs.openbsd.org: src

2023-04-17 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/17 09:18:25

Modified files:
usr.bin/mg : match.c 

Log message:
fix buffer overflow in displaymatch(); ok/tweak tb@



CVS: cvs.openbsd.org: src

2023-04-17 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/17 04:11:30

Modified files:
usr.bin/mg : extend.c interpreter.c 

Log message:
fix a few dobeep_msgs() calls: a space is already added between the arguments

ok tb@



CVS: cvs.openbsd.org: src

2023-04-17 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/17 03:53:08

Modified files:
usr.bin/mg : util.c 

Log message:
add doindent() prototype at the start of the file; forgotten in previous



  1   2   >