Re: CVS commit: src/sys/uvm

2009-08-10 Thread Bill Stouder-Studenmund
On Sat, Apr 18, 2009 at 01:46:43PM +0200, Christoph Egger wrote: > Christos Zoulas wrote: > This would imply to change the flags arguments of the pmap API > from int to u_int to avoid troubles with checking flag bits. > > Alternatively, code like this > > if (flags & FLAG1) > do_somet

Re: CVS commit: src/sys/uvm

2009-08-10 Thread Tonnerre LOMBARD
Salut, On Mon, Aug 10, 2009 at 11:30:38AM +, Mihai Chelaru wrote: > On Sun, 09 Aug 2009 22:19:10 +, Matt Thomas wrote: > > @@ -708,7 +742,7 @@ > > l = outl2; > > #ifdef DEBUG > >if (swapdebug & SDB_SWAPOUT) > > - printf("%s: no duds, try procp %p\n", __func__, l)

Re: CVS commit: src/sys/sys

2009-08-10 Thread Christos Zoulas
On Aug 10, 7:03pm, t...@netbsd.org (Matthias Scheler) wrote: -- Subject: Re: CVS commit: src/sys/sys | On Mon, Aug 10, 2009 at 12:59:57PM -0400, Christos Zoulas wrote: | > | That should allows us to keep the old-casts and avoid warnings. | > | > This cannot possibly work because the syntax parsi

Re: CVS commit: src/sys/sys

2009-08-10 Thread Matthias Scheler
On Mon, Aug 10, 2009 at 12:59:57PM -0400, Christos Zoulas wrote: > | That should allows us to keep the old-casts and avoid warnings. > > This cannot possibly work because the syntax parsing happens after the macro > is expanded and the macro is expanded in c++ code. Why would that matter? G++ sho

Re: CVS commit: src/sys/sys

2009-08-10 Thread Christos Zoulas
On Aug 10, 5:27pm, t...@netbsd.org (Matthias Scheler) wrote: -- Subject: Re: CVS commit: src/sys/sys | On Sun, Aug 09, 2009 at 09:20:02PM +, Christos Zoulas wrote: | > In article <20090809210918.gc22...@drowsy.duskware.de>, | > Martin Husemann wrote: | > >On Sun, Aug 09, 2009 at 09:29:50PM

re: CVS commit: src/sys/uvm

2009-08-10 Thread matthew green
Module Name: src Committed By:matt Date:Mon Aug 10 16:50:18 UTC 2009 Modified Files: src/sys/uvm: uvm_glue.c Log Message: Revent change to printf. (why can't __func__ concat with other string?) beacuse __func__ is defined to be as if you

Re: CVS commit: src/sys/sys

2009-08-10 Thread Matthias Scheler
On Sun, Aug 09, 2009 at 11:23:53PM +0200, Tonnerre LOMBARD wrote: > There may be valid reasons not to want to have them. Yes, in C++ sources and header files. System header files are C headers, not C++ headers. Kind regards P.S. The fundamental problem is of course that C++ tries to be

Re: CVS commit: src/sys/sys

2009-08-10 Thread Matthias Scheler
On Sun, Aug 09, 2009 at 09:20:02PM +, Christos Zoulas wrote: > In article <20090809210918.gc22...@drowsy.duskware.de>, > Martin Husemann wrote: > >On Sun, Aug 09, 2009 at 09:29:50PM +0200, Tonnerre LOMBARD wrote: > >> Unfortunately, these are widely used headers. We don't want to break > >> -

Re: CVS commit: src/sys

2009-08-10 Thread David Holland
On Mon, Aug 10, 2009 at 03:44:38PM +, David Holland wrote: > On Sun, Aug 09, 2009 at 10:49:01PM +, Adam Hamsik wrote: > > Log Message: > > Add enum uio_seg argument to do_sys_mknod and do_sys_mkdir so these > > functions can be called from kernel, too. > > This is the wrong approa

Re: CVS commit: src/sys

2009-08-10 Thread David Holland
On Sun, Aug 09, 2009 at 10:49:01PM +, Adam Hamsik wrote: > Log Message: > Add enum uio_seg argument to do_sys_mknod and do_sys_mkdir so these > functions can be called from kernel, too. This is the wrong approach: in the user case, copyinstr should happen before getting to these functions.

Re: CVS commit: src/sys/uvm

2009-08-10 Thread Mihai Chelaru
On Sun, 09 Aug 2009 22:19:10 +, Matt Thomas wrote: > @@ -708,7 +742,7 @@ > l = outl2; > #ifdef DEBUG >if (swapdebug & SDB_SWAPOUT) > - printf("%s: no duds, try procp %p\n", __func__, l); > + printf(__func__ ": no duds, try procp %p\n", l); > #endif >

Re: CVS commit: src/sys/sys

2009-08-10 Thread David Laight
On Mon, Aug 10, 2009 at 12:24:47AM +0200, Martin Husemann wrote: > On Sun, Aug 09, 2009 at 09:20:02PM +, Christos Zoulas wrote: > > The new style casts are very useful because they show programming intent. So do C casts! provided what you are casting is an integer type or a pointer to a struct