Re: CVS commit: src/lib/libedit

2011-07-30 Thread Alan Barrett
On Fri, 29 Jul 2011, Christos Zoulas wrote: Log Message: add -Wunused-parameter Is that the right way? Perhaps WARNS=5? Or add -Wunused-parameter to WARNS=4. WARNS levels should be organised by the ease of avoiding or fixing the warnings; there's no need to add a new level for each warning.

Re: CVS commit: src/sys/kern

2011-07-30 Thread Mindaugas Rasiukevicius
Masao Uebayashi uebay...@netbsd.org wrote: Module Name: src Committed By: uebayasi Date: Sat Jul 30 05:24:17 UTC 2011 Modified Files: src/sys/kern: kern_softint.c Log Message: Use kmem(9) to allocate per-cpu softint context. No functional changes. Why? The allocation

Re: CVS commit: src/sys/kern

2011-07-30 Thread Masao Uebayashi
On Sat, Jul 30, 2011 at 9:54 PM, Mindaugas Rasiukevicius rm...@netbsd.org wrote: Masao Uebayashi uebay...@netbsd.org wrote: Module Name:  src Committed By: uebayasi Date:         Sat Jul 30 05:24:17 UTC 2011 Modified Files:       src/sys/kern: kern_softint.c Log Message: Use kmem(9) to

Re: CVS commit: src/sys

2011-07-30 Thread Matthias Scheler
On Sat, Jul 30, 2011 at 01:01:05PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Jul 30 17:01:05 UTC 2011 Modified Files: src/sys/conf: files src/sys/kern: init_main.c kern_lwp.c kern_synch.c Added Files: src/sys/kern:

Re: CVS commit: src/sys

2011-07-30 Thread Joerg Sonnenberger
On Sat, Jul 30, 2011 at 07:23:51PM +0200, Jean-Yves Migeon wrote: I remember reading articles mentioning how wonderful lockless algorithms are, except in situation where the additional bus locking/atomic ops involved did not really improve the situation in highly concurrent systems (and could

Re: CVS commit: src/sys

2011-07-30 Thread David Laight
On Sat, Jul 30, 2011 at 11:04:24PM +0200, Joerg Sonnenberger wrote: ... Note that for a uncontested resource, the overhead of a mutex for a single operation tends to be comparable, if store fences have a similar price than bus locked operation on an owned cache line. I remember being told

Re: CVS commit: src/sys/dev/usb

2011-07-30 Thread Jeff Rizzo
On 7/30/11 1:05 PM, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Sat Jul 30 20:05:36 UTC 2011 Modified Files: src/sys/dev/usb: ohci.c usbdi.c Log Message: PR# port-i386/18818: cannot enter ddb with usb keyboard - ohci: when polling, make sure

Re: CVS commit: src/lib/libedit

2011-07-30 Thread Christos Zoulas
In article 20110730064751.ga19...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: On Fri, 29 Jul 2011, Christos Zoulas wrote: Log Message: add -Wunused-parameter Is that the right way? Perhaps WARNS=5? Or add -Wunused-parameter to WARNS=4. WARNS levels should be organised by the

Re: CVS commit: src/lib/libedit

2011-07-30 Thread Christos Zoulas
In article 20110730205523.gb3...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: Just cast the parameter to void? Do you prefer this than __unused? christos

Re: CVS commit: src/lib/libedit

2011-07-30 Thread Valeriy E. Ushakov
On Sun, Jul 31, 2011 at 00:50:03 +, Christos Zoulas wrote: In article 20110730205523.gb3...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: Just cast the parameter to void? Do you prefer this than __unused? I too would prefer something in the body of the