Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Marc Balmer
Am 18.10.11 06:27, schrieb Jukka Ruohonen: On Tue, Oct 18, 2011 at 12:07:45AM +, Jared D. McNeill wrote: Module Name: src Committed By:jmcneill Date:Tue Oct 18 00:07:45 UTC 2011 Modified Files: src/sys/arch/x86/x86: vmt.c Log Message: don't allow module

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 08:43:46AM +0200, Marc Balmer wrote: Am 18.10.11 06:27, schrieb Jukka Ruohonen: On Tue, Oct 18, 2011 at 12:07:45AM +, Jared D. McNeill wrote: Module Name: src Committed By: jmcneill Date: Tue Oct 18 00:07:45 UTC 2011 Modified Files:

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread David Brownlee
On 18 October 2011 10:07, Jukka Ruohonen jruoho...@iki.fi wrote: On Tue, Oct 18, 2011 at 08:43:46AM +0200, Marc Balmer wrote: Am 18.10.11 06:27, schrieb Jukka Ruohonen: On Tue, Oct 18, 2011 at 12:07:45AM +, Jared D. McNeill wrote: Module Name:       src Committed By:      jmcneill

Re: CVS commit: src

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 09:50:25AM +, Thomas Klausner wrote: Module Name: src Committed By: wiz Date: Tue Oct 18 09:50:25 UTC 2011 Modified Files: src/distrib/sets/lists/man: mi src/share/man/man4: Makefile Added Files: src/share/man/man4: vmt.4 Log

Re: CVS commit: src

2011-10-18 Thread Thomas Klausner
On Tue, Oct 18, 2011 at 01:15:08PM +0300, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 09:50:25AM +, Thomas Klausner wrote: Module Name:src Committed By: wiz Date: Tue Oct 18 09:50:25 UTC 2011 Modified Files: src/distrib/sets/lists/man: mi

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jared McNeill
I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? On Tue, 18 Oct 2011, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 08:43:46AM +0200, Marc Balmer wrote: Am 18.10.11

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? That sounds right to me. As noted, generally I am not

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Iain Hibbert
On Tue, 18 Oct 2011, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? That

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 12:44:52PM +0100, Iain Hibbert wrote: The real benefit of the modular system is that you don't need to load hundreds of modules on the off chance that they will be used. A cron entry could be used to flush unused modules if the sysop cares about that, why do we need a

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Paul Goyette
On Tue, 18 Oct 2011, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? That sounds

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jared D. McNeill
Well I loaded vmt manually and it was auto unloaded on me a few minutes later, that's why I made this change in the first place. On 2011-10-18, at 7:57 AM, Paul Goyette wrote: On Tue, 18 Oct 2011, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 07:59:35AM -0400, Jared D. McNeill wrote: Well I loaded vmt manually and it was auto unloaded on me a few minutes later, that's why I made this change in the first place. On 2011-10-18, at 7:57 AM, Paul Goyette wrote: On Tue, 18 Oct 2011, Jukka Ruohonen wrote:

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jared D. McNeill
No wonder, in the thread if uvmexp.free uvmexp.freemin it skips the mod_autotime == 0 check. On 2011-10-18, at 8:06 AM, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 07:59:35AM -0400, Jared D. McNeill wrote: Well I loaded vmt manually and it was auto unloaded on me a few minutes later,

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Jared D. McNeill
Fixed. On 2011-10-18, at 8:06 AM, Jukka Ruohonen wrote: True. But like Jared, I've also seen magic unloading of some of my driver modules. I guess there is a bug somewhere. - Jukka.

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Warner Losh
On Oct 18, 2011, at 4:39 AM, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? If I manually load a dozen drivers at boot because I have a dozen

Re: CVS commit: src/share/man/man4/man4.x86

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 02:25:06PM +, Thomas Klausner wrote: Module Name: src Committed By: wiz Date: Tue Oct 18 14:25:06 UTC 2011 Modified Files: src/share/man/man4/man4.x86: vmt.4 Log Message: Fix xref; comment out cpu(4) reference, does not exist. We could write

Re: CVS commit: src/sys/fs/puffs

2011-10-18 Thread Jukka Ruohonen
On Tue, Oct 18, 2011 at 03:39:10PM +, Emmanuel Dreyfus wrote: Module Name: src Committed By: manu Date: Tue Oct 18 15:39:09 UTC 2011 Modified Files: src/sys/fs/puffs: puffs_msgif.c puffs_node.c puffs_vfsops.c puffs_vnops.c Log Message: Make sure pagedaemon

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Warner Losh
On Oct 18, 2011, at 9:28 AM, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 08:49:39AM -0600, Warner Losh wrote: On Oct 18, 2011, at 4:39 AM, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded

Re: CVS commit: src/sys/fs/puffs

2011-10-18 Thread Emmanuel Dreyfus
Jukka Ruohonen jruoho...@iki.fi wrote: +#ifdef DIAGNOSTIC + KASSERT(curlwp != uvm.pagedaemon_lwp); +#endif Why pollute code with redundant #ifdefs? Right, I missed the point that KASSERT contains #ifdef DIAGNOSTIC. I will fix that tomorrow morning. -- Emmanuel Dreyfus

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Marc Balmer
Am 18.10.11 12:39, schrieb Jared McNeill: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only autounloading the autoloaded ones? I'd say that is a safe way. I am for it. On Tue, 18 Oct 2011, Jukka

Re: CVS commit: src/sys/arch/x86/x86

2011-10-18 Thread Marc Balmer
Am 18.10.11 13:44, schrieb Iain Hibbert: On Tue, 18 Oct 2011, Jukka Ruohonen wrote: On Tue, Oct 18, 2011 at 06:39:49AM -0400, Jared McNeill wrote: I would argue that any manually loaded module shouldn't be autounloaded. What do you think about flagging modules as autoloaded and only