Re: CVS commit: src

2014-04-21 Thread Maxime Villard
Le 21/04/2014 01:46, Taylor R Campbell a écrit : From: Maxime Villard m...@netbsd.org Date: Wed, 16 Apr 2014 18:55:20 + An (un)privileged user can easily make the kernel dereference a NULL pointer. The kernel allows 'data' to be NULL; it's the fs's responsibility to

Re: CVS commit: src

2014-04-21 Thread Taylor R Campbell
Date: Mon, 21 Apr 2014 08:20:22 +0200 From: Maxime Villard m...@m00nbsd.net Le 21/04/2014 01:46, Taylor R Campbell a écrit : In most cases of the changes you made, there is already a test for the length of the data buffer. Is this not guaranteed to be zero if data is null?

Re: CVS commit: src

2014-04-21 Thread Maxime Villard
Le 21/04/2014 16:29, Taylor R Campbell a écrit : Date: Mon, 21 Apr 2014 08:20:22 +0200 From: Maxime Villard m...@m00nbsd.net Le 21/04/2014 01:46, Taylor R Campbell a écrit : In most cases of the changes you made, there is already a test for the length of the data buffer.

Re: CVS commit: src/sys/dev/pcmcia

2014-04-21 Thread Joerg Sonnenberger
On Mon, Apr 21, 2014 at 08:24:21PM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Mon Apr 21 20:24:21 UTC 2014 Modified Files: src/sys/dev/pcmcia: if_malo_pcmcia.c Log Message: Insert { ... } to keep gcc happy when DPRINTF() macro is empty. This

Re: CVS commit: src/sys/dev/pcmcia

2014-04-21 Thread Paul Goyette
Ah, OK. I will fix shortly. On Tue, 22 Apr 2014, Joerg Sonnenberger wrote: On Mon, Apr 21, 2014 at 08:24:21PM +, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Mon Apr 21 20:24:21 UTC 2014 Modified Files: src/sys/dev/pcmcia: if_malo_pcmcia.c