Le 21/09/2014 20:22, Christos Zoulas a écrit :
On Sep 21, 7:57pm, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/arch/xen/xen
| Did you test this change? Verily I'm not sure it's a proper bug, but I
| kept it in my list so that someone (bouyer@?) could
On Fri, 26 Sep 2014, Roy Marples wrote:
Log Message:
Remove \$ as a hidden marker as vis(3) wasn't setting it
and it clobbered VIS_SHELL | VIS_CSTYLE.
This is wrong. vis -l outputs \$, and with this change,
unvis won't correctly handle it.
unvis is not intended to reverse shell-style
On Saturday 27 Sep 2014 11:04:09 Alan Barrett wrote:
On Fri, 26 Sep 2014, Roy Marples wrote:
Log Message:
Remove \$ as a hidden marker as vis(3) wasn't setting it
and it clobbered VIS_SHELL | VIS_CSTYLE.
This is wrong. vis -l outputs \$, and with this change,
unvis won't correctly
On Sep 27, 3:44pm, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/dev/pci
| This fix is wrong.
|
| - memset(p, sizeof(struct twa_param_9k *), 10);
| + memset(p, 0, sizeof(*p));
|
| p is a [10] array, your memset only initializes the first pointer.
|
|
On Sep 27, 8:36am, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/arch/xen/xen
| One however returns an error without freeing:
|
| if (newstart != start) {
| printf(uvm_map didn't give us back our vm space\n);
| return EINVAL;
|
Module Name:src
Committed By: christos
Date: Sun Sep 21 17:11:07 UTC 2014
Modified Files:
src/sys/dev/pci: twa.c
Log Message:
fix memset size inconsistency
This fix is wrong.
- memset(p, sizeof(struct twa_param_9k *), 10);
+ memset(p, 0, sizeof(*p));
p
On Sat, Sep 27, 2014 at 11:51:59AM -0400, Christos Zoulas wrote:
On Sep 27, 8:36am, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/arch/xen/xen
| One however returns an error without freeing:
|
| if (newstart != start) {
| printf(uvm_map
On Sep 27, 10:15pm, bou...@antioche.eu.org (Manuel Bouyer) wrote:
-- Subject: Re: CVS commit: src/sys/arch/xen/xen
| if (newstart != start) {
| printf(uvm_map didn't give us back our vm space\n);
| + uvm_unmap1(map, newstart, newstart + size, 0);
| + if
