re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread matthew green
David A. Holland writes: Module Name: src Committed By: dholland Date: Thu Oct 30 06:13:50 UTC 2014 Modified Files: src/usr.bin/rsh: rsh.c Log Message: Drop setuid before execing rlogin. Failure to do so should be harmless, but is sloppy. as jnemeth reminded me, this

Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread John Nemeth
On Oct 30, 6:13am, David A. Holland wrote: } } Module Name: src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: } src/usr.bin/rsh: rsh.c } } Log Message: } Drop setuid before execing rlogin. Failure to do so should be } harmless, but is sloppy.

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Alan Barrett
On Thu, 30 Oct 2014, Masao Uebayashi wrote: What do you expect by doing: options FOO no options FOO options FOO I expect it to be equivalent to just one options FOO. The no options FOO in line 2 should cancel the options FOO in line 1, and then the options FOO in line 3 should put it

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Takahiro HAYASHI
On 10/30/14 10:36, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Thu Oct 30 01:36:13 UTC 2014 Modified Files: src/usr.bin/config: mkheaders.c Log Message: print more info about the overflow It panics on amd64 when negative value is specified like

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Thu, Oct 30, 2014 at 8:36 PM, Alan Barrett a...@netbsd.org wrote: On Thu, 30 Oct 2014, Masao Uebayashi wrote: What do you expect by doing: options FOO no options FOO options FOO I expect it to be equivalent to just one options FOO. The no options FOO in line 2 should cancel the

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Quentin Garnier
On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 8:36 PM, Alan Barrett a...@netbsd.org wrote: On Thu, 30 Oct 2014, Masao Uebayashi wrote: What do you expect by doing: options FOO no options FOO options FOO I expect it to be equivalent

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Christos Zoulas
In article 54522b88.7060...@gmail.com, Takahiro HAYASHI t.hash...@gmail.com wrote: On 10/30/14 10:36, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Thu Oct 30 01:36:13 UTC 2014 Modified Files: src/usr.bin/config: mkheaders.c Log Message:

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Antti Kantee
On Thu, Oct 30, 2014 at 11:14:50AM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com wrote: In article 20141030012621.0982...@cvs.netbsd.org, Masao Uebayashi source-changes-d@NetBSD.org wrote: Re: constructors/destructors: Using them

Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread David Holland
On Wed, Oct 29, 2014 at 11:54:41PM -0700, John Nemeth wrote: On Oct 30, 6:13am, David A. Holland wrote: } } Module Name: src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: }src/usr.bin/rsh: rsh.c } } Log

Re: CVS commit: src/usr.bin/rsh

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 04:40:57PM +, David Holland wrote: } } Module Name:src } Committed By: dholland } Date: Thu Oct 30 06:13:50 UTC 2014 } } Modified Files: } src/usr.bin/rsh: rsh.c } } Log Message: } Drop setuid before

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread David Holland
On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: So, while you expect that options works before it's defined, you also expect the order is honored for no use. I'm not sure how it can work internally. At this moment, no are evaluated when it's parsed. Those no agp*

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Thu, Oct 30, 2014 at 10:01 PM, Quentin Garnier c...@cubidou.net wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 8:36 PM, Alan Barrett a...@netbsd.org wrote: On Thu, 30 Oct 2014, Masao Uebayashi wrote: What do you expect by doing:

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 1:33 AM, Antti Kantee po...@homeworld.netbsd.org wrote: On Thu, Oct 30, 2014 at 11:14:50AM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com wrote: In article 20141030012621.0982...@cvs.netbsd.org, Masao Uebayashi

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Antti Kantee
On 30/10/14 17:28, Masao Uebayashi wrote: Is there a problem rototilling config is going to solve over what is possible with the existing mechanism (*)? You're welcomed to fix any problems without rotorill and/or breakage. You're not answering the question. *) you probably also heard that

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 2:28 AM, Masao Uebayashi uebay...@gmail.com wrote: On Fri, Oct 31, 2014 at 1:33 AM, Antti Kantee po...@homeworld.netbsd.org wrote: On Thu, Oct 30, 2014 at 11:14:50AM +0900, Masao Uebayashi wrote: On Thu, Oct 30, 2014 at 10:51 AM, Christos Zoulas chris...@astron.com

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 3:00 AM, Antti Kantee po...@netbsd.org wrote: On 30/10/14 17:28, Masao Uebayashi wrote: Is there a problem rototilling config is going to solve over what is possible with the existing mechanism (*)? You're welcomed to fix any problems without rotorill and/or

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Masao Uebayashi
On Fri, Oct 31, 2014 at 1:49 AM, David Holland dholland-sourcechan...@netbsd.org wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: So, while you expect that options works before it's defined, you also expect the order is honored for no use. I'm not sure how it can

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Taylor R Campbell
Date: Fri, 31 Oct 2014 03:36:45 +0900 From: Masao Uebayashi uebay...@gmail.com On Fri, Oct 31, 2014 at 1:49 AM, David Holland dholland-sourcechan...@netbsd.org wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: At this moment, no are evaluated when it's

Re: CVS commit: [netbsd-7] src/sys/arch/x86/x86

2014-10-30 Thread John Nemeth
On Oct 30, 6:58pm, Martin Husemann wrote: } } Module Name: src } Committed By: martin } Date: Thu Oct 30 18:58:45 UTC 2014 } } Modified Files: } src/sys/arch/x86/x86 [netbsd-7]: identcpu.c } } Log Message: } Pull up following revision(s) (requested by riz in ticket #171): }