On Tue, Oct 17, 2017 at 9:03 PM, Christos Zoulas <chris...@astron.com> wrote: > In article <20171017071319.a4380f...@cvs.netbsd.org>, > Ryota Ozaki <source-changes-d@NetBSD.org> wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: ozaki-r >>Date: Tue Oct 17 07:13:19 UTC 2017 >> >>Modified Files: >> src/usr.sbin/inetd: inetd.c >> >>Log Message: >>Don't setup SPs if no policy sepecifier is specified >> >>We expect that SPs are set up iff some policy sepecifier(s) are specified. > > Why not just flip the order ? > > if (policy != NULL && ipsecfoo(...) < 0) { > }
I just wanted to pull ipsecsetup out from the conditional statement. ozaki-r