Re: CVS commit: src/sys/arch/aarch64

2018-08-05 Thread Jason Thorpe
> On Aug 5, 2018, at 1:55 AM, Martin Husemann wrote: > > On Sat, Aug 04, 2018 at 06:33:20AM -0700, Jason Thorpe wrote: >> It only matters when setting / removing breakpoints, so it seems like >> you want to defer changing page protection right until then. > > Can't we do the breakpoint change

Re: CVS commit: src/sys/arch/aarch64

2018-08-05 Thread Martin Husemann
On Sat, Aug 04, 2018 at 06:33:20AM -0700, Jason Thorpe wrote: > It only matters when setting / removing breakpoints, so it seems like > you want to defer changing page protection right until then. Can't we do the breakpoint changes via the direct map instead? Martin

Re: CVS commit: src/sys/arch/aarch64

2018-08-05 Thread Jason Thorpe
> On Aug 4, 2018, at 2:09 AM, Maxime Villard wrote: > > Regarding the DDB ifndef, probably there must be > a bit in ARM64 saying "disable page protection", so it could be set when > we enter DDB, and we could remove the ifndef. It only matters when setting / removing breakpoints, so it seems