Re: CVS commit: src/sys/arch/powerpc/oea

2021-04-01 Thread Jason Thorpe
Ugh. Can we please stop making these hacky one-offs in "shared by all PowerPC platforms" code? This actually points to a deeper problem in the pmap code that needs to be addressed correctly. > On Apr 1, 2021, at 3:02 PM, Michael Lorenz wrote: > > Module Name: src > Committed By: macallan >

Re: CVS commit: src/share/misc

2021-04-01 Thread Joerg Sonnenberger
On Fri, Apr 02, 2021 at 12:45:28AM +0200, Roland Illig wrote: > For simple cases I agree with Matthew that parentheses should not be > required. Looking through the src tree, I noticed though that the vast > majority of the code uses the redundant parentheses, so I also agree > with Christos that

Re: CVS commit: src/share/misc

2021-04-01 Thread Roland Illig
On 31.03.2021 11:03, Robert Elz wrote: Here, as I recall it, the issue only arose because of something either lint or indent was doing, or wanted to do. I don't recall which, but I do not remember any earlier complaints from anyone that they couldn't understand code because of missing () around