Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:28 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c usbnet.h
Log Message:
usbnet: Make usbnet_mii_readreg/writereg/statchg private to usbnet.c.
No drivers need to use these.
To generate a diff of this
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:28 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c usbnet.h
Log Message:
usbnet: Make usbnet_mii_readreg/writereg/statchg private to usbnet.c.
No drivers need to use these.
To generate a diff of this
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:21 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_mos.c if_mue.c
if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Avoid undefined behaviour if read reg
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:21 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_mos.c if_mue.c
if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Avoid undefined behaviour if read reg
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:11 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c
Log Message:
axen(4): Use axen mii read/write reg routines, not usbnet ones.
The usbnet wrappers don't add anything important. We already test
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:11 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c
Log Message:
axen(4): Use axen mii read/write reg routines, not usbnet ones.
The usbnet wrappers don't add anything important. We already test
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:03 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
usbnet drivers: Assert IFNET_LOCKED in if ioctl routines.
These only happen either during the transition up or down (init
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:54:03 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
usbnet drivers: Assert IFNET_LOCKED in if ioctl routines.
These only happen either during the transition up or down (init
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:56 UTC 2022
Modified Files:
src/sys/dev/usb: if_udav.c
Log Message:
udav(4): Stop asserting !usbnet_isdying.
This can change at any moment; no software lock can prevent the
device from being detached. Any
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:49 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Simplify. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.183 -r1.184 src/sys/dev/usb/if_aue.c
Please
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:56 UTC 2022
Modified Files:
src/sys/dev/usb: if_udav.c
Log Message:
udav(4): Stop asserting !usbnet_isdying.
This can change at any moment; no software lock can prevent the
device from being detached. Any
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:49 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Simplify. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.183 -r1.184 src/sys/dev/usb/if_aue.c
Please
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:41 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Enable rx/tx registers on init before usbnet_init_rx_tx.
This way, we still have exclusive access to the registers before
calls to
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:41 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Enable rx/tx registers on init before usbnet_init_rx_tx.
This way, we still have exclusive access to the registers before
calls to
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:33 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit redundant
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:33 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit redundant
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:23 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_smsc.c if_udav.c
if_ure.c if_url.c usbnet.c
Log Message:
usbnet: Apply hardware multicast filter updates synchronously
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:23 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_smsc.c if_udav.c
if_ure.c if_url.c usbnet.c
Log Message:
usbnet: Apply hardware multicast filter updates synchronously
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:14 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_cue.c if_kue.c if_mue.c if_smsc.c
if_udav.c
Log Message:
usbnet drivers: Stop abusing ifp->if_flags & IFF_ALLMULTI.
This legacy flag is a
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:14 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_cue.c if_kue.c if_mue.c if_smsc.c
if_udav.c
Log Message:
usbnet drivers: Stop abusing ifp->if_flags & IFF_ALLMULTI.
This legacy flag is a
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:04 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit needless
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:53:04 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit needless
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:55 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Reduce aue_uno_mcast from aue_uno_init to aue_setiff_locked.
This operation only needs to update the hardware to reflect
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:55 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Reduce aue_uno_mcast from aue_uno_init to aue_setiff_locked.
This operation only needs to update the hardware to reflect
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:46 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c usbnet.c
Log Message:
usbnet: Take the core lock
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:46 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c usbnet.c
Log Message:
usbnet: Take the core lock
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:36 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit needless uno_init locked
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:36 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_ure.c if_url.c
Log Message:
usbnet drivers: Omit needless uno_init locked
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:27 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for the core lock in usbnet_ifflags_cb.
The only state this touches is unp_if_flags, and all paths touching
it also hold
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:27 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for the core lock in usbnet_ifflags_cb.
The only state this touches is unp_if_flags, and all paths touching
it also hold
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:20 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_cdce.c usbnet.c usbnet.h
Log Message:
usbnet: Make the tx/rx locks private to usbnet.c.
Suffice it for the drivers to know that uno_tx_prepare and
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:20 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_cdce.c usbnet.c usbnet.h
Log Message:
usbnet: Make the tx/rx locks private to usbnet.c.
Suffice it for the drivers to know that uno_tx_prepare and
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:11 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c usbnet.h
Log Message:
usbnet: usbnet_busy is no longer referenced; release it!
To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:11 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c usbnet.h
Log Message:
usbnet: usbnet_busy is no longer referenced; release it!
To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:04 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for usbnet_busy in mii callbacks.
After mii_detach, these have all completed and no new ones can be
made, and detach doesn't
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:52:04 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for usbnet_busy in mii callbacks.
After mii_detach, these have all completed and no new ones can be
made, and detach doesn't
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:56 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for usbnet_busy in usbnet_init_rx_tx or usbnet_stop.
These run with IFNET_LOCK held, and the interface cannot be detached
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:56 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: No need for usbnet_busy in usbnet_init_rx_tx or usbnet_stop.
These run with IFNET_LOCK held, and the interface cannot be detached
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:44 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_axen.c if_smsc.c if_udav.c if_url.c
Log Message:
usbnet drivers: No need for usbnet_busy during attach.
usbnet_detach cannot run until the attach
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:44 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_axen.c if_smsc.c if_udav.c if_url.c
Log Message:
usbnet drivers: No need for usbnet_busy during attach.
usbnet_detach cannot run until the attach
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:36 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
usbnet drivers: No need for usbnet_busy in uno_ioctl.
This callback always runs with the IFNET_LOCK held, and the
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:36 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
usbnet drivers: No need for usbnet_busy in uno_ioctl.
This callback always runs with the IFNET_LOCK held, and the
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:27 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c if_mue.c
if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: No need for usbnet_busy in
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:27 UTC 2022
Modified Files:
src/sys/dev/usb: if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c if_mue.c
if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: No need for usbnet_busy in
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:17 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: No need for
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:17 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c
Log Message:
usbnet drivers: No need for
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:06 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c usbnet.c usbnet.h
Log Message:
usbnet: Split
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:51:06 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cue.c if_kue.c if_mos.c
if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c usbnet.c usbnet.h
Log Message:
usbnet: Split
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:57 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_mos.c if_mue.c if_smsc.c if_udav.c
if_ure.c if_url.c
Log Message:
usbnet drivers: Stop timeout loops early if device is detaching.
To
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:57 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_mos.c if_mue.c if_smsc.c if_udav.c
if_ure.c if_url.c
Log Message:
usbnet drivers: Stop timeout loops early if device is detaching.
To
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:47 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless locking around usbnet_isdying.
Now that is tested and set with atomic_load/store, there is no need
to hold the lock --
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:47 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless locking around usbnet_isdying.
Now that is tested and set with atomic_load/store, there is no need
to hold the lock --
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:40 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Use atomic_load/store_relaxed for unp_dying.
This way we don't need to hold the core lock to avoid upsetting
sanitizers (which
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:40 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Use atomic_load/store_relaxed for unp_dying.
This way we don't need to hold the core lock to avoid upsetting
sanitizers (which
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:31 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Print diagnostic about refcnt stragglers.
I don't think there can be any, but this message, if printed, would
falsify my hypothesis!
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:31 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Print diagnostic about refcnt stragglers.
I don't think there can be any, but this message, if printed, would
falsify my hypothesis!
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:22 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cdce.c if_cue.c
if_kue.c if_mos.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c
if_url.c if_urndis.c usbnet.c
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:22 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cdce.c if_cue.c
if_kue.c if_mos.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c
if_url.c if_urndis.c usbnet.c
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:13 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Assert ioctl locking.
To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 src/sys/dev/usb/usbnet.c
Please note that diffs
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:13 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Assert ioctl locking.
To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 src/sys/dev/usb/usbnet.c
Please note that diffs
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:06 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Impart blame on whose ifnet is unlocked in uno_init.
To generate a diff of this commit:
cvs rdiff -u -r1.68 -r1.69
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:50:06 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Impart blame on whose ifnet is unlocked in uno_init.
To generate a diff of this commit:
cvs rdiff -u -r1.68 -r1.69
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:58 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't waste time calling uno_stop if device is detaching.
The hardware is most likely gone, so trying to write to its registers
(and,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:58 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't waste time calling uno_stop if device is detaching.
The hardware is most likely gone, so trying to write to its registers
(and,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:51 UTC 2022
Modified Files:
src/sys/dev/usb: if_cue.c
Log Message:
cue(4): Return real error code, not -1, on init when detaching.
To generate a diff of this commit:
cvs rdiff -u -r1.91 -r1.92
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:51 UTC 2022
Modified Files:
src/sys/dev/usb: if_cue.c
Log Message:
cue(4): Return real error code, not -1, on init when detaching.
To generate a diff of this commit:
cvs rdiff -u -r1.91 -r1.92
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:44 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Avoid IFNET_LOCK on detach if we never attached the ifp.
To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:44 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Avoid IFNET_LOCK on detach if we never attached the ifp.
To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:37 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Clear watchdog timer before stopping hardware.
No need to take the lock again -- which might not be necessary
because the callout and
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:37 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Clear watchdog timer before stopping hardware.
No need to take the lock again -- which might not be necessary
because the callout and
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:29 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless locking/busying/testing in usbnet_tick_task.
usbnet_stop waits for the task to complete before resetting the
hardware,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:29 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless locking/busying/testing in usbnet_tick_task.
usbnet_stop waits for the task to complete before resetting the
hardware,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:22 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless tests in usbnet_tick.
It's harmless for us to schedule the tick task even if unp_dying or
unp_stopping is set by now,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:22 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless tests in usbnet_tick.
It's harmless for us to schedule the tick task even if unp_dying or
unp_stopping is set by now,
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:15 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Uncomment and fix assertion for ifp->if_flags |= IFF_RUNNING.
We always hold IFNET_LOCK for ioctls that end up here -- the ones
that
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:15 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Uncomment and fix assertion for ifp->if_flags |= IFF_RUNNING.
We always hold IFNET_LOCK for ioctls that end up here -- the ones
that
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:08 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't issue a detach event if we never issued an attach one.
To generate a diff of this commit:
cvs rdiff -u -r1.61 -r1.62
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:08 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't issue a detach event if we never issued an attach one.
To generate a diff of this commit:
cvs rdiff -u -r1.61 -r1.62
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:00 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Make detach order reverse attach order, for unp_stat_ch.
No functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:49:00 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Make detach order reverse attach order, for unp_stat_ch.
No functional change intended.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:52 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Detach interface and mii before waiting for refcnt to drain.
All outstanding software activity under usbnet's control -- which is
all
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:52 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Detach interface and mii before waiting for refcnt to drain.
All outstanding software activity under usbnet's control -- which is
all
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:45 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless callout_halt and usb_rem_task_wait.
The callout and tasks cannot be pending at this point -- it is a bug
if
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:45 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless callout_halt and usb_rem_task_wait.
The callout and tasks cannot be pending at this point -- it is a bug
if
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:37 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Refuse to bring interfaces back up once dying.
Make this happen uniformly across all usbnet drivers, not on a
per-driver basis.
This
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:37 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Refuse to bring interfaces back up once dying.
Make this happen uniformly across all usbnet drivers, not on a
per-driver basis.
This
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:30 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Assert IFNET_LOCKED in usbnet_media_upd.
This ensures, if the device is being initialized or stopped,
usbnet_media_upd will not run
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:30 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Assert IFNET_LOCKED in usbnet_media_upd.
This ensures, if the device is being initialized or stopped,
usbnet_media_upd will not run
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:23 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Fix ordering of actions in usbnet_stop.
Make sure all software activity is quiescent (callouts and tasks,
including ifmedia and mii
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:23 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Fix ordering of actions in usbnet_stop.
Make sure all software activity is quiescent (callouts and tasks,
including ifmedia and mii
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:14 UTC 2022
Modified Files:
src/sys/dev/usb: if_url.c usbnet.c usbnet.h
Log Message:
usbnet: Remove usbnet_set_dying.
Not necessary for the one caller that did it (url(4)): usbnet_detach
handles failed attach
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:14 UTC 2022
Modified Files:
src/sys/dev/usb: if_url.c usbnet.c usbnet.h
Log Message:
usbnet: Remove usbnet_set_dying.
Not necessary for the one caller that did it (url(4)): usbnet_detach
handles failed attach
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:06 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
axen(4), mue(4), smsc(4): Omit irrelevant cases in ioctl.
SIOCSIFFLAGS and SIOCSETHERCAP always end up in
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:48:06 UTC 2022
Modified Files:
src/sys/dev/usb: if_axen.c if_mue.c if_smsc.c
Log Message:
axen(4), mue(4), smsc(4): Omit irrelevant cases in ioctl.
SIOCSIFFLAGS and SIOCSETHERCAP always end up in
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:58 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless unp == NULL test in usbnet_tick_task.
The task is never scheduled until after un->un_pri is initialized,
and un->un_pri
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:58 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Omit needless unp == NULL test in usbnet_tick_task.
The task is never scheduled until after un->un_pri is initialized,
and un->un_pri
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:50 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't check if_flags for IFF_RUNNING in usbnet_pipe_intr.
The one user of this interface in tree, aue(4), doesn't care --
if_statinc
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:50 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't check if_flags for IFF_RUNNING in usbnet_pipe_intr.
The one user of this interface in tree, aue(4), doesn't care --
if_statinc
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:43 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't check if_flags for IFF_RUNNING in usbnet_rxeof.
This can only run after we start the pipes in usbnet_init_rx_tx, and
before we
Module Name:src
Committed By: riastradh
Date: Thu Mar 3 05:47:43 UTC 2022
Modified Files:
src/sys/dev/usb: usbnet.c
Log Message:
usbnet: Don't check if_flags for IFF_RUNNING in usbnet_rxeof.
This can only run after we start the pipes in usbnet_init_rx_tx, and
before we
101 - 200 of 216 matches
Mail list logo
