hi,
On Thu, Nov 11, 2010 at 02:10:00PM +, YAMAMOTO Takashi wrote:
hi,
Module Name: src
Committed By: rmind
Date: Wed Oct 27 02:58:05 UTC 2010
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
do_posix_fadvise: check for a negative
hi,
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
hi,
Module Name: src
Committed By: rmind
Date: Wed Oct 27 02:58:05 UTC 2010
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
do_posix_fadvise: check for a negative length; truncate
hi,
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
hi,
Module Name: src
Committed By: rmind
Date: Wed Oct 27 02:58:05 UTC 2010
Modified Files:
src/sys/kern: sys_descrip.c
Log Message:
do_posix_fadvise: check for a negative length; truncate
state variables that need it.
can you explain why they need to be volatile? aren't they protected
by a mutex?
btw, i'm not sure why this driver needs this complicate locking.
i guess it's better to (re?)design locking protocol for ifioctl before
putting this complicity to drivers.
YAMAMOTO Takashi
for the old ioctl size.
Detect and error files which are definitely sparse (va_bytes va_size).
please revert this part of the change.
because:
- the check doesn't work for certain filesystems. eg. zfs
- sparse files work fine in some cases. eg. read-only usage, nfs
YAMAMOTO Takashi
,
which is beyond filesystem's task.
it doesn't sound convincing to me, given that you have a separate copy
of genfs_getpages for xip.
YAMAMOTO Takashi
Why not adding pgo_get_xip - because I didn't think it's worth adding it.
XIP is transparent to other UVM pagers. (And only used by vnode
merge of what? your xip branch?
it's better to do it before the merge if you want people review it.
I clean up it today then.
Masao
done?
YAMAMOTO Takashi
Module Name:src
Committed By: yamt
Date: Wed Mar 3 00:44:52 UTC 2010
Modified Files:
src/external/bsd/iscsi/dist/include: iscsiprotocol.h
src/external/bsd/iscsi/dist/src/lib: disk.c target.c
Log Message:
fix multi-thread problems wrt read/write buffer. PR/42651.
Module Name:src
Committed By: yamt
Date: Wed Mar 3 00:45:55 UTC 2010
Modified Files:
src/sys/sys: proc.h
Log Message:
comment
To generate a diff of this commit:
cvs rdiff -u -r1.295 -r1.296 src/sys/sys/proc.h
Please note that diffs are not public domain; they are
Module Name:src
Committed By: yamt
Date: Wed Mar 3 00:47:31 UTC 2010
Modified Files:
src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c
kern_sig.c kern_synch.c vfs_syscalls.c
Log Message:
remove redundant checks of PK_MARKER.
To generate a
Module Name:src
Committed By: yamt
Date: Wed Mar 3 00:47:31 UTC 2010
Modified Files:
src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c
kern_sig.c kern_synch.c vfs_syscalls.c
Log Message:
remove redundant checks of PK_MARKER.
To generate a
merge. Give me
one week...
merge of what? your xip branch?
it's better to do it before the merge if you want people review it.
YAMAMOTO Takashi
Masao
and pgo_get_xip?
is it allowed to return both of device pages and normal pages mixed
for a request?
YAMAMOTO Takashi
To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.36.2.1 src/sys/miscfs/genfs/genfs_io.c
Please note that diffs are not public domain; they are subject to the
copyright
)?
YAMAMOTO Takashi
To generate a diff of this commit:
cvs rdiff -u -r1.153.2.7 -r1.153.2.8 src/sys/uvm/uvm_page.c
cvs rdiff -u -r1.59.2.5 -r1.59.2.6 src/sys/uvm/uvm_page.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
hi,
can you please add comments on each uvm_fault_* functions you introduced?
eg. what uvm_fault_lower1 does is not clear from its name at all.
to me, it isn't clear what was the purpose of the mechanical splitting of
these functions.
YAMAMOTO Takashi
On Fri, Jan 29, 2010 at 12:24:56AM +, YAMAMOTO Takashi wrote:
let's stop being too generic and go back to the change in question.
do you think this man page is an appropriate place for these functions?
Given that they exist in several MD implementations and (I think
On Thu, Jan 28, 2010 at 06:42:16AM +, YAMAMOTO Takashi wrote:
ISTM that section 9 is an appropriate place for both interface and
implementation docs. In the (few) cases where we actually have an
interface, as opposed to some exposed pieces of the implementation
available for every ports and MI code can use them.
dyoung, can you please back the change out?
(why tech-pkg, btw?)
YAMAMOTO Takashi
Module Name:src
Committed By: yamt
Date: Wed Jan 20 10:33:08 UTC 2010
Modified Files:
src/external/bsd/iscsi/dist/src/lib: disk.c
Log Message:
implement REPORT LUNS for non-zero LUNs correctly.
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5
Module Name:src
Committed By: yamt
Date: Wed Jan 20 11:50:29 UTC 2010
Modified Files:
src/external/bsd/iscsi/dist/src/lib: target.c
Log Message:
- remove unnecessary and confusing initialization of sess-d.
- add an assertion.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: yamt
Date: Tue Jan 19 13:29:40 UTC 2010
Modified Files:
src/sys/nfs: nfs.h
Log Message:
remove unused r_timer member.
To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71 src/sys/nfs/nfs.h
Please note that diffs are not public
Module Name:src
Committed By: yamt
Date: Wed Jan 20 00:58:49 UTC 2010
Modified Files:
src/external/bsd/iscsi/dist/src/lib: disk.c target.c
Log Message:
add missing trailing newline chars to some of iscsi_err messages.
To generate a diff of this commit:
cvs rdiff -u
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/ddb/db_lwp.c
cvs rdiff -u -r1.411 -r1.412 src/sys/kern/init_main.c
cvs rdiff -u -r1.136 -r1.137 src/sys/kern/kern_lwp.c
cvs rdiff -u -r1.158 -r1.159 src/sys/kern
hi,
can you please don't hardcode utf-8?
YAMAMOTO Takashi
Module Name: src
Committed By: christos
Date: Wed Dec 30 22:37:40 UTC 2009
Modified Files:
src/lib/libedit: Makefile chared.c chared.h common.c el.c el.h emacs.c
filecomplete.c filecomplete.h hist.c
On Jan 13, 8:21am, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/lib/libedit
| hi,
|
| can you please don't hardcode utf-8?
|
| YAMAMOTO Takashi
Once we verify that it works on non utf-8, sure.
what do you mean by verify?
YAMAMOTO Takashi
/sys/kern/kern_proc.c
this part of the change looks wrong to me.
YAMAMOTO Takashi
cvs rdiff -u -r1.44 -r1.45 src/sys/kern/subr_prof.c
cvs rdiff -u -r1.152 -r1.153 src/sys/kern/sys_process.c
cvs rdiff -u -r1.128 -r1.129 src/sys/uvm/uvm_fault.c
cvs rdiff -u -r1.142 -r1.143 src/sys/uvm/uvm_glue.c
it is not a right fix. With this
patch, build.sh release passes:
http://www.netbsd.org/~rmind/crash_pcb.diff
Requesting http://www.netbsd.org/~rmind/crash_pcb.diff
ftp: Error retrieving file `404 Not Found'
YAMAMOTO Takashi
It should have been enough to amend the argument of routine exported
be in kernel)
YAMAMOTO Takashi
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/usr.sbin/rpc.lockd/lockd_lock.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
hi,
On Wed, Nov 18, 2009 at 03:51:02AM +, YAMAMOTO Takashi wrote:
Log Message:
Add a kernel configuration flag, SPLDEBUG, that activates a per-CPU log
of transitions to IPL_HIGH from lower IPLs. SPLDEBUG is only available
on i386 and Xen kernels, today.
'options SPLDEBUG' adds
are not appropriate to be
described in this page. please revert.
adding xrefs to splraiseipl and makeiplcookie instead is probably
a good idea.
YAMAMOTO Takashi
To generate a diff of this commit:
cvs rdiff -u -r1.1338 -r1.1339 src/distrib/sets/lists/comp/mi
cvs rdiff -u -r1.297 -r1.298 src/share/man
code like this in kern/. IPL_ values can't be
compared with = in MI code. return_address.9 is in man.i386.
- there are other places where the spl value is modified.
eg. interrupt stubs, lock stubs, etc.
- can you explain cpu_index(ci) MAXCPUS and cpu_index(ci) = MAXCPUS ?
YAMAMOTO Takashi
is important for nfs.
freebsd has a knob to switch getnanotime/nanotime for vfs_timestamp
for the tradeoff.
YAMAMOTO Takashi
hi,
doesn't it leak a page for x86 redzone?
YAMAMOTO Takashi
Module Name: src
Committed By: rmind
Date: Wed Oct 21 21:12:07 UTC 2009
Modified Files:
src/bin/ps: keyword.c print.c ps.1
src/external/bsd/top/dist/machine: m_netbsd.c
src/lib/libkvm: kvm_proc.c
hi,
Hello,
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
hi,
what's the status of this?
in case it was not clear, i want you revert the changes.
It does not change the way how other (and older) section 9 man pages are
written, it rather makes our man pages consistent. And I
kmem_zalloc.9
Log Message:
Unify kmem_alloc/zalloc/free under kmem(9). Links preserved.
i intentionally made them separate pages because
it's easier to read for me. (ie. no need to search in a man page.)
YAMAMOTO Takashi
To generate a diff of this commit:
cvs rdiff -u -r1.1289
On Wed, Jun 24, 2009 at 02:21:44PM +, YAMAMOTO Takashi wrote:
Module Name: src
Committed By:yamt
Date:Wed Jun 24 14:21:44 UTC 2009
Modified Files:
src/sys/kern [yamt-nfs-mp]: vfs_syscalls.c
src/sys/nfs [yamt-nfs-mp]: nfs_vfsops.c nfs_vnops.c
Log
hi,
On Tue, Jun 09, 2009 at 11:21:34AM +, YAMAMOTO Takashi wrote:
Log Message:
don't bother to say that some advises are not implemented.
ignoring them is a valid implementation.
It should not be under BUGS, but it should still be documented.
E.g. POSIX_FADV_NOREUSE would be very
hi,
On Sat, May 16, 2009 at 08:29:54AM +, YAMAMOTO Takashi wrote:
Modified Files:
src/sys/kern: vfs_subr.c
src/sys/sys: vnode.h
Log Message:
put a flag bit into v_usecount to prevent vtryget during getcleanvnode.
this fixes the following deadlock.
Thanks! How about
hi,
Hi,
do you think it could also help with kern/41417 ?
cache_lookup seems also to be involved in this deadlock ...
it seems like a different problem.
YAMAMOTO Takashi
hi,
On Sat, May 16, 2009 at 12:02:00PM +, YAMAMOTO Takashi wrote:
Module Name: src
Committed By:yamt
Date:Sat May 16 12:02:00 UTC 2009
Modified Files:
src/sys/kern: init_sysctl.c
Log Message:
sysctl_doeproc:
- simplify.
- KERN_PROC: fix
hi,
On Sun, May 10, 2009 at 8:44 AM, YAMAMOTO Takashi
y...@mwd.biglobe.ne.jp wrote:
have you checked callers and ensure that the change from EACCES to EPERM
won't be a problem?
Only ipsec_set_policy() returns EPERM instead of EACCES now, and I
don't think it should be a problem.
don't
isn't KAUTH_REQ_NETWORK_SOCKET_RAWSOCK being deprecated in favor of _OPEN?
YAMAMOTO Takashi
cvs rdiff -u -r1.38 -r1.39 src/sys/netinet6/udp6_output.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
hi,
On Sun, May 10, 2009 at 05:18:26AM +, YAMAMOTO Takashi wrote:
Module Name: src
Committed By: yamt
Date: Sun May 10 05:18:26 UTC 2009
Modified Files:
src/sys/nfs: nfs_vnops.c
Log Message:
nfs_lookup: vn_lock the vnode returned
hi,
On Fri, May 8, 2009 at 2:18 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp
wrote:
hi,
have you checked callers and ensure that the change from EACCES to EPERM
won't be a problem?
Only ipsec_set_policy() returns EPERM instead of EACCES now, and I
don't think it should be a problem
hi,
Antti Kantee po...@netbsd.org wrote:
On Mon, May 04, 2009 at 06:05:19AM +, YAMAMOTO Takashi wrote:
Module Name: src
Committed By: yamt
Date: Mon May 4 06:05:19 UTC 2009
Modified Files:
src/sys/kern: vfs_lookup.c
src/sys/nfs: nfs_srvsubs.c
remove/rename operation.
because it's what ufs expects. :-)
i introduced cache_lookup_raw for nfs, which doesn't want these behaviours.
i wanted to replace cache_lookup but some people prefered the current one.
YAMAMOTO Takashi
101 - 146 of 146 matches
Mail list logo
