Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-26 Thread Alistair Crooks
On Fri, Oct 26, 2012 at 07:28:15AM +0100, David Laight wrote: On Fri, Oct 26, 2012 at 05:03:24AM +0200, Alistair Crooks wrote: /* set up the pubkey keyring */ int pgpv_read_pubring(pgpv_t *pgp, const void *keyring, ssize_t size) { if (keyring) { return

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-26 Thread David Laight
On Fri, Oct 26, 2012 at 08:47:39AM +0200, Alistair Crooks wrote: What happens if $HOME is undefined ? If $HOME is undefined, then the default public keyring will not be found. If the default public keyring is not found, then the verification will fail. I thought the code would probably

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-26 Thread Alistair Crooks
On Fri, Oct 26, 2012 at 07:45:14AM +0100, David Laight wrote: On Fri, Oct 26, 2012 at 08:47:39AM +0200, Alistair Crooks wrote: What happens if $HOME is undefined ? If $HOME is undefined, then the default public keyring will not be found. If the default public keyring is not found,

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-25 Thread Christos Zoulas
In article 20121025040317.3b16417...@cvs.netbsd.org, Alistair G. Crooks source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: agc Date: Thu Oct 25 04:03:16 UTC 2012 Modified Files: src/crypto/external/bsd/netpgp/dist/src/libverify

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-25 Thread Alistair Crooks
On Thu, Oct 25, 2012 at 12:40:28PM +, Christos Zoulas wrote: In article 20121025040317.3b16417...@cvs.netbsd.org, Alistair G. Crooks source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:agc Date:Thu Oct 25 04:03:16 UTC 2012 Modified

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-25 Thread Christos Zoulas
In article 20121025143517.gb19...@nef.pbox.org, Alistair Crooks a...@pkgsrc.org wrote: On Thu, Oct 25, 2012 at 12:40:28PM +, Christos Zoulas wrote: In article 20121025040317.3b16417...@cvs.netbsd.org, Alistair G. Crooks source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:

Re: CVS commit: [agc-netpgp-standalone] src/crypto/external/bsd/netpgp/dist/src

2012-10-25 Thread Alistair Crooks
On Thu, Oct 25, 2012 at 04:09:12PM +, Christos Zoulas wrote: But I'm not sure it should - the memory pointer or filename argument is overloaded when it is passed in; the size parameter being negative is used to signify that it's a filename, so ssize_t is the correct type. Perhaps there