OK, it makes sense. I will revert the changes. Thanks for your explanations.
On Sun, Oct 8, 2023 at 12:49 PM matthew green wrote:
>
> > I was changing news68k specific code, thus wasn't treating them as
> > common. But I understand the point.
>
> there's a *LOT* of m68k code that is copied
> I was changing news68k specific code, thus wasn't treating them as
> common. But I understand the point.
there's a *LOT* of m68k code that is copied into all the ports
that is almost identical, and should really be shared, but it
not, and changes like can make this harder to share.
ie, while
On Sun, Oct 8, 2023 at 6:56 AM Izumi Tsutsui wrote:
>
> > In this case maybe I should remove all FPSP references (vectors.S,
> > locore.S, Makefile.news68k (MD_LIBS={FPSP})?
>
> IMO we don't have to keep strict consistencies or buildabilities of
> options but rather should consider readabilities
> In this case maybe I should remove all FPSP references (vectors.S,
> locore.S, Makefile.news68k (MD_LIBS={FPSP})?
IMO we don't have to keep strict consistencies or buildabilities of
options but rather should consider readabilities and maintainabilities.
- options FPSP in a config file is not
In this case maybe I should remove all FPSP references (vectors.S,
locore.S, Makefile.news68k (MD_LIBS={FPSP})?
On Sun, Oct 1, 2023 at 10:08 PM Izumi Tsutsui wrote:
>
> > Module Name: src
> > Committed By: andvar
> > Date: Sun Oct 1 18:50:53 UTC 2023
> >
> > Modified Files:
> >
> Module Name: src
> Committed By: andvar
> Date: Sun Oct 1 18:50:53 UTC 2023
>
> Modified Files:
> src/sys/arch/news68k/conf: Makefile.news68k
>
> Log Message:
> include fpsp Makefile.inc in Makefile.news68k, same as other m68k ports.
>
> needed for FPSP option to build,
Module Name:src
Committed By: andvar
Date: Sun Oct 1 18:50:53 UTC 2023
Modified Files:
src/sys/arch/news68k/conf: Makefile.news68k
Log Message:
include fpsp Makefile.inc in Makefile.news68k, same as other m68k ports.
needed for FPSP option to build, otherwise FPSP
Module Name:src
Committed By: andvar
Date: Sun Oct 1 18:50:53 UTC 2023
Modified Files:
src/sys/arch/news68k/conf: Makefile.news68k
Log Message:
include fpsp Makefile.inc in Makefile.news68k, same as other m68k ports.
needed for FPSP option to build, otherwise FPSP
