CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:37 UTC 2022 Modified Files: src/sys/dev/usb: usb.h Log Message: usbdi(9): Restore usb_descriptor_t to its correct definition. Descriptors in the USB spec all start with bLength and bDescriptorType. bDescripto

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:37 UTC 2022 Modified Files: src/sys/dev/usb: usb.h Log Message: usbdi(9): Restore usb_descriptor_t to its correct definition. Descriptors in the USB spec all start with bLength and bDescriptorType. bDescripto

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:27 UTC 2022 Modified Files: src/sys/dev/usb: if_umb.c Log Message: umb(4): Use usb_cdc_descriptor_t for bDescriptorSubtype. Note: This needs more length validation! TBD in a separate commit. To generate a d

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:27 UTC 2022 Modified Files: src/sys/dev/usb: if_umb.c Log Message: umb(4): Use usb_cdc_descriptor_t for bDescriptorSubtype. Note: This needs more length validation! TBD in a separate commit. To generate a d

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:15 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Restore umidi_cs_descriptor_t type. Had been previously deleted under the misapprehension that usb_descriptor_t is appropriate here,

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:15 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Restore umidi_cs_descriptor_t type. Had been previously deleted under the misapprehension that usb_descriptor_t is appropriate here,

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:05 UTC 2022 Modified Files: src/sys/dev/usb: uvideo.c Log Message: uvideo(4): Avoid printing off the end of truncated descriptors. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/usb

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 13:15:05 UTC 2022 Modified Files: src/sys/dev/usb: uvideo.c Log Message: uvideo(4): Avoid printing off the end of truncated descriptors. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/usb

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 09:25:24 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Make sure rndsource is attached before use and detach. Reported-by: syzbot+04fb6786e0cf87390...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/dev/usb

2022-04-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Apr 17 09:25:24 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Make sure rndsource is attached before use and detach. Reported-by: syzbot+04fb6786e0cf87390...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/dev/usb

2022-04-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Apr 7 21:47:02 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Use tty_unit -- save a couple lines of code. To generate a diff of this commit: cvs rdiff -u -r1.131 -r1.132 src/sys/dev/usb/ucom.c P

CVS commit: src/sys/dev/usb

2022-04-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Apr 7 21:47:02 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Use tty_unit -- save a couple lines of code. To generate a diff of this commit: cvs rdiff -u -r1.131 -r1.132 src/sys/dev/usb/ucom.c P

CVS commit: src/sys/dev/usb

2022-04-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Apr 7 17:35:31 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Fix unit numbering for devsw/autoconf cross-wiring. Should introduce a tty_unit function to use here but this'll do for now to fix the

CVS commit: src/sys/dev/usb

2022-04-07 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Apr 7 17:35:31 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Fix unit numbering for devsw/autoconf cross-wiring. Should introduce a tty_unit function to use here but this'll do for now to fix the

CVS commit: src/sys/dev/usb

2022-04-06 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Apr 6 22:01:45 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c if_smscreg.h if_urtwn.c ubt.c uhub.c usb_subr.c usbdi.c uvideo.c xhci.c xhcireg.h Log Message: revert accidental last commit (except ukbd.c) To ge

CVS commit: src/sys/dev/usb

2022-04-06 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Apr 6 22:01:45 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c if_smscreg.h if_urtwn.c ubt.c uhub.c usb_subr.c usbdi.c uvideo.c xhci.c xhcireg.h Log Message: revert accidental last commit (except ukbd.c) To ge

CVS commit: src/sys/dev/usb

2022-04-06 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Apr 6 21:51:29 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c if_smscreg.h if_urtwn.c ubt.c uhub.c ukbd.c usb_subr.c usbdi.c uvideo.c xhci.c xhcireg.h Log Message: remove debug printf To generate a diff of th

CVS commit: src/sys/dev/usb

2022-04-06 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Wed Apr 6 21:51:29 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c if_smscreg.h if_urtwn.c ubt.c uhub.c ukbd.c usb_subr.c usbdi.c uvideo.c xhci.c xhcireg.h Log Message: remove debug printf To generate a diff of th

CVS commit: src/sys/dev/usb

2022-04-02 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Apr 2 19:19:12 UTC 2022 Modified Files: src/sys/dev/usb: ukbd.c Log Message: Don't attach Yubikeys as console keyboard. To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160 src/sys/dev/usb/ukbd.c Please note th

CVS commit: src/sys/dev/usb

2022-04-02 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Apr 2 19:19:12 UTC 2022 Modified Files: src/sys/dev/usb: ukbd.c Log Message: Don't attach Yubikeys as console keyboard. To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160 src/sys/dev/usb/ukbd.c Please note th

CVS commit: src/sys/dev/usb

2022-03-31 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Mar 31 17:43:50 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: simplify. To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125 src/sys/dev/usb/uhid.c Please note that diffs are not public domain;

CVS commit: src/sys/dev/usb

2022-03-31 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Mar 31 17:43:50 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: simplify. To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125 src/sys/dev/usb/uhid.c Please note that diffs are not public domain;

CVS commit: src/sys/dev/usb

2022-03-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Mar 29 09:08:44 UTC 2022 Modified Files: src/sys/dev/usb: emdtv.c emdtv_dtv.c emdtv_ir.c Log Message: emdtv(4): Fix issues in detach. - Use config_detach_children, and do it up front, and handle failure (not relevant for

CVS commit: src/sys/dev/usb

2022-03-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Mar 29 09:08:44 UTC 2022 Modified Files: src/sys/dev/usb: emdtv.c emdtv_dtv.c emdtv_ir.c Log Message: emdtv(4): Fix issues in detach. - Use config_detach_children, and do it up front, and handle failure (not relevant for

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Mar 29 06:59:19 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: uhid(4): Make sure error is initialized in uhidkqfilter. To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/dev/usb/uhid.c

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Mar 29 06:59:19 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: uhid(4): Make sure error is initialized in uhidkqfilter. To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/dev/usb/uhid.c

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:45:04 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c Log Message: uatp(4): Use usbd_get/set_report for Geyser 3/4 reset. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/uatp.c Pl

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:45:04 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c Log Message: uatp(4): Use usbd_get/set_report for Geyser 3/4 reset. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/uatp.c Pl

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:55 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c Log Message: uatp(4): Fix detach logic. Let wsmouse child decide whether it's in use or close if mandatory. If config_detach_children succeeds, this must no

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:55 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c Log Message: uatp(4): Fix detach logic. Let wsmouse child decide whether it's in use or close if mandatory. If config_detach_children succeeds, this must no

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:45 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Assert uhidev is open when writing. (Maybe we could have uhidevs that are output-only, in which case a driver could, in principle,

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:45 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Assert uhidev is open when writing. (Maybe we could have uhidevs that are output-only, in which case a driver could, in principle,

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:37 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Define UHIDEV_MAXREPID = 255. Report ids are limited by the HID spec to a single byte. - Clamp max report id in report de

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:37 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Define UHIDEV_MAXREPID = 255. Report ids are limited by the HID spec to a single byte. - Clamp max report id in report de

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:28 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Omit needless sc_dying. To generate a diff of this commit: cvs rdiff -u -r1.90 -r1.91 src/sys/dev/usb/uhidev.c Please note that d

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:28 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Omit needless sc_dying. To generate a diff of this commit: cvs rdiff -u -r1.90 -r1.91 src/sys/dev/usb/uhidev.c Please note that d

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:17 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c ucycom.c uhid.c uhidev.c uhidev.h ukbd.c ums.c uthum.c uts.c Log Message: uhidev(9): Make uhidev state opaque. This makes the API simpler and cle

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:17 UTC 2022 Modified Files: src/sys/dev/usb: uatp.c ucycom.c uhid.c uhidev.c uhidev.h ukbd.c ums.c uthum.c uts.c Log Message: uhidev(9): Make uhidev state opaque. This makes the API simpler and cle

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:06 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Fix race between uhidev_close and uhidev_intr. uhidev_intr currently relies on the kernel lock to serialize access to struct uhidev

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:44:06 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Fix race between uhidev_close and uhidev_intr. uhidev_intr currently relies on the kernel lock to serialize access to struct uhidev

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:58 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Refactor error branch to use one label. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.87 -r1

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:58 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Refactor error branch to use one label. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.87 -r1

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:48 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Make some private functions static and fix comment. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.86

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:48 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c Log Message: uhidev(9): Make some private functions static and fix comment. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.86

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:39 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Make uhidev_stop work reliably. To generate a diff of this commit: cvs rdiff -u -r1.85 -r1.86 src/sys/dev/usb/uhidev.c cv

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:39 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Make uhidev_stop work reliably. To generate a diff of this commit: cvs rdiff -u -r1.85 -r1.86 src/sys/dev/usb/uhidev.c cv

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:30 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c Log Message: ucycom(4): Defer uhidev_write_async to taskq. Can't submit USB transfers while holding tty_lock, a spin lock. To generate a diff of this com

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:30 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c Log Message: ucycom(4): Defer uhidev_write_async to taskq. Can't submit USB transfers while holding tty_lock, a spin lock. To generate a diff of this com

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:22 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Move struct uhidev_softc into uhidev.c. No longer part of any ABI for uhidev modules. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:22 UTC 2022 Modified Files: src/sys/dev/usb: uhidev.c uhidev.h Log Message: uhidev(9): Move struct uhidev_softc into uhidev.c. No longer part of any ABI for uhidev modules. To generate a diff of this commit:

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:03 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c uhidev.c uhidev.h Log Message: uhidev(9): New uhidev_write_async. Like uhidev_write but issues the transfer asynchronously with a callback. Use it in ucyc

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:43:03 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c uhidev.c uhidev.h Log Message: uhidev(9): New uhidev_write_async. Like uhidev_write but issues the transfer asynchronously with a callback. Use it in ucyc

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:54 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c uhid.c uhidev.c uhidev.h Log Message: uhidev(9): Partially fix uhidev_write aborting. In my previous change, I intended to make uhidev_stop abort any pendi

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:54 UTC 2022 Modified Files: src/sys/dev/usb: ucycom.c uhid.c uhidev.c uhidev.h Log Message: uhidev(9): Partially fix uhidev_write aborting. In my previous change, I intended to make uhidev_stop abort any pendi

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:45 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: uhid(4): Use d_cfdriver/devtounit/cancel to avoid open/detach races. - Split uhidclose into separate uhidcancel and uhidclose parts. uhidcance

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:45 UTC 2022 Modified Files: src/sys/dev/usb: uhid.c Log Message: uhid(4): Use d_cfdriver/devtounit/cancel to avoid open/detach races. - Split uhidclose into separate uhidcancel and uhidclose parts. uhidcance

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:37 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Rework open/close/attach/detach logic. - Defer sleep after hangup until open. No need to make close hang; we just need to make sure

CVS commit: src/sys/dev/usb

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:42:37 UTC 2022 Modified Files: src/sys/dev/usb: ucom.c Log Message: ucom(4): Rework open/close/attach/detach logic. - Defer sleep after hangup until open. No need to make close hang; we just need to make sure

CVS commit: src/sys/dev/usb

2022-03-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 13:18:30 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Enter the data under the softc lock. This avoids a race with a concurrent ualea_get updating sc_needed, which could lead to hang when

CVS commit: src/sys/dev/usb

2022-03-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 13:18:30 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Enter the data under the softc lock. This avoids a race with a concurrent ualea_get updating sc_needed, which could lead to hang when

CVS commit: src/sys/dev/usb

2022-03-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 13:13:10 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Simplify xfer error branches. - Avoid going into a loop in case the transfer fails repeatedly -- just give up immediately if it fai

CVS commit: src/sys/dev/usb

2022-03-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 13:13:10 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Simplify xfer error branches. - Avoid going into a loop in case the transfer fails repeatedly -- just give up immediately if it fai

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 00:41:01 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Fix detach and error paths. - Set sc_needed before aborting the pipe to prevent the xfer callback from rescheduling itself. - Make

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 00:41:01 UTC 2022 Modified Files: src/sys/dev/usb: ualea.c Log Message: ualea(4): Fix detach and error paths. - Set sc_needed before aborting the pipe to prevent the xfer callback from rescheduling itself. - Make

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 00:40:52 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Make sure aborting a pipe waits for all callbacks. There may be a callback in flight from an xfer that has already been taken off the

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 20 00:40:52 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Make sure aborting a pipe waits for all callbacks. There may be a callback in flight from an xfer that has already been taken off the

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 20:50:32 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb: Insert assertion to diagnose ud_cdesc/ud_ifaces inconsistency. Syzbot found a way to see ud_cdesc=NULL but ud_ifaces!=NULL: https://sy

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 20:50:32 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb: Insert assertion to diagnose ud_cdesc/ud_ifaces inconsistency. Syzbot found a way to see ud_cdesc=NULL but ud_ifaces!=NULL: https://sy

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 20:44:07 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Parse descriptors a little more robustly. Reported-by: syzbot+fd58d1d4dd12f8931...@syzkaller.appspotmail.com To generate a diff of

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 20:44:07 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Parse descriptors a little more robustly. Reported-by: syzbot+fd58d1d4dd12f8931...@syzkaller.appspotmail.com To generate a diff of

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 10:05:52 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix usbd_get_no_alts. This incorrectly rejected the configuration as invalid if any descriptor is not large enough to be interface de

CVS commit: src/sys/dev/usb

2022-03-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 19 10:05:52 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix usbd_get_no_alts. This incorrectly rejected the configuration as invalid if any descriptor is not large enough to be interface de

CVS commit: src/sys/dev/usb

2022-03-14 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 14 16:14:11 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Bail early if no endpoints. kmem_alloc is unhappy with zero-size allocation. Reported-by: syzbot+483b984480c295979...@syzkaller.apps

CVS commit: src/sys/dev/usb

2022-03-14 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 14 16:14:11 UTC 2022 Modified Files: src/sys/dev/usb: umidi.c Log Message: umidi(4): Bail early if no endpoints. kmem_alloc is unhappy with zero-size allocation. Reported-by: syzbot+483b984480c295979...@syzkaller.apps

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 20:44:06 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb: Fix debug build. To generate a diff of this commit: cvs rdiff -u -r1.273 -r1.274 src/sys/dev/usb/usb_subr.c Please note that diffs ar

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 20:44:06 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb: Fix debug build. To generate a diff of this commit: cvs rdiff -u -r1.273 -r1.274 src/sys/dev/usb/usb_subr.c Please note that diffs ar

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 13:18:22 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usbdi(9): Fix mistake in previous change to usbd_fill_iface_data. The previous change stopped and rejected any descriptors smaller than an e

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 13:18:22 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usbdi(9): Fix mistake in previous change to usbd_fill_iface_data. The previous change stopped and rejected any descriptors smaller than an e

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 13:07:39 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix paste-o in previous change to usbd_ar_pipe. To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/sys/dev/usb/usbd

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 13:07:39 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usbdi(9): Fix paste-o in previous change to usbd_ar_pipe. To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/sys/dev/usb/usbd

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 12:49:37 UTC 2022 Modified Files: src/sys/dev/usb: auvitek.c auvitek_audio.c auvitek_dtv.c auvitek_i2c.c auvitek_video.c auvitekvar.h Log Message: auvitek(4): Fix i2c detach if attach failed. While here,

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 12:49:37 UTC 2022 Modified Files: src/sys/dev/usb: auvitek.c auvitek_audio.c auvitek_dtv.c auvitek_i2c.c auvitek_video.c auvitekvar.h Log Message: auvitek(4): Fix i2c detach if attach failed. While here,

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:30:13 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi_util.c Log Message: usb: Parse descriptors a little more robustly. - Avoid reading past the end in the event of bogus bLength. - Avoid arit

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:30:13 UTC 2022 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi_util.c Log Message: usb: Parse descriptors a little more robustly. - Avoid reading past the end in the event of bogus bLength. - Avoid arit

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:30:04 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c xhcivar.h Log Message: xhci(4): Serialize access to portsc registers. Both xhci_roothub_ctrl and xhci_suspend/resume do r/m/w on them, so use a mutex to seri

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:30:04 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c xhcivar.h Log Message: xhci(4): Serialize access to portsc registers. Both xhci_roothub_ctrl and xhci_suspend/resume do r/m/w on them, so use a mutex to seri

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:55 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Restore synchronous abort. In revision 1.155, I made the logic to abort the hardware asynchronous, under the misapprehension that it is

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:55 UTC 2022 Modified Files: src/sys/dev/usb: xhci.c Log Message: xhci(4): Restore synchronous abort. In revision 1.155, I made the logic to abort the hardware asynchronous, under the misapprehension that it is

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:46 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Stop taking the intr lock in uhci_run. Not needed for anything here. To generate a diff of this commit: cvs rdiff -u -r1.314 -r1.315

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:46 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Stop taking the intr lock in uhci_run. Not needed for anything here. To generate a diff of this commit: cvs rdiff -u -r1.314 -r1.315

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:38 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Simplify uhci_run. `locked' is always 0 now. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.313

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:38 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Simplify uhci_run. `locked' is always 0 now. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.313

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:31 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Fix synchronization between suspend/resume and poll hub. - sc_intr_lock is not relevant to anything here -- stop using it. - Never sche

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:31 UTC 2022 Modified Files: src/sys/dev/usb: uhci.c Log Message: uhci(4): Fix synchronization between suspend/resume and poll hub. - sc_intr_lock is not relevant to anything here -- stop using it. - Never sche

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:10 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c ehcivar.h Log Message: ehci(4): Fix doorbell synchronization. ehci_sync_hc was previously subject to spurious wakeup, in which case the CPU might proceed fro

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:10 UTC 2022 Modified Files: src/sys/dev/usb: ehci.c ehcivar.h Log Message: ehci(4): Fix doorbell synchronization. ehci_sync_hc was previously subject to spurious wakeup, in which case the CPU might proceed fro

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:01 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb: Clarify contract of usbd_xfer_trycomplete. No functional change. This rule has always been in place since usbd_xfer_trycomplete was creat

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:29:01 UTC 2022 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb: Clarify contract of usbd_xfer_trycomplete. No functional change. This rule has always been in place since usbd_xfer_trycomplete was creat

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:28:52 UTC 2022 Modified Files: src/sys/dev/usb: usb.c usbdivar.h usbroothub.c Log Message: usb: Fix roothub ctrl xfer aborts. No mechanism for actually aborting, but at least this now waits for the xfer to have c

CVS commit: src/sys/dev/usb

2022-03-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 13 11:28:52 UTC 2022 Modified Files: src/sys/dev/usb: usb.c usbdivar.h usbroothub.c Log Message: usb: Fix roothub ctrl xfer aborts. No mechanism for actually aborting, but at least this now waits for the xfer to have c

<    1   2   3   4   5   6   7   8   9   10   >