Module Name:src
Committed By: riastradh
Date: Wed Sep 11 15:01:11 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvlist.c
Log Message:
libnv: Fix pointer/struct confusion in bounds check.
No impact to NetBSD because the path where this bounds check matters
is n
Module Name:src
Committed By: riastradh
Date: Wed Sep 11 15:01:11 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvlist.c
Log Message:
libnv: Fix pointer/struct confusion in bounds check.
No impact to NetBSD because the path where this bounds check matters
is n
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:57:10 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
libnv: Check for NUL within bounds when unpacking string arrays.
This avoids buffer overrun in the subsequent nv_strdup, which
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:57:10 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
libnv: Check for NUL within bounds when unpacking string arrays.
This avoids buffer overrun in the subsequent nv_strdup, which
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:57:00 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nv_kern_netbsd.c nvlist.c nvpair.c
Log Message:
libnv: Avoid arithmetic overflow in array allocation.
1. Teach nv_calloc and nv_strdup to detect ari
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:57:00 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nv_kern_netbsd.c nvlist.c nvpair.c
Log Message:
libnv: Avoid arithmetic overflow in array allocation.
1. Teach nv_calloc and nv_strdup to detect ari
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:56:47 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvlist.c
Log Message:
libnv: Refuse nonsensically large header size in nvlist_check_header.
This avoids potential integer overflow in nvlist_recv, w
Module Name:src
Committed By: riastradh
Date: Wed Sep 4 12:56:47 UTC 2024
Modified Files:
src/sys/external/bsd/libnv/dist: nvlist.c
Log Message:
libnv: Refuse nonsensically large header size in nvlist_check_header.
This avoids potential integer overflow in nvlist_recv, w
Module Name:src
Committed By: martin
Date: Wed Jul 24 14:25:56 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nv_impl.h nvpair.c
Log Message:
Adapt for userland compilation
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/external/bsd/libnv/
Module Name:src
Committed By: martin
Date: Wed Jul 24 14:25:56 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nv_impl.h nvpair.c
Log Message:
Adapt for userland compilation
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/external/bsd/libnv/
Module Name:src
Committed By: sevan
Date: Wed Jul 24 12:13:13 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
off by 1
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/external/bsd/libnv/dist/nvpair.c
Please note that
Module Name:src
Committed By: sevan
Date: Wed Jul 24 12:13:13 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
off by 1
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/external/bsd/libnv/dist/nvpair.c
Please note that
Module Name:src
Committed By: sevan
Date: Wed Jul 24 11:34:55 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
need sys/kmem.h for kmem_free()
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/external/bsd/libnv/dist/nvpai
Module Name:src
Committed By: sevan
Date: Wed Jul 24 11:34:55 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
need sys/kmem.h for kmem_free()
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/external/bsd/libnv/dist/nvpai
Module Name:src
Committed By: martin
Date: Wed Jul 24 11:12:31 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
PR kern/54406: the result of vasprintf (in the kernel) should be freed
by kmem_free(). Spotted by Mindaugas.
To generate a diff
Module Name:src
Committed By: martin
Date: Wed Jul 24 11:12:31 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nvpair.c
Log Message:
PR kern/54406: the result of vasprintf (in the kernel) should be freed
by kmem_free(). Spotted by Mindaugas.
To generate a diff
Module Name:src
Committed By: rmind
Date: Tue Jul 23 00:49:16 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nv.h nvlist.c nvpair.c
Log Message:
- nvpair_create_stringf: use the in-kernel vasprintf().
- Make nvlist_add_stringf() availabe in the kernel.
To gene
Module Name:src
Committed By: rmind
Date: Tue Jul 23 00:49:16 UTC 2019
Modified Files:
src/sys/external/bsd/libnv/dist: nv.h nvlist.c nvpair.c
Log Message:
- nvpair_create_stringf: use the in-kernel vasprintf().
- Make nvlist_add_stringf() availabe in the kernel.
To gene
On Fri, Feb 15, 2019 at 11:21:51PM +, Mindaugas Rasiukevicius wrote:
> Well, I did run libnv tests as well as NPF tests and they both passed,
> just not on NetBSD. :) Turns out NetBSD libnv and Github libnv code
> bases deviated a little bit, causing a bug in NetBSD (but not upstream).
> Anywa
Martin Husemann wrote:
> Can you try this patch?
>
> rmind: can you *please* run the tests before commiting such changes?
> That would have immediately caught this.
Well, I did run libnv tests as well as NPF tests and they both passed,
just not on NetBSD. :) Turns out NetBSD libnv and Github li
> Can you try this patch?
With the patch I get a different panic:
| # npfctl reload
| panic: kernel diagnostic assertion "(nvp) != ((void *)0)" failed: file
"/home/fstd/qemutest/src/sys/external/bsd/libnv/dist/nvpair.c", line 2140
| cpu0: Begin traceback...
|
vpanic(c15035d4,c94c0b80,c94c0b80,c
Can you try this patch?
rmind: can you *please* run the tests before commiting such changes?
That would have immediately caught this.
Martin
Index: nvlist.c
===
RCS file: /cvsroot/src/sys/external/bsd/libnv/dist/nvlist.c,v
retrievin
This commit (or the following one) gives me the following
panic on 'npfctl reload':
| # npfctl reload
| [ 169.6257771] panic: kmem_free(0xc1fd76a0, 46) != allocated size 4294967295
| [ 169.6361202] cpu0: Begin traceback...
| [ 169.6361202]
vpanic(c14cc1ac,c94e0b30,c94e0b30,c94e0b44,c0bf557e,c14cc
23 matches
Mail list logo
