On Tue, Jul 08, 2025 at 03:56:23PM +, Emmanuel wrote:
> Module Name: src
> Committed By: joe
> Date: Tue Jul 8 15:56:23 UTC 2025
>
> Modified Files:
> src/sys/net/npf: npf_handler.c
>
> Log Message:
> Pass frames directly when no layer 2 rules are set
>
> NPF's original imple
When did it start causing panics ?
Can I get a log of the crash ?
> On 20 Mar 2025, at 9:49 AM, Paul Goyette wrote:
>
> Module Name: src
> Committed By: pgoyette
> Date: Thu Mar 20 09:49:02 UTC 2025
>
> Modified Files:
> src/sys/net/npf: npf_os.c
>
> Log Message:
> Disable auto
On Thu, 20 Mar 2025, Emmanuel Nyarko wrote:
When did it start causing panics ?
sometime between Feb 9 and March 19
Can I get a log of the crash ?
No serial coonsole, but I did transcribe the backtrace:
vpanic
kern_assert
spec_close
VOP_CLOSE
vn_clos
Module Name:src
Committed By: pgoyette
Date: Thu Mar 20 09:49:02 UTC 2025
Modified Files:
src/sys/net/npf: npf_os.c
Log Message:
Disable autounload for the npf module, until we can figure out why
it's causing panic during system startup.
To generate a diff of this commit
Module Name:src
Committed By: pgoyette
Date: Thu Mar 20 09:49:02 UTC 2025
Modified Files:
src/sys/net/npf: npf_os.c
Log Message:
Disable autounload for the npf module, until we can figure out why
it's causing panic during system startup.
To generate a diff of this commit
Module Name:src
Committed By: joe
Date: Fri Feb 7 23:37:46 UTC 2025
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
introduce a kernel boolean assertion to ensure the running thread holds the
mutex
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1
Module Name:src
Committed By: joe
Date: Fri Feb 7 23:37:46 UTC 2025
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
introduce a kernel boolean assertion to ensure the running thread holds the
mutex
To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1
Module Name:src
Committed By: rin
Date: Fri Jul 5 04:34:35 UTC 2024
Modified Files:
src/sys/net/npf: npf_handler.c
Log Message:
npf: Drop redundant NULL check before m_freem(9)
XXX
Their standalone version of m_freem() does not work for NULL input.
I will send pullreq to
Module Name:src
Committed By: rin
Date: Fri Jul 5 04:34:35 UTC 2024
Modified Files:
src/sys/net/npf: npf_handler.c
Log Message:
npf: Drop redundant NULL check before m_freem(9)
XXX
Their standalone version of m_freem() does not work for NULL input.
I will send pullreq to
Module Name:src
Committed By: kardel
Date: Tue Aug 8 16:10:42 UTC 2023
Modified Files:
src/sys/net/npf: npf_ruleset.c
Log Message:
The analysis documented in PR misc/56990 is correct.
Fix by not returning when encountering a ruleset rule.
The code up to now would stop at
Module Name:src
Committed By: kardel
Date: Tue Aug 8 16:10:42 UTC 2023
Modified Files:
src/sys/net/npf: npf_ruleset.c
Log Message:
The analysis documented in PR misc/56990 is correct.
Fix by not returning when encountering a ruleset rule.
The code up to now would stop at
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:03:01 UTC 2023
Modified Files:
src/sys/net/npf: npf_nat.c npf_rproc.c npf_tableset.c
Log Message:
npf: Eliminate __HAVE_ATOMIC_AS_MEMBAR conditionals.
Discussed on tech-kern:
https://mail-index.netbsd.org/tech-ke
Module Name:src
Committed By: riastradh
Date: Fri Feb 24 11:03:01 UTC 2023
Modified Files:
src/sys/net/npf: npf_nat.c npf_rproc.c npf_tableset.c
Log Message:
npf: Eliminate __HAVE_ATOMIC_AS_MEMBAR conditionals.
Discussed on tech-kern:
https://mail-index.netbsd.org/tech-ke
Module Name:src
Committed By: kardel
Date: Sun Feb 12 13:38:37 UTC 2023
Modified Files:
src/sys/net/npf: npf.h npf_mbuf.c npf_sendpkt.c
Log Message:
PR kern/56052:
allow block-return packets passed through without rule matching.
Included up-stream as https://github.com/rmi
Module Name:src
Committed By: kardel
Date: Sun Feb 12 13:38:37 UTC 2023
Modified Files:
src/sys/net/npf: npf.h npf_mbuf.c npf_sendpkt.c
Log Message:
PR kern/56052:
allow block-return packets passed through without rule matching.
Included up-stream as https://github.com/rmi
Module Name:src
Committed By: riastradh
Date: Mon Jan 23 13:40:05 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Drop table lock around copyout.
It is forbidden to hold a spin lock around copyout, and t_lock is a
spin lock.
We need t_lock i
Module Name:src
Committed By: riastradh
Date: Mon Jan 23 13:40:05 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Drop table lock around copyout.
It is forbidden to hold a spin lock around copyout, and t_lock is a
spin lock.
We need t_lock i
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:45:43 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Another comment tweak to match upstream.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 s
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:45:43 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Another comment tweak to match upstream.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 s
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:39:35 UTC 2023
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
npf(9): Update comment to reduce diff from upstream.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 s
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:39:35 UTC 2023
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
npf(9): Update comment to reduce diff from upstream.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 s
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:39:22 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Use __HAVE_ATOMIC_AS_MEMBAR around refcnt consistently.
To generate a diff of this commit:
cvs rdiff -u -r1.38 -r1.39 src/sys/n
Module Name:src
Committed By: riastradh
Date: Sun Jan 22 18:39:22 UTC 2023
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
npf(9): Use __HAVE_ATOMIC_AS_MEMBAR around refcnt consistently.
To generate a diff of this commit:
cvs rdiff -u -r1.38 -r1.39 src/sys/n
Module Name:src
Committed By: martin
Date: Thu Apr 28 17:28:15 UTC 2022
Modified Files:
src/sys/net/npf: npf_params.c
Log Message:
Make the thmap(9) used for params use sleepable allocations,
suggested by rmind@. Should fix PR 56802.
To generate a diff of this commit:
cv
Module Name:src
Committed By: martin
Date: Thu Apr 28 17:28:15 UTC 2022
Modified Files:
src/sys/net/npf: npf_params.c
Log Message:
Make the thmap(9) used for params use sleepable allocations,
suggested by rmind@. Should fix PR 56802.
To generate a diff of this commit:
cv
Module Name:src
Committed By: martin
Date: Thu Apr 28 15:43:51 UTC 2022
Modified Files:
src/sys/net/npf: npf_params.c
Log Message:
Temporary hack to make PR 56802 (when it happens) tell us for sure that
it is caused by KM_NOSLEEP memory allocation failure.
To generate a
Module Name:src
Committed By: martin
Date: Thu Apr 28 15:43:51 UTC 2022
Modified Files:
src/sys/net/npf: npf_params.c
Log Message:
Temporary hack to make PR 56802 (when it happens) tell us for sure that
it is caused by KM_NOSLEEP memory allocation failure.
To generate a
Module Name:src
Committed By: riastradh
Date: Sun Feb 13 19:20:23 UTC 2022
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
npf(4): Use atomic_store_release and atomic_load_consume for conn_db.
...or atomic_load_relaxed, when npf->conn_lock is held, for the sake
o
Module Name:src
Committed By: riastradh
Date: Sun Feb 13 19:20:23 UTC 2022
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
npf(4): Use atomic_store_release and atomic_load_consume for conn_db.
...or atomic_load_relaxed, when npf->conn_lock is held, for the sake
o
Module Name:src
Committed By: riastradh
Date: Sun Feb 13 19:20:11 UTC 2022
Modified Files:
src/sys/net/npf: npf_conf.c npf_ifaddr.c
Log Message:
npf(4): Use atomic_store_release and atomic_load_consume for config.
...or atomic_load_relaxed, when the config is locked. (No
Module Name:src
Committed By: riastradh
Date: Sun Feb 13 19:20:11 UTC 2022
Modified Files:
src/sys/net/npf: npf_conf.c npf_ifaddr.c
Log Message:
npf(4): Use atomic_store_release and atomic_load_consume for config.
...or atomic_load_relaxed, when the config is locked. (No
Module Name:src
Committed By: rmind
Date: Mon Sep 30 22:04:33 UTC 2019
Modified Files:
src/sys/net/npf: npf_if.c
Log Message:
npf_ifmap_copylogname: be more defensive.
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/net/npf/npf_if.c
Please note tha
Module Name:src
Committed By: rmind
Date: Mon Sep 30 22:04:33 UTC 2019
Modified Files:
src/sys/net/npf: npf_if.c
Log Message:
npf_ifmap_copylogname: be more defensive.
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/net/npf/npf_if.c
Please note tha
Module Name:src
Committed By: rmind
Date: Sun Sep 29 17:00:29 UTC 2019
Modified Files:
src/sys/net/npf: npf_conn.c npf_if.c npf_impl.h npf_ruleset.c
Log Message:
NPF ifmap: rework and fix a few small bugs.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src
Module Name:src
Committed By: rmind
Date: Sun Sep 29 17:00:29 UTC 2019
Modified Files:
src/sys/net/npf: npf_conn.c npf_if.c npf_impl.h npf_ruleset.c
Log Message:
NPF ifmap: rework and fix a few small bugs.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src
Module Name:src
Committed By: christos
Date: Thu Sep 26 18:44:45 UTC 2019
Modified Files:
src/sys/net/npf: npf_mbuf.c
Log Message:
Cast m_mbuflen() result to "size_t". It could also be "u_int" since it is
assigned to "u_int", but all the other "standalone" equivalent funct
Module Name:src
Committed By: christos
Date: Thu Sep 26 18:44:45 UTC 2019
Modified Files:
src/sys/net/npf: npf_mbuf.c
Log Message:
Cast m_mbuflen() result to "size_t". It could also be "u_int" since it is
assigned to "u_int", but all the other "standalone" equivalent funct
Module Name:src
Committed By: rmind
Date: Sun Aug 25 17:38:25 UTC 2019
Modified Files:
src/sys/net/npf: npf_ctl.c npf_impl.h npf_os.c
Log Message:
ake npfctl_switch() and pfil private to OS-specific module.
To generate a diff of this commit:
cvs rdiff -u -r1.57 -r1.58 s
Module Name:src
Committed By: rmind
Date: Sun Aug 25 17:38:25 UTC 2019
Modified Files:
src/sys/net/npf: npf_ctl.c npf_impl.h npf_os.c
Log Message:
ake npfctl_switch() and pfil private to OS-specific module.
To generate a diff of this commit:
cvs rdiff -u -r1.57 -r1.58 s
Le 06/08/2019 à 12:31, Christos Zoulas a écrit :
I did not see any messages about it, and the fix is fine until rmind comes up
with something better.
Yes turns out it was an off-list email
It is not nice to have HEAD unusable for 2 weeks now (since July 22nd).
Given your second commit, I s
Yes, rmind asked me to commit the change in private email.
christos
> On Aug 6, 2019, at 3:59 PM, Maxime Villard wrote:
>
> Le 06/08/2019 à 12:31, Christos Zoulas a écrit :
>> I did not see any messages about it, and the fix is fine until rmind comes
>> up with something better.
>
> Yes turns
Module Name:src
Committed By: christos
Date: Tue Aug 6 11:40:15 UTC 2019
Modified Files:
src/sys/net/npf: npf.c npf_conn.c npf_conn.h
Log Message:
- npf_conn_init(): fix a race when initialising the G/C thread.
- Fix a bug when partially initialised connection is destroye
Module Name:src
Committed By: christos
Date: Tue Aug 6 11:40:15 UTC 2019
Modified Files:
src/sys/net/npf: npf.c npf_conn.c npf_conn.h
Log Message:
- npf_conn_init(): fix a race when initialising the G/C thread.
- Fix a bug when partially initialised connection is destroye
I did not see any messages about it, and the fix is fine until rmind comes up
with something better.
It is not nice to have HEAD unusable for 2 weeks now (since July 22nd).
christos
> On Aug 6, 2019, at 1:26 PM, Maxime Villard wrote:
>
> Le 06/08/2019 à 12:25, Christos Zoulas a écrit :
>> Modu
Le 06/08/2019 à 12:25, Christos Zoulas a écrit :
Module Name:src
Committed By: christos
Date: Tue Aug 6 10:25:13 UTC 2019
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
Introduce an npf_conn_destroy_idx() that can handle partially constructed
conn structures.
Module Name:src
Committed By: christos
Date: Tue Aug 6 10:25:13 UTC 2019
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
Introduce an npf_conn_destroy_idx() that can handle partially constructed
conn structures.
To generate a diff of this commit:
cvs rdiff -u -
Module Name:src
Committed By: christos
Date: Tue Aug 6 10:25:13 UTC 2019
Modified Files:
src/sys/net/npf: npf_conn.c
Log Message:
Introduce an npf_conn_destroy_idx() that can handle partially constructed
conn structures.
To generate a diff of this commit:
cvs rdiff -u -
Module Name:src
Committed By: rmind
Date: Thu Jul 25 01:00:28 UTC 2019
Modified Files:
src/sys/net/npf: npf_portmap.c
Log Message:
npf_portmap_flush: remove invalid assert (this routine can be callied via
the npf_destroy() path where the constraint is not applicable).
To
Module Name:src
Committed By: rmind
Date: Thu Jul 25 01:00:28 UTC 2019
Modified Files:
src/sys/net/npf: npf_portmap.c
Log Message:
npf_portmap_flush: remove invalid assert (this routine can be callied via
the npf_destroy() path where the constraint is not applicable).
To
Module Name:src
Committed By: rmind
Date: Tue Jul 23 08:25:52 UTC 2019
Modified Files:
src/sys/net/npf: npf_portmap.c
Log Message:
NPF portmap: add a workaround for archs without 64-bit CAS.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/net/npf/npf_
Module Name:src
Committed By: rmind
Date: Tue Jul 23 08:25:52 UTC 2019
Modified Files:
src/sys/net/npf: npf_portmap.c
Log Message:
NPF portmap: add a workaround for archs without 64-bit CAS.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/net/npf/npf_
Module Name:src
Committed By: christos
Date: Thu Jun 20 17:12:37 UTC 2019
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
Add error checking for previous memory allocation failure.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/net/npf
Module Name:src
Committed By: christos
Date: Thu Jun 20 17:12:37 UTC 2019
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
Add error checking for previous memory allocation failure.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/net/npf
Module Name:src
Committed By: christos
Date: Thu Jun 20 17:08:52 UTC 2019
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
PR/54314: Frank Kardel: LOCKDEBUG: Mutex error: assert_sleepable,70:
spin lock held when loading NPF
To generate a diff of this commit:
Module Name:src
Committed By: christos
Date: Thu Jun 20 17:08:52 UTC 2019
Modified Files:
src/sys/net/npf: npf_tableset.c
Log Message:
PR/54314: Frank Kardel: LOCKDEBUG: Mutex error: assert_sleepable,70:
spin lock held when loading NPF
To generate a diff of this commit:
Module Name:src
Committed By: christos
Date: Wed Jun 12 14:36:32 UTC 2019
Modified Files:
src/sys/net/npf: lpm.c lpm.h npf_tableset.c
Log Message:
Avoid LOCKDEBUG pserialize panic by implementing suggestion #1 from
http://mail-index.netbsd.org/current-users/2019/02/24
Module Name:src
Committed By: christos
Date: Wed Jun 12 14:36:32 UTC 2019
Modified Files:
src/sys/net/npf: lpm.c lpm.h npf_tableset.c
Log Message:
Avoid LOCKDEBUG pserialize panic by implementing suggestion #1 from
http://mail-index.netbsd.org/current-users/2019/02/24
Le 07/04/2018 à 23:28, Christos Zoulas a écrit :
In article <20180407090627.20058f...@cvs.netbsd.org>,
Maxime Villard wrote:
-=-=-=-=-=-
Module Name:src
Committed By: maxv
Date: Sat Apr 7 09:06:27 UTC 2018
Modified Files:
src/sys/net/npf: npf_inet.c
Log Message:
Rewr
In article <20180407090627.20058f...@cvs.netbsd.org>,
Maxime Villard wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: maxv
>Date: Sat Apr 7 09:06:27 UTC 2018
>
>Modified Files:
> src/sys/net/npf: npf_inet.c
>
>Log Message:
>Rewrite npf_fetch_tcpopts:
>
> * Instead of doing
Le 31/01/2018 à 00:18, Mindaugas Rasiukevicius a écrit :
[...]
Fix this by using uint32_t. While here, it seems to me there is also a
memory overflow: still in npf_cache_ip, npc_hlen may be incremented with
a value that goes beyond the mbuf.
[...]
If the npc_hlen value is beyond the packet leng
"Maxime Villard" wrote:
> Module Name: src
> Committed By: maxv
> Date: Fri Dec 15 21:00:26 UTC 2017
>
> Modified Files:
> src/sys/net/npf: npf.h
>
> Log Message:
> Fix a vulnerability in NPF, that allows whatever incoming IPv6 packet to
> bypass a certain number of filtering rule
In article <20151019002957.b972...@cvs.netbsd.org>,
Christos Zoulas wrote:
>Log Message:
>Fix the code so that it works in all 3 cases: non-modular, modular/builtin,
>modular/filesystem. In the non-modular case we initialize through attach.
>In the modular/builtin case we define the module to be c
On Tue, 29 Oct 2013, Mindaugas Rasiukevicius wrote:
npf_session_setnat: fix the race condition when the old connection is
still being expired while a new/duplicate is being created.
Should we have (or do we have) a regression test to catch this race
condition?
You would need to write a test
Paul Goyette wrote:
> On Tue, 29 Oct 2013, Mindaugas Rasiukevicius wrote:
>
> > Module Name:src
> > Committed By: rmind
> > Date: Tue Oct 29 16:39:10 UTC 2013
> >
> > Modified Files:
> > src/sys/net/npf: npf_impl.h npf_nat.c npf_session.c
> >
> > Log Message:
> > n
On Tue, 29 Oct 2013, Mindaugas Rasiukevicius wrote:
Module Name:src
Committed By: rmind
Date: Tue Oct 29 16:39:10 UTC 2013
Modified Files:
src/sys/net/npf: npf_impl.h npf_nat.c npf_session.c
Log Message:
npf_session_setnat: fix the race condition when the old connection
65 matches
Mail list logo
