Re: CVS commit: src/tests/syscall

2011-07-03 Thread David Holland
On Sun, Jul 03, 2011 at 08:22:51PM +, Jukka Ruohonen wrote: Modified Files: src/tests/syscall: t_mknod.c Log Message: Remove wrong check. XXX: Why does this fail on tmpfs but not ffs? That *should* fail. Probably ffs is failing to check. -- David A. Holland

Re: CVS commit: src/tests/syscall

2011-07-03 Thread Jukka Ruohonen
On Sun, Jul 03, 2011 at 11:45:24PM +, David Holland wrote: On Sun, Jul 03, 2011 at 08:22:51PM +, Jukka Ruohonen wrote: Modified Files: src/tests/syscall: t_mknod.c Log Message: Remove wrong check. XXX: Why does this fail on tmpfs but not ffs? That *should*

Re: CVS commit: src/tests/syscall

2011-05-29 Thread Julio Merino
On 5/29/11 1:57 PM, Matthias Scheler wrote: Modified Files: src/tests/syscall: t_pollts.c Log Message: [...] Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid crashes if one of the required conditions isn't met. It could be a bug in the macro. I tried changing the

Re: CVS commit: src/tests/syscall

2011-05-29 Thread Matthias Scheler
On Sun, May 29, 2011 at 02:57:14PM +0100, Julio M. Merino Vidal wrote: On 5/29/11 1:57 PM, Matthias Scheler wrote: Modified Files: src/tests/syscall: t_pollts.c Log Message: [...] Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid crashes if one of the required

Re: CVS commit: src/tests/syscall

2011-05-28 Thread Matthias Scheler
On Sat, May 28, 2011 at 11:34:49AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat May 28 15:34:49 UTC 2011 Modified Files: src/tests/syscall: t_pselect.c Log Message: add a timeout test Your tests don't pass on my setup: t_pselect

Re: CVS commit: src/tests/syscall

2011-05-28 Thread Christos Zoulas
In article 20110528161614.ga71...@colwyn.zhadum.org.uk, Matthias Scheler t...@zhadum.org.uk wrote: On Sat, May 28, 2011 at 11:34:49AM -0400, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Sat May 28 15:34:49 UTC 2011 Modified Files:

Re: CVS commit: src/tests/syscall

2011-05-22 Thread Julio Merino
On 5/22/11 12:48 AM, Christos Zoulas wrote: On May 22, 12:28am, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | That's what was done. But in order to enforce the timeouts et. al. this | library had to fork() on every test case. This was really, really

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On Wed, May 18, 2011 at 12:30:24PM +, Christos Zoulas wrote: In article 4dd39547.9010...@julipedia.org, Julio Merino j...@julipedia.org wrote: On 5/18/11 4:15 AM, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed May 18 03:15:12 UTC 2011

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
In article 20110521083602.ga24...@netbsd.org, Julio Merino j...@netbsd.org wrote: On Wed, May 18, 2011 at 12:30:24PM +, Christos Zoulas wrote: In article 4dd39547.9010...@julipedia.org, Julio Merino j...@julipedia.org wrote: On 5/18/11 4:15 AM, Christos Zoulas wrote: Module Name:

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On 5/21/11 3:19 PM, Christos Zoulas wrote: In article20110521083602.ga24...@netbsd.org, Julio Merinoj...@netbsd.org wrote: 1. It did not work. What units is the timeout anyway? I waited 2 seconds and 2 minutes and it did not fire. It's in seconds. The default is 300. I think the unit

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
On May 21, 3:34pm, j...@netbsd.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | On 5/21/11 3:19 PM, Christos Zoulas wrote: | In article20110521083602.ga24...@netbsd.org, | Julio Merinoj...@netbsd.org wrote: | 1. It did not work. What units is the timeout anyway? I

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Manuel Bouyer
On Sat, May 21, 2011 at 03:34:22PM +0100, Julio Merino wrote: Yes, the timeout thing is broken. It should really be a specification of the test case size (e.g. 'small', 'large') and allow the user to define his timeout preferences for every class, because they will vary from machine to

Re: CVS commit: src/tests/syscall

2011-05-21 Thread David Laight
On Sat, May 21, 2011 at 05:14:07PM +0200, Manuel Bouyer wrote: On Sat, May 21, 2011 at 03:34:22PM +0100, Julio Merino wrote: Yes, the timeout thing is broken. It should really be a specification of the test case size (e.g. 'small', 'large') and allow the user to define his timeout

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
On May 21, 5:25pm, da...@l8s.co.uk (David Laight) wrote: -- Subject: Re: CVS commit: src/tests/syscall | On Sat, May 21, 2011 at 05:14:07PM +0200, Manuel Bouyer wrote: | On Sat, May 21, 2011 at 03:34:22PM +0100, Julio Merino wrote: | Yes, the timeout thing is broken. It should really

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On 5/21/11 5:25 PM, David Laight wrote: On Sat, May 21, 2011 at 05:14:07PM +0200, Manuel Bouyer wrote: On Sat, May 21, 2011 at 03:34:22PM +0100, Julio Merino wrote: Yes, the timeout thing is broken. It should really be a specification of the test case size (e.g. 'small', 'large') and allow

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On 05/21/11 15:44, Christos Zoulas wrote: On May 21, 3:34pm, j...@netbsd.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | On 5/21/11 3:19 PM, Christos Zoulas wrote: | Revert the latest revision in the test and boot a kernel before the pselect | changes, and see

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
On May 21, 9:26pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | On 05/21/11 15:44, Christos Zoulas wrote: | On May 21, 3:34pm, j...@netbsd.org (Julio Merino) wrote: | -- Subject: Re: CVS commit: src/tests/syscall | | | On 5/21/11 3:19 PM

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On 05/21/11 21:58, Christos Zoulas wrote: On May 21, 9:26pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | Just to make sure we are talking about the same: you were running the | test program with atf-run; correct? If yes, what platform

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
On May 21, 10:31pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | Sounds like a good idea. Note that there is *many* more things that | will not work. The test case will dump garbage in the current directory | and it won't be cleaned, the environment

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Julio Merino
On 5/22/11 12:18 AM, Christos Zoulas wrote: On May 21, 10:31pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | Sounds like a good idea. Note that there is *many* more things that | will not work. The test case will dump garbage in the current

Re: CVS commit: src/tests/syscall

2011-05-21 Thread Christos Zoulas
On May 22, 12:28am, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/tests/syscall | atf-test-case(4) contains a description of these. (Yeah, it could be | improved.) Good. | I don't see why. You just put it all in a shared library written in c and | used from c

Re: CVS commit: src/tests/syscall

2011-05-18 Thread Julio Merino
On 5/18/11 4:15 AM, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Wed May 18 03:15:12 UTC 2011 Modified Files: src/tests/syscall: t_pselect.c Log Message: Don't depend on the atf timeout stuff, do it ourselves. Why? Could atf do something better

Re: CVS commit: src/tests/syscall

2011-05-18 Thread Christos Zoulas
In article 4dd39547.9010...@julipedia.org, Julio Merino j...@julipedia.org wrote: On 5/18/11 4:15 AM, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Wed May 18 03:15:12 UTC 2011 Modified Files: src/tests/syscall: t_pselect.c Log Message:

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Nicolas Joly
On Mon, Apr 04, 2011 at 08:32:14AM +0300, Jukka Ruohonen wrote: On Mon, Apr 04, 2011 at 01:59:50AM +, Christos Zoulas wrote: Check for getuid(2) == 0. Why not setuid() to fix it? That would indeed be the right thing to do. However, I am not quite sure how atf(7) actually works. It

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Jukka Ruohonen
On Mon, Apr 04, 2011 at 09:05:19AM +0200, Nicolas Joly wrote: Adding the following to the testcase header should do the trick: atf_tc_set_md_var(tc,require.user,unprivileged); In that case, if run as root, it will lower its privileges to the unprivileged user _atf before running the

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Nicolas Joly
On Mon, Apr 04, 2011 at 10:18:52AM +0300, Jukka Ruohonen wrote: On Mon, Apr 04, 2011 at 09:05:19AM +0200, Nicolas Joly wrote: Adding the following to the testcase header should do the trick: atf_tc_set_md_var(tc,require.user,unprivileged); In that case, if run as root, it will

Re: CVS commit: src/tests/syscall

2011-04-04 Thread Jukka Ruohonen
On Mon, Apr 04, 2011 at 09:05:19AM +0200, Nicolas Joly wrote: Adding the following to the testcase header should do the trick: atf_tc_set_md_var(tc,require.user,unprivileged); In that case, if run as root, it will lower its privileges to the unprivileged user _atf before running the

Re: CVS commit: src/tests/syscall

2011-04-03 Thread Christos Zoulas
In article 20110404014946.4b9e917...@cvs.netbsd.org, Jukka Ruohonen source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: jruoho Date: Mon Apr 4 01:49:45 UTC 2011 Modified Files: src/tests/syscall: t_access.c Log Message: Check for getuid(2) == 0.