Re: CVS commit: src/usr.bin/make

Taylor R Campbell wrote: > Can you please back this out promptly, add automatic tests for > whatever the underlying issue is, and redo it another way? I did a scan of miss-use of <>, and looks like libc might have an issue: lib/libc/arch/arm/Makefile.inc:28:.include expects to find

Re: CVS commit: src/usr.bin/make

Taylor R Campbell wrote: > > --- cleandir-libterminfo --- > nbmake[5]: "/tmp/build/2024.05.19.20.09.40-i386/src/lib/libterminfo/Makefile" > line 50: Could not find Makefile.hash > > Can you please back this out promptly, add automatic tests for > whatever the underlying issue is, and redo it

Re: CVS commit: src/usr.bin/make

> Module Name:src > Committed By: sjg > Date: Sun May 19 20:09:40 UTC 2024 > > Modified Files: > src/usr.bin/make: dir.c dir.h parse.c > > Log Message: > make: use separate function to include makefiles. > > Have Dir_FindFile and Dir_FindInclude call FindFile with a >

Re: CVS commit: src/usr.bin/make

On Thu, 25 Jan 2024 20:02:00 +0100, Roland Illig writes: >>> Modified Files: >>> src/usr.bin/make: make.1 >>> >>> Log Message: >>> Indicate that for :U newval is optional >> >> I think this is more confusing than helpful. > >I agree. Make doesn't distinguish between an empty string and an

Re: CVS commit: src/usr.bin/make

On Thu, 25 Jan 2024 21:12:20 +0100, Roland Illig writes: >them all. Due to this, I'd go with: > >> .It Cm \&:U\| Ns Ar newval >> If the variable is undefined, >> .Ar newval >> (which may be empty) is the value. That's almost exactly what I had in my 1st cut ;-) Will do. >Then, add the same

Re: CVS commit: src/usr.bin/make

About optional arguments to modifiers, such as in ${VAR:U}: Am 25.01.2024 um 20:54 schrieb Simon Gerraty: > Is there perhaps a general statement somewhere (I may have missed it) > that could cover all these and be cited to pedantic users? > Eg to the effect of perhaps, unless stated otherwise

Re: CVS commit: src/usr.bin/make

Am 25.01.2024 um 14:25 schrieb Valery Ushakov: > On Thu, Jan 25, 2024 at 07:35:46 +, Simon J. Gerraty wrote: > >> Modified Files: >> src/usr.bin/make: make.1 >> >> Log Message: >> Indicate that for :U newval is optional > > I think this is more confusing than helpful. I agree. Make

Re: CVS commit: src/usr.bin/make

On Fri, Sep 8, 2023 at 21:38 matthew green wrote: > Module Name:src > Committed By: mrg > Date: Sat Sep 9 04:38:49 UTC 2023 > > Modified Files: > src/usr.bin/make: main.c > > Log Message: > add explicit cast for long -> int truncation warning-as-error. > > as this is

Re: CVS commit: src/usr.bin/make

Taylor R Campbell wrote: > That said, I don't see any reason why this should be a macro in the > first place. If there is a compelling reason, please write it down; > if not, please change it to a static function: > Sure. > static BuildMon * > BM(Job *job) > { > > return (job != NULL

Re: CVS commit: src/usr.bin/make

> Module Name:src > Committed By: sjg > Date: Sat Feb 25 22:52:22 UTC 2023 > > Modified Files: > src/usr.bin/make: meta.c > > Log Message: > meta.c: use macro to access job->bm > > and if job is NULL use Mybm. > +#define BM(job) (job != NULL) ? >bm : If this must be a

Re: CVS commit: src/usr.bin/make

Date:Mon, 10 Oct 2022 17:33:35 + From:"Roland Illig" Message-ID: <20221010173335.c3cccf...@cvs.netbsd.org> | Document only the POSIX requirement for now, as I didn't find | information about _which_ ancient UNIX systems would corrupt the | filesystem on

Re: CVS commit: src/usr.bin/make

In article <20220928163447.b0bf6f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Wed Sep 28 16:34:47 UTC 2022 > >Modified Files: > src/usr.bin/make: main.c meta.c > >Log Message: >Don't ignore return from snprintf or getcwd

Re: CVS commit: src/usr.bin/make

Am 14.08.2022 um 12:14 schrieb Valeriy E. Ushakov: Module Name:src Committed By: uwe Date: Sun Aug 14 10:14:58 UTC 2022 Modified Files: src/usr.bin/make: make.1 Thanks for your corrections and improvements, now that I see them they are obvious. :) Roland

Re: CVS commit: src/usr.bin/make

> On Jan 30, 2022, at 2:41 PM, Roland Illig wrote: > > Am 30.01.2022 um 14:21 schrieb Christos Zoulas: >> Module Name: src >> Committed By:christos >> Date:Sun Jan 30 13:21:09 UTC 2022 >> >> Modified Files: >> src/usr.bin/make: dir.c job.c make.h >> >> Log

Re: CVS commit: src/usr.bin/make

Am 30.01.2022 um 20:54 schrieb Christos Zoulas: On Jan 30, 2022, at 2:41 PM, Roland Illig mailto:roland.il...@gmx.de>> wrote: Am 30.01.2022 um 14:21 schrieb Christos Zoulas: Module Name:src Committed By:christos Date:Sun Jan 30 13:21:09 UTC 2022 Modified Files: src/usr.bin/make: dir.c job.c

Re: CVS commit: src/usr.bin/make

On Sun, 30 Jan 2022 14:54:25 -0500, Christos Zoulas writes: >> Since usr.bin/make is also used in tools/make, it needs to follow the >> rules in tools/README, which say that all tools should stick to C89. >> The format specifier %zu comes from C99 though. > >Yes, %zu is annoying because windows

Re: CVS commit: src/usr.bin/make

Am 30.01.2022 um 14:21 schrieb Christos Zoulas: Module Name:src Committed By: christos Date: Sun Jan 30 13:21:09 UTC 2022 Modified Files: src/usr.bin/make: dir.c job.c make.h Log Message: Make the GNode lineno unsigned to fix lint warning in var.c calling

Re: CVS commit: src/usr.bin/make

Am 09.01.2022 um 23:04 schrieb Joerg Sonnenberger: On Fri, Jan 07, 2022 at 08:04:49PM +, Roland Illig wrote: Module Name:src Committed By: rillig Date: Fri Jan 7 20:04:49 UTC 2022 Modified Files: src/usr.bin/make: for.c Log Message: make: use simpler code for

Re: CVS commit: src/usr.bin/make

On Fri, Jan 07, 2022 at 08:04:49PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Fri Jan 7 20:04:49 UTC 2022 > > Modified Files: > src/usr.bin/make: for.c > > Log Message: > make: use simpler code for handling .for loops This seems backwards to me.

Re: CVS commit: src/usr.bin/make

On Sun, Jan 09, 2022 at 01:18:32AM +0100, Roland Illig wrote: > If I were to extract the newly added code into a function call > cpp_skip_string(, varname), would that help? That function could be > used in var.c as well, for example in ModMatch and ModMatchEq. Yes, it should be a utility

Re: CVS commit: src/usr.bin/make

Am 08.01.2022 um 23:54 schrieb nia: On Fri, Jan 07, 2022 at 08:04:49PM +, Roland Illig wrote: Using memcmp for comparing the variable name was probably overkill since the variable names are usually very short, so rather compare them byte by byte. I don't see the point of this change - it

Re: CVS commit: src/usr.bin/make

On Fri, Jan 07, 2022 at 08:04:49PM +, Roland Illig wrote: > Using memcmp for comparing the variable name was probably overkill since > the variable names are usually very short, so rather compare them byte > by byte. I don't see the point of this change - it makes the code harder to read. We

Re: CVS commit: src/usr.bin/make

Date:Fri, 10 Dec 2021 01:36:10 +0100 (GMT+01:00) From:Roland Illig Message-ID: | I guess there's really no way around running the whole build before each | commit, to reach a build success rate of 99.9 %. What I tend to do, where possible, is make a bunch of

Re: CVS commit: src/usr.bin/make

10.12.2021 01:07:22 Robert Elz : >     Date:    Thu, 9 Dec 2021 22:25:58 + >     From:    "Roland Illig" >     Message-ID:  <20211209222558.cdf22f...@cvs.netbsd.org> >   | No functional change. > > That obviously wasn't true.   That means that you just guessed at that, I cannot

Re: CVS commit: src/usr.bin/make/unit-tests

Date:Thu, 9 Dec 2021 23:57:19 + From:"Roland Illig" Message-ID: <20211209235719.cde20f...@cvs.netbsd.org> | Log Message: | tests/make: prevent the bug from cond.c 1.283 from happening again This new test (while OK of itself) would not have done that. I

Re: CVS commit: src/usr.bin/make

Date:Thu, 9 Dec 2021 22:25:58 + From:"Roland Illig" Message-ID: <20211209222558.cdf22f...@cvs.netbsd.org> | make: avoid recursion in CondParser_Or | | Previously, a long chain of '1 || 1 || 1 || 1 || ...' led to a deep | recursion. Furhermore, the code

re: CVS commit: src/usr.bin/make

Roland Illig writes: > Am 09.12.2021 um 21:01 schrieb matthew green: > > i'm not asking that you make sun2 or vax stuff work, but > > some of us choose to use jemalloc 100 on all builds and > > since this is a supported option, i wanted to make sure > > you were aware of it. > > I added back the

Re: CVS commit: src/usr.bin/make

Am 09.12.2021 um 21:01 schrieb matthew green: i'm not asking that you make sun2 or vax stuff work, but some of us choose to use jemalloc 100 on all builds and since this is a supported option, i wanted to make sure you were aware of it. I added back the support for jemalloc 100, the few extra

re: CVS commit: src/usr.bin/make

Roland Illig writes: > Am 08.12.2021 um 02:09 schrieb matthew green: > >> Module Name: src > >> Committed By: rillig > >> Date: Sun Dec 5 14:57:36 UTC 2021 > >> > >> Modified Files: > >>src/usr.bin/make: test-variants.sh > >>src/usr.bin/make/unit-tests: Makefile

Re: CVS commit: src/usr.bin/make

Am 08.12.2021 um 02:09 schrieb matthew green: Module Name:src Committed By: rillig Date: Sun Dec 5 14:57:36 UTC 2021 Modified Files: src/usr.bin/make: test-variants.sh src/usr.bin/make/unit-tests: Makefile export.mk opt-file.mk Log Message: tests/make: migrate

re: CVS commit: src/usr.bin/make

> Module Name: src > Committed By: rillig > Date: Sun Dec 5 14:57:36 UTC 2021 > > Modified Files: > src/usr.bin/make: test-variants.sh > src/usr.bin/make/unit-tests: Makefile export.mk opt-file.mk > > Log Message: > tests/make: migrate to jemalloc > 100 note that the build

Re: CVS commit: src/usr.bin/make

On 27.01.2021 20:54, Reinoud Zandijk wrote: Hi, On Tue, Jan 26, 2021 at 11:44:56PM +, Roland Illig wrote: Module Name:src Committed By: rillig Date: Tue Jan 26 23:44:56 UTC 2021 Modified Files: src/usr.bin/make: parse.c src/usr.bin/make/unit-tests:

Re: CVS commit: src/usr.bin/make

Hi, On Tue, Jan 26, 2021 at 11:44:56PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Tue Jan 26 23:44:56 UTC 2021 > > Modified Files: > src/usr.bin/make: parse.c > src/usr.bin/make/unit-tests: include-main.exp include-subsub.mk > > Log

Re: CVS commit: src/usr.bin/make

On Tue, Jan 26, 2021 at 11:39:52PM +0100, Roland Illig wrote: > The code of usr.bin/make gets distributed to a wider audience by Simon's > bmake distribution (http://www.crufty.net/help/sjg/bmake.html), that's > where the requirement of supporting C89 compilers comes from. At the > time I

Re: CVS commit: src/usr.bin/make

On 26.01.2021 21:04, Christos Zoulas wrote: Yes, and I did not push for it for the exact reasons stated below: There was only a handful of cases and those can be handled with casts or a macro for now. I am questioning though the utility of maintaining compatibility with platforms that do not

Re: CVS commit: src/usr.bin/make

Yes, and I did not push for it for the exact reasons stated below: There was only a handful of cases and those can be handled with casts or a macro for now. I am questioning though the utility of maintaining compatibility with platforms that do not support C99 20 years later, vs. using %u and

Re: CVS commit: src/usr.bin/make

On 26.01.2021 11:19, Rin Okuyama wrote: Ping? I don't think this is correct fix either. Can you please revert this commit? Sorry, I didn't get the first mail from Christos back in December, that's why I didn't take any action. Why shouldn't the fix I did be correct? I carefully checked the

Re: CVS commit: src/usr.bin/make

Ping? I don't think this is correct fix either. Can you please revert this commit? Thanks, rin On 2020/12/15 7:57, Christos Zoulas wrote: In article <20201213212746.3cfc3f...@cvs.netbsd.org>, Roland Illig wrote: -=-=-=-=-=- Module Name:src Committed By: rillig Date: Sun Dec

re: CVS commit: src/usr.bin/make

"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Tue Dec 22 08:10:39 UTC 2020 > > Modified Files: > src/usr.bin/make: parse.c i'm not sure which change did it (but before this one for sure), but my builds crash early now (still trying to bootstrap nbmake):

Re: CVS commit: src/usr.bin/make

In article <20201213212746.3cfc3f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Dec 13 21:27:46 UTC 2020 > >Modified Files: > src/usr.bin/make: for.c meta.c parse.c var.c > >Log Message: >make(1): replace %zu with %u in

Re: CVS commit: src/usr.bin/make

On Sun, Oct 25, 2020 at 05:37:36PM +, Simon J. Gerraty wrote: > Modified Files: > src/usr.bin/make: main.c > src/usr.bin/make/unit-tests: varmod-match-escape.exp > > Log Message: > Skip reading .MAKE.DEPENDFILE if set to > "/dev/null" or anything starting with "no". > >

Re: CVS commit: src/usr.bin/make

On 24.09.2020 18:02, Jonathan A. Kollasch wrote: cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130:

Re: CVS commit: src/usr.bin/make

> cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130: /local/jakllsch/netbsd/src/usr.bin/make/lst.h:92:5: error: unknown

Re: CVS commit: src/usr.bin/make

On 14.09.2020 21:05, Robert Elz wrote: Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't

Re: CVS commit: src/usr.bin/make

Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't have | named constants as well. Most likely

Re: CVS commit: src/usr.bin/make

On 02.08.2020 13:06, Simon Burge wrote: > "Roland Illig" wrote: > >> Module Name: src >> Committed By:rillig >> Date:Sun Aug 2 09:43:22 UTC 2020 >> >> Modified Files: >> >> src/usr.bin/make: var.c >> >> Log Message: >> >> make(1): use shorter local variable names >>

Re: CVS commit: src/usr.bin/make

"Roland Illig" wrote: > Module Name: src > Committed By: rillig > Date: Sun Aug 2 09:43:22 UTC 2020 > > Modified Files: > > src/usr.bin/make: var.c > > Log Message: > > make(1): use shorter local variable names > > The c in cp was redundant since the context makes it obvious that

Re: CVS commit: src/usr.bin/make

On Sun, 2 Aug 2020, Roland Illig wrote: Module Name:src Committed By: rillig Date: Sun Aug 2 09:43:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use shorter local variable names The c in cp was redundant since the context makes it obvious

Re: CVS commit: src/usr.bin/make

In article <20200726200457.f2522f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Jul 26 20:04:57 UTC 2020 > >Modified Files: > src/usr.bin/make: Makefile > >Log Message: >make(1): explicitly add dependencies on headers >

re: CVS commit: src/usr.bin/make

> In a follow-up commit, I adjusted the build scripts, and I'm doing a > full build right now. I'm pretty confident that everything works now > again, and if not, I'll fix it immediately. thanks! .mrg.

Re: CVS commit: src/usr.bin/make

On 26.07.2020 10:29, matthew green wrote: > "Roland Illig" writes: >> Module Name: src >> Committed By:rillig >> Date:Sun Jul 26 07:15:26 UTC 2020 >> >> Modified Files: >> src/usr.bin/make: Makefile >> Added Files: >> src/usr.bin/make: lst.c >> Removed Files: >>

re: CVS commit: src/usr.bin/make

"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Sun Jul 26 07:15:26 UTC 2020 > > Modified Files: > src/usr.bin/make: Makefile > Added Files: > src/usr.bin/make: lst.c > Removed Files: > src/usr.bin/make/lst.lib: Makefile lstAppend.c lstAtEnd.c

Re: CVS commit: src/usr.bin/make

kardel@ wrote: > nbmake currently fails to build the tree. > > config.status: creating buildmake.sh > compile arch.c > compile buf.c > compile compat.c > compile cond.c > compile dir.c > compile for.c > compile hash.c > compile job.c > compile

Re: CVS commit: src/usr.bin/make

nbmake currently fails to build the tree. config.status: creating buildmake.sh compile arch.c compile buf.c compile compat.c compile cond.c compile dir.c compile for.c compile hash.c compile job.c compile main.c compile make.c compile

Re: CVS commit: src/usr.bin/make

On Sat, Jul 04, 2020 at 03:44:07PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Sat Jul 4 15:44:07 UTC 2020 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > make(1): fix :hash modifier on 16-bit platforms > > On platforms where int

Re: CVS commit: src/usr.bin/make

J. Hannken-Illjes wrote: > After this commit parallel builds take much longer. Building > amd64 release with -j16 for example goes from 45 to 380 minutes. Interesting. Removing the sleep would help there - the busy waiting issue isn't new anyway.

Re: CVS commit: src/usr.bin/make

> On 12. May 2018, at 20:17, Simon J. Gerraty wrote: > > Module Name: src > Committed By: sjg > Date: Sat May 12 18:17:04 UTC 2018 > > Modified Files: > src/usr.bin/make: job.c > > Log Message: > Skip setting wantToken. > > polling the job token pipe adds a

Re: CVS commit: src/usr.bin/make

On Wed, Apr 04, 2018 at 08:31:11PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Thu Apr 5 00:31:11 UTC 2018 > > Modified Files: > src/usr.bin/make: parse.c > > Log Message: > Be more selective about detecting a SYSV

re: CVS commit: src/usr.bin/make

> > And it still does. You cannot use -VV because of getopt(3). You can use > > a different letter. The complexity is when I get this long string instead > > of the evaluated variable. > > Please do not unilaterally change behavior. Especially if it has been > discussed in the past. This is rude

Re: CVS commit: src/usr.bin/make

On Jun 19, 6:58am, mar...@duskware.de (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Sun, Jun 18, 2017 at 04:26:38PM -0400, Christos Zoulas wrote: | > As I said above "reasons other than debugging", and you can still | > get the previous "debug

Re: CVS commit: src/usr.bin/make

On Jun 19, 6:58am, mar...@duskware.de (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | There was a discussion way back, exactly about what the default | behaviour should be: | | http://mail-index.netbsd.org/tech-toolchain/2012/08/06/msg001900.html | | If we now want

Re: CVS commit: src/usr.bin/make

On Sun, Jun 18, 2017 at 02:21:42PM -0400, Christos Zoulas wrote: > 1. What needs the intermediate representation, and how it can be used? For debuging makefiles. Martin

Re: CVS commit: src/usr.bin/make

On Jun 18, 7:01pm, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Sat, Jun 17, 2017 at 10:40:25PM -0400, Christos Zoulas wrote: | > On Jun 18, 12:36am, jo...@bec.de (Joerg Sonnenberger) wrote: | > -- Subject: Re: CVS commit: src/usr.bi

Re: CVS commit: src/usr.bin/make

On Jun 18, 12:36am, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Please do not unilaterally change behavior. Especially if it has been | discussed in the past. This is rude at best and not everyone shares your | opinion. Please explain the use case

Re: CVS commit: src/usr.bin/make

On Sun, Jun 18, 2017 at 12:40:20AM +0200, Kamil Rytarowski wrote: > Can we reuse show-var from pkgsrc? > > $ make show-var VARNAME=MACHINE_CPU > x86_64 It's no better than just using -V '${expr}' directly. Joerg

Re: CVS commit: src/usr.bin/make

;>>> In article <20170617213136.ga21...@britannica.bec.de>, >>>> Joerg Sonnenberger <jo...@bec.de> wrote: >>>>> On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >>>>>> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenbe

Re: CVS commit: src/usr.bin/make

.bec.de>, >> > Joerg Sonnenberger <jo...@bec.de> wrote: >> >> On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >> >>> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >> >>> -- Subject: Re: CVS commit: src/u

Re: CVS commit: src/usr.bin/make

berger) wrote: >>> -- Subject: Re: CVS commit: src/usr.bin/make >>> >>> | Agreed, please revert. This was discussed at the time and FreeBSD >>> | behavior you have now implemented is much less useful. >>> >>> You can get the original with -V '

Re: CVS commit: src/usr.bin/make

In article <20170617213136.ga21...@britannica.bec.de>, Joerg Sonnenberger <jo...@bec.de> wrote: >On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >> -- Subject: Re: CVS commit: src/usr.bin/m

Re: CVS commit: src/usr.bin/make

On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: > On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: > -- Subject: Re: CVS commit: src/usr.bin/make > > | Agreed, please revert. This was discussed at the time and FreeBSD > | behavior you have now implement

Re: CVS commit: src/usr.bin/make

On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Agreed, please revert. This was discussed at the time and FreeBSD | behavior you have now implemented is much less useful. You can get the original with -V '\VAR' christos

re: CVS commit: src/usr.bin/make

"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Sat Jun 17 15:49:56 UTC 2017 > > Modified Files: > src/usr.bin/make: main.c > > Log Message: > -V: try to expand the variable again if the value contains a variable. how do i get the original behaviour?

Re: CVS commit: src/usr.bin/make

In article <20170421221544.6b4eaf...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Fri Apr 21 22:15:44 UTC 2017 > >Modified Files: > src/usr.bin/make: str.c > src/usr.bin/make/unit-tests:

Re: CVS commit: src/usr.bin/make

Simon J. Gerraty wrote: > wrote: > > > On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > > > Log Message: > > > Str_Match: allow [^a-z] to behave as expected. > > > > % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' > >

Re: CVS commit: src/usr.bin/make

wrote: > On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > > Log Message: > > Str_Match: allow [^a-z] to behave as expected. > > % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' > NetBSD-7-x86_64 Well that's interesting - thanks...

Re: CVS commit: src/usr.bin/make

On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > Log Message: > Str_Match: allow [^a-z] to behave as expected. % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' NetBSD-7-x86_64

Re: CVS commit: src/usr.bin/make

In article <20170420035727.ba900f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Thu Apr 20 03:57:27 UTC 2017 > >Modified Files: > src/usr.bin/make: main.c > >Log Message: >We cannot tollerate

Re: CVS commit: src/usr.bin/make

In article <20170131065424.246a2f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Tue Jan 31 06:54:24 UTC 2017 > >Modified Files: > src/usr.bin/make: dir.c main.c > >Log Message: >Partially

Re: CVS commit: src/usr.bin/make

Module Name:src Committed By: sjg Date: Sat Jan 14 22:58:04 UTC 2017 Modified Files: src/usr.bin/make: make.1 var.c src/usr.bin/make/unit-tests: varmisc.exp varmisc.mk Log Message: Allow providing a utc value to :{gm,local}time Reviewed by: christos The

Re: CVS commit: src/usr.bin/make

Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Should be fixed... Don't know if you want to get carried away with

Re: CVS commit: src/usr.bin/make

Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Gah, bmake provides strlcpy... sorry about that.

Re: CVS commit: src/usr.bin/make

On Fri, Jun 03, 2016 at 01:21:59AM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Fri Jun 3 01:21:59 UTC 2016 > > Modified Files: > src/usr.bin/make: main.c make.h meta.c nonints.h var.c > > Log Message: > Add cached_realpath() > > realpath(3) is

Re: CVS commit: src/usr.bin/make

In article <20160603012159.a51b6f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Fri Jun 3 01:21:59 UTC 2016 > >Modified Files: > src/usr.bin/make: main.c make.h meta.c nonints.h var.c > >Log

Re: CVS commit: src/usr.bin/make

On Sat, Jan 16, 2016 at 04:15:21PM -0800, Simon J. Gerraty wrote: > Joerg Sonnenberger wrote: > > I suspect this change broke editors/xemacs-current, which is now failing > > with: > > > > make[1]: make[1]: don't know how to make insert-data-in-exec. Stop > > I'm

Re: CVS commit: src/usr.bin/make

Joerg Sonnenberger wrote: > I suspect this change broke editors/xemacs-current, which is now failing > with: > > make[1]: make[1]: don't know how to make insert-data-in-exec. Stop I'm guessing you are talking about a makefile that comes with emacs? I don't see anything

Re: CVS commit: src/usr.bin/make

On Sun, Dec 20, 2015 at 10:44:10PM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Sun Dec 20 22:44:10 UTC 2015 > > Modified Files: > src/usr.bin/make: suff.c > > Log Message: > Suff_ClearSuffixes() needs to re-initialize suffNull, > otherwise its

Re: CVS commit: src/usr.bin/make

On Tue, Dec 01, 2015 at 07:26:08AM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Tue Dec 1 07:26:08 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > Avoid calling brk_string() and hence Var_Export1() on > empty strings.

Re: CVS commit: src/usr.bin/make

Joerg Sonnenberger wrote: > > Log Message: > > Avoid calling brk_string() and hence Var_Export1() on > > empty strings. > > I'm not sure which change, but now I get fallout in the clang builds > from constructs like: Shouldn't this one since only affects exporting of

Re: CVS commit: src/usr.bin/make

Thanks - fixed. > /work/src/usr.bin/make/var.c:2772:7: error: variable 'emsg' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > if (wantit) > /work/src/usr.bin/make/var.c:2777:7: note: uninitialized use occurs here > if (emsg)

Re: CVS commit: src/usr.bin/make

On Mon, 12 Oct 2015 16:48:13 + "Simon J. Gerraty" wrote: > Module Name: src > Committed By: sjg > Date: Mon Oct 12 16:48:13 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > The conditional expressions used with ':?' can be expensive

Re: CVS commit: src/usr.bin/make

> Am 06.10.2015 um 19:36 schrieb Christos Zoulas : > > Module Name: src > Committed By: christos > Date: Tue Oct 6 17:36:25 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > don't check for NULL before free() (Tilman Sauerbeck) > >

Re: CVS commit: src/usr.bin/make

In article <3c6cf536-97db-4dae-966e-a3c02c505...@msys.ch>, Marc Balmer wrote: >>v->name, delim); >> -if (*freePtr) { >> -free(*freePtr); >> -*freePtr = NULL; >> -} >> +free(*freePtr); >> +*freePtr = NULL; > >is this sentinel, setting *freePtr to

Re: CVS commit: src/usr.bin/make

On Tue, Sep 09, 2014 at 06:18:17AM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Tue Sep 9 06:18:17 UTC 2014 Modified Files: src/usr.bin/make: main.c Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error

Re: CVS commit: src/usr.bin/make

On Tue, Sep 09, 2014 at 02:19:02PM +0200, Joerg Sonnenberger wrote: Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error to have VAR != command that prints no output Joerg reverted a bit too enthusiastically. Thanks. I will go over the

Re: CVS commit: src/usr.bin/make

In article 20140907205534.98d4...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: joerg Date: Sun Sep 7 20:55:34 UTC 2014 Modified Files: src/usr.bin/make: compat.c lst.h main.c make.c make.h nonints.h parse.c

Re: CVS commit: src/usr.bin/make

On Aug 31, 12:36am, u...@stderr.spb.ru (Valery Ushakov) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: | | Module Name:src | Committed By: christos | Date: Fri Aug 29 09:27:44 UTC 2014

Re: CVS commit: src/usr.bin/make

On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Aug 29 09:27:44 UTC 2014 Modified Files: src/usr.bin/make: parse.c Log Message: undo eating the trailing backslash now that the shell has been fixed. IIRC,

Re: CVS commit: src/usr.bin/make

On Tue, Sep 03, 2013 at 09:58:55PM +0200, Alan Barrett wrote: On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92

Re: CVS commit: src/usr.bin/make

On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/usr.bin/make/compat.c Will this fix PR 45356? --apb (Alan

Re: CVS commit: src/usr.bin/make

Hi, From: Christos Zoulas chris...@netbsd.org, Date: Tue, 16 Jul 2013 10:00:53 -0400 Module Name: src Committed By: christos Date: Tue Jul 16 14:00:53 UTC 2013 Modified Files: src/usr.bin/make: main.c make.1 var.c Log Message: More gmake compatibility: 1. add -w flag

  1   2   >