> This feels not good.
> strncpy->strlcpy has repercussions like how strlcpy doesn't zero out the
> remaining length and thus leaks uninitialized data.
>
> There has to be a reasonable way to handle these warnings instead of
> rototilling which str*cpy function is used.
Please read the code
On Sun, May 31, 2020 at 07:24:24PM -0400, Christos Zoulas wrote:
> Module Name: src
> Committed By: christos
> Date: Sun May 31 23:24:24 UTC 2020
>
> Modified Files:
> src/lib/libedit: terminal.c tty.c
>
> Log Message:
> use strlcpy() instead of strncpy() for gcc happiness
>
...
On Jun 18, 7:49pm, m...@3am-software.com (Matt Thomas) wrote:
-- Subject: Re: CVS commit: src/lib/libedit/TEST
|
| On Jun 18, 2014, at 1:12 PM, Christos Zoulas chris...@netbsd.org wrote:
|
| cast gotsig because it is long on some systems.
|
| Why cast to int instead of long?
Because
On Jun 18, 2014, at 1:12 PM, Christos Zoulas chris...@netbsd.org wrote:
cast gotsig because it is long on some systems.
Why cast to int instead of long?
Am 19.05.14 21:54, schrieb Christos Zoulas:
Module Name: src
Committed By: christos
Date: Mon May 19 19:54:12 UTC 2014
Modified Files:
src/lib/libedit: tty.c tty.h
Log Message:
more tty modes refactoring, no functional change intended.
To generate a diff of this
In article 537a6540.1070...@gmx.de,
Christoph Egger christoph_eg...@gmx.de wrote:
private? I think you mean static, right?
It does if compiled that way. Helps to read the rest of the file instead
of just diffs :-)
christos
On Wed, Aug 28, 2013 at 06:09:21PM +, Christos Zoulas wrote:
Log Message:
get rid of PATH_MAX.
...by leaking memory?
How so? It probably uses less memory than before, but not on the bss
but on the data segment.
Sorry, misread.
--
David A. Holland
dholl...@netbsd.org
On Wed, Aug 28, 2013 at 04:05:21AM -0400, Christos Zoulas wrote:
Modified Files:
src/lib/libedit: readline.c
Log Message:
get rid of PATH_MAX.
...by leaking memory?
--
David A. Holland
dholl...@netbsd.org
Can we please stop abusing the notation of GCC is available to mean
GCC is used? If you want a GCC-specific warning flag, at least put it
into CWARNFLAGS.gcc. I'm actually in favour of dropping this
unconditionally -- GCC 4.1 is just behaving way too lax for this option
to make sense.
Joerg
On
On Fri, 29 Jul 2011, Christos Zoulas wrote:
Log Message:
add -Wunused-parameter
Is that the right way? Perhaps WARNS=5?
Or add -Wunused-parameter to WARNS=4.
WARNS levels should be organised by the ease of avoiding or fixing the
warnings; there's no need to add a new level for each warning.
In article 20110730064751.ga19...@apb-laptoy.apb.alt.za,
Alan Barrett a...@cequrux.com wrote:
On Fri, 29 Jul 2011, Christos Zoulas wrote:
Log Message:
add -Wunused-parameter
Is that the right way? Perhaps WARNS=5?
Or add -Wunused-parameter to WARNS=4.
WARNS levels should be organised by the
In article 20110730205523.gb3...@britannica.bec.de,
Joerg Sonnenberger jo...@britannica.bec.de wrote:
Just cast the parameter to void?
Do you prefer this than __unused?
christos
On Sun, Jul 31, 2011 at 00:50:03 +, Christos Zoulas wrote:
In article 20110730205523.gb3...@britannica.bec.de,
Joerg Sonnenberger jo...@britannica.bec.de wrote:
Just cast the parameter to void?
Do you prefer this than __unused?
I too would prefer something in the body of the
On Sun, 18 Apr 2010, Christos Zoulas wrote:
Modified Files:
src/lib/libedit: makelist
Log Message:
shame on solaris that is the last OS not supporting $()
build.sh tries to set HOST_SH=/usr/xpg4/bin/sh on Solaris, and that
shell does support $(...). Also, we make free use of $(...)
In article 20100419075526.ga1...@apb-laptoy.apb.alt.za,
Alan Barrett a...@cequrux.com wrote:
On Sun, 18 Apr 2010, Christos Zoulas wrote:
Modified Files:
src/lib/libedit: makelist
Log Message:
shame on solaris that is the last OS not supporting $()
build.sh tries to set
hi, all.
i found one more big problem.
we had lost source/binary level backward compatibility, sigh.
el_set(3) defines EL_GETCFN flag, and some application(such as Asterisk) use it:
el_set()
Set editline parameters. op determines which parameter to set, and
each
On Mar 7, 5:24am, takehiko.noz...@gmail.com (Takehiko NOZAKI) wrote:
-- Subject: Re: CVS commit: src/lib/libedit
| -typedef int (*el_rfunc_t)(EditLine *, char *);
| +typedef int (*el_rfunc_t)(EditLine *, Char *);
|
| typedef struct el_read_t {
| el_rfunc_t read_char
convert multibyte - wide-character is
# EL_BUILTIN_GETCFN(=read_char) itself.
very truly yours.
--
Takehiko NOZAKItakehiko.noz...@gmail.com
2010/3/7 Christos Zoulas chris...@zoulas.com:
On Mar 7, 5:24am, takehiko.noz...@gmail.com (Takehiko NOZAKI) wrote:
-- Subject: Re: CVS commit: src/lib
On Mar 7, 7:46am, takehiko.noz...@gmail.com (Takehiko NOZAKI) wrote:
-- Subject: Re: CVS commit: src/lib/libedit
| oh, i see. i don't recognize NARROW_READ flag.
| source/binary compatibility are still **kept**,
| i withdrawn previous mail, sorry.
|
|
| BTW, this hack is not good
hi,
can you please don't hardcode utf-8?
YAMAMOTO Takashi
Module Name: src
Committed By: christos
Date: Wed Dec 30 22:37:40 UTC 2009
Modified Files:
src/lib/libedit: Makefile chared.c chared.h common.c el.c el.h emacs.c
filecomplete.c filecomplete.h hist.c
On Jan 13, 8:21am, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/lib/libedit
| hi,
|
| can you please don't hardcode utf-8?
|
| YAMAMOTO Takashi
Once we verify that it works on non utf-8, sure.
christos
On Jan 13, 8:21am, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/lib/libedit
| hi,
|
| can you please don't hardcode utf-8?
|
| YAMAMOTO Takashi
Once we verify that it works on non utf-8, sure.
what do you mean by verify?
YAMAMOTO Takashi
Module Name: src
Committed By:christos
Date:Mon Sep 7 21:24:34 UTC 2009
Modified Files:
src/lib/libedit: histedit.h history.c readline.c
src/lib/libedit/readline: readline.h
Log Message:
apply apple patches from:
23 matches
Mail list logo
