CVS commit: src/games/canfield/canfield
Module Name:src Committed By: wiz Date: Fri Jan 1 11:45:34 UTC 2010 Modified Files: src/games/canfield/canfield: canfield.6 Log Message: New sentence, new line. To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12 src/games/canfield/canfield/canfield.6 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/games/canfield/cfscores
Am 01.01.2010 um 07:20 schrieb David A. Holland:
Module Name: src
Committed By: dholland
Date: Fri Jan 1 06:20:45 UTC 2010
Modified Files:
src/games/canfield/cfscores: cfscores.c
Log Message:
Send error messages to stderr. Use errx/warnx, not printf.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/games/canfield/cfscores/cfscores.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/games/canfield/cfscores/cfscores.c
diff -u src/games/canfield/cfscores/cfscores.c:1.17
src/games/canfield/cfscores/cfscores.c:1.18
--- src/games/canfield/cfscores/cfscores.c:1.17 Fri Jan 1 06:16:36 2010
+++ src/games/canfield/cfscores/cfscores.cFri Jan 1 06:20:45 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: cfscores.c,v 1.17 2010/01/01 06:16:36 dholland Exp $ */
+/* $NetBSD: cfscores.c,v 1.18 2010/01/01 06:20:45 dholland Exp $ */
/*
* Copyright (c) 1983, 1993
@@ -39,7 +39,7 @@
#if 0
static char sccsid[] = @(#)cfscores.c8.1 (Berkeley) 5/31/93;
#else
-__RCSID($NetBSD: cfscores.c,v 1.17 2010/01/01 06:16:36 dholland Exp $);
+__RCSID($NetBSD: cfscores.c,v 1.18 2010/01/01 06:20:45 dholland Exp $);
#endif
#endif /* not lint */
@@ -78,8 +78,7 @@
setgid(getgid());
if (argc 2) {
- printf(Usage: cfscores -a | cfscores [user]\n);
- exit(1);
+ errx(1, Usage: cfscores -a | cfscores [user]);
imo, lower case usage would be more consistent with other commands.
}
dbfd = open(_PATH_SCORE, O_RDONLY);
if (dbfd 0)
@@ -89,8 +88,7 @@
uid = getuid();
pw = getpwuid(uid);
if (pw == 0) {
- printf(You are not listed in the password file?!?\n);
- exit(2);
+ errx(2, You are not listed in the password file?!?);
}
printuser(pw, 1);
exit(0);
@@ -102,8 +100,7 @@
}
pw = getpwnam(argv[1]);
if (pw == 0) {
- printf(User %s unknown\n, argv[1]);
- exit(3);
+ errx(3, User %s unknown, argv[1]);
}
printuser(pw, 1);
exit(0);
@@ -122,7 +119,7 @@
pos = pw-pw_uid * (off_t)sizeof(struct betinfo);
/* test pos, not pw_uid; uid_t can be unsigned, which makes gcc warn */
if (pos 0) {
- printf(Bad uid %d\n, (int)pw-pw_uid);
+ warnx(Bad uid %d, (int)pw-pw_uid);
return;
}
i = lseek(dbfd, pos, SEEK_SET);
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:41:25 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Don't infer a sensor driver's ability to handle limit checking itself. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/i2c
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:43:50 UTC 2010 Modified Files: src/sys/dev/i2c: sdtemp.c Log Message: Explicitly inform envsys that the driver is capable of doing its own limit checking at initialization time. Later on, if user specifics any unsupported limits, the driver will relinquish this task. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/i2c/sdtemp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: pgoyette Date: Fri Jan 1 15:55:30 UTC 2010 Modified Files: src/sys/dev/acpi: acpi_tz.c Log Message: Don't set sensor state to SWARNOVER here. Doing so based only on the device's active cooling levels prevents the user from overriding these limits with his own values. XXX We should probably also change setting SCRITOVER state to SCRITICAL, XXX but right now that just confuses things. We currently don't have a XXX way for a sensor to be both SCRITICAL and SCRITOVER. To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/dev/acpi/acpi_tz.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/games/canfield/cfscores
On Fri, Jan 01, 2010 at 03:33:26PM +0100, Marc Balmer wrote:
if (argc 2) {
- printf(Usage: cfscores -a | cfscores [user]\n);
- exit(1);
+ errx(1, Usage: cfscores -a | cfscores [user]);
imo, lower case usage would be more consistent with other commands.
Some grep usage suggests that lowercase outnumbers capitalized by a
good margin, but there's still a healthy minority of capitalized usage
messages. (It's about 500 to 125.)
Is this something we care enough about to make a point of fixing it as
we go?
--
David A. Holland
dholl...@netbsd.org
CVS commit: src/bin/sh
Module Name:src Committed By: dholland Date: Fri Jan 1 18:09:16 UTC 2010 Modified Files: src/bin/sh: sh.1 Log Message: fix typo To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/bin/sh/sh.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/games/canfield/cfscores
Am 01.01.2010 um 18:35 schrieb David Holland:
On Fri, Jan 01, 2010 at 03:33:26PM +0100, Marc Balmer wrote:
if (argc 2) {
- printf(Usage: cfscores -a | cfscores [user]\n);
- exit(1);
+ errx(1, Usage: cfscores -a | cfscores [user]);
imo, lower case usage would be more consistent with other commands.
Some grep usage suggests that lowercase outnumbers capitalized by a
good margin, but there's still a healthy minority of capitalized usage
messages. (It's about 500 to 125.)
Is this something we care enough about to make a point of fixing it as
we go?
with a ratio of 500:125, I am inclined to say no.
--
David A. Holland
dholl...@netbsd.org
CVS commit: src/bin/sh
Module Name:src Committed By: dholland Date: Fri Jan 1 19:34:59 UTC 2010 Modified Files: src/bin/sh: cd.c sh.1 Log Message: Make the cd builtin accept and ignore -P, which is a kshism that has been allowed to leak into POSIX and selects the behavior cd already implements. Closes PR bin/42557 and also relevant to PR pkg/42168. I suppose this should probably be pulled up to both -4 and -5... To generate a diff of this commit: cvs rdiff -u -r1.39 -r1.40 src/bin/sh/cd.c cvs rdiff -u -r1.94 -r1.95 src/bin/sh/sh.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: dholland Date: Fri Jan 1 19:51:19 UTC 2010 Modified Files: src/bin/sh: sh.1 Log Message: fix another typo To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96 src/bin/sh/sh.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc/gen
Module Name:src Committed By: dholland Date: Fri Jan 1 19:59:21 UTC 2010 Modified Files: src/lib/libc/gen: getcwd.c Log Message: POSIX says realpath(NULL, foo) is supposed to yield EINVAL rather than being allowed to crash. Go figure. Closes PR lib/42559 from Stathis Kamperis. To generate a diff of this commit: cvs rdiff -u -r1.45 -r1.46 src/lib/libc/gen/getcwd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/syslogd
Module Name:src Committed By: mbalmer Date: Fri Jan 1 21:26:18 UTC 2010 Modified Files: src/usr.sbin/syslogd: syslog.conf.5 Log Message: fold long lines. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/usr.sbin/syslogd/syslog.conf.5 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/syslogd
Module Name:src Committed By: wiz Date: Fri Jan 1 21:44:08 UTC 2010 Modified Files: src/usr.sbin/syslogd: syslog.conf.5 Log Message: Fix previous: Dd argument and lost Em markup. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/usr.sbin/syslogd/syslog.conf.5 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: wiz Date: Fri Jan 1 21:46:31 UTC 2010 Modified Files: src/bin/sh: sh.1 Log Message: Bump date for cd -P support. To generate a diff of this commit: cvs rdiff -u -r1.96 -r1.97 src/bin/sh/sh.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/i386/conf
Module Name:src Committed By: dholland Date: Fri Jan 1 22:12:19 UTC 2010 Modified Files: src/sys/arch/i386/conf: MONOLITHIC Log Message: add rcsid To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/arch/i386/conf/MONOLITHIC Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/games/canfield/cfscores
In article 20100101173538.ga17...@netbsd.org,
David Holland dholland-sourcechan...@netbsd.org wrote:
On Fri, Jan 01, 2010 at 03:33:26PM +0100, Marc Balmer wrote:
if (argc 2) {
- printf(Usage: cfscores -a | cfscores [user]\n);
- exit(1);
+ errx(1, Usage: cfscores -a | cfscores [user]);
imo, lower case usage would be more consistent with other commands.
Some grep usage suggests that lowercase outnumbers capitalized by a
good margin, but there's still a healthy minority of capitalized usage
messages. (It's about 500 to 125.)
Is this something we care enough about to make a point of fixing it as
we go?
I think consistency is good, but at the same time I like upper case :-)
Also using errx() for usage is inconsistent because you end up printing
prog: Usage: prog instead of Usage: prog. And everything should
consistently use getprogname() instead of hard-coding it.
christos
CVS commit: src/sys/dev/pcmcia
Module Name:src Committed By: christos Date: Sat Jan 2 01:43:12 UTC 2010 Modified Files: src/sys/dev/pcmcia: if_ne_pcmcia.c Log Message: convert to pmf To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/dev/pcmcia/if_ne_pcmcia.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sbus
Module Name:src Committed By: christos Date: Sat Jan 2 01:43:42 UTC 2010 Modified Files: src/sys/dev/sbus: dbri.c Log Message: convert to pmf To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/sys/dev/sbus/dbri.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/isa
Module Name:src Committed By: christos Date: Sat Jan 2 02:37:09 UTC 2010 Modified Files: src/sys/dev/isa: ym.c Log Message: make rhis compile. To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/dev/isa/ym.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5-0] src/usr.sbin/makefs/cd9660
Module Name:src Committed By: snj Date: Sat Jan 2 06:26:11 UTC 2010 Modified Files: src/usr.sbin/makefs/cd9660 [netbsd-5-0]: iso9660_rrip.c Log Message: Pull up following revision(s) (requested by tsutsui in ticket #1198): usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.5 When splitting a System Use Area between a System Use field and a Continuation Area, be sure to insert the CE record at the correct point in the chain of SUSP records. Without this, makefs emits an invalid image if any file needs a Continuation Area. The bug seems to have been introduced with the conversion to TAILQs. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.4.20.1 src/usr.sbin/makefs/cd9660/iso9660_rrip.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5-0] src/usr.sbin/makefs/cd9660
Module Name:src Committed By: snj Date: Sat Jan 2 06:27:27 UTC 2010 Modified Files: src/usr.sbin/makefs/cd9660 [netbsd-5-0]: iso9660_rrip.c Log Message: Pull up following revision(s) (requested by tsutsui in ticket #1198): usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.6 Fix another bug in SUSP CE handling: when the SUSP records fit into the System Use field with fewer then 28 bytes to spare, we were remembering the wrong length for the System Use field and hence emitting a corrupt directory entry. This could be triggered by trying to build a filesystem containing a regular file with a 120-byte name. Now we're a little more careful. To generate a diff of this commit: cvs rdiff -u -r1.4.20.1 -r1.4.20.2 src/usr.sbin/makefs/cd9660/iso9660_rrip.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5-0] src/usr.sbin/makefs/cd9660
Module Name:src Committed By: snj Date: Sat Jan 2 06:28:27 UTC 2010 Modified Files: src/usr.sbin/makefs/cd9660 [netbsd-5-0]: iso9660_rrip.c Log Message: Pull up following revision(s) (requested by tsutsui in ticket #1198): usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.7 Initialize a local variable to get rid of a may be used uninitialized warning (turned into error by -Werror). To generate a diff of this commit: cvs rdiff -u -r1.4.20.2 -r1.4.20.3 src/usr.sbin/makefs/cd9660/iso9660_rrip.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5-0] src/usr.sbin/makefs
Module Name:src
Committed By: snj
Date: Sat Jan 2 06:34:15 UTC 2010
Modified Files:
src/usr.sbin/makefs [netbsd-5-0]: cd9660.c cd9660.h
src/usr.sbin/makefs/cd9660 [netbsd-5-0]: cd9660_write.c iso9660_rrip.c
iso9660_rrip.h
Log Message:
Pull up following revision(s) (requested by tsutsui in ticket #1198):
usr.sbin/makefs/cd9660.c: revision 1.25 via patch
usr.sbin/makefs/cd9660.h: revision 1.13 via patch
usr.sbin/makefs/cd9660/cd9660_write.c: revision 1.10
usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.8
usr.sbin/makefs/cd9660/iso9660_rrip.h: revision 1.5
Add support for encoding RISC OS metadata into ISO 9660 filesystems.
This is done by adding the general ability to stuff non-SUSP data into
the end of the System Use field of a Directory Record, which required
some amount of rewriting of the SUSP support. I think the result is
at least as good as what came before, and I've fixed at least one bug
along the way. Tested against RISC OS 3.70 on my Risc PC.
Oh, why do we want it? It should allow us to make acorn{26,32} CDs that
can be booted directly from RISC OS without mucking around copying the
bootloader to a native filing system.
To generate a diff of this commit:
cvs rdiff -u -r1.22.2.1 -r1.22.2.1.2.1 src/usr.sbin/makefs/cd9660.c
cvs rdiff -u -r1.12 -r1.12.6.1 src/usr.sbin/makefs/cd9660.h
cvs rdiff -u -r1.9 -r1.9.6.1 src/usr.sbin/makefs/cd9660/cd9660_write.c
cvs rdiff -u -r1.4.20.3 -r1.4.20.4 src/usr.sbin/makefs/cd9660/iso9660_rrip.c
cvs rdiff -u -r1.4 -r1.4.28.1 src/usr.sbin/makefs/cd9660/iso9660_rrip.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/distrib/miniroot
Module Name:src Committed By: tsutsui Date: Sat Jan 2 06:37:28 UTC 2010 Modified Files: src/distrib/miniroot: list Log Message: Remove -ledit and -lmagic from LIBS. No program requires -ledit in crunched SMALLPROG case, and miniroot doesn't have /usr/bin/file which requires -lmagic. (sparc had it but it was removed in distrib/sparc/miniroot/list rev 1.29) To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/distrib/miniroot/list Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/amiga/miniroot
Module Name:src Committed By: tsutsui Date: Sat Jan 2 06:39:01 UTC 2010 Modified Files: src/distrib/amiga/miniroot: list Log Message: Remove LIBS -lz which is already in distrib/miniroot/list. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/distrib/amiga/miniroot/list Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5-0] src/doc
Module Name:src Committed By: snj Date: Sat Jan 2 06:40:03 UTC 2010 Modified Files: src/doc [netbsd-5-0]: CHANGES-5.0.2 Log Message: Ticket 1198. To generate a diff of this commit: cvs rdiff -u -r1.1.2.34 -r1.1.2.35 src/doc/CHANGES-5.0.2 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5] src/usr.sbin/makefs/cd9660
Module Name:src Committed By: snj Date: Sat Jan 2 06:41:03 UTC 2010 Modified Files: src/usr.sbin/makefs/cd9660 [netbsd-5]: iso9660_rrip.c Log Message: Pull up following revision(s) (requested by tsutsui in ticket #1198): usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.5 When splitting a System Use Area between a System Use field and a Continuation Area, be sure to insert the CE record at the correct point in the chain of SUSP records. Without this, makefs emits an invalid image if any file needs a Continuation Area. The bug seems to have been introduced with the conversion to TAILQs. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.4.18.1 src/usr.sbin/makefs/cd9660/iso9660_rrip.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5] src/usr.sbin/makefs/cd9660
Module Name:src Committed By: snj Date: Sat Jan 2 06:41:48 UTC 2010 Modified Files: src/usr.sbin/makefs/cd9660 [netbsd-5]: iso9660_rrip.c Log Message: Pull up following revision(s) (requested by tsutsui in ticket #1198): usr.sbin/makefs/cd9660/iso9660_rrip.c: revision 1.6 Fix another bug in SUSP CE handling: when the SUSP records fit into the System Use field with fewer then 28 bytes to spare, we were remembering the wrong length for the System Use field and hence emitting a corrupt directory entry. This could be triggered by trying to build a filesystem containing a regular file with a 120-byte name. Now we're a little more careful. To generate a diff of this commit: cvs rdiff -u -r1.4.18.1 -r1.4.18.2 src/usr.sbin/makefs/cd9660/iso9660_rrip.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib
Module Name:src Committed By: tsutsui Date: Sat Jan 2 06:46:09 UTC 2010 Modified Files: src/distrib/hp300/miniroot: list src/distrib/mac68k/miniroot: list src/distrib/mvme68k/miniroot: list src/distrib/pmax/miniroot: list src/distrib/sgimips/miniroot: list src/distrib/sparc/miniroot: list src/distrib/vax/miniroot: list Log Message: No need to install /usr/share/zoneinfo into miniroot because libc functions in libhack doesn't require it and zoneinfo files seem to get larger since tzcode2009k import. (due to 64bit time_t support?) Briefly tested sysinst on sparc miniroot. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/distrib/hp300/miniroot/list cvs rdiff -u -r1.9 -r1.10 src/distrib/mac68k/miniroot/list cvs rdiff -u -r1.17 -r1.18 src/distrib/mvme68k/miniroot/list cvs rdiff -u -r1.19 -r1.20 src/distrib/pmax/miniroot/list cvs rdiff -u -r1.7 -r1.8 src/distrib/sgimips/miniroot/list cvs rdiff -u -r1.32 -r1.33 src/distrib/sparc/miniroot/list cvs rdiff -u -r1.10 -r1.11 src/distrib/vax/miniroot/list Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [netbsd-5] src/doc
Module Name:src Committed By: snj Date: Sat Jan 2 06:47:51 UTC 2010 Modified Files: src/doc [netbsd-5]: CHANGES-5.1 Log Message: Ticket 1198. To generate a diff of this commit: cvs rdiff -u -r1.1.2.166 -r1.1.2.167 src/doc/CHANGES-5.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/arm32
Module Name:src Committed By: he Date: Sat Jan 2 07:53:29 UTC 2010 Modified Files: src/sys/arch/arm/arm32: pmap.c Log Message: Remove a shadowed and unused local declaration so that this builds again. To generate a diff of this commit: cvs rdiff -u -r1.210 -r1.211 src/sys/arch/arm/arm32/pmap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
