Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread Simon Burge
Antti Kantee wrote: On Tue Nov 09 2010 at 13:10:02 +1100, Simon Burge wrote: David Holland wrote: On Mon, Nov 08, 2010 at 06:09:39PM +, Antti Kantee wrote: Modified Files: src/sys/arch/mips/mips: locore_mips1.S Log Message: In TLBRead, restore PID

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread Antti Kantee
On Tue Nov 09 2010 at 22:43:53 +1100, Simon Burge wrote: I'm curious about this too. That code hasn't changed for at least 14 years... Given that it's only called from ddb, i'm not too surprised nobody has noticed. Now, unless someone argues that the stores should definitely

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread Antti Kantee
On Tue Nov 09 2010 at 13:10:02 +1100, Simon Burge wrote: David Holland wrote: On Mon, Nov 08, 2010 at 06:09:39PM +, Antti Kantee wrote: Modified Files: src/sys/arch/mips/mips: locore_mips1.S Log Message: In TLBRead, restore PID before doing the saves so that the

Re: CVS commit: src/tests/fs/tmpfs

2010-11-09 Thread Antti Kantee
On Tue Nov 09 2010 at 13:01:34 +, Julio Merino wrote: Module Name: src Committed By: jmmv Date: Tue Nov 9 13:01:34 UTC 2010 Modified Files: src/tests/fs/tmpfs: t_create.sh Log Message: Remove ugly workaround to skip this if unprivileged-user=_atf and just use 'su

Re: CVS commit: src/tests/fs/tmpfs

2010-11-09 Thread Alan Barrett
On Tue, 09 Nov 2010, Julio Merino wrote: Log Message: Remove ugly workaround to skip this if unprivileged-user=_atf and just use 'su -m' as pooka@ did in t_mkdir.sh. As he says this may still fail if root's shell is csh; we need a better solution. su -m ${user} -c /bin/sh -c 'your command

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread David Holland
On Tue, Nov 09, 2010 at 01:46:46PM +0200, Antti Kantee wrote: Thanks for the extra details. It may be obvious with the background info you've now provided, but wasn't from your initial commit message. Gotta love source-changes-full and nxr.netbsd.org ;) No, it's not obvious from those

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread Warner Losh
On 11/09/2010 13:54, David Holland wrote: On Tue, Nov 09, 2010 at 01:46:46PM +0200, Antti Kantee wrote: Thanks for the extra details. It may be obvious with the background info you've now provided, but wasn't from your initial commit message. Gotta love source-changes-full

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread David Holland
On Mon, Nov 08, 2010 at 03:49:09PM -0700, Warner Losh wrote: I don't have a mips1-specific reference on hand, but my recollection is that you need *three* nops when messing with cop0 registers for all effects to flush through. locore_mips1.S doesn't agree with your recollection, e.g.

Re: CVS commit: src/sys/arch/mips/mips

2010-11-09 Thread David Holland
On Tue, Nov 09, 2010 at 02:20:11PM -0700, Warner Losh wrote: No, it's not obvious from those either, and I'm even familiar with the architecture. This whole thing could have been avoided if you'd written a clear commit message; can you revise the text in CVS to have fewer dangling