Re: CVS commit: src/lib/libc/sys

2011-03-05 Thread David Holland 
On Mon, Feb 28, 2011 at 07:17:03AM +, Thomas Klausner wrote:
  Modified Files:
   src/lib/libc/sys: mlock.2
  
  Log Message:
  Merge EINVAL descriptions; sort errors alphabetically; bump date.

Is that the required convention now? ISTM that quite a few pages have
or had the same errno listed more than once, usually for logically
separate conditions.

-- 
David A. Holland
dholl...@netbsd.org

re: CVS commit: src/sys/dev/marvell

2011-03-05 Thread matthew green 

 Module Name:  src
 Committed By: christos
 Date: Sat Mar  5 18:28:13 UTC 2011
 
 Modified Files:
   src/sys/dev/marvell: if_mvgbe.c
 
 Log Message:
 From Dave Mills: It would appear that the two PHYs can only be
 accessed from the registers of controller0 (mvgbec0) hence why both
 PHYs are being detected on controller0. I have made the assumption
 that PHY0 = controller0 (mvgbec0), PHY1 = controller1(mvgbec1)
 and developed a patch accordingly. Also the irq is 15 for controller1
 not 14.

this patch introduced cf_unit abuse.  please re-work it.


.mrg.

Re: CVS commit: src/lib/libc/sys

2011-03-05 Thread Thomas Klausner 
On Sat, Mar 05, 2011 at 09:14:32PM +, David Holland wrote:
 On Mon, Feb 28, 2011 at 07:17:03AM +, Thomas Klausner wrote:
   Modified Files:
  src/lib/libc/sys: mlock.2
   
   Log Message:
   Merge EINVAL descriptions; sort errors alphabetically; bump date.
 
 Is that the required convention now? ISTM that quite a few pages have
 or had the same errno listed more than once, usually for logically
 separate conditions.

It's the one to which I've been converting files I've touched for
quite some time now.

I think it's easier to see all reasons for an error code when you look
up the error code and wouldn't expect multiple entries for the same
error code in the list.
(Especially since sometimes they aren't even next to each other, where
one might see them by reading on.)
 Thomas