Re: CVS commit: src/lib/libc/stdlib

2011-05-16 Thread tsugutomo . enami 
Christos Zoulas  writes:

> Module Name:  src
> Committed By: christos
> Date: Fri May 13 23:11:00 UTC 2011
>
> Modified Files:
>   src/lib/libc/stdlib: jemalloc.c malloc.c
>
> Log Message:
> don't let readlink trash errno.;
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.22 -r1.23 src/lib/libc/stdlib/jemalloc.c
> cvs rdiff -u -r1.52 -r1.53 src/lib/libc/stdlib/malloc.c

- Is the existing guard in malloc_init() of malloc.c insufficient?

- In the malloc_init_hard() of jemalloc.c, there are another calls may
set errno.  Especially, the code explicitly handles an error from
sysctl(3).

enami.

Re: CVS commit: src/sys

2011-05-16 Thread Izumi Tsutsui 
> Reminds me of http://www.netbsd.org/ports/ -- remember
> sparc is "tier 2" aka "Go fix it yourself if you don't
> hurt me"...

Probably you should also read announcement.
http://mail-index.NetBSD.org/netbsd-announce/2011/03/30/msg000126.html

---
Izumi Tsutsui

Re: CVS commit: src/sys

2011-05-16 Thread Mindaugas Rasiukevicius 
"Martin S. Weber"  wrote:
> On Mon, May 16, 2011 at 08:18:08PM +0200, Martin Husemann wrote:
> > On Mon, May 16, 2011 at 07:29:26PM +0200, Martin S. Weber wrote:
> > > Reminds me of http://www.netbsd.org/ports/ -- remember
> > > sparc is "tier 2" aka "Go fix it yourself if you don't
> > > hurt me"...
> > 
> > Well, but the fix is simple in this case: turn it into a MD macro like
> > MAXDMAP() and allow other archs to provide a const implementation, while
> > sparc pays the price and has to fetch it from a variable.
> > 
> 
> or just hack it brutally
> 
> ( cvs rdiff -u -r1.308 -r1.309 src/sys/arch/sparc/sparc/machdep.c )
>  -- who cares about hacks in tier 2 architectures when the netbsd
> goals (http://www.netbsd.org/about/system.html - "well designed")
> only apply to tier 1 ports? (the goals page should be updated anyways
> to exclude examples such as EISA, TurboChannel, the alpha or pmap port
> etc)

The *modification* of those variables in such way is rather a hack.  Note
that I have asked sparc guys whether they are happy with such change.

Tell me more about "well designed".

-- 
Mindaugas

Re: CVS commit: src/sys

2011-05-16 Thread Martin S. Weber 
On Mon, May 16, 2011 at 08:18:08PM +0200, Martin Husemann wrote:
> On Mon, May 16, 2011 at 07:29:26PM +0200, Martin S. Weber wrote:
> > Reminds me of http://www.netbsd.org/ports/ -- remember
> > sparc is "tier 2" aka "Go fix it yourself if you don't
> > hurt me"...
> 
> Well, but the fix is simple in this case: turn it into a MD macro like
> MAXDMAP() and allow other archs to provide a const implementation, while
> sparc pays the price and has to fetch it from a variable.
> 

or just hack it brutally

( cvs rdiff -u -r1.308 -r1.309 src/sys/arch/sparc/sparc/machdep.c )
 -- who cares about hacks in tier 2 architectures when the netbsd
goals (http://www.netbsd.org/about/system.html - "well designed")
only apply to tier 1 ports? (the goals page should be updated anyways
to exclude examples such as EISA, TurboChannel, the alpha or pmap port
etc)

/me shrugs

Re: CVS commit: src/sys

2011-05-16 Thread Mindaugas Rasiukevicius 
Hauke Fath  wrote:
> >Module Name:src
> >Committed By:   rmind
> >Date:   Sat May 14 17:57:05 UTC 2011
> >
> >Modified Files:
> >src/sys/kern: kern_resource.c
> >src/sys/sys: resource.h resourcevar.h
> >
> >Log Message:
> >- Sprinkle __read_mostly, consitify maxdmap and maxsmap.
> 
> 
> This breaks the sparc build, which sets 'maxdmap', see
> .

Fixed.

-- 
Mindaugas

Re: CVS commit: src/sys

2011-05-16 Thread Martin Husemann 
On Mon, May 16, 2011 at 07:29:26PM +0200, Martin S. Weber wrote:
> Reminds me of http://www.netbsd.org/ports/ -- remember
> sparc is "tier 2" aka "Go fix it yourself if you don't
> hurt me"...

Well, but the fix is simple in this case: turn it into a MD macro like
MAXDMAP() and allow other archs to provide a const implementation, while
sparc pays the price and has to fetch it from a variable.

Martin

Re: CVS commit: src/sys

2011-05-16 Thread Martin S. Weber 
On Mon, May 16, 2011 at 06:35:35PM +0200, Hauke Fath wrote:
> >Module Name:src
> >Committed By:   rmind
> >Date:   Sat May 14 17:57:05 UTC 2011
> >
> >Modified Files:
> >src/sys/kern: kern_resource.c
> >src/sys/sys: resource.h resourcevar.h
> >
> >Log Message:
> >- Sprinkle __read_mostly, consitify maxdmap and maxsmap.
> 
> 
> This breaks the sparc build, which sets 'maxdmap', see
> .
> 

Reminds me of http://www.netbsd.org/ports/ -- remember
sparc is "tier 2" aka "Go fix it yourself if you don't
hurt me"...

Re: CVS commit: src/sys

2011-05-16 Thread Hauke Fath 
>Module Name:src
>Committed By:   rmind
>Date:   Sat May 14 17:57:05 UTC 2011
>
>Modified Files:
>src/sys/kern: kern_resource.c
>src/sys/sys: resource.h resourcevar.h
>
>Log Message:
>- Sprinkle __read_mostly, consitify maxdmap and maxsmap.


This breaks the sparc build, which sets 'maxdmap', see
.

hauke

-- 
 The ASCII Ribbon CampaignHauke Fath
() No HTML/RTF in emailInstitut für Nachrichtentechnik
/\ No Word docs in email TU Darmstadt
 Respect for open standards  Ruf +49-6151-16-3281

Re: CVS commit: src/tests/lib/libposix

2011-05-16 Thread Julio Merino 

On 5/16/11 1:03 AM, Christos Zoulas wrote:

Module Name:src
Committed By:   christos
Date:   Mon May 16 00:03:36 UTC 2011

Modified Files:
src/tests/lib/libposix: t_rename.c

Log Message:
h_macros need strlcat and random ugh, please someone remove this header.
define _NETBSD_SOURCE so those are defined.


The original intent of h_macros was as a place to provide 
NetBSD-specific check macros that can't be part of the generic codebase 
of atf.  I'm not sure what it currently includes, but I presume it does 
not follow this rule any more.  I'll check later (FSVO later ;-) what 
pieces could be now moved to atf to clean this up a bit.