Re: CVS commit: src/distrib/sets/lists
On May,Monday 30 2011, at 4:10 AM, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Mon May 30 02:10:26 UTC 2011 Modified Files: src/distrib/sets/lists/base: ad.mips64eb src/distrib/sets/lists/comp: ad.mips64eb ad.mips64el md.amd64 md.sparc64 mi shl.mi src/distrib/sets/lists/tests: shl.mi Log Message: fix a lot of different issues (doesn't anyone build anymore) - libdns had the wrong version libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. - zfs attributes missing - missing debug libs - typos in library names - typos in library versions - _g libraries missing for new .so files (since we don't install .a files we should not be installing _g.a files either, why are we?) Hopefully this will fix the sparc64 build. To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/distrib/sets/lists/base/ad.mips64eb cvs rdiff -u -r1.32 -r1.33 src/distrib/sets/lists/comp/ad.mips64eb \ src/distrib/sets/lists/comp/ad.mips64el cvs rdiff -u -r1.115 -r1.116 src/distrib/sets/lists/comp/md.amd64 cvs rdiff -u -r1.99 -r1.100 src/distrib/sets/lists/comp/md.sparc64 cvs rdiff -u -r1.1625 -r1.1626 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.172 -r1.173 src/distrib/sets/lists/comp/shl.mi cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/tests/shl.mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/base/ad.mips64eb diff -u src/distrib/sets/lists/base/ad.mips64eb:1.50 src/distrib/sets/lists/base/ad.mips64eb:1.51 --- src/distrib/sets/lists/base/ad.mips64eb:1.50 Sun May 29 11:17:08 2011 +++ src/distrib/sets/lists/base/ad.mips64eb Sun May 29 22:10:25 2011 @@ -1,4 +1,4 @@ -# $NetBSD: ad.mips64eb,v 1.50 2011/05/29 15:17:08 spz Exp $ +# $NetBSD: ad.mips64eb,v 1.51 2011/05/30 02:10:25 christos Exp $ ./libexec/ld.elf_so-64base-compat-shlib compat,pic ./libexec/ld.elf_so-o32 base-sysutil-bin compat,pic ./usr/lib/64 base-compat-lib @@ -359,7 +359,7 @@ ./usr/lib/o32/libdm.so.0 base-compat-shlib compat,pic ./usr/lib/o32/libdm.so.0.0base-compat-shlib compat,pic ./usr/lib/o32/libdns.so.5 base-compat-shlib compat,pic -./usr/lib/o32/libdns.so.5.3 base-compat-shlib compat,pic +./usr/lib/o32/libdns.so.5.4 base-compat-shlib compat,pic ./usr/lib/o32/libdns_sd.so.0 base-compat-shlib compat,pic,mdns ./usr/lib/o32/libdns_sd.so.0.0base-compat-shlib compat,pic,mdns ./usr/lib/o32/libdwarf.so.0 base-compat-shlib compat,pic Index: src/distrib/sets/lists/comp/ad.mips64eb diff -u src/distrib/sets/lists/comp/ad.mips64eb:1.32 src/distrib/sets/lists/comp/ad.mips64eb:1.33 --- src/distrib/sets/lists/comp/ad.mips64eb:1.32 Thu May 12 21:56:27 2011 +++ src/distrib/sets/lists/comp/ad.mips64eb Sun May 29 22:10:25 2011 @@ -1,4 +1,4 @@ -# $NetBSD: ad.mips64eb,v 1.32 2011/05/13 01:56:27 christos Exp $ +# $NetBSD: ad.mips64eb,v 1.33 2011/05/30 02:10:25 christos Exp $ ./usr/bin/elf2aoutcomp-obsolete obsolete ./usr/bin/elf2ecoff comp-sysutil-bin ./usr/include/mipscomp-c-include @@ -1212,7 +1212,7 @@ ./usr/libdata/debug/usr/lib/64/libdes.so.8.1.debug comp-crypto-debug crypto,debug,compat ./usr/libdata/debug/usr/lib/64/libdevmapper.so.1.0.debug comp-lvm-debug lvm,debug,compat ./usr/libdata/debug/usr/lib/64/libdm.so.0.0.debug comp-sys-debug debug,compat -./usr/libdata/debug/usr/lib/64/libdns.so.5.3.debug comp-bind-debug debug,compat +./usr/libdata/debug/usr/lib/64/libdns.so.5.4.debug comp-bind-debug debug,compat ./usr/libdata/debug/usr/lib/64/libdns_sd.so.0.0.debug comp-mdns-debug mdns,debug,compat ./usr/libdata/debug/usr/lib/64/libdtrace.so.2.0.debug comp-sys-debug dtrace,debug,compat ./usr/libdata/debug/usr/lib/64/libdwarf.so.0.0.debug comp-sys-debug debug,compat @@ -1234,7 +1234,7 @@ ./usr/libdata/debug/usr/lib/64/libhx509.so.5.0.debug comp-krb5-debug kerberos,debug,compat ./usr/libdata/debug/usr/lib/64/libintl.so.1.0.debug comp-sys-debug debug,compat ./usr/libdata/debug/usr/lib/64/libipsec.so.3.0.debug comp-net-debug debug,compat -./usr/libdata/debug/usr/lib/64/libisc.so.5.3.debug comp-bind-debug debug,compat +./usr/libdata/debug/usr/lib/64/libisc.so.5.4.debug comp-bind-debug debug,compat ./usr/libdata/debug/usr/lib/64/libisccc.so.5.3.debug comp-bind-debug debug,compat
Re: CVS commit: src
In article iru1h7$g33$1...@dough.gmane.org, Christos Zoulas chris...@astron.com wrote: In article 20110529165252.ga17...@colwyn.zhadum.org.uk, Matthias Scheler t...@netbsd.org wrote: On Sun, May 29, 2011 at 01:07:34PM +, Christos Zoulas wrote: I've fixed it as suggested by you. Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. They also fail on virtual machines: http://www.gson.org/netbsd/bugs/build/build/2011.05.29.12.57.14/test.html#syscall_t_pselect_pselect_signal_mask_with_signal Yes, now it fails on mine too; I just rebuilt the test binary. Going back to the old source (1.2) does not fix it either. Should all be fixed now. christos
Re: CVS commit: src/distrib/sets/lists
In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, Adam Hamsik haa...@gmail.com wrote: libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. I think that this is not true for shared libraries; this happens automatically now. Perhaps not for .debug libraries? If that's the case it should be fixed. christos
Re: CVS commit: src/distrib/sets/lists
On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, Adam Hamsik haa...@gmail.com wrote: libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. I think that this is not true for shared libraries; this happens automatically now. Perhaps not for .debug libraries? If that's the case it should be fixed. I tweaked postinstall, quite some time ago, to handle debug libraries too. AFAIK, it works. -- Nicolas Joly Projects and Developments in Bioinformatics Institut Pasteur, Paris.
Re: CVS commit: src/distrib/sets/lists
On May,Monday 30 2011, at 11:23 AM, Nicolas Joly wrote: On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, Adam Hamsik haa...@gmail.com wrote: libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. I think that this is not true for shared libraries; this happens automatically now. Perhaps not for .debug libraries? If that's the case it should be fixed. I tweaked postinstall, quite some time ago, to handle debug libraries too. AFAIK, it works. I was not aware of that, it might be a good idea to document this difference in set lists file which is different. e.g. in shl.mi now. Regards Adam.
Re: CVS commit: src/distrib/sets/lists
On May 30, 12:52pm, haa...@gmail.com (Adam Hamsik) wrote: -- Subject: Re: CVS commit: src/distrib/sets/lists | | On May,Monday 30 2011, at 11:23 AM, Nicolas Joly wrote: | | On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: | In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, | Adam Hamsik haa...@gmail.com wrote: | | libdns was minor bumped after last bind update you should mark old | entries obsolete | and add new ones. Same should be done for all 64 archs. | | I think that this is not true for shared libraries; this happens | automatically now. Perhaps not for .debug libraries? If that's the | case it should be fixed. | | I tweaked postinstall, quite some time ago, to handle debug libraries | too. AFAIK, it works. | | I was not aware of that, it might be a good idea to document this difference | in set lists file which is different. e.g. in shl.mi now. I killed all the bogus entries there, to avoid cut-n-paste proliferation. christos
Re: CVS commit: src/distrib/sets/lists
On May,Monday 30 2011, at 1:02 PM, Christos Zoulas wrote: On May 30, 12:52pm, haa...@gmail.com (Adam Hamsik) wrote: -- Subject: Re: CVS commit: src/distrib/sets/lists | | On May,Monday 30 2011, at 11:23 AM, Nicolas Joly wrote: | | On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: | In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, | Adam Hamsik haa...@gmail.com wrote: | | libdns was minor bumped after last bind update you should mark old | entries obsolete | and add new ones. Same should be done for all 64 archs. | | I think that this is not true for shared libraries; this happens | automatically now. Perhaps not for .debug libraries? If that's the | case it should be fixed. | | I tweaked postinstall, quite some time ago, to handle debug libraries | too. AFAIK, it works. | | I was not aware of that, it might be a good idea to document this difference | in set lists file which is different. e.g. in shl.mi now. I killed all the bogus entries there, to avoid cut-n-paste proliferation. Thanks. Regards Adam.
Re: CVS commit: src/distrib/sets/lists
On Mon, May 30, 2011 at 12:52:57PM +0200, Adam Hamsik wrote: On May,Monday 30 2011, at 11:23 AM, Nicolas Joly wrote: On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, Adam Hamsik haa...@gmail.com wrote: libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. I think that this is not true for shared libraries; this happens automatically now. Perhaps not for .debug libraries? If that's the case it should be fixed. I tweaked postinstall, quite some time ago, to handle debug libraries too. AFAIK, it works. I was not aware of that, it might be a good idea to document this difference in set lists file which is different. e.g. in shl.mi now. Actually, only minor number changes are handled automatically for both shared/debug libraries. I do have, on my TODO list, to add a postinstall majorlib target (which will default to off) to ease builds when major is incremented. This is a real pain for MKDEBUG builds ... Just like kernel version bump versus module tree. -- Nicolas Joly Projects and Developments in Bioinformatics Institut Pasteur, Paris.
Re: CVS commit: src/distrib/sets/lists
On Mon, May 30, 2011 at 03:37:13PM +0200, Nicolas Joly wrote: On Mon, May 30, 2011 at 12:52:57PM +0200, Adam Hamsik wrote: On May,Monday 30 2011, at 11:23 AM, Nicolas Joly wrote: On Mon, May 30, 2011 at 09:17:52AM +, Christos Zoulas wrote: In article 9fd1caa9-1c17-4198-a9cc-57f4de798...@gmail.com, Adam Hamsik haa...@gmail.com wrote: libdns was minor bumped after last bind update you should mark old entries obsolete and add new ones. Same should be done for all 64 archs. I think that this is not true for shared libraries; this happens automatically now. Perhaps not for .debug libraries? If that's the case it should be fixed. I tweaked postinstall, quite some time ago, to handle debug libraries too. AFAIK, it works. I was not aware of that, it might be a good idea to document this difference in set lists file which is different. e.g. in shl.mi now. Actually, only minor number changes are handled automatically for both shared/debug libraries. I do have, on my TODO list, to add a postinstall majorlib target (which will default to off) to ease builds when major is incremented. This is a real pain for MKDEBUG builds ... Just like kernel version bump versus module tree. Well, not MKDEBUG, but MKUPDATE builds. -- Nicolas Joly Projects and Developments in Bioinformatics Institut Pasteur, Paris.
Re: CVS commit: src/external/bsd/tmux/dist/compat
In article 20110530162059.1a6d217...@cvs.netbsd.org,
Joerg Sonnenberger source-changes-d@NetBSD.org wrote:
-=-=-=-=-=-
+#ifdef __clang__
+ charbuf[128];
+#else
charbuf[CMSG_SPACE(sizeof(int))];
+#endif
} cmsgbuf;
Wouldn't it be better insted to re-define CMSG_SPACE for clang like:
#ifdef __clang__
#define CMSG_SPACE(x) ((x) + 128)
#else
...
#endif
This is bad too, what if sizeof(buf) CMSG_SPACE(sizeof(int)):
if (buf != NULL buf-fd != -1) {
msg.msg_control = (caddr_t)cmsgbuf.buf;
- msg.msg_controllen = sizeof(cmsgbuf.buf);
+ msg.msg_controllen = CMSG_SPACE(sizeof(int));
cmsg = CMSG_FIRSTHDR(msg);
cmsg-cmsg_len = CMSG_LEN(sizeof(int));
cmsg-cmsg_level = SOL_SOCKET;
Re: CVS commit: src/external/bsd/tmux/dist/compat
On Mon, May 30, 2011 at 06:10:36PM +, Christos Zoulas wrote: In article 20110530162059.1a6d217...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- +#ifdef __clang__ +charbuf[128]; +#else charbuf[CMSG_SPACE(sizeof(int))]; +#endif } cmsgbuf; Wouldn't it be better insted to re-define CMSG_SPACE for clang like: #ifdef __clang__ #define CMSG_SPACE(x) ((x) + 128) #else ... #endif No. The real fix would be to teach the kernel compat32 handling for cmsg and make it a proper constant again. 128 is simply large enough for all platforms we have. Joerg
Re: CVS commit: src/external/bsd/tmux/dist/compat
In article 20110530184621.ga14...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Mon, May 30, 2011 at 06:10:36PM +, Christos Zoulas wrote: In article 20110530162059.1a6d217...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- +#ifdef __clang__ + charbuf[128]; +#else charbuf[CMSG_SPACE(sizeof(int))]; +#endif } cmsgbuf; Wouldn't it be better insted to re-define CMSG_SPACE for clang like: #ifdef __clang__ #define CMSG_SPACE(x) ((x) + 128) #else ... #endif No. The real fix would be to teach the kernel compat32 handling for cmsg and make it a proper constant again. 128 is simply large enough for all platforms we have. Yes, but now you are polluting the code with ifdefs everywhere that will need to be undone. christos
