Re: CVS commit: src/sys/kern

[Valery Ushakov]

On Mon, Oct 10, 2016 at 01:22:08 +, David A. Holland wrote:

> Modified Files:
>   src/sys/kern: uipc_socket.c
> 
> Log Message:
> PR 49636 Henning Petersen: use "0L" to return 0 from a function returning
> long, and test its returned value against "0L" instead of "0".
> 
> This is not especially necessary, but it's also harmless.

No, it's not.  It sends a strong signal that integer promotions are
not enough here, and that explicit cast/sufix is required for some
reason.  Yet, no such reason is provided in the PR.  Please revert.
Or are you going to tag all long zeroes in the tree as 0L?

-uwe

Re: CVS commit: src/sbin/mount

[coypu]

On Sun, Oct 09, 2016 at 12:57:50PM -0600, Greg Oster wrote:
> 
> mount -t ext2 /dev/sd0e /mnt1
> mount -t ext2 /dev/sd1e /mnt2
> mount -t ext2 /dev/sd2e /mnt3
> mount -t ext2 /dev/sd3e /mnt4
> -
> 
> and getting the message:
> 
> mount: mount_ext2 not found
> 
> Now: which of those mounts failed?
> 

I feel like in any case you learn that you shouldn't be using mount -t ext2.
and you'd want to correct all of them.