Re: CVS commit: src/sys/kern

2017-01-08 Thread Kamil Rytarowski 


On 09.01.2017 05:06, Christos Zoulas wrote:
> On Jan 9,  4:40am, n...@gmx.com (Kamil Rytarowski) wrote:
> -- Subject: Re: CVS commit: src/sys/kern
> 
> | It's almost 5 years since commenting out - I assumed that it will rot to
> | the point that it might need to be rewritten. A reminder could be added
> | to roadmap and the code is still there in code history.
> | 
> | But if there is a request, I will revert it.
> 
> But neither the API or the ABI or something that is related to that
> code to cause it to rot has changed... If there was a change that would
> make it not compile anymore I would understand why it was removed...
> But it was just sitting there hurting nothing :-)
> 
> christos
> 

I'm testing and analyzing proper tracing of vfork events also around the
removed code fragments (even if new code might be in other place) and
testing this ifdef is ouf scope of my work - unless someone will make it
enabled and eventually fixed. Getting rid of it reduces the complexity
(at least for my eyes).

If there is a request to add it to TODO/roadmap or to back it out, I
will do it.



signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src/sys/kern

2017-01-08 Thread Christos Zoulas 
On Jan 9,  4:40am, n...@gmx.com (Kamil Rytarowski) wrote:
-- Subject: Re: CVS commit: src/sys/kern

| It's almost 5 years since commenting out - I assumed that it will rot to
| the point that it might need to be rewritten. A reminder could be added
| to roadmap and the code is still there in code history.
| 
| But if there is a request, I will revert it.

But neither the API or the ABI or something that is related to that
code to cause it to rot has changed... If there was a change that would
make it not compile anymore I would understand why it was removed...
But it was just sitting there hurting nothing :-)

christos

Re: CVS commit: src/sys/kern

2017-01-08 Thread Kamil Rytarowski 


On 09.01.2017 04:36, Christos Zoulas wrote:
> In article <20170109003130.33807f...@cvs.netbsd.org>,
> Kamil Rytarowski  wrote:
>> -=-=-=-=-=-
>>
>> Module Name: src
>> Committed By:kamil
>> Date:Mon Jan  9 00:31:30 UTC 2017
>>
>> Modified Files:
>>  src/sys/kern: kern_exec.c kern_exit.c kern_fork.c
>>
>> Log Message:
>> Cleanup dead code after revert of racy vfork(2) commit
>>
>> This removes dead code introduced with the following commit:
> 
> That's not dead code; it is commented out code that we would like
> to eventually get working. Rmind committed the change but it caused
> some regressions we did not understand. It did not hurt anything as
> it was commented out, and served as a reminder that something is
> wrong and we should one day track it down and fix it. Now there is
> no such reminder.
> 
> dead code = unreachable code but still compiled.
> 
> christos
> 

It's almost 5 years since commenting out - I assumed that it will rot to
the point that it might need to be rewritten. A reminder could be added
to roadmap and the code is still there in code history.

But if there is a request, I will revert it.



signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src/sys/kern

2017-01-08 Thread Christos Zoulas 
In article <20170109003130.33807f...@cvs.netbsd.org>,
Kamil Rytarowski  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  kamil
>Date:  Mon Jan  9 00:31:30 UTC 2017
>
>Modified Files:
>   src/sys/kern: kern_exec.c kern_exit.c kern_fork.c
>
>Log Message:
>Cleanup dead code after revert of racy vfork(2) commit
>
>This removes dead code introduced with the following commit:

That's not dead code; it is commented out code that we would like
to eventually get working. Rmind committed the change but it caused
some regressions we did not understand. It did not hurt anything as
it was commented out, and served as a reminder that something is
wrong and we should one day track it down and fix it. Now there is
no such reminder.

dead code = unreachable code but still compiled.

christos

Re: CVS commit: src/sys/conf

2017-01-08 Thread Christos Zoulas 
In article <20170108175946.gb5...@britannica.bec.de>,
Joerg Sonnenberger   wrote:
>On Sun, Jan 08, 2017 at 12:02:08AM -0500, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Sun Jan  8 05:02:08 UTC 2017
>> 
>> Modified Files:
>>  src/sys/conf: Makefile.kern.inc
>> 
>> Log Message:
>> Add COPTS for xhci.c, since the do_command_locked causes a spurious stack
>> proector warning.
>
>Please restrict that to GCC.

We apparently have a /usr/src/sys/conf/ssp.mk; perhaps look if there are
any others that are not needed for !GCC.

christos

Re: CVS commit: src/sys/conf

2017-01-08 Thread Joerg Sonnenberger 
On Sun, Jan 08, 2017 at 12:02:08AM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Sun Jan  8 05:02:08 UTC 2017
> 
> Modified Files:
>   src/sys/conf: Makefile.kern.inc
> 
> Log Message:
> Add COPTS for xhci.c, since the do_command_locked causes a spurious stack
> proector warning.

Please restrict that to GCC.

Joerg

Re: CVS commit: src/doc

2017-01-08 Thread coypu 
On Sun, Jan 08, 2017 at 04:17:44PM +, Thomas Klausner wrote:
> Module Name:  src
> Committed By: wiz
> Date: Sun Jan  8 16:17:44 UTC 2017
> 
> Modified Files:
>   src/doc: 3RDPARTY
> 
> Log Message:
> zlib-1.2.9 out.
> 

1.2.10 is out