Re: CVS commit: src/tools/compat

2017-12-09 Thread Joerg Sonnenberger 
On Sat, Dec 09, 2017 at 04:22:53AM +, Sevan Janiyan wrote:
> Module Name:  src
> Committed By: sevan
> Date: Sat Dec  9 04:22:53 UTC 2017
> 
> Modified Files:
>   src/tools/compat: configure.ac
> 
> Log Message:
> Add asnprintf() to the AC_CHECK_DECLS list.
> Resolves conflict when cross compiling on Cygwin the provided implementation
> does not get picked up.
> 
> Closes PR toolchain/52797

This change is wrong and makes the situation worse. The asnprintf on
Cygwin is broken by the agreed upon interface of asnprintf.

Joerg

Re: CVS commit: src/sys/arch

2017-12-09 Thread Maxime Villard 

Le 04/12/2017 à 23:13, Maxime Villard a écrit :

Le 04/12/2017 à 20:17, Christos Zoulas a écrit :

In article ,
Maxime Villard   wrote:

Le 03/12/2017 à 16:55, David Holland a écrit :

On Sun, Dec 03, 2017 at 10:05:08AM +0100, Maxime Villard wrote:
> Good, and apparently no one has noticed that some options don't compile.

Are you saying Christos is lying about it working after reverting your
commits?


Why don't you read the previous emails from this thread, instead of coming
up with random, inaccurate statements like this one? I said very clearly that
COMPAT_20 for example does not compile. Same for COMPAT_16 and COMPAT_10,
actually.


By "does not compile" you probably mean "does not compile for me". Can you
please post your config file? Perhaps it is easy to fix.


Give me a few days and I'll handle that (along with reverting the things).


After investigating the matter, it looks like my VM's disk was corrupt. I
was getting the following error:

at_print.o: In function '_KERNEL_OPT__DIAGNOSTIC':
at_print.c:(*ABS*+0x6e074def): multiple definition of '_KERNEL_OPT_COMPAT_14'
at_print.c:(*ABS*+0x6e074def): multiple definition of '_KERNEL_OPT_COMPAT_13'
at_print.c:(*ABS*+0x6e074def): multiple definition of '_KERNEL_OPT_COMPAT_12'
at_print.c:(*ABS*+0x6e074def): multiple definition of '_KERNEL_OPT_COMPAT_11'
at_print.c:(*ABS*+0x6e074def): multiple definition of '_KERNEL_OPT_COMPAT_10'

With an up-to-date cvs tree, with no changes from me except
compat_netbsd10.config included in GENERIC instead of
compat_netbsd15.config.

After removing src/ and re-checking out everything, it builds normally.

Therefore, I withdraw what I said, it was an inaccurate statement from me
too.

Maxime