re: CVS commit: src

2018-03-19 Thread matthew green
> Well, how about "lockstats"?  It's different from lockstat(8) and
> still appropriate (because stats means statistics).

lockstats sounds fine to me.  thanks.


.mrg.


Re: CVS commit: src

2018-03-19 Thread Ryota Ozaki
On Sat, Mar 17, 2018 at 2:04 AM, matthew green  wrote:
> "Ryota Ozaki" writes:
>> Module Name:  src
>> Committed By: ozaki-r
>> Date: Fri Mar 16 04:37:55 UTC 2018
>>
>> Modified Files:
>>   src/share/man/man4: ddb.4
>>   src/sys/ddb: db_command.c
>>   src/sys/sys: lockdebug.h
>>
>> Log Message:
>> Add a new command, show lockstat, which shows statistics of locks
>>
>> Currently the command shows the number of allocated locks.
>>
>> The command is useful only if LOCKDEBUG is enabled.
>
> would you mind renaming this?  "lockstat" makes me think of
> lockstat(8), not what this does.  "lockinfo"?  "lockstate"?

I'm not sure that we have to worry about the similarity between
a userland command and a ddb command.

Well, how about "lockstats"?  It's different from lockstat(8) and
still appropriate (because stats means statistics).

  ozaki-r


Re: CVS commit: src

2018-03-19 Thread Ryota Ozaki
On Mon, Mar 19, 2018 at 5:22 PM, matthew green  wrote:
>> Well, how about "lockstats"?  It's different from lockstat(8) and
>> still appropriate (because stats means statistics).
>
> lockstats sounds fine to me.  thanks.

Changed. Thanks!
  ozaki-r