Re: CVS commit: src/distrib/sets/lists

2018-11-12 Thread Maxime Villard

Le 12/11/2018 à 10:27, Martin Husemann a écrit :

On Mon, Nov 12, 2018 at 07:05:25AM +0100, Maxime Villard wrote:

I did test this, but it didn't work. I tested three combinations of MLIBDIR
and the error was still the same each time.


It seems to work for me (and I commited it). Did you build with a clean
obj/dest dir, or at least remove the eroneously created compat libs
between the tries?


I didn't build with a clean destdir, because it would have taken too much
time; between the tries I removed obj/lib/libnvmm to force a rebuild, but
it's clear that was wrong. Anyway my AMD setup is ridiculous, I will erase
and re-install correctly. Thanks for fixing.


re: CVS commit: src/distrib/sets/lists

2018-11-12 Thread matthew green
Maxime Villard writes:

> I did test this, but it didn't work. I tested three combinations of MLIBDIR
> and the error was still the same each time.

you probably wanted something like this as the whole file:

# $NetBSD$

.if !defined(MLIBDIR)

.endif

.include 


Re: CVS commit: src/sys

2018-11-12 Thread Maxime Villard

Le 12/11/2018 à 10:28, Ryo Shimizu a écrit :

We can still observe kernel addresses by below commands, they also
should be hidden?

   ps -o pid,laddr,uaddr
   netstat -A
   pstat -v, pstat -t

There may still be other command...


I think these are already listed in:

https://nxr.netbsd.org/xref/src/doc/TODO.kaslr

Yes, they should be hidden.


Re: CVS commit: src/sys

2018-11-12 Thread Ryo Shimizu


>> We can still observe kernel addresses by below commands, they also
>> should be hidden?
>>
>>ps -o pid,laddr,uaddr
>>netstat -A
>>pstat -v, pstat -t
>>
>> There may still be other command...
>
>I think these are already listed in:
>
>   https://nxr.netbsd.org/xref/src/doc/TODO.kaslr
>
>Yes, they should be hidden.

Ah, I missed that TODO items. I got. Thanks!

-- 
ryo shimizu


Re: CVS commit: src/distrib/sets/lists

2018-11-12 Thread Martin Husemann
On Mon, Nov 12, 2018 at 10:27:29AM +0100, Martin Husemann wrote:
> On Mon, Nov 12, 2018 at 07:05:25AM +0100, Maxime Villard wrote:
> > I did test this, but it didn't work. I tested three combinations of MLIBDIR
> > and the error was still the same each time.
> 
> It seems to work for me (and I commited it). Did you build with a clean
> obj/dest dir, or at least remove the eroneously created compat libs
> between the tries?

It is still failing: for reasons unclear to me libnvmm is installed into /lib,
but the set lists expect /usr/lib.

Otherwise the build looks fine.

Martin

checkflist ===> distrib/sets
===  4 extra files in DESTDIR  =
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
--
./lib/libnvmm.so
./lib/libnvmm.so.0
./lib/libnvmm.so.0.1
./usr/libdata/debug/lib/libnvmm.so.0.1.debug
=  end of 4 extra files  ===



Re: CVS commit: src/sys

2018-11-12 Thread Ryo Shimizu


>Module Name:   src
>Committed By:  christos
>Date:  Fri Oct  5 22:12:38 UTC 2018
>
>Modified Files:
>   src/sys/kern: init_sysctl.c kern_descrip.c kern_proc.c
>   src/sys/secmodel/suser: secmodel_suser.c
>   src/sys/sys: kauth.h systm.h
>
>Log Message:
>Provide a sysctl kern.expose_address to expose kernel addresses in
>sysctl structure returns for non-root. Defaults to off. Turning it
>on will restore sockstat/fstat and friends for regular users.
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.217 -r1.218 src/sys/kern/init_sysctl.c \
>src/sys/kern/kern_proc.c
>cvs rdiff -u -r1.237 -r1.238 src/sys/kern/kern_descrip.c
>cvs rdiff -u -r1.48 -r1.49 src/sys/secmodel/suser/secmodel_suser.c
>cvs rdiff -u -r1.80 -r1.81 src/sys/sys/kauth.h
>cvs rdiff -u -r1.278 -r1.279 src/sys/sys/systm.h
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.

We can still observe kernel addresses by below commands, they also should be 
hidden?

  ps -o pid,laddr,uaddr
  netstat -A
  pstat -v, pstat -t

There may still be other command...

-- 
ryo shimizu


Re: CVS commit: src/distrib/sets/lists

2018-11-12 Thread Martin Husemann
On Mon, Nov 12, 2018 at 07:05:25AM +0100, Maxime Villard wrote:
> I did test this, but it didn't work. I tested three combinations of MLIBDIR
> and the error was still the same each time.

It seems to work for me (and I commited it). Did you build with a clean
obj/dest dir, or at least remove the eroneously created compat libs
between the tries?

Martin