Re: CVS commit: src
> On Apr 26, 2020, at 5:23 AM, Maxime Villard wrote: > > Because I modeled my tests after the ufetchstore and threadpool tests which > are > both in this directory and provide user access to kernel internals via > modules, > which is exactly what I'm doing. ..and those are there because, IIRC, that's where someone asked me to move them to. -- thorpej
Re: CVS commit: src/sys/uvm
On 2020/04/27 11:47, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Apr 27 02:47:26 UTC 2020 Modified Files: src/sys/uvm: uvm_extern.h Log Message: Add missing \ to fix build for PMAP_CACHE_VIVT, i.e., ARMv4 and prior. s/v4/v5/
Re: CVS commit: src/sys/kern
> On Apr 26, 2020, at 2:04 PM, Michael van Elst wrote: > > Log Message: > fix DIAGNOSTIC build non-DIAGNOSTIC you mean? -- thorpej
[sctp fix] Re: CVS commit: src/sys/kern
Le 26/04/2020 à 16:21, Jonathan A. Kollasch a écrit : > Module Name: src > Committed By: jakllsch > Date: Sun Apr 26 14:21:14 UTC 2020 > > Modified Files: > src/sys/kern: uipc_socket.c > > Log Message: > Implement SCTP bug fixes found by maxv@. > > Adding these seems to improve the SCTP situation. Yeah, thanks... I remember I had sent an email about these bugs, no one cared, so I just put big XXXs and left the broken thing as-is. That was more than a year ago. I remember also pointing out at some point the severe deficiencies of the SCTP code we have, with no one caring once again (not even me actually). In its current state (that is, the state it has been in ever since it was imported five years ago), our SCTP code is a near-perfect example of gigantic, buggy and useless bloat. Specifically, as far as I remember: - Last I checked, SCTP occupies, in number of lines of code, half of our IPv4 network stack. In other words, when it was imported, our kernel netinet stack suddenly doubled in size. I don't see how we will ever MP-ify all of that. - There was no demonstrated use-case justifying importing it. In addition, major OSes like Windows and macOS do not implement SCTP. There just is no demand for SCTP on the market; and on NetBSD, proportionally even less. - The code is of remarkably poor quality, with bugs in all directions, complex pieces of logic that seem rarely justified, and implementation errors like the pointer bugs you just fixed. The bloat and bugs are already evident as early as in the first twenty lines of code of the sctp_input() entry point. - IIRC the mbuf API usage is very poor (though I don't remember the specifics here; I must have kept paper notes somewhere). - It seems that no one is maintaining it? Nothing has improved over the last five years, and there are no apparent signs that this situation will ever change. There are piecemeal changes like yours and mine, to accommodate API changes and fix obvious bugs, and that's about it, as far as I can tell. At one point I hesitated about doing a big cleanup of SCTP. But I concluded that it is too structurally broken, and that fixing it is a waste of time; rewriting it would be faster and would result in a better, more functional, and easier to maintain code. Overall I think this is an example of bad policy. It's good to have support for new protocols, but at some point, we need to question whether landing 40K lines of buggy yet critical kernel code out of nowhere with no one maintaining it and little justification for the feature is a good thing to do. CC'ing core@ in case they are interested in making a useful statement for once. In all cases, this code is disabled by default, which is a good thing given its state, but results in us not giving a damn about it. Maxime
Re: CVS commit: src
On Sun, 26 Apr 2020, Maxime Villard wrote: Le 26/04/2020 à 14:05, Paul Goyette a écrit : Why are these files being placed in src/tests/modules? Because I modeled my tests after the ufetchstore and threadpool tests which are both in this directory and provide user access to kernel internals via modules, which is exactly what I'm doing. Also it looks like the t_kcov one doesn't match your definition of what this directory should be about. Yes, those are also mis-placed. That directory is supposed to contain tests of the module feature; it is not intended to place modules-that-support-tests-of-other- features. Can you please put these in src/tests/sys/ or somewhere more appropriate? On Sun, 26 Apr 2020, Maxime Villard wrote: Module Name: src Committed By: maxv Date: Sun Apr 26 09:08:41 UTC 2020 Modified Files: src/distrib/sets/lists/debug: md.amd64 src/distrib/sets/lists/tests: md.amd64 src/tests/modules: Makefile Added Files: src/tests/modules: t_x86_pte.c src/tests/modules/x86_pte_tester: Makefile x86_pte_tester.c Log Message: Add tests on the x86 PTEs. We scan the MMU page tables directly and verify certain properties. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108 src/distrib/sets/lists/debug/md.amd64 cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/tests/md.amd64 cvs rdiff -u -r1.18 -r1.19 src/tests/modules/Makefile cvs rdiff -u -r0 -r1.1 src/tests/modules/t_x86_pte.c cvs rdiff -u -r0 -r1.1 src/tests/modules/x86_pte_tester/Makefile \ src/tests/modules/x86_pte_tester/x86_pte_tester.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. ++--+---+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | ++--+---+ !DSPAM:5ea57d44212103157353641! ++--+---+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | ++--+---+
Re: CVS commit: src
Le 26/04/2020 à 14:05, Paul Goyette a écrit : > Why are these files being placed in src/tests/modules? Because I modeled my tests after the ufetchstore and threadpool tests which are both in this directory and provide user access to kernel internals via modules, which is exactly what I'm doing. Also it looks like the t_kcov one doesn't match your definition of what this directory should be about. > That directory is supposed to contain tests of the module feature; > it is not intended to place modules-that-support-tests-of-other- > features. > > Can you please put these in src/tests/sys/ or somewhere more > appropriate? > > > > > On Sun, 26 Apr 2020, Maxime Villard wrote: > >> Module Name: src >> Committed By: maxv >> Date: Sun Apr 26 09:08:41 UTC 2020 >> >> Modified Files: >> src/distrib/sets/lists/debug: md.amd64 >> src/distrib/sets/lists/tests: md.amd64 >> src/tests/modules: Makefile >> Added Files: >> src/tests/modules: t_x86_pte.c >> src/tests/modules/x86_pte_tester: Makefile x86_pte_tester.c >> >> Log Message: >> Add tests on the x86 PTEs. We scan the MMU page tables directly and verify >> certain properties. >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.107 -r1.108 src/distrib/sets/lists/debug/md.amd64 >> cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/tests/md.amd64 >> cvs rdiff -u -r1.18 -r1.19 src/tests/modules/Makefile >> cvs rdiff -u -r0 -r1.1 src/tests/modules/t_x86_pte.c >> cvs rdiff -u -r0 -r1.1 src/tests/modules/x86_pte_tester/Makefile \ >> src/tests/modules/x86_pte_tester/x86_pte_tester.c >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >> >> >> !DSPAM:5ea54fda15308349521! >> >> > > ++--+---+ > | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | > | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | > | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | > ++--+---+
Re: CVS commit: src
Why are these files being placed in src/tests/modules? That directory is supposed to contain tests of the module feature; it is not intended to place modules-that-support-tests-of-other- features. Can you please put these in src/tests/sys/ or somewhere more appropriate? On Sun, 26 Apr 2020, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sun Apr 26 09:08:41 UTC 2020 Modified Files: src/distrib/sets/lists/debug: md.amd64 src/distrib/sets/lists/tests: md.amd64 src/tests/modules: Makefile Added Files: src/tests/modules: t_x86_pte.c src/tests/modules/x86_pte_tester: Makefile x86_pte_tester.c Log Message: Add tests on the x86 PTEs. We scan the MMU page tables directly and verify certain properties. To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108 src/distrib/sets/lists/debug/md.amd64 cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/tests/md.amd64 cvs rdiff -u -r1.18 -r1.19 src/tests/modules/Makefile cvs rdiff -u -r0 -r1.1 src/tests/modules/t_x86_pte.c cvs rdiff -u -r0 -r1.1 src/tests/modules/x86_pte_tester/Makefile \ src/tests/modules/x86_pte_tester/x86_pte_tester.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:5ea54fda15308349521! ++--+---+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com | | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | ++--+---+
