Re: CVS commit: src/distrib/sets

2009-04-03 Thread Alan Barrett
On Fri, 03 Apr 2009, Soren Jacobsen wrote: > On 04/04 00:47, Alan Barrett wrote: > > I have committed a change to make "mtree -C" sort its output. I think > > we can now remove sort incovations from shell scripts or make rules that > > invoke mtree -C. > > That's fine, but for 5.0 I'd rather just

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Soren Jacobsen
On 04/04 00:47, Alan Barrett wrote: > > I have committed a change to make "mtree -C" sort its output. I think > we can now remove sort incovations from shell scripts or make rules that > invoke mtree -C. That's fine, but for 5.0 I'd rather just have the additional sort invocation in maketars.

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Alan Barrett
On Fri, 03 Apr 2009, Izumi Tsutsui wrote: > a...@cequrux.com wrote: > > I think it would be better to do this in the sanitise_METALOG target in > > src/distrib/sets/Makefile, like this: > > But it is not confiremd yet that using METALOG.sanitised is okay or not. Oh, I see that the makesetfiles ta

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Perry E. Metzger
Izumi Tsutsui writes: > Did you commit your change without build and test? ;-p No, I did a test build. I just noted that when I re-ordered things they got re-reordered by mtree, but I didn't look into it much. Perry -- Perry E. Metzgerpe...@piermont.com

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Izumi Tsutsui
pe...@piermont.com wrote: > > Log Message: > > Explicitly sort entries on preparing set files from METALOG. > > METALOG could have different order due to install(1) race > > on parallel builds, and mtree(8) doesn't sort files. > > Should fix inconsistent shared sets among builds as seen in > > /pu

Re: CVS commit: src/share/man/man9

2009-04-03 Thread Matt Fleming
On Thu, Apr 02, 2009 at 08:55:36PM -0700, Tom Spindler wrote: > > src/share/man/man9: scsipi.9 > > Continue my crusade - queueing -> queuing > > A crusade against British English? That's British English? Well I'll be damned. Anyway, the reason I changed it is because the ATA-7 standard and I

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Perry E. Metzger
Alan Barrett writes: > On Fri, 03 Apr 2009, Perry E. Metzger wrote: >> Alan Barrett writes: >> > It would also make sense to add a sort option to mtree. >> >> Does mtree -C sort already? I haven't read the sources but it seems to >> rearrange what it is fed into a canonicalized order. > > No, i

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Alan Barrett
On Fri, 03 Apr 2009, Perry E. Metzger wrote: > Alan Barrett writes: > > It would also make sense to add a sort option to mtree. > > Does mtree -C sort already? I haven't read the sources but it seems to > rearrange what it is fed into a canonicalized order. No, it doesn't sort; whatever rearrang

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Perry E. Metzger
Alan Barrett writes: > It would also make sense to add a sort option to mtree. Does mtree -C sort already? I haven't read the sources but it seems to rearrange what it is fed into a canonicalized order. Perry

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Perry E. Metzger
Izumi Tsutsui writes: > Module Name: src > Committed By: tsutsui > Date: Thu Apr 2 23:06:16 UTC 2009 > > Modified Files: > src/distrib/sets: maketars > > Log Message: > Explicitly sort entries on preparing set files from METALOG. > METALOG could have different order due to install

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Izumi Tsutsui
a...@cequrux.com wrote: > On Thu, 02 Apr 2009, Izumi Tsutsui wrote: > > Log Message: > > Explicitly sort entries on preparing set files from METALOG. > > METALOG could have different order due to install(1) race > > on parallel builds, and mtree(8) doesn't sort files. > > Should fix inconsistent s

Re: CVS commit: src/distrib/sets

2009-04-03 Thread Alan Barrett
On Thu, 02 Apr 2009, Izumi Tsutsui wrote: > Log Message: > Explicitly sort entries on preparing set files from METALOG. > METALOG could have different order due to install(1) race > on parallel builds, and mtree(8) doesn't sort files. > Should fix inconsistent shared sets among builds as seen in >

Re: CVS commit: src/sbin/mount_nfs

2009-04-03 Thread Antti Kantee
Whoops. the commit message below should've said "no functional change apart from new bugs". patched, thanks. On Fri Apr 03 2009 at 00:37:43 +, YAMAMOTO Takashi wrote: > hi, > > 'sa' in mount_nfs_dogetargs will be out of the scope when it's used. > > YAMAMOTO Takashi > > > Module Name: