Re: CVS commit: src

2009-04-04 Thread Alan Barrett
Perry, please could you answer this question. --apb (Alan Barrett) On Fri, 13 Mar 2009, Alan Barrett wrote: On Fri, 13 Mar 2009, Perry E. Metzger wrote: As indicated, I see nothing wrong with a MKDETERMINISTIC that flips the MKARZERO flag as well as the other flags that control

Re: CVS commit: src/sys/net

2009-04-04 Thread Masao Uebayashi
Sorry for delayed review. @@ -410,6 +419,10 @@ /* Tear down the routing table. */ bridge_rtable_fini(sc); + + + softint_disestablish(sc-sc_softintr); + free(sc, M_DEVBUF); return (0); Please trim these blank lines. @@ -1305,124 +1318,139 @@ * The

Re: CVS commit: src/distrib/utils/sysinst

2009-04-04 Thread Izumi Tsutsui
a...@netbsd.org wrote: On Sat, Apr 04, 2009 at 07:47:12PM +0900, Izumi Tsutsui wrote: a...@netbsd.org wrote: Module Name: src Committed By: ad Date: Sat Apr 4 10:38:00 UTC 2009 Modified Files: src/distrib/utils/sysinst: bsddisklabel.c Log

Re: CVS commit: src/distrib/utils/sysinst

2009-04-04 Thread Martin Husemann
On Sat, Apr 04, 2009 at 09:43:46PM +0900, Izumi Tsutsui wrote: In any case, __HAVE_UFS2_BOOT in types.h seems ambiguous for me. Isn't it better to have some other macro in sysinst/arch/${MACHINE}/md.h ? I agree, it does not belong in types.h. Martin

Re: CVS commit: src/sys/net

2009-04-04 Thread Manuel Bouyer
On Sun, Apr 05, 2009 at 12:06:12AM +0900, Masao Uebayashi wrote: I was reviewing this change. :) On Sat, Apr 04, 2009 at 10:00:23AM +, Manuel Bouyer wrote: Module Name:src Committed By: bouyer Date: Sat Apr 4 10:00:23 UTC 2009 Modified Files:

Re: CVS commit: src/sys/net

2009-04-04 Thread Manuel Bouyer
On Sat, Apr 04, 2009 at 09:04:36PM +0900, Masao Uebayashi wrote: Sorry for delayed review. @@ -410,6 +419,10 @@ /* Tear down the routing table. */ bridge_rtable_fini(sc); + + + softint_disestablish(sc-sc_softintr); + free(sc, M_DEVBUF); return (0);

Re: CVS commit: src/distrib/sets/lists/comp

2009-04-04 Thread Perry E. Metzger
Alan Barrett a...@netbsd.org writes: Module Name: src Committed By: apb Date: Sat Apr 4 15:27:48 UTC 2009 Modified Files: src/distrib/sets/lists/comp: mi Log Message: Mention html versions of recently-added bit* man pages Thanks for getting that, Alan. Perry -- Perry