Re: CVS commit: src/sys

2009-05-16 Thread Andrew Doran
On Sat, May 16, 2009 at 08:29:54AM +, YAMAMOTO Takashi wrote: Modified Files: src/sys/kern: vfs_subr.c src/sys/sys: vnode.h Log Message: put a flag bit into v_usecount to prevent vtryget during getcleanvnode. this fixes the following deadlock. Thanks! How about this to

Re: CVS commit: src/sys

2009-05-16 Thread Manuel Bouyer
On Sat, May 16, 2009 at 08:29:54AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Sat May 16 08:29:54 UTC 2009 Modified Files: src/sys/kern: vfs_subr.c src/sys/sys: vnode.h Log Message: put a flag bit into v_usecount to prevent vtryget

Re: CVS commit: src/sys

2009-05-16 Thread YAMAMOTO Takashi
hi, On Sat, May 16, 2009 at 08:29:54AM +, YAMAMOTO Takashi wrote: Modified Files: src/sys/kern: vfs_subr.c src/sys/sys: vnode.h Log Message: put a flag bit into v_usecount to prevent vtryget during getcleanvnode. this fixes the following deadlock. Thanks! How about

Re: CVS commit: src/sys

2009-05-16 Thread YAMAMOTO Takashi
hi, Hi, do you think it could also help with kern/41417 ? cache_lookup seems also to be involved in this deadlock ... it seems like a different problem. YAMAMOTO Takashi

Re: CVS commit: src/sys

2009-05-16 Thread Manuel Bouyer
On Sat, May 16, 2009 at 11:14:49AM +, YAMAMOTO Takashi wrote: hi, Hi, do you think it could also help with kern/41417 ? cache_lookup seems also to be involved in this deadlock ... it seems like a different problem. Would have been too easy ... thanks -- Manuel Bouyer

Re: CVS commit: src/sys/kern

2009-05-16 Thread David Laight
On Sat, May 16, 2009 at 12:02:00PM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Sat May 16 12:02:00 UTC 2009 Modified Files: src/sys/kern: init_sysctl.c Log Message: sysctl_doeproc: - simplify. - KERN_PROC: fix possible stale proc

Re: CVS commit: src/sys/kern

2009-05-16 Thread YAMAMOTO Takashi
hi, On Sat, May 16, 2009 at 12:02:00PM +, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Sat May 16 12:02:00 UTC 2009 Modified Files: src/sys/kern: init_sysctl.c Log Message: sysctl_doeproc: - simplify. - KERN_PROC: fix

Re: CVS commit: src/sys

2009-05-16 Thread Alan Barrett
On Sat, 16 May 2009, Andrew Doran wrote: Thanks! How about this to avoid potential sign compare issues? I forgot to e-mail you about it earlier. @@ -252,8 +252,8 @@ typedef struct vnode vnode_t; /* * v_usecount; see the comment in vfs_subr.c */ -#defineVC_XLOCK

Re: CVS commit: src/sys

2009-05-16 Thread David Young
On Sat, May 16, 2009 at 10:05:36PM +0300, Alan Barrett wrote: On Sat, 16 May 2009, Andrew Doran wrote: Thanks! How about this to avoid potential sign compare issues? I forgot to e-mail you about it earlier. @@ -252,8 +252,8 @@ typedef struct vnode vnode_t; /* * v_usecount; see the

re: CVS commit: src/sys/arch/sparc/sparc

2009-05-16 Thread matthew green
Module Name: src Committed By:cegger Date:Sat May 16 17:01:16 UTC 2009 Modified Files: src/sys/arch/sparc/sparc: machdep.c process_machdep.c svr4_machdep.c vm_machdep.c Log Message: KNF, same object code generated. why are

Re: CVS commit: src/sys/arch/sparc/sparc

2009-05-16 Thread Izumi Tsutsui
Modified Files: src/sys/arch/sparc/sparc: machdep.c process_machdep.c svr4_machdep.c vm_machdep.c Log Message: KNF, same object code generated. why are you doing this? are you planning on touching all of these files or are you doing a KNF rototill that you